📋 PM Board
Sub-task EP-02-T01-S03 Kritik 02_products erpbom-backend

Resept va marshrut — recipe_versions, recipe_lines, variant_operations, predecessors

Bajarildi
Status:

Tavsif

`recipe_versions` (`product_variant_id` FK, `version_number`, `active`; `UNIQUE(product_variant_id, version_number)` + qisman `UNIQUE(product_variant_id) WHERE active`); `recipe_lines` (`recipe_version_id` FK, `variant_operation_id` FK — Tovar1 da NOT NULL / Tovar2 da NULL, `component_variant_id` FK→`product_variants`, `quantity`; unikallik operatsiya darajasida `UNIQUE(variant_operation_id, component_variant_id)` — Tovar2 uchun alohida yo'l, `variant_operation_id IS NULL` holatda `UNIQUE(recipe_version_id, component_variant_id)`, partial unique index bilan); `variant_operations` (`recipe_version_id` FK, `operation_no`, `name`, **`profession_id` — oddiy `bigint`, FK CONSTRAINT YO'Q** (epic tavsifidagi qaror); `UNIQUE(recipe_version_id, operation_no)`, `UNIQUE(recipe_version_id, name)`); `variant_operation_predecessors` (`operation_id`, `predecessor_operation_id`, ikkalasi FK→`variant_operations`; `UNIQUE(operation_id, predecessor_operation_id)`; CHECK `operation_id <> predecessor_operation_id`). DAG siklsizligi va "bog'langanlik" (qoida 26b/26e) DB darajasida CHECK bilan ifodalanmaydi (grafik invariant) — bu service qatlamida (T04) tekshiriladi; migratsiya faqat struktura va oddiy cheklovlarni qo'yadi.

Qabul mezonlari (DoD)

4 / 4 bajarildi

  • Ikkinchi aktiv resept versiyasi kiritilsa qisman unique index INSERT'ni rad etadi

    qa-ep-02-t01-s03 · 1 о аввал

  • `recipe_lines` da bir operatsiya ichida bir komponent ikki marta kiritilmaydi (unique violation)

    qa-ep-02-t01-s03 · 1 о аввал

  • `operation_id = predecessor_operation_id` INSERT CHECK bilan rad etiladi

    qa-ep-02-t01-s03 · 1 о аввал

  • `variant_operations.profession_id` ustuni bor, lekin migratsiyada `professions` ga REFERENCES yo'q (grep tekshiruvi)

    qa-ep-02-t01-s03 · 1 о аввал

O'zgargan fayllar

2 ta

  • modified src/test/java/uz/erpbom/products/RecipesAndRoutesMigrationTest.java
  • modified src/main/resources/db/migration/V10__recipes_and_routes.sql

Izoh qoldirish

Tarix

24 yozuv

  • ✎

    finalize-ep-02 yangiladi

    Yangilandi: commit_sha

  • ⇄

    qa-ep-02-t01-s03 statusni o'zgartirdi Review → Bajarildi

  • ✎

    unknown-agent yangiladi

    Yangilandi: commit_sha

  • ⇄

    unknown-agent statusni o'zgartirdi Ishlanyapti → Review

  • 📄

    unknown-agent fayllarni qayd etdi

    1 ta fayl qayd etildi

  • ⇄

    qa-ep-02-t01-s03 statusni o'zgartirdi Review → Ishlanyapti

  • 💬

    qa-ep-02-t01-s03 izoh qoldirdi

    QA natijasi — EP-02-T01-S03 (V10__recipes_and_routes.sql). Mustaqil tekshirildi: mvn -Dtest=RecipesAndRoutesMigrationTest,ProductDictionariesMigrationTest,ProductsAndVariantsMigrationTest test -> 18/17/13 test, 0 failure (flock ostida). AC995-998 mustaqil tasdiqlandi (kod + test o'qildi, is_met=true qo'yildi): - AC995: uq_recipe_versions_product_variant_id_active (partial unique WHERE active) — test secondActiveRecipeVersionForSameVariantIsRejected yashil. - AC996: uq_recipe_lines_operation_component — test duplicateComponentWithinSameOperationIsRejected yashil. - AC997: chk_variant_operation_predecessors_no_self_reference — test selfReferencingPredecessorIsRejected yashil. MUTATSIYA TEKSHIRUVI: CHECK'ni vaqtincha o'chirib (V10 satr 190-193) qayta yurgizdim -> AssertionError 'Expecting code to raise a throwable' (test qulaydi, demak haqiqatan CHECK'ga bog'liq) -> git checkout bilan tikladim, qayta yashil. - AC998: profession_id FK'siz — grep + information_schema so'rovi bilan tasdiqlandi. Bu task tavsifidagi ('epic tavsifidagi qaror') va openapi/v1/products.yaml (RecipeOperationInput.profession_id, VariantOperationResponse.profession_id — int64, DB FK talab qilinmaydi) bilan mos. `active DEFAULT false` ham kontrakt bilan mos: POST /recipe-versions javobi '201 Yaratildi (active=false)' + alohida /activate endpoint (openapi 1529-1551, 1600-1634) — coder asosi to'g'ri. QAYTARISH SABABI (cross-cutting #6 — precision, done bo'lolmaydi): V10__recipes_and_routes.sql:116 -> `quantity numeric(19, 4)`. 00_CROSS_CUTTING.md B bandi (85-91 qator) aniq belgilagan: "miqdor ustunlari (qty, qoldiq, ...) — numeric(18,4)". Bu V10'dagi YAGONA og'ish — V11__selling_prices_and_piece_rates.sql (parallel ish) xuddi shu sessiyada narx/miqdor ustunlarini to'g'ri numeric(18,4)/numeric(18,2) bilan yozgan, V8/V9 da ham 19 raqami hech qayerda yo'q. Migratsiya izohida sabab ko'rsatilgan: ".claude/skills/coding/postgresql/SKILL.md" 76-77 qatorda "Miqdor -> numeric(19,4)" deb yozilgan — bu skill fayli 00_CROSS_CUTTING.md bilan ZID (fayl xato, lekin bu QA vazifasi doirasida tuzatilmaydi, faqat qayd etildi). Iltimos: V10 satr 116'ni `numeric(18, 4)` ga o'zgartiring (izohdagi 'postgresql skill §6' asoslamasini ham CROSS_CUTTING B bandi bilan almashtiring); tegishli testlardagi qiymatlar (masalan '0.5000') buzilmaydi, faqat ustun precision'i o'zgaradi. SKILL.md'dagi 19,4 xatoligini PM/team-lead-pm alohida ko'rib chiqishi kerak (boshqa kelajakdagi migratsiyalarga ham ta'sir qiladi — mas. 03_warehouse). Boshqa hamma cross-cutting bandlar mos: tenant_id/organization_id yo'q (test noNewTableHasTenantOrOrganizationIdColumn + AR-1), nomlash snake_case/ko'plik/to'liq FK nomlari (V9 naqshiga mos), soft-delete kerak emas (spec 2.5a-d'da deleted_at yo'q, bu jadvallar versiyalangan/append-only, o'chirish endpointi yo'q — boshqa lug'at jadvallar bilan bir xil naqsh, 02_products.md 871-879). @Transactional/outbox/audit bu subtaskka tegishli emas (faqat migratsiya, servis qatlami yo'q).

  • ✓

    qa-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `variant_operations.profession_id` ustuni bor, lekin migratsiyada `professions` ga REFERENCES yo'q (grep tekshiruvi)

  • ✓

    qa-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `operation_id = predecessor_operation_id` INSERT CHECK bilan rad etiladi

  • ✓

    qa-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `recipe_lines` da bir operatsiya ichida bir komponent ikki marta kiritilmaydi (unique violation)

  • ✓

    qa-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ Ikkinchi aktiv resept versiyasi kiritilsa qisman unique index INSERT'ni rad etadi

  • ⇄

    coder-ep-02-t01-s03 statusni o'zgartirdi Ishlanyapti → Review

  • ✎

    coder-ep-02-t01-s03 yangiladi

    Yangilandi: branch, commit_sha

  • ✓

    coder-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `variant_operations.profession_id` ustuni bor, lekin migratsiyada `professions` ga REFERENCES yo'q (grep tekshiruvi)

  • ✓

    coder-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `operation_id = predecessor_operation_id` INSERT CHECK bilan rad etiladi

  • ✓

    coder-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ `recipe_lines` da bir operatsiya ichida bir komponent ikki marta kiritilmaydi (unique violation)

  • ✓

    coder-ep-02-t01-s03 qabul mezonini belgiladi

    ✓ Ikkinchi aktiv resept versiyasi kiritilsa qisman unique index INSERT'ni rad etadi

  • 📄

    coder-ep-02-t01-s03 fayllarni qayd etdi

    2 ta fayl qayd etildi

  • ⇄

    coder-ep-02-t01-s03 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-02-t01-s03 ishga oldi

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-02-T01-S02

  • ✎

    pm-agent yangiladi

    Yangilandi: estimate_hours

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-02-T01-S02

  • ✦

    pm-agent yaratdi

    Resept va marshrut — recipe_versions, recipe_lines, variant_operations, predecessors

Ma'lumot

Agent
coder-ep-02-t01-s03
Olingan
1 о аввал
Boshlandi
18.08.2026 18:52
Tugadi
18.08.2026 19:18
Baho
6 soat
Spec
erp/docs/modules/02_products.md#2.5c
Branch
feat/EP-02-erpbom-backend
Commit
4b90a3e35337

Bog'liqliklar

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-02-T01-S03/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-02-T01-S03/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'