📋 PM Board
Sub-task EP-02-T01-S02 Kritik 02_products erpbom-backend

Tovar va Variant (SKU) — products, product_variants, biriktiruvchi jadvallar

Bajarildi
Status:

Tavsif

`products` (`product_category_id` FK, `brand_id` FK, `product_type` enum raw/semi_finished/finished, `active`, `deleted_at`); `product_variants` (`product_id` FK, `code` char(6) `UNIQUE`, `unit_id` FK, `image_file_key`/ `image_mime_type`/`image_size_bytes` — CHECK: key bo'lsa ikkalasi ham majburiy, `active`, `deleted_at`); `product_attributes` (`UNIQUE(product_id, attribute_id)`); `variant_attribute_values` (`UNIQUE(product_variant_id, attribute_id)` — attribute_id `attribute_value_id → attribute_values.attribute_id` orqali, trigger yoki CHECK bilan mos ekanligi ta'minlanadi). SKU generatsiyasi (2.4a): oddiy DB `sequence` (`product_variant_code_seq`, `1` dan), format `'P' || lpad(nextval(...)::text, 5, '0')` — DB function yoki application-level, ikkalasi ham mumkin, lekin **DB sequence haqiqat manbai** (concurrency xavfsizligi uchun).

Qabul mezonlari (DoD)

4 / 4 bajarildi

  • `product_variants.code` avtomatik `P00001`, `P00002`… ketma-ket, `UNIQUE` violation ikkinchi marta qo'lda urinishda

    qa-ep-02-t01-s02 · 1 о аввал

  • `image_file_key` to'ldirilib `image_mime_type` bo'sh qoldirilsa INSERT rad etiladi (CHECK testi)

    qa-ep-02-t01-s02 · 1 о аввал

  • `product_attributes` da bir (product,attribute) juftligi ikki marta kiritilmaydi

    qa-ep-02-t01-s02 · 1 о аввал

  • `variant_attribute_values` da bir variantga bitta atributdan ikki qiymat kiritilmaydi

    qa-ep-02-t01-s02 · 1 о аввал

O'zgargan fayllar

2 ta

  • modified src/test/java/uz/erpbom/products/ProductsAndVariantsMigrationTest.java
  • modified src/main/resources/db/migration/V9__products_and_variants.sql

Izoh qoldirish

Tarix

20 yozuv

  • ✎

    finalize-ep-02 yangiladi

    Yangilandi: commit_sha

  • 💬

    qa-ep-02-t01-s02 izoh qoldirdi

    QA PASS. Mustaqil tekshirildi: V9__products_and_variants.sql (products/product_variants/product_attributes/variant_attribute_values) spec #2.3/#2.4/#2.4a/#2.8/#2.9 bilan qator-qator solishtirildi. AC991-994 — barchasi kod darajasida tasdiqlandi: DB sequence orqali P+5xona ketma-ket kod (MAXVALUE 99999, NO CYCLE — sigim edge-case ham qamrab olingan), UNIQUE(code) butun DB boylab; image_* CHECK all-or-nothing; UNIQUE(product_id,attribute_id); UNIQUE(product_variant_id,attribute_id) trigger orqali attribute_id sinxronlab. Test: flock ostida mvn -Dtest=ProductsAndVariantsMigrationTest,ProductDictionariesMigrationTest test -> Tests run: 30, Failures: 0 (17+13), BUILD SUCCESS. Mutatsiya tekshiruvi: uq_variant_attribute_values_variant_id_attribute_id vaqtincha kommentga olindi -> aynan AC994 testi (secondValueForSameAttributeOnSameVariantIsRejected) qulad, qolgan 12 test yashil qoldi (haqiqiy tekshiruv, false-positive emas). git checkout -- bilan tiklandi, diff HEAD ga nisbatan boʻsh, keyin qayta test yashil. Kontrakt: openapi/v1/products.yaml (ProductResponse/ProductVariantResponse/ProductAttributeResponse/VariantAttributeValueResponse) — id/FK maydonlari bigint(int64), code minLength/maxLength=6, image_* nullable, audit ustunlari yoq — migratsiya bilan mos. Cross-cutting: tenant_id/organization_id yoq (AR-1, test bilan tasdiqlangan); barcha FK oddiy bigint (AR-10); outbox/async N/A (sof migratsiya); nomlash snake_case+kolplik+FK toliq nomdan mos; qty/price ustuni yoq (N/A); deleted_at faqat spec belgilagan 2 jadvalda (products, product_variants); parol/audit N/A. CATEGORY_NOT_LEAF/BRAND_INACTIVE va attribute_id trigger yechimi — spec 2.9 ochiq qoldirgan ikkita variantdan (a) ni tanlagan, qonuniy. Regressiya yoq (V8 testlari ham yashil). Status -> done.

  • ⇄

    qa-ep-02-t01-s02 statusni o'zgartirdi Review → Bajarildi

  • ✓

    qa-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `variant_attribute_values` da bir variantga bitta atributdan ikki qiymat kiritilmaydi

  • ✓

    qa-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `product_attributes` da bir (product,attribute) juftligi ikki marta kiritilmaydi

  • ✓

    qa-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `image_file_key` to'ldirilib `image_mime_type` bo'sh qoldirilsa INSERT rad etiladi (CHECK testi)

  • ✓

    qa-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `product_variants.code` avtomatik `P00001`, `P00002`… ketma-ket, `UNIQUE` violation ikkinchi marta qo'lda urinishda

  • ⇄

    coder-ep-02-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

  • ✎

    coder-ep-02-t01-s02 yangiladi

    Yangilandi: branch, commit_sha

  • ✓

    coder-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `variant_attribute_values` da bir variantga bitta atributdan ikki qiymat kiritilmaydi

  • ✓

    coder-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `product_attributes` da bir (product,attribute) juftligi ikki marta kiritilmaydi

  • ✓

    coder-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `image_file_key` to'ldirilib `image_mime_type` bo'sh qoldirilsa INSERT rad etiladi (CHECK testi)

  • ✓

    coder-ep-02-t01-s02 qabul mezonini belgiladi

    ✓ `product_variants.code` avtomatik `P00001`, `P00002`… ketma-ket, `UNIQUE` violation ikkinchi marta qo'lda urinishda

  • 📄

    coder-ep-02-t01-s02 fayllarni qayd etdi

    2 ta fayl qayd etildi

  • ⇄

    coder-ep-02-t01-s02 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-02-t01-s02 ishga oldi

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-02-T01-S01

  • ✎

    pm-agent yangiladi

    Yangilandi: estimate_hours

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-02-T01-S01

  • ✦

    pm-agent yaratdi

    Tovar va Variant (SKU) — products, product_variants, biriktiruvchi jadvallar

Ma'lumot

Agent
coder-ep-02-t01-s02
Olingan
1 о аввал
Boshlandi
18.08.2026 18:36
Tugadi
18.08.2026 18:50
Baho
6 soat
Spec
erp/docs/modules/02_products.md#2.4a
Branch
feat/EP-02-erpbom-backend
Commit
4b90a3e35337

Bog'liqliklar

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-02-T01-S02/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-02-T01-S02/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'