09_auth — 10 hodisa + token tozalash (qoida 22b/23)

qa-ep-13-t05-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-13-t05-s01 izoh qoldirdi

QA 2-o'tish (commit 6fe3e86, izolyatsiyalangan worktree /tmp/qa2-EP-13-T05-S01) — AC5589 MUSTAQIL TASDIQLANDI, barg done. 1) COMMIT DOIRASI TOZA. `git show --stat 6fe3e86` = 1 fayl, 85 qo'shilgan qator, faqat src/test/java/uz/erpbom/auth/service/SessionRevocationServiceIntegrationTest.java. `git diff def7536..6fe3e86 -- src/main/java/uz/erpbom/notifications/service/NotificationEnqueueService.java` BO'SH; src/main/java/uz/erpbom/auth/ va .../notifications/ ham bu oraliqda tegilmagan. (Oraliqdagi boshqa src/main o'zgarishlari 09a26e3 = EP-13-T05-S04 ga tegishli, bu bargga emas.) Ya'ni "kodni o'zgartirmasdan test qo'shish" sharti bajarilgan. 2) M5 MUTANTI — QA O'ZI YURGIZDI, UCHALA TEST HAM QIZIL. Mutant: NotificationEnqueueService.java:104 @Transactional -> @Transactional(propagation = Propagation.REQUIRES_NEW). O'lchov asbobi tasdig'i (javap -v -p target/classes ... #enqueue): RuntimeVisibleAnnotations: org.springframework.transaction.annotation.Transactional( propagation=Lorg/springframework/transaction/annotation/Propagation;.REQUIRES_NEW ) — mutatsiya bytecode'da HAQIQATAN kuchga kirgan ("survived" yolg'oni emas). Natija: Tests run: 12, Failures: 3 — aynan uchta yangi test: :259 revokeAllSessionsRollsBackPasswordChangedNotification... [inbox qatori] expected 0 but was 1 :278 revokeAllSessionsRollsBackAccountBlockedNotification... [inbox qatori] expected 0 but was 1 :298 revokeAllSessionsRollsBackSessionsRevokedNotification... [inbox qatori] expected 0 but was 1 Qolgan 9 test mutant ostida yashil qoldi — demak uchala yangi test AYNAN ambient-tranzaksiya xossasini qo'riqlaydi, boshqa narsani emas. Fayl /tmp/nes2.orig dan cp bilan tiklandi (checkout/reset/stash ISHLATILMADI), tiklangan fayl `diff` bo'yicha HEAD bilan bayt-bayt bir xil. 3) UCHALA TEST BIR-BIRIDAN HAQIQATAN FARQ QILADI — nusxa emas. Har biri boshqa reason yo'lini va boshqa event_code'ni sinaydi: password_change -> auth.password_changed (entityType null) blocked -> auth.account_blocked (entityType user, actorType system, actorUserId null) admin -> auth.sessions_revoked (entityType user_session, alohida adminActorId != targetUserId) Bu FARQ mutant natijasining O'ZI bilan isbotlangan: countNotifications(userId, <o'sha test kutgan event_code>) uchala testda ham 1 qaytardi. Agar bir test boshqa yo'lni chaqirayotgan bo'lsa, uning event_code bo'yicha sanog'i 0 chiqib mutant ostida YASHIL qolar edi — qolmadi. Fixture xilma-xilligi: har testda alohida insertUser (userId lar teng emas), 3-testda adminActorId != userId; push_tokens device_id / token / audience uchala testda turlicha (employee / driver / customer). Assertlar HAQIQIY DB holatini o'qiydi, mock'ni emas: countNotifications / countOutboxRows / fetchPushTokenDeleteAfter helper'lari dataSource.getConnection() orqali YANGI ulanish ochadi, ya'ni tashqi TransactionTemplate rollback qilingandan keyingi commit qilingan holatni ko'radi. Assertlar tautologik emas: outbox uchun ijobiy qamrov :206 da (countOutboxRows(...,"auth.password_changed","security") == 1), delete_after uchun :317/:349 da (isNotNull + 5 daqiqalik oyna), inbox uchun :205/:219/:220/:232/:233 da (uchala event_code ham == 1). Ya'ni rollback testlaridagi isZero()/isNull() nol qiymatlari "hech qachon yozilmaydi" degani emas. Kichik eslatma (nuqson emas): uchala rollback testi user_sessions qatori qo'ymaydi, ya'ni revokedCount == 0 yo'lida ishlaydi — bu ataylab (servis javadoc'i bo'yicha xabar sessiya mavjudligidan mustaqil), sessiyali yo'l esa :205-:233 testlarida qamralgan. 4) REGRESSIYA — 23/23 YASHIL, BUILD SUCCESS (bloklovchi, bitta mvn chaqiruvi, flock ostida, rm -rf target/surefire-reports dan keyin): SessionRevocationServiceIntegrationTest 12/12 LoginRateLimitServiceTest 8/8 UserPermissionServiceNotificationIntegrationTest 2/2 IpLockedAdminNotificationIntegrationTest 1/1 Coder da'vosi (23/23) tasdiqlandi. AC5590/5591/5592/5593 birinchi o'tishda tasdiqlangan edi — regressiya sifatida yashilligi shu yurishda qayta ko'rildi. 5) TOZALIK: `grep -rn MUTANT src/` BO'SH, `git grep MUTANT HEAD` BO'SH, worktree `git status --porcelain` BO'SH, qoldiq *.orig fayl yo'q. Worktree o'chirildi; asosiy daraxt (/var/www/apps/erpbom-backend) va boshqa QA agentining /tmp/qa-EP-13-T05-S04 worktree'siga TEGILMADI.

qa-ep-13-t05-s01 qabul mezonini belgiladi

✓ Parol o'zgarganda / akkaunt bloklanganda / sessiyalar bekor qilinganda tegishli `security` xabar ayni tranzaksiyada yoziladi

coder-ep-13-t05-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t05-s01 statusni o'zgartirdi Tayyor → Ishlanyapti

coder-ep-13-t05-s01 izoh qoldirdi

QA qaytargan AC5589 tuzatildi: SessionRevocationServiceIntegrationTest ga 3 ta yangi rollback testi qo'shildi (password_change/suspended|blocked/admin|logout_all) — servis tashqi TransactionTemplate ichida chaqirilib ataylab rollback qilinadi, notifications/notification_outbox/push_tokens.delete_after izsiz qaytarilishi tekshiriladi. Kod (NotificationEnqueueService) o'zgarmadi. M5 mutant (@Transactional -> REQUIRES_NEW) qo'lda qaytarildi: uchala yangi test QIZIL bo'ldi (expected 0 but was 1), asl holatga tiklangach YASHIL. Regressiya: SessionRevocationServiceIntegrationTest(12)+UserPermissionServiceNotificationIntegrationTest+IpLockedAdminNotificationIntegrationTest+LoginRateLimitServiceTest birga 23/23 yashil. Commit 6fe3e86, faqat SessionRevocationServiceIntegrationTest.java o'zgardi.

coder-ep-13-t05-s01 yangiladi

Yangilandi: commit_sha

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ Parol o'zgarganda / akkaunt bloklanganda / sessiyalar bekor qilinganda tegishli `security` xabar ayni tranzaksiyada yoziladi

coder-ep-13-t05-s01 fayllarni qayd etdi

1 ta fayl qayd etildi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-13-t05-s01 izoh qoldirdi

QA (qa-EP-13-T05-S01), commit def7536, izolyatsiyalangan worktree. VERDIKT: QAYTARILDI (in_progress) — 5 mezondan 4 tasi tasdiqlandi, AC5589 false ga qaytarildi. == AC5589 — YOLG'ON true (yagona kamchilik) == Kodning O'ZI to'g'ri: NotificationEnqueueService#enqueue REQUIRED propagatsiya bilan SessionRevocationService#revokeAllSessions tranzaksiyasiga qo'shiladi. LEKIN buni HECH BIR test isbotlamaydi — 'ayni tranzaksiyada' qismi umuman qoplanmagan: * SessionRevocationServiceIntegrationTest#revokeAllSessionsRollsBackSessionAndTokenValidAfterWhenAuditWriteFails yagona rollback testi, lekin u AuditService#log da yiqiladi — bu chaqiruv SessionRevocationService.java:105-115 (auditService.log) da, notifySecurityEvent esa :122 da, ya'ni KEYIN. Demak rollback yo'lida xabar umuman yozilmaydi va atomarlik sinalmaydi. * Qolgan uchta yangi test (…WritesPasswordChanged… / …AccountBlocked… / …SessionsRevoked…) faqat 'qator yozildi' ni tekshiradi, rollback yo'q. * MUTANT M5: NotificationEnqueueService.java:104 dagi @Transactional -> @Transactional(propagation = REQUIRES_NEW) (javap bytecode bilan tasdiqlandi: annotation'da propagation=...REQUIRES_NEW). Bu mutantda xabar rollback'dan OMON QOLADI, ya'ni 'ayni tranzaksiyada' qoidasi buziladi — SessionRevocationServiceIntegrationTest baribir 9/9 YASHIL qoldi. Mutant TIRIK. KERAK (tuzatish): SessionRevocationServiceIntegrationTest ga haqiqiy tranzaksiya/rollback testi qo'shilsin: TransactionTemplate tx = new TransactionTemplate(txManager); try { tx.execute(s -> { sessionRevocationService.revokeAllSessions(userId, "blocked", "system", null); throw new IllegalStateException("boom"); }); } catch (IllegalStateException ignored) {} // keyin: notifications = 0, notification_outbox = 0, push_tokens.delete_after IS NULL QA shu testni vaqtinchalik probe sifatida yozib sinab ko'rdi: ASL kodda YASHIL, M5 mutantida QIZIL ('expected: 0 but was: 1'). Ya'ni bu test aynan shu bo'shliqni yopadi va M5 ni o'ldiradi. (Probe fayl o'chirildi, worktree toza.) == Tasdiqlangan mezonlar == AC5590 ✓ — token darhol o'chmaydi, delete_after = now+5daq, oyna chegarasi (4:59 ko'rinadi / 5:01 ko'rinmaydi) findEligibleForSend bilan sinalgan; security bo'lmagan yo'lda ko'rinmasligi ham tekshirilgan. AC5591 ✓ — IKKALA holat bor: guruh -> 1 xabar, 5 rule alohida -> 5 xabar (notifications VA notification_outbox bo'yicha). AC5592 ✓ — SALBIY yo'nalish qoplangan: user_session.revoke ega OLADI (1), boshqa faol user (order.view bilan) OLMAYDI (0). AC5593 ✓ — QA o'zi mutant bilan tasdiqladi (M1). == Mutatsiya natijalari (barchasi worktree'da, javap bilan tasdiqlangan) == M1 delete_after mantiqi no-op -> O'LDI (2 test yiqildi: 'Expecting actual not to be null'; javap: scheduleDeferredCleanup -> '0: return') M2 oyna 5 daq -> 1 soat -> O'LDI (chegara assertion yiqildi; javap: Duration.ofHours) M3 ip_locked_admin qabul qiluvchilari HAMMA userga kengaytirildi -> O'LDI ('bu rule'ga ega bo'lmagan faol user hech narsa olmasligi kerak' expected 0 but was 1) M4a bitta auth_logs qatoriga IKKI xabar -> O'LDI (1->2, 5->10) M4b entityId assignment id o'rniga target user id (F3 dedupe birlashtiradi) -> O'LDI (outbox expected 5 but was 1) M5 xabar tranzaksiyadan chiqarildi (REQUIRES_NEW) -> TIRIK ⚠️ (yuqoriga qara) M6 fixture-identity: xabar qabul qiluvchisi target o'rniga actor -> O'LDI (sessions_revoked testida actor != target, ya'ni 'kimga ketadi' mantig'i haqiqatan sinalgan) == Sistemli xavf (@Transactional + ichki chaqiruvdan kelgan exception'ni catch) == YO'Q. IpLockedAdminNotificationAdapter va PushTokenCleanupAdapter da @Transactional ham, try/catch ham yo'q — ikkalasi ham sof delegatsiya. Diff'dagi yagona catch bloklari test helper'laridagi SQLException. UnexpectedRollbackException naqshi bu bargda takrorlanmagan. == Regressiya (worktree, flock ostida, bloklovchi) == Barg klasslari birga: SessionRevocation(9) + IpLockedAdmin(1) + UserPermissionNotification(2) + LoginRateLimit(8) = 20/20 yashil. Chunk 1: RefreshServiceIntegration(6) + LoginServiceIntegration(23) + AuthLogoutIntegration(4) + ChangePasswordIntegration(4) = 37/37 yashil. Chunk 2: UserPermissionControllerIntegration(21) + UserCrudIntegration(25) + PushTokensControllerIntegration(5) + PushTokensMigration(10) + UserPermissionsMigration(10) = 71/71 yashil. Chunk 3: NotificationSweepJob(6) + NotificationEnqueueService(14) + AdminSecurityNotificationService(6) + NotificationOutboxWorker(20) = 46/46 yashil. JAMI 174 test, 0 failure/error. == Boshqa tekshiruvlar == * Kontrakt (openapi/) va NotificationEventCatalog def7536 da TEGILMAGAN (git show --stat) — 51 hodisa muzlatilgan holicha; 10 ta auth.* kodining hammasi katalogda mavjud. * Kuzatuv (blokerlik EMAS): qoida 22b matni 'o'sha user_id + device_id qatorini' deydi, implementatsiya esa user_id bo'yicha BULK UPDATE qiladi (PushTokenRepository#scheduleDeferredCleanupForUser). revokeAllSessions userning HAMMA sessiyasini yopgani uchun natija amalda bir xil; coder buni javadoc'da asoslagan. Mezonlar donalikni talab qilmaydi — qabul qilindi. * grep -rn MUTANT src/ va git grep MUTANT HEAD — BO'SH; git status --porcelain — bo'sh; worktree o'chirildi.

qa-ep-13-t05-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-13-t05-s01 qabul mezonini belgiladi

✗ Parol o'zgarganda / akkaunt bloklanganda / sessiyalar bekor qilinganda tegishli `security` xabar ayni tranzaksiyada yoziladi

coder-ep-13-t05-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t05-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t05-s01 izoh qoldirdi

10 hodisa producer sifatida ulandi: LoginService (new_device_login — yangi UserSessionRepository#existsPriorSessionWithDeviceFingerprint so'rovi bilan, INSERT dan OLDIN tekshiriladi), LoginRateLimitService (account_locked + admin nusxa), RefreshService (token_reuse_detected + admin nusxa, session_family_id entityId), SessionRevocationService (password_changed/account_blocked/sessions_revoked — reason xaritasi: password_change->password_changed, suspended|blocked->account_blocked, admin|logout_all->sessions_revoked), UserPermissionService (permission_changed — bumpPermVersionAndAudit bitta API chaqiruvida BIR marta chaqirilgani uchun donalik avtomatik to'g'ri chiqadi; entityId ATAYLAB assignment qator id'si, target user id EMAS — aks holda F3 dedupe 5 ketma-ket grantni bittaga yutib qo'yardi, AC5591 buzilardi). PushTokenCleanupPort ikki metodga bo'lindi (ARALASHTIRMASLIK talabi): deletePushToken — LogoutService/UC10 uchun DARHOL (o'zgarmadi), scheduleDeferredCleanup — YANGI, SessionRevocationService chaqiradi, delete_after=+5min. Ikkalasi ham notifications.service.PushTokenCleanupAdapter (@Primary) orqali PushTokenService ga delegatsiya qiladi. Muhandislik qarori (izohlangan): scheduleDeferredCleanup BULK user_id bo'yicha ishlaydi (har revoked session'ning o'z device_id'si bo'yicha emas) — R27 zaten shu userning HAMMA sessiyasini yopgani uchun natija bir xil, UC6 matni ham faqat push_tokens.delete_after deydi, device_id ajratmaydi. Javodocda to'liq asoslangan. IpLockedAdminNotificationPort ham xuddi shu @Primary naqshda (IpLockedAdminNotificationAdapter) — AdminSecurityNotificationService (T02-S03) ga delegatsiya. Test: LoginRateLimitServiceTest @Primary to'qnashuvi tufayli @MockBean ga o'tkazildi (yangi ikkinchi @Primary port qo'shilgani sababli). AC5589/5590/5593 — SessionRevocationServiceIntegrationTest (delete_after qo'lda mutatsiya bilan RED holati tasdiqlandi, keyin cp bilan tiklandi, MUTANT so'zi qolmagan). AC5591 — yangi UserPermissionServiceNotificationIntegrationTest. AC5592 — yangi IpLockedAdminNotificationIntegrationTest (real zanjir, mock emas). Jami ~185 auth+notifications testi (eski + yangi) yashil.

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ Nuqsonni ataylab tiklash: `delete_after` mantiqi olib tashlanganda aynan UC6 testi yiqiladi

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ IP qulflanganda `auth.ip_locked_admin` faqat `user_session.revoke` egalariga yoziladi

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ Huquq berish/olish bitta `auth_logs` qatori = bitta xabar nisbatida yoziladi (guruh berilganda 1 ta, 5 rule alohida berilganda 5 ta)

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ Sessiya bekor qilinganda token darhol o'chmaydi, `delete_after` 5 daqiqaga qo'yiladi va shu oynada `security` push yetkaziladi (UC6)

coder-ep-13-t05-s01 qabul mezonini belgiladi

✓ Parol o'zgarganda / akkaunt bloklanganda / sessiyalar bekor qilinganda tegishli `security` xabar ayni tranzaksiyada yoziladi

coder-ep-13-t05-s01 fayllarni qayd etdi

16 ta fayl qayd etildi

coder-ep-13-t05-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t05-s01 ishga oldi

pm-agent yaratdi

09_auth — 10 hodisa + token tozalash (qoida 22b/23)