Sozlama endpointlari (UC7) — user override, tenant sukuti, katalog

qa-ep-13-t04-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-13-t04-s03 izoh qoldirdi

QA 2-tekshiruv (qa-EP-13-T04-S03), commit 096df9c, yangi izolyatsiyalangan worktree — O'TDI. MUSTAQIL TASDIQ: `git diff --stat 07f01f6 096df9c -- src/main/` VA `git diff --stat 5cb030c 096df9c -- src/main/` — ikkalasi ham BO'SH, ya'ni ishlab chiqarish kodi tegilmagan; butun diff = faqat test fayli (+191 qator). UCH TIRIK MUTANT ENDI O'LDI (har biri javap bilan klasspathda tasdiqlangan, cp bilan tiklangan): - M8 (`NotificationPreferenceService.java:182` -> `can_disable` doimiy true; javap: canDisable() chaqiruvi 0 ta) -> canDisableReflectsSecurityInEventsCatalogResponse:248 YIQILDI ('auth.password_changed — security hodisa uchun can_disable=false bo'lishi kerak'). - M9 (`:173-175` -> `security ||` olib tashlandi; javap: toResponse dagi NotificationSeverity.SECURITY getstatic yo'q, faqat requireConfigurable dagisi qoldi) -> securityEventIgnoresRawlyWrittenPreferenceOverrideInCatalog:278 YIQILDI. - M10 (repository: `DELETE ... WHERE event_code = ?` scope shartisiz; javap -constants bilan bytecode'dagi SQL satri tasdiqlangan) -> deletingTenantPreferenceDoesNotTouchUserScopeOverrides:330 YIQILDI ('tenant DELETE ikki user override qatoriga TEGMASLIGI kerak'). YANGI TESTLAR TAUTOLOGIK EMAS: (B) DB'ga raw SQL bilan auth.sessions_revoked uchun scope='user' false/false qator yozib, GET javobida push_enabled=true VA inapp_enabled=true kelishini da'vo qiladi (kodni emas, natijani tekshiradi). (C) IKKI xil userga TURLI qiymatli override (true/false va false/true) yozadi, tenant DELETE dan keyin scope bo'yicha sanaydi (tenant=0, user=2) va har ikki userning user_push/user_inapp qiymatlarini hamda F2 natijasi o'z override'iga ergashishini alohida tekshiradi — fixture bir xilligi tuzog'iga tushmagan. (D) TARTIB BOG'LIQLIGI — O'LCHOV BILAN YOPILGANI TASDIQLANDI. Sistema xossasi bo'yicha random orderer system-property orqali kuchga kirmadi, shuning uchun vaqtinchalik teskari MethodOrderer probe'i bilan tartib majburan aylantirildi: threeLayerResolution... #2, securityEventPutIsRejected... #4 (ya'ni 5585 endi 5583 dan OLDIN yuradi) -> 13/13 YASHIL. Probe'ning o'zi haqiqiy asbob ekani ham tasdiqlandi: ayni teskari tartibda test faylidan `deleteRawUserPreference(userId, "auth.account_blocked")` qatorini olib tashlaganda securityEventPutIsRejected... 'expected: 0L' bilan YIQILDI. Probe fayllari (QaTempReverseOrderer.java, src/test/resources/junit-platform.properties va ularning .class/target nusxalari) o'chirildi — git status toza. TO'LIQ TO'PLAM: 186 test / 0 xato / 0 error / 0 skip, BUILD SUCCESS (oldingi o'lchov 183; +3 yangi test — kamaymadi). NotificationPreferenceControllerIntegrationTest = 13 test, surefire hisobotida BOR (filtrga tushgani tasdiqlangan). Yakuniy holat: worktree'da grep -rn MUTANT src/ bo'sh, .orig fayl yo'q, git status toza; asosiy repo'da git grep MUTANT HEAD bo'sh; worktree o'chirildi. Kodga, kontraktga va erp/docs ga tegilmadi. 4 mezon (5582-5585) 1-tekshiruvda mutatsiya bilan isbotlangan holda qoladi -> status: done.

coder-ep-13-t04-s03 yangiladi

Yangilandi: commit_sha

coder-ep-13-t04-s03 izoh qoldirdi

QA 1-qaytish (A/B/C) yopildi: can_disable, security F2 filtri, tenant DELETE doirasi — uch mutant ham navbatma-navbat tasdiqlab o'ldirildi (commit 096df9c). D (5583/5585 event_code tartib bog'liqligi) ham tuzatildi. 186 test/0 xato (23 klass, +3). src/main o'zgarmagan (mezonlar 5582-5585 allaqachon is_met=true).

coder-ep-13-t04-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t04-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

coder-ep-13-t04-s03 statusni o'zgartirdi Tayyor → Ishlanyapti

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-13-t04-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-13-t04-s03 izoh qoldirdi

QA (qa-EP-13-T04-S03), commit 5cb030c, izolyatsiyalangan worktree. POYDEVOR: 181 test / 0 xato / 0 skip (171 eski + yangi klass 10 test; NotificationPreferenceControllerIntegrationTest surefire hisobotida BOR — filtrga tushgani tasdiqlangan). 4 mezon (5582/5583/5584/5585) mutatsiya bilan ISBOTLANDI: (1) tenant yo'llardan @RequirePermission olib tashlandi (javap: annotatsiya 0 ta) -> 5582 yiqildi; (2) requireConfigurable no-op (javap: '0: return') -> 5583 yiqildi; (2b) 409 HAMON qaytadi, lekin qator yozilib qoladi (noRollbackFor + upsert tekshiruvdan oldin) -> 5583 'expected: 0L' bilan yiqildi, ya'ni 'jadvalga hech narsa yozilmaydi' yarmi ALOHIDA qo'riqlangan; (3) is_admin_copy filtri olib tashlandi -> 5584 yiqildi; (4) filtr sahifalashdan KEYIN (total filtrdan oldin) -> 5584 'expected: 44L' bilan yiqildi, izchillik qoplangan; (5) F2 COALESCE teskari (enqueue) -> 5585 yiqildi; (6) NotificationEnqueueService security shoxi o'chirildi (javap: SECURITY getstatic 0) -> 5585 yiqildi; (7) DELETE me -> 'true yozish' -> 2 test yiqildi. Hamma mutant tiklandi (cp), git status toza, MUTANT grep bo'sh. QAYTARISH SABABI — 3 ta mutant TO'LIQ 181 testlik to'plamdan TIRIK o'tdi (kod TO'G'RI, TEST YO'Q). Uchalasi ham brifda 'aynan tekshir' deb sanalgan kontrakt talabi: (A) can_disable API maydoni umuman da'vo qilinmagan. Mutant: NotificationPreferenceService.java:182 dagi `definition.canDisable(),` -> doimiy `true` — 181 test YASHIL qoldi. NotificationEventCatalogTest faqat katalog (T02) darajasidagi canDisable() ni tekshiradi; GET /notification-events JSON javobida `can_disable` hech qayerda tekshirilmagan. Bu — UI o'chirish tugmasini yashiradigan yagona maydon (AC6/AC12, qoida 12). KERAK: NotificationPreferenceControllerIntegrationTest da katalog javobi bo'ylab har qator uchun `can_disable == (severity != 'security')` da'vosi (6 ta security kod uchun false, qolganlar true). (B) GET katalogida `severity='security' -> push_enabled=true, inapp_enabled=true` majburiyligi qo'riqlanmagan. Mutant: NotificationPreferenceService.java:173-175 dagi `security ||` prefiksi olib tashlandi -> 181 test YASHIL. Enqueue tomoni qoplangan (mutant 6 o'ldi), lekin toResponse() dagi shoxobcha alohida kod va qoplanmagan. KERAK: DB'ga to'g'ridan-to'g'ri (insertRawUserPreference bilan, API 409 beradi) `auth.account_blocked` uchun scope='user' false/false qator kiritilgach GET /notification-events da o'sha qator `push_enabled=true`, `inapp_enabled=true`, `can_disable=false`, `user_push_enabled=false` (xom qatlam ko'rinadi, amaldagi qiymat esa majburiy true) ekanini tekshiruvchi test. (C) DELETE tenant/{event_code} `scope='user'` override'larga tegmasligi qo'riqlanmagan. Mutant: deleteTenantPreference (NotificationPreferenceService.java:141-145) repository'da `DELETE ... WHERE event_code = ?` (scope shartisiz) ga o'zgartirildi -> 181 test YASHIL, ya'ni har bir userning override'i jimgina yo'q qilinishi hech qayerda ushlanmaydi. threeLayerResolution... testida 4-qadamda tenant o'chirilganda user override ALLAQACHON o'chirilgan (3-qadam), shu sababli holat qamralmagan. KERAK: tenant qatori VA user override birga turgan holatda DELETE tenant/... -> 204, so'ng GET da o'sha hodisada `user_push_enabled` HAMON mavjud (null EMAS) va `tenant_push_enabled = null` ekanini da'vo qiluvchi test. QO'SHIMCHA (bloklovchi emas, lekin tuzatilsa yaxshi): NotificationPreferenceControllerIntegrationTest da test tartibiga bog'liqlik bor — securityEventPutIsRejectedOnBothScopesAndTableStaysEmpty `countPreferenceRows("auth.account_blocked")` ni 0 deb kutadi, threeLayerResolutionIntegratesEndToEndWithEnqueueService esa AYNI event_code ga insertRawUserPreference bilan qator yozadi va tozalamaydi. Hozir JUnit tartibi 5583 ni oldin yurgizgani uchun yashil; tartib o'zgarsa (yangi test qo'shilsa/JDK yangilansa) 5583 sababsiz qizil bo'ladi. Yechim: raw qatorni test oxirida o'chirish yoki alohida event_code ishlatish. FIXTURE XILMA-XILLIGI — YETARLI: push/inapp to'rt kombinatsiyasi bor (true/false, false/true+user true/true, false/false, qatorsiz), ikki xil user har testda, security va oddiy hodisa, is_admin_copy bor/yo'q, sahifa chegarasi (size=100 bitta sahifa + size=3 bilan 15 sahifa, 44 ko'rinadigan qator, oxirida bo'sh sahifa). F2 to'rt holati: tenant-bor/user-yo'q, tenant+user, ikkisi ham yo'q — GET testida; 'user bor / tenant yo'q' holati GET da yo'q, lekin NotificationEnqueueServiceTest da (inappDisabledWritesPushOnlyOutboxRow..., bothChannelsDisabledWritesNothing) qamralgan. KONTRAKT MOSLIGI (o'tdi): GET /notification-events PageParam/SizeParam + total_items/total_pages konverti (kursor EMAS); me yo'llarida rule YO'Q, tenant yo'llarida notification_setting.manage BOR (javap bilan tasdiqlangan, grep bilan emas); PUT me -> 200, security -> 409 SECURITY_EVENT_NOT_CONFIGURABLE, noma'lum kod -> 404, is_admin_copy qator huquqsiz userdan -> 404 (403 emas); DELETE -> 204 idempotent; maydon nomlari/tiplari kontraktdagidek (snake_case, user_*/tenant_* nullable). Kontraktga tegilmagan.

qa-ep-13-t04-s03 qabul mezonini belgiladi

✓ Sozlama o'chirilgan hodisa enqueue'da yozilmaydi (F2 bilan uchdan-uch bog'langan)

qa-ep-13-t04-s03 qabul mezonini belgiladi

✓ Katalog javobida `auth.*_admin` qatorlari faqat `user_session.revoke` egasiga ko'rinadi

qa-ep-13-t04-s03 qabul mezonini belgiladi

✓ `security` hodisa uchun sozlama yozish urinishida xato qaytadi va jadvalga hech narsa yozilmaydi

qa-ep-13-t04-s03 qabul mezonini belgiladi

✓ `notification_setting.manage` huquqisiz user tenant sozlamasini o'zgartira olmaydi (403)

coder-ep-13-t04-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t04-s03 izoh qoldirdi

5 operatsiya qo'shildi: GET /notification-events (katalog + F2 uch qatlamli sozlama, is_admin_copy filtri sahifalashdan OLDIN qo'llanadi — total_items filtrdan keyin hisoblanadi), PUT/DELETE /notification-preferences/me/{event_code} (rule yo'q, obyekt darajasida), PUT/DELETE /notification-preferences/tenant/{event_code} (notification_setting.manage, @RequirePermission). security hodisa -> 409 SECURITY_EVENT_NOT_CONFIGURABLE, jadvalga yozilmaydi (DB count(*) bilan tasdiqlangan). Repository (NotificationPreferenceRepository) ga upsert/delete + findAllTenantPreferences/findAllUserPreferences qo'shildi, mavjud findTenantPreference/findUserPreferences (NotificationEnqueueService ishlatadi) O'ZGARTIRILMADI. Yangi migratsiya YOZILMADI (V53 jadvali va notification_setting.manage rule allaqachon bor). Test: NotificationPreferenceControllerIntegrationTest (10 metod) — mvn -o test -Dtest="Notification*Test,PushTokens*Test,AdminSecurityNotification*Test,Fcm*Test": Tests run: 181, Failures: 0, Errors: 0 (avvalgi ≥170 dan oshdi). Mezon 5585 uchdan-uch (tenant disable -> user re-enable COALESCE ustunligi -> user delete -> tenant delete -> kod sukuti) + security hodisa DB'ga to'g'ridan-to'g'ri kiritilgan 'o'chirilgan' qatorga qaramay kelishi NotificationEnqueueService bilan bevosita chaqiruv orqali sinaldi. git show --stat HEAD tasdiqlandi — faqat shu bargning 7 fayli, begona narsa yo'q. grep MUTANT src/ bo'sh.

coder-ep-13-t04-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t04-s03 qabul mezonini belgiladi

✓ Sozlama o'chirilgan hodisa enqueue'da yozilmaydi (F2 bilan uchdan-uch bog'langan)

coder-ep-13-t04-s03 qabul mezonini belgiladi

✓ Katalog javobida `auth.*_admin` qatorlari faqat `user_session.revoke` egasiga ko'rinadi

coder-ep-13-t04-s03 qabul mezonini belgiladi

✓ `security` hodisa uchun sozlama yozish urinishida xato qaytadi va jadvalga hech narsa yozilmaydi

coder-ep-13-t04-s03 qabul mezonini belgiladi

✓ `notification_setting.manage` huquqisiz user tenant sozlamasini o'zgartira olmaydi (403)

coder-ep-13-t04-s03 fayllarni qayd etdi

7 ta fayl qayd etildi

coder-ep-13-t04-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t04-s03 ishga oldi

pm-agent yaratdi

Sozlama endpointlari (UC7) — user override, tenant sukuti, katalog