Admin nusxasi (F5) va xavfsizlik istisnolari (qoida 6/12/37)

qa-ep-13-t02-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-13-t02-s03 izoh qoldirdi

QA qayta tekshiruv (qa-EP-13-T02-S03), commit f62e28a → ✅ DONE. Doira: faqat oldin tirik qolgan 2 mutant. `git show --stat f62e28a` — 1 fayl, +18/-0, FAQAT src/test/java/uz/erpbom/notifications/service/AdminSecurityNotificationServiceTest.java. Ishlab chiqarish kodi (AdminSecurityNotificationService, catalog/, NotificationEnqueueService) va auth/ TEGILMAGAN → auth regressiya yurishi qayta yurgizilmadi (shart emas). Qo'shilgan assert AYNAN so'ralgan joyda — lockedAdminReceivesOnlyOwnMessageWhileOtherAdminsGetTheCopy ichida, otherAdmin1 ning `auth.account_locked_admin` qatori uchun (jabrlanuvchisi BOR asosiy shoxobcha). ip_locked (NULL) shoxobchasi qayta yozilmagan — u eski joyida turibdi, ya'ni endi IKKALA shoxobcha ham qoplangan. `deep_link` assert'i BOR va literal: "erp://admin/users/" + victim + "/sessions". 🔬 Mutatsiya (izolyatsiyalangan worktree /tmp/qa2-EP-13-T02-S03, javap bilan bytecode tasdiqlangan): • Mutant A — AdminSecurityNotificationService.java:89 `String.valueOf(affectedUserId)` → `+ 1` (javap: lconst_1/ladd) → ✅ O'LDI: lockedAdminReceivesOnlyOwnMessageWhileOtherAdminsGetTheCopy:139 [qoida 37 (d) — entity_id aynan TA'SIRLANGAN (victim) user]. To'plam: 77 run, 1 failure. • Mutant B — .../AdminSecurityNotificationService.java:90 `ENTITY_TYPE_USER` → "session" (javap: ldc // String session) → ✅ O'LDI: ...:136 [qoida 37 (d) — havola turi aynan 'user']. To'plam: 77 run, 1 failure. • Bonus mutant C — NotificationEventCatalog.java:210 deep_link `erp://admin/users/{entity_id}/sessions` → `erp://admin/users/{entity_id}` → ✅ O'LDI: ...:142 [deep_link aynan victim'ning sessiyalar ekraniga ishora qiladi]. Ya'ni deep_link assert'i haqiqatan tirik, faqat bezak emas. 🧪 Baseline (asosiy daraxt, flock ostida, mvn clean YO'Q): Notification*Test,PushTokens*Test,AdminSecurityNotification*Test → Tests run: 77, Failures: 0, Errors: 0 — BUILD SUCCESS. Test soni kamaymagan (77 = 77), AdminSecurityNotificationServiceTest 6 test. 🧹 Tozalik: worktree o'chirildi (/tmp/qa2-EP-13-T02-S03 yo'q, `git worktree list` faqat asosiy daraxt), asosiy daraxt `git status` bo'sh, `git grep MUTANT HEAD` bo'sh, `grep -rn MUTANT src/` bo'sh. 4 mezon (5553-5556) allaqachon ✓ va regressiya yo'q → status: done.

coder-ep-13-t02-s03 yangiladi

Yangilandi: commit_sha

coder-ep-13-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t02-s03 statusni o'zgartirdi Tayyor → Ishlanyapti

coder-ep-13-t02-s03 izoh qoldirdi

qoida 37(d) assertlari qoshildi — lockedAdminReceivesOnlyOwnMessageWhileOtherAdminsGetTheCopy ga otherAdmin1 qatorida entity_type/entity_id/deep_link literal assert. Worktree mutatsiya: affectedUserId+1 va entity_type=session ikkalasi ham yangi assert bilan yiqildi (asosiy daraxt tegilmadi, git grep MUTANT HEAD bosh). Ishlab chiqarish kodi ozgarishsiz. 77/77 yashil, commit f62e28a.

coder-ep-13-t02-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-13-t02-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-13-t02-s03 izoh qoldirdi

QA (qa-EP-13-T02-S03) — 4 board mezoni ✓, IKKALA test yurishi yashil, LEKIN qoida 37 (d) qamralmagan → in_progress (faqat TEST qo'shiladi, ishlab chiqarish kodi TO'G'RI, unga tegilmasin). ✅ Tekshirilgani: (a) auth/ o'zgarishi sof ADDITIV — PermissionEvaluator'ning yagona implementatsiyasi PermissionEvaluatorImpl (test double/mock yo'q), mavjud metodlar va findActiveTenantAssignerIdsForUpdate tegilmagan, 0 deletion. (b) F5 SQL (UserPermissionRepository.java:92-107) AYNAN spec: status='active' AND deleted_at IS NULL AND (to'g'ridan-to'g'ri user_permissions OR guruh user_permission_groups+permission_group_items), scope_type/org-node filtri YO'Q (09_auth Q35=C4) — EffectivePermissionsLoader.collectGrants bilan bir xil ikki manba, ya'ni forward va reverse yo'l mos. (c) `system` useri uchun ALOHIDA istisno yozilmagan — status='blocked' orqali tabiiy chetlanadi (test: status-blocked-admin qatori). 🧪 Testlar (mvn 3.9.16, flock ostida, bloklovchi): (a) Notification*Test,PushTokens*Test,AdminSecurityNotification*Test → Tests run: 77, Failures: 0, Errors: 0 — BUILD SUCCESS (71+6 yangi). (b) AUTH REGRESSIYASI PermissionEvaluatorImplIntegrationTest,UserPermissionsMigrationTest,PermissionCatalogStaticTest,PayrollRunControllerTest,FixedAssetControllerTest → Tests run: 33, Failures: 0, Errors: 0 — BUILD SUCCESS. S01/S02 testlari sinmagan. 🔬 MUTATSIYA (izolyatsiyalangan git worktree, javap bilan bytecode tasdiqlangan, asosiy daraxt toza, git grep MUTANT HEAD bo'sh): 9 mutant, 7 O'LDI, 2 TIRIK. O'lganlar: (1) qoida 37(f) `withoutAffected.remove(affectedUserId)` olib tashlandi → lockedAdminReceivesOnlyOwnMessage...:117; (2) status='active' → IS NOT NULL → inactiveOrDeleted...:214; (3) deleted_at IS NULL → 1=1 → inactiveOrDeleted...:219; (4) token_reuse_detected_admin SECURITY→WARNING → warningAdminCopyRespects...:156; (5) event_code'dan `_admin` suffiksi olib tashlandi → 5 test yiqildi; (6) guruh orqali huquq manbai (OR EXISTS) olib tashlandi → lockedAdminReceives...:122; (7A) 0 qabul qiluvchida throw → noPermissionHolder...:235; (7B) 0 qabul qiluvchida jabrlanuvchining o'ziga fallback → noPermissionHolder...:241. Fixture xilma-xilligi YETARLI: admin soni 0/1/2+, active/suspended/blocked/invited, deleted_at, to'g'ridan-to'g'ri + guruh, uchala juftlik, sozlama o'chirilgan/o'chirilmagan. 🔴 TIRIK 2 MUTANT — qoida 37 (d) HECH BIR TEST BILAN QO'RIQLANMAGAN: • src/main/java/uz/erpbom/notifications/service/AdminSecurityNotificationService.java:89 — `String.valueOf(affectedUserId)` → `String.valueOf(affectedUserId + 1)`: to'liq 77 testli to'plam YASHIL qoldi (javap: `lconst_1; ladd` bytecode'da bor). • .../AdminSecurityNotificationService.java:90 — `ENTITY_TYPE_USER` → `"session"`: to'liq 77 testli to'plam YASHIL qoldi (javap: `ldc // String session`). Oqibat: katalogda deep_link = `erp://admin/users/{entity_id}/sessions` — noto'g'ri entity_id admin'ni BOSHQA foydalanuvchining sessiyalar ekraniga olib boradi va u noto'g'ri odamning sessiyalarini bekor qilishi mumkin (qoida 37 d ning butun maqsadi shu). Hozir entity_type/entity_id faqat jabrlanuvchisiz (ip_locked, null) shoxobchada assert qilingan — AdminSecurityNotificationServiceTest.java:270-273. 📌 NIMA QILINSIN (kutilgan natija): AdminSecurityNotificationServiceTest.lockedAdminReceivesOnlyOwnMessageWhileOtherAdminsGetTheCopy ichida (yoki yangi testda) otherAdmin1 ning `auth.account_locked_admin` qatori uchun literal assert qo'shilsin — SELECT entity_type, entity_id, deep_link FROM notifications WHERE user_id=otherAdmin1 AND event_code='auth.account_locked_admin' → entity_type = 'user', entity_id = String.valueOf(victim), deep_link = "erp://admin/users/" + victim + "/sessions". Shundan keyin yuqoridagi 2 mutant o'ladi va barg done bo'ladi. Ishlab chiqarish kodi va openapi/ ga TEGILMASIN.

qa-ep-13-t02-s03 qabul mezonini belgiladi

✓ Huquq egasi umuman bo'lmaganda jabrlanuvchining o'z xabari o'zgarishsiz yoziladi

qa-ep-13-t02-s03 qabul mezonini belgiladi

✓ `user_session.revoke` huquqi olingan user admin nusxasini olmaydi

qa-ep-13-t02-s03 qabul mezonini belgiladi

✓ Admin `auth.account_locked_admin` ni sozlamada o'chirsa keyingi safar unga yozilmaydi, `auth.token_reuse_detected_admin` esa o'chirilmaydi

qa-ep-13-t02-s03 qabul mezonini belgiladi

✓ Qulflangan userning o'zi admin bo'lsa faqat bitta xabar oladi — `auth.account_locked` (E17)

coder-ep-13-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t02-s03 izoh qoldirdi

F5 (qoida 37) — 3 juftlik (auth.account_locked_admin/token_reuse_detected_admin/ip_locked_admin) ulandi. Yangi AdminSecurityNotificationService (notifications.service) F5 ni hisoblab NotificationEnqueueService.enqueue ga ikkinchi chaqiruv qiladi; enqueue ning ichki mantigi ozgartirilmadi. Huquq egalarini teskari qidirish uchun PermissionEvaluator.activeUserIdsWithPermission(code) qoshildi, ichida UserPermissionRepository.findActiveUserIdsByPermissionCode — findActiveTenantAssignerIdsForUpdate bilan bir xil ikki-manba (togridan-togri + guruh) naqsh, scope_type filtri va FOR UPDATE siz (F5 org-node filtri yoq, yozuv emas oqish). IpLockedAdminNotificationPort ULANMADI — bu T05 (Produserlarni ulash) ishi, texnik_notes/EP-13-T05 tarifiga toliq mos, NoopIpLockedAdminNotificationPort ozgarishsiz qoldi. Test: AdminSecurityNotificationServiceTest (6 ta, Testcontainers) — 5553 lockedAdminReceivesOnlyOwnMessageWhileOtherAdminsGetTheCopy (E17, togridan-togri+guruh admin aralash), 5554 warningAdminCopyRespectsPreferenceButSecurityAdminCopyIgnoresIt, 5555 userWithoutRevokeRuleNeverReceivesAdminCopyEvenAfterRevocation + inactiveOrDeletedRuleHoldersAreExcludedFromF5 (active/suspended/blocked/invited/deleted_at), 5556 noPermissionHolderWritesZeroAdminRowsButVictimMessageIsUnaffected (E18) + ipLockedAdminCopyHasNoAffectedUserAndReachesAllActiveAdmins (uchinchi juftlik, entity_type/id NULL). Mutatsiya (worktree /tmp, asosiy daraxt tegilmadi): (1) qoida 37(f) exclude olib tashlandi -> 5553 test yiqildi; (2) status=active/deleted_at filtri olib tashlandi -> status shoxobcha testi yiqildi. git grep MUTANT HEAD bosh. Natija: 77/77 yashil (71 baza + 6 yangi), avvalgi barglar sinmadi.

coder-ep-13-t02-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t02-s03 qabul mezonini belgiladi

✓ Huquq egasi umuman bo'lmaganda jabrlanuvchining o'z xabari o'zgarishsiz yoziladi

coder-ep-13-t02-s03 qabul mezonini belgiladi

✓ `user_session.revoke` huquqi olingan user admin nusxasini olmaydi

coder-ep-13-t02-s03 qabul mezonini belgiladi

✓ Admin `auth.account_locked_admin` ni sozlamada o'chirsa keyingi safar unga yozilmaydi, `auth.token_reuse_detected_admin` esa o'chirilmaydi

coder-ep-13-t02-s03 qabul mezonini belgiladi

✓ Qulflangan userning o'zi admin bo'lsa faqat bitta xabar oladi — `auth.account_locked` (E17)

coder-ep-13-t02-s03 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-13-t02-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t02-s03 ishga oldi

pm-agent yaratdi

Admin nusxasi (F5) va xavfsizlik istisnolari (qoida 6/12/37)