Enqueue servisi — snapshot, F2 sozlama, F3 dedupe, transaksion yozuv

qa-ep-13-t02-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-13-t02-s02 izoh qoldirdi

QA qayta tekshiruv (qa-EP-13-T02-S02) — commit ae5a855 ustida. VERDIKT: DONE. Doira: faqat D1 va D2. Ikkalasi ham endi O'LDI. Commit doirasi tasdiqlandi: `git show --stat ae5a855` -> 1 fayl, +88/-1, FAQAT src/test/java/uz/erpbom/notifications/service/NotificationEnqueueServiceTest.java. Ishlab chiqarish kodi (NotificationEnqueueService.java, NotificationOutboxRepository.java) va uz/erpbom/notifications/catalog/ TEGILMAGAN — kutilgandek. Mutatsiya (izolyatsiyalangan worktree /tmp/qa2-EP-13-T02-S02, HEAD=ae5a855; 3 mutant, 3 o'ldi): [D1] NotificationOutboxRepository.java:46 — interval '5 minutes' -> '5 hours' -> O'LDI: dedupeWindowBoundaryJustOutsideFiveMinutesWritesNewOutboxRow:207 ("5:01 oldingi qator ... yangi outbox qatori YOZILISHI kerak"). Oldin bu mutant 11 testdan tirik o'tgan edi. [D2] NotificationEnqueueService.java:168 — (entityId == null ? "-" : entityId + "!") -> O'LDI: nonNullEntityIdProducesLiteralDedupeKeyWithEntityIdSuffix:230 (+ yon ta'sirda dedupeWindowBoundaryJustInside...:190). javap: constant pool'da "\u0001!" recipe'iga 3 ta havola — mutant haqiqatan kompilyatsiya bo'lgan. [D3, QA qo'shimchasi — chegara ikki tomondan qo'riqlanganini isbotlash uchun] interval '5 minutes' -> '4 minutes' (oynani TORAYTIRISH) -> O'LDI: dedupeWindowBoundaryJustInsideFiveMinutesSkipsNewOutboxRow:190. Demak ikkala chegara testi ham o'z o'rnini oqlaydi: kengaytirishni 5:01 testi, toraytirishni 4:59 testi ushlaydi. F3 oynasi endi ikki tomondan qo'riqlangan. Testlar HAQIQIY DB holatini o'zgartiradi (soxta/mock emas): insertOutboxRow (test:373-379) notification_outbox ga to'g'ridan-to'g'ri INSERT qiladi va created_at ni DB tomonida `now() - ?::interval` bilan orqaga suradi; now() mock qilinmagan, dedupe SELECT'i shu real qatorni ko'radi. Test dalili: mvn -o test -Dtest='Notification*Test,PushTokens*Test' -> Tests run: 71, Failures: 0, Errors: 0, Skipped: 0 (BUILD SUCCESS). Oldingi o'lchov 68 edi -> +3 (NotificationEnqueueServiceTest 11 -> 14). Regressiya YO'Q: NotificationsInboxMigrationTest 8, PushTokensMigrationTest 10, NotificationEventCatalogTest 12 (S01), NotificationPreferencesMigrationTest 15, NotificationOutboxMigrationTest 12 — hammasi yashil. Mezon 5550 endi ✓. 5548/5549/5551/5552 avvalgi yurishda isbotlangan edi (M1/M3/M4/M5/M6/M7 mutantlari o'lgan) va bu yurishda ham yashil. NON-BLOKLOVCHI kuzatuv (bu barg emas, partition/retention egasiga — EP-13-T01-S02 doirasi): V51 boshlang'ich partitsiyalari joriy oy + 3 oy OLDINGA yaratadi, OLDINGI oy uchun partition yo'q. dedupeWindowBoundaryJustOutside... testi `now() - 5 minutes 1 second` yozgani uchun, agar to'plam oyning 1-kuni 00:00-00:05 oralig'ida yurgizilsa INSERT "no partition of relation found" bilan yiqiladi (oyiga ~5 daqiqalik oyna). Bu barg mezonlariga ta'sir qilmaydi va kod defekti emas — kelajakda partition oldindan yaratish job'i (V51 izohida "bu subtask doirasidan tashqarida" deb yozilgan) buni ham yopadi. Tozalik: worktree /tmp/qa2-EP-13-T02-S02 o'chirildi (`git worktree list` -> faqat asosiy daraxt), `git grep -l MUTANT HEAD` BO'SH, `git status --porcelain` BO'SH.

qa-ep-13-t02-s02 qabul mezonini belgiladi

✓ 5 daqiqa ichida ayni `dedupe_key` bilan ikkinchi enqueue outbox qatori yozmaydi, inbox qatori esa yoziladi (E15)

coder-ep-13-t02-s02 yangiladi

Yangilandi: commit_sha

coder-ep-13-t02-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t02-s02 izoh qoldirdi

D1: dedupe oyna chegarasiga ikkita test qo'shildi — 4:59 oldingi qator (outbox to'siladi, sonini 1da qoldiradi) va 5:01 oldingi qator (yangi outbox yoziladi, son 2ga chiqadi), created_at DB tomonida now()-interval bilan orqaga surilgan. D2: entity_id TO'LGAN holat uchun dedupe_key literal assert qo'shildi ("task.available:<userId>:77"). Worktree'da tasdiqlandi: '5 minutes'->'5 hours' mutanti dedupeWindowBoundaryJustOutsideFiveMinutesWritesNewOutboxRow'ni yiqitdi (2 kutilgan, 1 olindi); entityId+"!" mutanti nonNullEntityIdProducesLiteralDedupeKeyWithEntityIdSuffix'ni yiqitdi ("...77" kutilgan, "...77!" olindi). Ikkala mutant ham tiklandi, git grep MUTANT HEAD bo'sh. Main branch: 71 test yashil (68 eski + 3 yangi), commit ae5a855.

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ 5 daqiqa ichida ayni `dedupe_key` bilan ikkinchi enqueue outbox qatori yozmaydi, inbox qatori esa yoziladi (E15)

coder-ep-13-t02-s02 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-13-t02-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-13-t02-s02 izoh qoldirdi

QA (qa-EP-13-T02-S02) — QAYTARILDI. Kod TO'G'RI; qaytarish sababi — 5550 mezoni test bilan ISBOTLANMAGAN (ikki tirik mutant). Test: mvn -o test -Dtest='Notification*Test,PushTokens*Test' -> Tests run: 68, Failures: 0, Errors: 0 (S01 dagi 57 -> 68, +11; oldingi barg testlari sinmagan). Mutatsiya (izolyatsiyalangan worktree, HEAD=a273ab3, 8 mutant / 6 o'ldi / 2 TIRIK): M1 F2 dan security istisnosi olib tashlandi -> O'LDI, AYNAN 1 test: securityEventIgnoresPreferencesAndAlwaysWritesBothChannels (mezon 5549 talabi bajarildi) M3 dedupe inbox'ni ham to'sadi -> O'LDI: secondEnqueueWithinFiveMinutesSkipsOutboxButStillWritesInbox:155 (E15 inbox tomoni haqiqatan tekshirilgan) M4 push-only'da inbox ham yoziladi -> O'LDI: inappDisabledWritesPushOnlyOutboxRowWithNullNotificationId:171 (5551) M5 ikkala kanal false bo'lganda ham outbox -> O'LDI: bothChannelsDisabledWritesNothing:193 (5552) M6 F2 COALESCE teskari (tenant > user) -> O'LDI: userOverrideWinsOverTenantDefault:212 (spec F2 "Aziz" misoli qamralgan) M7 @Transactional -> REQUIRES_NEW -> O'LDI: businessTransactionRollbackDiscardsBothInboxAndOutboxRows:109 => 5548 testi HAQIQIY rollback'ni tekshiradi, "servis chaqirilmadi" holati emas TIRIK MUTANTLAR — ikkalasi ham mezon 5550 (F3, qoida 13): [D1] NotificationOutboxRepository.java:46 (DEDUPE_SQL) — interval '5 minutes' -> '5 hours' bilan almashtirilganda 11 testdan BIRORTASI yiqilmadi (BUILD SUCCESS; javap bilan bytecode'da "'5 hours'" tasdiqlandi). Ya'ni dedupe OYNASINING KATTALIGI umuman qo'riqlanmagan: kimdir oynani soatlarga kengaytirsa xabarlar jimgina bo'g'iladi va CI buni ushlamaydi. Kutilgan: NotificationEnqueueServiceTest ga chegara testi. Namuna: outbox qatorini qo'lda created_at = now() - interval '4 minutes 59 seconds' bilan (aynan shu dedupe_key) yozib enqueue -> yangi outbox qatori YOZILMASIN; keyin created_at = now() - interval '5 minutes 1 second' bilan -> yangi outbox qatori YOZILSIN. (created_at DEFAULT now() bo'lgani uchun INSERT da aniq qiymat berish kerak; jadval created_at bo'yicha oylik RANGE partition — qiymat joriy oy ichida.) [D2] NotificationEnqueueService.java:174 — dedupe_key ifodasining entity_id != NULL shoxobchasi hech qayerda ASSERT qilinmagan: (entityId == null ? "-" : entityId) -> (entityId == null ? "-" : entityId + "!") mutanti 11 testdan tirik o'tdi (javap: constant pool #328 = "\u0001!"). Sabab — dedupe testi bir xil kalitni ikki marta hisoblaydi (format buzilsa ham ikkalasi bir xil), literal tekshiruv esa faqat nullEntityIdProducesDashDedupeKeyAndNullDeepLink:285 da, ya'ni faqat NULL shoxobchada. Kutilgan: entity_id mavjud holat uchun ham literal assert, mas. task.available holatida SELECT dedupe_key ... = "task.available:<user_id>:77" (F3: event_code || ':' || user_id || ':' || COALESCE(entity_id,'-')). Tekshirilgan va MUAMMOSIZ: - 5548: rollback haqiqiy (M7 dalili); enqueue @Transactional REQUIRED — ambient biznes tranzaksiyasiga qo'shiladi, alohida tranzaksiya ochmaydi. - 5549: M1 aynan bitta testni yiqitdi, qolgan 10 tasi o'tdi. - 5551: notification_id VA notification_created_at ikkalasi ham NULL tekshirilgan (V51 CHECK juftligi), FP-10 to'g'ri. - 5552: ikkala kanal false -> 0 qator. - Qoida 12: kod sozlamani o'qib keyin bekor qilmaydi — security bo'lsa findTenantPreference/findUserPreferences UMUMAN chaqirilmaydi (NotificationEnqueueService.java:131-136: Optional.empty() / Map.of()). Spec "umuman o'qilmaydi" talabi kod darajasida bajarilgan. (Eslatma: test bu farqni ajrata olmaydi — u faqat natijani ko'radi; defekt emas, kod to'g'ri.) - F2 COALESCE tartibi user_pref -> tenant_pref -> true (coalescePush/coalesceInapp); "qator yo'qligi = yoqilgan" (§2.4) tenantOnly va noPreferenceRows testlarida qamralgan. - Fixture xilma-xilligi YETARLI: 10 xil event_code (order.created/delivered/cancelled, task.available, stock.low, payroll.accrued/paid, expense.pending, auth.account_blocked, auth.sessions_revoked), 3 severity (info/warning/security), entity_id NULL va NULL emas, tenant-only / user-only / ikkalasi / hech biri kombinatsiyalari, takroriy user_id. - ADMIN NUSXASI (F5 / *_admin) bu bargda YO'Q — to'g'ri, u S03 ishi (grep: service/ va repository/ da hech qanday _admin/user_session.revoke yo'q). - Katalog O'ZGARMAGAN: git show --stat a273ab3 -> faqat 5 fayl (3 repository + service + test), uz/erpbom/notifications/catalog/ ga tegilmagan. - Cross-cutting: tenant_id/schema almashtirish yo'q (AR-1); tashqi broker/kesh yo'q (AR-4); fizik DELETE yo'q; log'da parol/token yo'q (servisda logging umuman yo'q); snake_case + ko'plik jadval nomlari; event_code ga FK yo'q — spec §2.4 "FK yo'q (M2)" bo'yicha ataylab. - DOIRA ESLATMASI (PM uchun, mezon emas): servis qabul qiluvchilarni HISOBLAMAYDI — recipientUserIds parametr sifatida (muzlatilgan snapshot) qabul qilinadi. Bu izchil: F5 admin ro'yxati T02-S03 da, modul bo'yicha qabul qiluvchilar esa T05-S01..S05 da nomlangan (T05-S01 TN: "7 ta o'ziga ... 3 ta adminga (T02-S03 mantiqi orqali)"). Jimgina tushib qolgan ish emas. Ish daraxti toza: mutatsiya /tmp/qa-EP-13-T02-S02 worktree'da o'tkazildi va o'chirildi; `git grep -l MUTANT HEAD` bo'sh, `git status` toza.

qa-ep-13-t02-s02 qabul mezonini belgiladi

✗ 5 daqiqa ichida ayni `dedupe_key` bilan ikkinchi enqueue outbox qatori yozmaydi, inbox qatori esa yoziladi (E15)

qa-ep-13-t02-s02 qabul mezonini belgiladi

✓ Ikkala kanal ham o'chirilganda hech qanday qator yozilmaydi

qa-ep-13-t02-s02 qabul mezonini belgiladi

✓ `inapp_enabled=false` da outbox qatori `notification_id IS NULL` bilan yoziladi

qa-ep-13-t02-s02 qabul mezonini belgiladi

✓ Nuqsonni ataylab tiklash: F2 dan `security` istisnosi olib tashlansa aynan shu holat testi yiqiladi, qolganlari o'tadi

qa-ep-13-t02-s02 qabul mezonini belgiladi

✓ Biznes tranzaksiyasi rollback bo'lganda hech qanday inbox/outbox qatori qolmaydi (AC8)

coder-ep-13-t02-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t02-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t02-s02 izoh qoldirdi

NotificationEnqueueService (UC1 3-4-qadam) yozildi: F2 (user>tenant>true, security uchun preferences umuman o'qilmaydi — qoida 12), F3 DB dedupe (5 daq, best-effort), FP-10 push-only (notification_id NULL). Repository qatlami — notifications/notification_outbox uchun JdbcTemplate (AuthLogRepository/V7 bilan bir xil sabab: kompozit PK (id, created_at) + oylik RANGE partition, JPA composite key muammoli); notification_preferences ham izchillik uchun JdbcTemplate, faqat SELECT (yozish — UC7, boshqa barg). NotificationPort/NotificationEvent (tasks/orders/finance) ga TEGILMADI — ularni bu servisga ulash EP-13-T05 ishi ("T05 uni ulaydi", texnik izoh). F5 admin nusxasi va worker (UC2) — bu bargdan TASHQARIDA. Testlar (11 ta, NotificationEnqueueServiceTest): 5548 rollback (TransactionTemplate + majburiy exception), 5549 mutatsiya sinovi (qoida-12 istisnosi butunlay olib tashlangan mutant bilan qo'lda tekshirildi — faqat shu test yiqildi, qolgan 67 ta yashil qoldi, keyin fayl tiklandi), 5550 dedupe+E15 (ikki mustaqil enqueue chaqiruvi, real COMMIT), 5551 FP-10, 5552 ikkala kanal o'chiq + qo'shimcha: F2 ustuvorlik zanjiri, tenant-only, takroriy user_id, deep_link render, entity_id NULL, shablon joy egallovchisi yetishmasa xato. To'liq notifications test to'plami (6 klass, 68 test — 57 eski + 11 yangi) BIRGA yashil.

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ Ikkala kanal ham o'chirilganda hech qanday qator yozilmaydi

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ `inapp_enabled=false` da outbox qatori `notification_id IS NULL` bilan yoziladi

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ 5 daqiqa ichida ayni `dedupe_key` bilan ikkinchi enqueue outbox qatori yozmaydi, inbox qatori esa yoziladi (E15)

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ Nuqsonni ataylab tiklash: F2 dan `security` istisnosi olib tashlansa aynan shu holat testi yiqiladi, qolganlari o'tadi

coder-ep-13-t02-s02 qabul mezonini belgiladi

✓ Biznes tranzaksiyasi rollback bo'lganda hech qanday inbox/outbox qatori qolmaydi (AC8)

coder-ep-13-t02-s02 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-13-t02-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t02-s02 ishga oldi

pm-agent yaratdi

Enqueue servisi — snapshot, F2 sozlama, F3 dedupe, transaksion yozuv