`notification_preferences` + rule katalogi tekshiruvi

qa-ep-13-t01-s04 izoh qoldirdi

QAYTA TEKSHIRUV OK (worktree 151300d, izolyatsiyalangan). 1) Yangi test pushAndInappDefaultToTrueWhenOmittedFromInsert xom INSERT (scope,user_id,event_code,updated_by_user_id) ishlatadi — insertPreference() helper EMAS; qator qayta o0qilib ikkala ustun ham true ekani alohida assert qilinadi. 2) Mutatsiya: (a) push_enabled DEFAULT true->false => O0LDI (push assert, :331); (b) inapp_enabled DEFAULT true->false => O0LDI (inapp assert, :334) — assertlar mustaqil; (c) DEFAULT butunlay olib tashlandi => O0LDI (PSQL: null value in column push_enabled violates not-null, :318). Har mutatsiya target/classes/db/migration/V53 nusxasi mtime va mazmuni bilan tasdiqlandi (Flyway aynan mutant DDL ni qo0lladi). 3) Diff 151300d: 1 fayl, +39/-0 — migratsiya va insertPreference() helper0iga tegilmagan. 4) Tests run: 15, Failures: 0, Errors: 0 (oldin 14 edi; +1 yangi). Mutantlar cp bilan tiklandi, grep -rn MUTANT bo0sh, git diff bo0sh, worktree o0chirildi.

qa-ep-13-t01-s04 statusni o'zgartirdi Review → Bajarildi

coder-ep-13-t01-s04 yangiladi

Yangilandi: commit_sha

coder-ep-13-t01-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t01-s04 statusni o'zgartirdi Tayyor → Ishlanyapti

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-13-t01-s04 izoh qoldirdi

QA (qa-EP-13-T01-S04, izolyatsiyalangan worktree /tmp/qa-EP-13-T01-S04 @ 7badbea) — baza: Tests run: 14, Failures: 0, Errors: 0. [OK] §2.4 sxemasi AYNAN mos (V53__notification_preferences.sql:44-77): id uuid PK, scope varchar(10)+CHECK IN ('tenant','user'), user_id bigint NULLABLE, event_code varchar(64) NOT NULL (FK YO'Q), push_enabled/inapp_enabled bool NOT NULL DEFAULT true, updated_by_user_id bigint NOT NULL FK->users, updated_at timestamptz NOT NULL DEFAULT now(); CHECK ((scope='user')=(user_id IS NOT NULL)). Ikkala unikal kalit HAQIQIY PARTIAL INDEKS (:66-72), oddiy UNIQUE cheklov EMAS. Partitsiya yo'q (relkind='r' test bilan qotirilgan), seed/oldindan to'ldirish yo'q, commit faqat 2 faylga tegadi — R__permissions_and_currencies_seed.sql va openapi/ TEGILMAGAN. [OK] Mezonlar mutatsiya bilan MUSTAQIL tasdiqlandi (5 mutant, 4 tasi ushlandi; har biri target/classes da tasdiqlangan): (a) CHECK(scope<->user_id) olib tashlandi -> 2 test yiqildi: tenantScopeRowRejectsNonNullUserId + userScopeRowRejectsNullUserId (5540 ning IKKALA yo'nalishi qoplangan; ikkala to'g'ri holat ham alohida assert qilinadi). (b) UNIQUE(event_code) WHERE scope='tenant' olib tashlandi -> secondTenantRowForSameEventCodeIsRejected yiqildi. (c2) user indeksi kalitidan user_id olib tashlandi -> sameEventCodeIsAllowedForTwoDifferentUsers yiqildi ('duplicate key ... uq_notification_preferences_user_id_event_code_user') = 5541 ning IJOBIY yo'nalishi haqiqatan sinalgan. (e) testdagi kutilgan sanoq 140->141 -> catalogStillHasExactly140ActivePermissions yiqildi ('expected: 141 but was: 140') = test sanoqni DB dan o'qiydi, tautologik emas. notification_setting.manage mavjud, module='10_notifications', default_scope_type='tenant', active=true. [izoh] (c) 'WHERE scope=user shartini olib tashlash' mutanti tirik qoldi — bu EKVIVALENT mutant, defekt EMAS: CHECK tufayli scope='user' qatorida user_id NOT NULL, tenant qatorida NULL, PostgreSQL NULLS DISTINCT -> taqiqlanadigan to'plam aynan bir xil. Shuning uchun o'rniga (c2) ishlatildi. [QAYTARISH SABABI — bitta bo'shliq] (d) push_enabled DEFAULT true->false va (d2) inapp_enabled DEFAULT true->false mutantlari 14 testning HECH BIRINI yiqitmadi (Tests run: 14, Failures: 0; mutatsiya target/classes/db/migration/V53__notification_preferences.sql:49-50 da amalda ekani tasdiqlandi). Sabab: NotificationPreferencesMigrationTest dagi insertPreference() helper'i (fayl oxiri, 'INSERT ... (scope, user_id, event_code, push_enabled, inapp_enabled, updated_by_user_id)') ikkala boolean'ni HAR DOIM aniq yozadi — DEFAULT hech qachon ishlatilmaydi. §2.4 jadvalida ikkala ustun uchun Default `true` majburiy va 'qator yo'qligi = yoqilgan' semantikasining bir qismi; hozir uni hech narsa qo'riqlamaydi. KERAKLI TUZATISH (kichik, 1 ta test): NotificationPreferencesMigrationTest ga qo'sh — INSERT INTO notification_preferences (scope, event_code, updated_by_user_id) VALUES ('tenant', '<kod>', ?) (push_enabled/inapp_enabled ustunlari YOZILMAYDI), keyin o'sha qatorni o'qib assert: push_enabled = true VA inapp_enabled = true. Migratsiyaning o'zi TO'G'RI — faqat test yetishmayapti. [OK] Fixture xilma-xilligi yetarli: 4 xil event_code (order.created, payroll.accrued, task.available, supplier_payment.due_soon), ikkala scope, (push,inapp) ning 4 kombinatsiyasi ham (t/t, t/f, f/t, f/f), 3+ xil user. Yagona qotib qolgan joy — yuqoridagi DEFAULT holati. [OK] Spec JIM bo'lgan FK qarori QABUL QILINADI (biznes qarorini talab qilmaydi): updated_by_user_id ON DELETE RESTRICT — CROSS_CUTTING G (audit: 'kim tegdi' tarixiy fakt yo'qolmasin) va §2.4 dagi 'Audit (CROSS_CUTTING G)' izohi bilan mos; user_id ON DELETE CASCADE — V50/V51/V52 dagi user_id FK qarori bilan bir xil (override egasi ketsa override ma'nosiz). Ikkala yo'nalish ham test bilan qamralgan (deletingUpdaterUserIsRestrictedWhileRowExists, deletingOwnerUserCascadesUserScopeRow). [izoh] Mezon bayroqlari o'zgartirilmadi: 5540/5541/5542 ning uchalasi ham mustaqil tasdiqlandi va HAQIQATAN bajarilgan — barg faqat yuqoridagi DEFAULT testi uchun qaytarilmoqda.

qa-ep-13-t01-s04 statusni o'zgartirdi Review → Ishlanyapti

coder-ep-13-t01-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t01-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t01-s04 qabul mezonini belgiladi

✓ Test `notification_setting.manage` rule'i mavjudligini va katalog sanog'i 140 ligini tasdiqlaydi

coder-ep-13-t01-s04 qabul mezonini belgiladi

✓ Bir xil `event_code` uchun ikkinchi `tenant` qatori yozilmaydi; ikki xil user uchun esa mumkin

coder-ep-13-t01-s04 qabul mezonini belgiladi

✓ `scope='tenant'` bo'lgan qatorga `user_id` yozib bo'lmaydi va aksincha

coder-ep-13-t01-s04 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-13-t01-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t01-s04 ishga oldi

pm-agent yaratdi

`notification_preferences` + rule katalogi tekshiruvi