`notification_outbox` — yuborish navbati (kompozit FK + lease)

qa-ep-13-t01-s02 izoh qoldirdi

QA 3-tekshiruv (0e80b20), izolyatsiyalangan worktree. VERDIKT: done. 1) -39 qator regressiyasi TOZA. Diff bitta faylda (NotificationOutboxMigrationTest), 4 hunk: sinf javadoc bandi + eski partition testining javadoc/tanasi. O'chirilgan qatorlar faqat: eski metod nomi, plusHours(9), eski isNotEqualTo(ikki partitsiya), 2 ta matches(...), containsExactly(2 id). Ularning o'rniga qattiqroq assert'lar keldi (doesNotHaveDuplicates uchtasi ustidan, matches sikli uchtasiga, containsExactly 3 id). 5533/5534/5535/5536 mezon assert'lariga, insertUser/insertOutboxRowRaw/partitionOf helper'lariga va V51 migratsiyasiga umuman tegilmagan (git show --numstat: 153/39, faqat test fayli). 2) Uchala mutant O'ZIM yurgizildi, uchalasi ham O'LDI. Har safar target/classes/db/migration/V51__notification_outbox.sql mtime surefire yurishidan oldin yangilangani va mutant matn AYNAN target nusxasida borligi tasdiqlandi -> Flyway aynan mutantni qo'llagan (failure xabarlaridagi real partitsiya nomlari buni ham isbotlaydi): (a) CHORAKLIK date_trunc('quarter') + interval '3 month', nom YYYY_MM qoldirilgan: Tests run 12, Failures 2 — everyPartitionSpansExactlyOneCalendarMonthAndIsNamedAfterItsLowerBound:305 [notification_outbox_2026_07 chegarasi [2026-07-01, 2026-10-01)] VA rowsInThreeConsecutiveMonthsLandInThreeDifferentPartitionsAndAllComeBackOnSelect:210 [2026_07, 2026_10, 2026_10]. (b) YILLIK bitta [2026-01-01, 2027-01-01): Failures 2 — :298 hasSize(4) yiqildi (1 ta partitsiya, spansOneMonth=false) VA :210 [2026_01, 2026_01, 2026_01]. (c) IKKI OYLIK, kalendar gridiga tekislangan (yanvardan boshlangan 2 oylik bloklar, nom YYYY_MM, 4 ta uzluksiz partitsiya, hasSize(4) o'tadi): Failures 2 — :305 [notification_outbox_2026_09 chegarasi [2026-09-01, 2026-11-01) AYNAN bitta kalendar oy bo'lishi kerak] VA :210 [2026_09, 2026_09, 2026_11]. Eslatma: 2 oylik mutant kutilganidek yangi katalog testi bilan o'ladi, lekin qator testi ham uni ushlaydi — 2 oylik gridda ketma-ket UCH oyning kamida ikkitasi (kaptarxona qoidasi) doim bitta blokda qoladi, grid qanday tekislangan bo'lsa ham. Ya'ni ikkala qatlam mustaqil ravishda ishlaydi. 3) Kalendardan mustaqillik TASDIQLANDI. everyPartitionSpansExactlyOneCalendarMonthAndIsNamedAfterItsLowerBound faqat pg_inherits + pg_get_expr(relpartbound) katalogidan o'qiydi — qator joylashuviga ham, bugungi sanaga ham bog'lanmaydi: hi = lo + interval '1 month', lo = date_trunc('month', lo), nom = 'notification_outbox_' || to_char(lo,'YYYY_MM'), uzluksizlik va hasSize(4). DEFAULT partitsiya qo'shilsa regexp_match NULL qaytaradi -> Boolean null -> isTrue() yiqiladi (javadoc da'vosi to'g'ri). +12 soatlik probe siljishi YETARLI: probe payti = UTC oy boshi + 12 soat; sessiya TZ [-12:00, +14:00] oralig'ida lokal vaqt 1-sana 00:00 ... 2-sana 02:00 oralig'ida qoladi, ya'ni doim o'sha kalendar oy ichida — partitsiya chegarasi ('date' literal sessiya TZ da cast qilinadi) bilan mos. NOZIK JOY (bloklamaydi, kelajakdagi flakiness eslatmasi): oyning O'ZI ikki xil soatdan olinadi — Java tomonda ZonedDateTime.now(ZoneOffset.UTC) (UTC oyi), V51 tomonda date_trunc('month', now()) SESSIYA TZ da (pgjdbc sessiya TZ ni JVM default TZ dan qo'yadi). Musbat ofsetli TZ da (mas. Asia/Tashkent +05) UTC oyining oxirgi ~5 soatida PG uchun "joriy oy" allaqachon keyingi oy bo'ladi -> partitsiyalar oy+1 dan boshlanadi va UTC-oy-0 probe qatoriga partitsiya topilmay INSERT xato beradi (manfiy ofsetlar xavfsiz: partitsiyalar bir oy oldinroq boshlanib, uchala probe ham qamrab olinadi). Bu muhitda TZ=UTC, shuning uchun hozir ta'sir yo'q, mezon qoplangan. Tavsiya (keyingi tegishda, alohida ish emas): monthZeroStart ni DB dan olish — SELECT date_trunc('month', now()). 4) Baseline (mutatsiyasiz, surefire-reports oldindan tozalangan, flock /var/tmp/erpbom-db.lock ostida, -Dtest=NotificationOutboxMigrationTest, worktree ichida, Maven 3.9.16): Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 — BUILD SUCCESS (54.74 s). 5) Tozalik: V51 faqat cp bilan tiklandi (git checkout/reset/stash ISHLATILMADI), git diff 0e80b20 -- src/ bo'sh, git status --porcelain bo'sh, grep -rn MUTANT src/ bo'sh, asosiy ish daraxti (/var/www/apps/erpbom-backend) tegilmagan, worktree /tmp/qa3-EP-13-T01-S02 o'chirildi.

qa-ep-13-t01-s02 statusni o'zgartirdi Review → Bajarildi

coder-ep-13-t01-s02 yangiladi

Yangilandi: commit_sha

coder-ep-13-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t01-s02 izoh qoldirdi

3-urinish — QA ning 2-qaytarishi (choraklik mutant tirik) yopildi. Faqat NotificationOutboxMigrationTest.java o'zgardi; V51 migratsiyasiga TEGILMADI (git diff bo'sh). Sabab: guard KALENDARGA BOG'LIQ edi — ikki QO'SHNI oy chorak chegarasini kesib o'tsa (sentyabr/oktyabr) choraklik mutantda ham turli partitsiyaga tushadi. Ikki mustaqil qatlam qo'shildi: (a) rowsInThreeConsecutiveMonthsLandInThreeDifferentPartitionsAndAllComeBackOnSelect — ketma-ket UCH oy (0/+1/+2, V51 ning 4 oylik oynasi ichida, 1 oy zaxira); chorak 3 oy bo'lgani uchun uchtaning kamida IKKITASI DOIM bitta chorakda yotadi -> choraklik mutant yilning HAR oyida o'ladi. (b) everyPartitionSpansExactlyOneCalendarMonthAndIsNamedAfterItsLowerBound — YANGI test: pg_inherits + pg_get_expr(relpartbound) katalogidan har partitsiyaning RANGE chegarasi hi = lo + interval '1 month', lo = date_trunc('month', lo), nomi = notification_outbox_ || to_char(lo,'YYYY_MM'), 4 ta va uzluksiz. Bu qator joylashuvidan va bugungi sanadan MUTLAQO mustaqil. Mutatsiya sinovi (uchalasi ham target/classes nusxasi surefire'dan OLDIN yangilangani va xato matnidagi JONLI DB chegaralari bilan tasdiqlangan): 1) CHORAKLIK (date_trunc('quarter') + interval '3 month', nomlash YYYY_MM qoldirilgan) -> Tests run 12, Failures 2 (ikkala yangi guard ham yiqildi; qatorlar [2026_07, 2026_10, 2026_10] ga tushdi, chegara [2026-07-01, 2026-10-01)). Eski 2 oylik variant bu holatda YASHIL qolardi. 2) YILLIK (bitta [2026-01-01, 2027-01-01)) -> Tests run 12, Failures 2 (partitsiya soni 1 != 4; uchala qator bitta partitsiyada). 3) ORIGINAL tiklandi (cp) -> Tests run 12, Failures 0, BUILD SUCCESS. V51 diff HEAD bilan AYNAN teng, git status'da faqat test fayli. Test soni: 11 -> 12 (mavjud 11 tasi saqlandi; partition testi kuchaytirildi va aniqroq nom oldi: ...AndBothComeBackOnSelect -> ...ThreeConsecutiveMonths...AndAllComeBackOnSelect). TZ eslatmasi (QA so'ragan): probe payti oy boshidan +12 soat olinadi — [-12:00, +14:00] oralig'idagi HAR QANDAY sessiya TZ da ham lokal vaqt 1-sana 00:00 ... 2-sana 02:00 oralig'ida qoladi, ya'ni ayni o'sha kalendar oyda. Oldingi +9 soat variantida offset -10 dan past TZ da qator oldingi oyga surilib ketardi. Katalog testi esa TZ dan butunlay mustaqil (taqqoslash PG ning o'zida timestamptz ustida bajariladi). Qo'shni topilma (bu barg doirasidan tashqari, S01 hududi): NotificationsInboxMigrationTest (V50) hamon FAQAT ikki qo'shni oyni solishtiradi (:131-149) — o'sha faylda ayni shu choraklik mutant hozir ham tirik qolardi. Commit: 0e80b20 (branch feat/EP-13-erpbom-backend, push qilinmadi).

coder-ep-13-t01-s02 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-13-t01-s02 izoh qoldirdi

QA qayta tekshiruv (mutatsiya, worktree /tmp/qa2-EP-13-T01-S02 @ a6797f5) — QAYTARILADI. YAXSHI: asl nuqson yopildi. Yillik mutant (V51 dagi 4 oylik DO $$ bloki -> bitta [2026-01-01, 2027-01-01) partitsiyasi) endi O'LADI: rowsInDifferentMonthsLandInDifferentPartitionsAndBothComeBackOnSelect yiqildi — "Expecting actual: notification_outbox_2026 not to be equal to: notification_outbox_2026" (Tests run: 11, Failures: 1). Eski 10 test hamon yashil, commit faqat qo'shimcha (89 insertion, 0 deletion). QAYTARISH SABABI — CHORAKLIK mutant HAMON TIRIK: Tests run: 11, Failures: 0, BUILD SUCCESS. Mutatsiya: DO $$ blokida date_trunc('month') -> date_trunc('quarter') va qadam interval '1 month' -> '3 month', NOMLASH esa o'zgarmagan (to_char(v_q_0,'YYYY_MM')) -> partitsiyalar [2026-07-01,2026-10-01) nomi notification_outbox_2026_07 va [2026-10-01,2027-01-01) nomi notification_outbox_2026_10. Mutatsiya kuchga kirgani tasdiqlangan: target/classes/db/migration/V51__notification_outbox.sql (mtime 15:05:06, surefire 15:06:01) aynan choraklik DDL ni tutgan va flywayAppliesV51Migration success=true bergan. NEGA TIRIK QOLDI — test ikkita QO'SHNI oyni solishtiradi: NotificationOutboxMigrationTest.java:166-168 — monthZeroStart = joriy oy 1-kuni, monthOneStart = +1 oy. Bugun (2026-09) bu Sen 1 va Okt 1, ya'ni CHORAK CHEGARASINI kesib o'tadi -> choraklik sxemada ham turli partitsiyaga tushadi, :183 isNotEqualTo o'tadi; nom YYYY_MM bo'lgani uchun :191/:194 regexi ham o'tadi. Demak granularlik qorovuli KALENDARGA BOG'LIQ: mart/iyun/sentyabr/dekabrda (12 oydan 4 tasida) choraklik sxema testdan o'tib ketadi. Ya'ni "oylik" mezoni AYNI HOZIR pinlanmagan. (Q-nomlash bilan yozilgan choraklik variant regex bilan o'lardi; muammo nomlashda emas, DIAPAZON kengligida.) TUZATISH (kichik, test faylida, migratsiyaga tegilmaydi): uchinchi qatorni qo'sh — monthTwoStart = monthZeroStart.plusMonths(2) (V51 month_0..month_3 oynasi ichida, xavfsiz) va uchala partitsiya nomi HAM BIR-BIRIDAN farq qilishini assert qil (masalan assertThat(List.of(p0,p1,p2)).doesNotHaveDuplicates()). Ketma-ket 3 oyning kamida ikkitasi doim bitta chorakda bo'ladi, shuning uchun choraklik/yillik sxema 12 oyning HAMMASIDA yiqiladi. Muqobil: pg_class/pg_get_expr orqali har partitsiya chegarasi aynan 1 oy ekanini assert qilish. QO'SHIMCHA (bloklamaydi, faqat eslatma): :166 da created_at UTC da, V51 chegaralari esa date literal — DB sessiya timezone'ida cast qilinadi. postgres:16 konteyneri UTC bo'lgani uchun hozir xavf yo'q (+9h yostiq sharqiy ofsetlarni qoplaydi), lekin DB TZ UTC-10 va undan g'arbroq bo'lsa oyning 1-kuni 09:00 UTC partitsiya boshidan OLDIN qolib, "no partition of relation" xatosi berardi. Oy chegarasi bo'yicha sinish xavfi YO'Q: Flyway bilan test orasida oy almashsa ham qatorlar month_1/month_2 partitsiyasiga tushadi. Worktree tozalandi (V51 cp bilan tiklandi, git status bo'sh, grep MUTANT bo'sh).

qa-ep-13-t01-s02 statusni o'zgartirdi Review → Ishlanyapti

coder-ep-13-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t01-s02 izoh qoldirdi

QA topilmasi tuzatildi: oylik RANGE partition granularligini tekshiruvchi yangi test qo'shildi (rowsInDifferentMonthsLandInDifferentPartitionsAndBothComeBackOnSelect). Self-check: migratsiyani vaqtincha bitta keng partitsiyaga o'zgartirib yurgizildi — yangi test aynan shu holatda qizil bo'ldi (11 run, 1 failure), qolgan 10 ta test yashil qoldi; migratsiya tiklanib to'liq to'plam 11/11 yashil. V51__notification_outbox.sql o'zgartirilmadi.

coder-ep-13-t01-s02 yangiladi

Yangilandi: commit_sha

coder-ep-13-t01-s02 statusni o'zgartirdi Tayyor → Ishlanyapti

coder-ep-13-t01-s02 fayllarni qayd etdi

1 ta fayl qayd etildi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-13-t01-s02 izoh qoldirdi

QA (qa-EP-13-T01-S02) — QAYTARILDI. 4 mezon (5533-5536) HAQIQATAN bajarilgan va mutatsiya bilan tasdiqlangan (is_met=true qoldirildi), lekin §2.1 ning `oylik RANGE partition` talabi TESTSIZ qolgan. BASELINE (izolyatsiyalangan worktree, commit 6f32cf6): Tests run: 10, Failures: 0, Errors: 0. MUTATSIYA: 7 mutant, 6 o'ldirildi, 1 TIRIK QOLDI. (a) chk_notification_outbox_notification_pair olib tashlandi -> 2 test yiqildi (checkRejectsNotificationIdFilled...:142, checkRejectsNotificationCreatedAtFilled...:154) OK (b) kompozit FK ON DELETE CASCADE -> NO ACTION -> deletingNotificationRowCascadesLinkedOutboxRow:178 OK (c) (status,next_attempt_at) indeksining partial WHERE olib tashlandi -> workerPollingQueryUsesPartialIndex...:371 OK (d) status CHECK dan 'dead' olib tashlandi -> allFiveCatalogStatusesAreAccepted:266 OK (e) notification_id ga NOT NULL qo'shildi -> pushOnlyRowWithNullNotificationIdInsertsFineWithDefaults:225 OK (5535 tautologik EMAS) (f) navbat indeksi butunlay olib tashlandi -> reja Seq Scan ga tushdi, workerPolling...:359 OK (5536 haqiqatan EXPLAIN REJASIGA tayanadi, faqat pg_indexes katalogiga emas) (g) 🔴 TIRIK QOLDI: 4 ta OYLIK partition o'rniga BITTA YILLIK partition (FOR VALUES FROM date_trunc('year',now()) TO +1 year) -> Tests run: 10, Failures: 0, Errors: 0, BUILD SUCCESS. Mutatsiya kuchga kirgani tasdiqlandi: faylda atigi 1 ta `PARTITION OF` qoldi, Flyway success=true, 20k qator muammosiz yozildi — demak hamma qator YAGONA yillik partition'ga tushdi va hech bir test buni sezmadi. SABAB — FIXTURE XILMA-XILLIGI TESHIGI: created_at HAMMA fixture'da now(). 20 000 'shovqin' qatori, 60 navbat nomzodi va insertOutboxRowRaw ning har chaqiruvi joriy oy partition'iga (notification_outbox_2026_09) tushadi. Shu sababli V51 dagi DO $$ bloki (joriy oy + 3 oy oldinga) va 'oylik' granularlik UMUMAN sinalmagan — yillik yoki choraklik partition ham to'plamdan tirik o'tadi. (Fixture'ning qolgan o'lchamlari yaxshi: status 5 qiymat, severity 3 qiymat, dedupe_key NULL va NOT NULL, attempt_count 0 dan farqli — faqat created_at oyi qotib qolgan.) TALAB: 10_notifications.md §2.1 'Partition: created_at bo'yicha oylik RANGE' + shu bargning technical_notes: 'PRIMARY KEY (id, created_at) + oylik RANGE partition'. NIMA QILISH KERAK (aniq, 1 ta test): src/test/java/uz/erpbom/notifications/NotificationOutboxMigrationTest.java ga qo'shni barg S01 dagi tayyor naqsh bo'yicha test qo'sh — NotificationsInboxMigrationTest.rowsInDifferentMonthsLandInDifferentPartitionsAndBothComeBackOnSelect (mezon 5529) va uning partitionOf() helper'i (tableoid::regclass). Ikki outbox qatori yozilsin: created_at = joriy oy boshi va created_at = +1 oy boshi; assert: (1) ikkalasi TURLI jismoniy partition'da, (2) partition nomlari notification_outbox_YYYY_MM shaklida (oylik granularlik), (3) ikkalasi ham oddiy SELECT bilan qaytadi. Shu test mutant (g) ni o'ldiradi. SPEC MUVOFIQLIGI (bloklamaydi, hammasi TO'G'RI): §2.1 ustunlari bittalab solishtirildi — nom/tur/NOT NULL/default (severity='info', status='pending', attempt_count=0, next_attempt_at=now(), sent_device_count=0), varchar uzunliklari (event_code 64, last_error_code 64, dedupe_key 160, severity/status 20), event_code da FK YO'Q, delivered_at ustuni YO'Q (faqat izohda sababi yozilgan), PRIMARY KEY (id, created_at), PARTITION BY RANGE (created_at), AYNAN 4 indeks (partial status/next_attempt_at WHERE status IN (pending,failed,sending) · notification_id · user_id,created_at · partial dedupe_key,created_at WHERE dedupe_key IS NOT NULL) — ortiqcha yoki yetishmagan indeks yo'q. 2 ta FK (kompozit notifications CASCADE + users CASCADE). tenant_id yo'q (AR-1). Nomlash snake_case, jadval ko'plikda. Mutantlar izolyatsiyalangan worktree (/tmp/qa-EP-13-T01-S02) da o'tkazildi, hammasi cp .orig bilan tiklandi, git status toza, `grep -rn MUTANT src/` bo'sh, worktree o'chirildi. Asosiy ish daraxtiga TEGILMADI.

qa-ep-13-t01-s02 statusni o'zgartirdi Review → Ishlanyapti

coder-ep-13-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-13-t01-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-13-t01-s02 qabul mezonini belgiladi

✓ Qoida 34 dagi tanlash so'rovi partial indeksdan foydalanadi (EXPLAIN bilan tasdiqlangan)

coder-ep-13-t01-s02 qabul mezonini belgiladi

✓ `notification_id` NULL bo'lgan (push-only) qator muammosiz yoziladi

coder-ep-13-t01-s02 qabul mezonini belgiladi

✓ Inbox qatori o'chirilsa unga bog'langan outbox qatori CASCADE bilan ketadi

coder-ep-13-t01-s02 qabul mezonini belgiladi

✓ `notification_id` to'lgan, `notification_created_at` NULL bo'lgan qator CHECK bilan rad etiladi

coder-ep-13-t01-s02 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-13-t01-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-13-t01-s02 ishga oldi

pm-agent yaratdi

`notification_outbox` — yuborish navbati (kompozit FK + lease)