Hisoblash (F7) — proratsiya, yaxlitlash, qoldiq

finalize-ep-12 yangiladi

Yangilandi: pr_url

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

qa-ep-12-t05-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-12-t05-s02 izoh qoldirdi

QA (qa-EP-12-T05-S02) — izolyatsiyalangan worktree, commit 4ad983e. VERDIKT: done. TEST: 51/51 yashil (PayrollRunServiceTest 41 + PayrollRunsAndLinesMigrationTest 10), Failures: 0, Errors: 0. SPEC MUVOFIQLIGI (08_finance F7, Q64=A / Q65=A): PayrollRunService.java:651-663 formulani AYNAN bajaradi — accrued = salary+piece; to_lanadigan = accrued.subtract(opening).max(ZERO); net = FLOOR(/10000)*10000; remainder = to_lanadigan - net. Ishora TO GRI (subtract), abs YO Q, MAX(...,0) BOR. Zanjir to liq: V46 migratsiya (salary_component/piece_component numeric(18,2) NOT NULL DEFAULT 0, 118/123-qator) -> PayrollRunLine entity (@Column 68/77) -> PayrollRunLineResponse -> toLineResponse mapper (1375-1376). NULL qolmaydi: generateLines ham (373-374) ZERO_2DP bilan initsializatsiya qiladi. Kontrakt finance.yaml:9907/9915 maydon nomlari mos. MUTATSIYA TEKSHIRUVI — 6/6 MUTANT O LDI (har biri javap bilan bytecode da tasdiqlandi): M1 subtract->add: O LDI (4 test) | M2 .max(ZERO) olib tashlandi: O LDI (1 test) | M3 FLOOR->CEILING: O LDI (4 test) | M3b FLOOR->HALF_UP (nozikroq): O LDI (2 test) | M4 accrued=salary only: O LDI (6 test) | M5 remainder da MAX siz qiymat: O LDI (1 test). FIXTURE XILMA-XILLIGI — qotib qolish YO Q: opening_balance -952.38 / 0 / +100000 / +600000 / -150000; piece_component 0 va 125000; to_lanadigan < 0 (avans > hisoblangan) alohida qamralgan; worked_days 0 / 5 / 8 / 10 / 20 / =working_days_total. Spec ning uchala tekshiruv misoli ham test sifatida bor (AC41 birinchi/ikkinchi, avans oshib ketishi). AC4660: calculateHandlesMixedOylikbayAndIshbayEmployeesInSameRun:533-537 — salary 2380952.38, net 2380000.00, remainder 952.38. AC4661: calculateRecalculatesRowsWithoutWritingLedgerOrChangingCounterpartyBalance — ikki marta calculate, qator 100000->160000 yangilandi, opening_balance snapshot tegilmadi, counterparty balans -150000 o zgarmadi; kod darajasida ham calculate() da ledger/expense/payment yozuvi UMUMAN yo q. CROSS-CUTTING: @Transactional bor · tenant_id ustuni YO Q (AR-1) · pul maydonlari numeric(18,2) · snake_case, jadval ko plikda · FK (payroll_run_id, employee_id) · outbox bu bosqichda ishtirok etmaydi · log da parol/token yo q. V46 JOYIDA TAHRIRI XAVFSIZ — mustaqil tasdiqlandi: `git ls-tree main` da V46 YO Q va dev DB flyway max version = 37 (payroll_run_lines jadvali hali hech qayerda yaratilmagan) -> checksum buzilishi mumkin emas. ESLATMA (bloklovchi EMAS): PayrollRunsAndLinesMigrationTest yangi ikki ustunni ALOHIDA tasdiqlamaydi (mavjudligi service testlari orqali tranzitiv isbotlangan — insertLine ularsiz insert qiladi, ya ni DEFAULT 0 ishlaydi). numeric precision ni bu test to plami umuman tekshirmaydi — repo ning mavjud standarti, shu barg keltirgan regressiya emas. Kod O ZGARTIRILMADI, hech narsa commit qilinmadi, worktree o chirildi (grep -rn MUTANT src/ BO SH, git status toza).

qa-ep-12-t05-s02 qabul mezonini belgiladi

✓ Qayta hisoblashda qatorlar yangilanadi, ledger'da yangi accrual paydo bo'lmaydi

qa-ep-12-t05-s02 qabul mezonini belgiladi

✓ Maosh 5 000 000, `working_days_total=21`, `worked_days=10` → to'lanadi 2 380 000, hodim balansida 952,38 qoladi (08 AC6)

coder-ep-12-t05-s02 izoh qoldirdi

Q65=A (ikki komponentli qator: salary_component+piece_component -> accrued_amount hosila) va Q64=A (F7 ishorasi: to_lanadigan=accrued_amount-opening_balance, MAX(...,0) bilan) tuzatildi. V46 migratsiya joyida tahrirlandi (branchda yangi, main da yoq). approve()/pay() (S03/S04) mantigiga tegilmadi — ular hali accrued_amount dan oladi (salary_component ga otish S03 ishi, board qarzida qayd etilgan). 08_finance.md jurnalida shu tarzda yozilgan. Eski ikkita calculate testi (opening balance ishorasi eski/notogri formulaga asoslangan edi) yangi togri formulaga moslab qayta yozildi + AC39/AC41(1)/AC41(2)/to_lanadigan<0 uchun yangi testlar qoshildi. payCreatesOnePaymentPerPositiveNetLineAndSkipsFullyNettedZeroLine (S04) fixture ishorasi ham tuzatildi (netting endi musbat opening_balance bilan modellanadi, qoida 5ga mos) — pay() logikasi ozi tegilmadi. Test: 51/51 yashil (PayrollRunServiceTest 41 + PayrollRunsAndLinesMigrationTest 10).

coder-ep-12-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t05-s02 yangiladi

Yangilandi: commit_sha

coder-ep-12-t05-s02 qabul mezonini belgiladi

✓ Qayta hisoblashda qatorlar yangilanadi, ledger'da yangi accrual paydo bo'lmaydi

coder-ep-12-t05-s02 qabul mezonini belgiladi

✓ Maosh 5 000 000, `working_days_total=21`, `worked_days=10` → to'lanadi 2 380 000, hodim balansida 952,38 qoladi (08 AC6)

coder-ep-12-t05-s02 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-12-t05-s02 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t05-s02 ishga oldi

team-lead-pm statusni o'zgartirdi Bloklangan → Tayyor

Q64 = A javobi keldi — F7 ishorasi tuzatildi, blok olib tashlandi.

team-lead-pm izoh qoldirdi

✅ JAVOB KELDI (2026-09-07, §5 sikli) — Q64 = A: QOIDA 52 TO'G'RI, FORMULA TUZATILDI. SPEC YANGILANDI (08_finance §8.4 F7): to_lanadigan = accrued_amount − opening_balance net_amount = FLOOR(MAX(to_lanadigan, 0) / 10 000) × 10 000 rounding_remainder = MAX(to_lanadigan, 0) − net_amount Ishora izohi (spec'da ham yozildi): opening_balance < 0 → BIZ qarzdormiz (o'tgan oy qoldig'i) → AYIRISH uni QO'SHADI opening_balance > 0 → HODIM qarzdor (avans oldi) → AYIRISH uni USHLAB QOLADI Ikkita raqamli misol spec'da: (1) qoldiq: opening −952,38 + hisoblangan 1 000 000 → to_lanadigan 1 000 952,38 → to'lanadi 1 000 000, qoldiq 952,38 (ilgari 999 047,62 chiqardi — XATO edi). (2) avans: opening +100 000, hisoblangan 500 000 → 400 000 (ilgari 600 000 — XATO edi). 💡 TAKLIF (spec'da 'tasdiq kutilmoqda' deb belgilangan, lekin sen shunday YOZ): to_lanadigan < 0 bo'lsa (avans > hisoblangan) → net_amount = 0, qarz hodim balansida QOLADI va keyingi oyga o'tadi. Eski |…| bu holatda qarzdor hodimga to'lab yuborardi. MAX(…,0) shuni to'sadi. ⚠️ KONTRAKT HALI TUZATILMAGAN: finance.yaml:4680 atrofida eski formula matni turibdi. Lead uni T03 worker'i erpbom-backend'ni bo'shatgach tuzattiradi (bitta repo — bitta yozuvchi). Sen kontraktga TEGMA — faqat kodni va testlarni spec bo'yicha yoz. Barg `ready` ga qaytarildi.

team-lead-pm izoh qoldirdi

✅ LEAD DA'VONI MUSTAQIL TASDIQLADI (2026-09-07) — bu haqiqiy spec defekti, koder xatosi emas. O'lchov (08_finance.md dan): - `accrued_amount` (648-qator) = "Hisoblangan summa"; F7 (1990/1995-qator) uni `oylik_maosh × worked_days/working_days_total` yoki `Σ wage_entries.amount` deb ta'riflaydi — ya'ni MUSBAT kattalik. - `opening_balance` — F7 ning o'zi qavs ichida yozadi: "manfiy → biz qarzdormiz". - Demak `to_lanadigan = opening_balance + accrued_amount` da: qoldiq (−952.38) + 1 000 000 = 999 047.62 → qoldiq QO'SHILMAY AYIRILADI. - Qoida 52 (1656-qator) esa AYNAN teskarisini talab qiladi: "farq hodim balansida turadi va keyingi oy hisobiga QO'SHILADI. Ya'ni uzoq muddatda hodimga TO'LIQ hisoblangani to'lanadi." - Avans holatida ham teskari: opening_balance = +100 000 (hodim qarzdor), accrued 500 000 → formula 600 000 beradi, to'g'risi 400 000. Ya'ni pul IKKI YO'NALISHDA ham noto'g'ri chiqadi. Tuzatish MUZLATILGAN kontrakt matniga tegadi (finance.yaml:4680 ayni formulani hujjatlaydi) → §5 sikli + kontrakt agenti tuzatish rejimi kerak. 🔴 Foydalanuvchiga uzatildi. Javob kelmaguncha bu bargda formulani O'ZBOSHIMCHALIK bilan o'zgartirma.

qa-ep-12-t05-s02 statusni o'zgartirdi Review → Bloklangan

F7 ishora ziddiyati (spec ichida, coder aybi emas): muzlatilgan kontrakt (finance.yaml:4680) va F7 (08_finance.md:2003) `to_lanadigan = |opening_balance + accrued_amount|` deydi; qoida 5 (08_finance.md:1276-1288) + V46 migratsiya izohi esa hodimda `<0` = biz qarzdormiz, `>0` = hodim avans olgan deb qotiradi. Natijada (a) yaxlitlash qoldig`i keyingi oyda QO`SHILMASDAN AYIRILADI -> qoida 52 buzildi, (b) avans olgan hodimga KO`PROQ to`lanadi -> 04_employees §6.2 (avans ayirmasi) buzildi. Yechim ikkala variantda ham MUZLATILGAN kontrakt matniga tegadi (A: formula `accrued - opening_balance` ga tuzatiladi; B: opening_balance snapshot ishorasi teskari qilinadi + §2.12a/V46/S01 generateLines o`zgaradi) -> barg darajasida hal bo`lmaydi, PM/spec qarori kerak. Batafsil + 2-defekt (abs() shoxobchasi testsiz, mutant tirik qoldi) oldingi izohda.

qa-ep-12-t05-s02 izoh qoldirdi

QA (qa-EP-12-T05-S02, commit 80b5fac, izolyatsiyalangan worktree). O'TDI: AC4660 va AC4661 ikkalasi ham kod darajasida tasdiqlandi. - AC4660: PayrollRunService.java:519-533 (F7) + test PayrollRunServiceTest.java:460-462 -> accrued 2380952.38, net 2380000.00, rounding_remainder 952.38. - AC4661: calculate() da HECH QANDAY ledger/expense/money yozuvi yo'q; PayrollRunServiceTest.java:592-628 qayta hisoblashda accrued 100000->160000 yangilanishini VA counterparty balansi -150000.00 o'zgarmasligini isbotlaydi. Test (bloklovchi, flock ostida, tor doira): PayrollRunServiceTest 24/24 + PayrollRunCreateRequestValidationTest 9/9 = 33 yashil, 0 failure. Kontrakt: FinanceContractOperationCoverageTest yurgizildi (qizil, kutilgandek) - yetim ro'yxatida 'POST /api/v1/payroll-runs/{id}/calculate' YO'Q (faqat approve/return-to-calculated/pay = S03/S04 + T06/T07 operatsiyalari). Bu barg kontraktga bog'langan. Test o'zgartirilmadi. Mutatsiya (7 mutant, har biri javap bytecode md5 bilan tasdiqlandi, baseline 3a35c2a4): FLOOR->CEILING (4 fail), 10000->1000 (4 fail), worked/total numerator-denominator almashtirish (2 fail + 1 error), rounding_remainder=0 (4 fail), opening_balance ni formuladan olib tashlash (2 fail), qayta hisoblashda qatorni yangilamaslik (1 fail) = 6 O'LDI. === BLOK 1 (asosiy) - F7 ishora ziddiyati, SPEC ichida, coder aybi EMAS === Kod: PayrollRunService.java:525 `line.getOpeningBalance().add(accruedAmount).abs()` Bu F7 (08_finance.md:2003) va MUZLATILGAN kontrakt (openapi/v1/finance.yaml:4680) matnining so'zma-so'z ijrosi: `to_lanadigan = |opening_balance + accrued_amount|`. Coder taxmin QILMAGAN. Lekin `opening_balance` ning ishorasi 08_finance.md qoida 5 (1276-1288-qatorlar) va V46 migratsiya izohi (89-93, 108-109-qatorlar) bilan QOTIRILGAN: hodim uchun `< 0` = biz qarzdormiz, `> 0` = hodim avans olgan. Shu ikki qoida bir-biriga ZID: (a) Qoida 52 (08_finance.md:1656-1659): yaxlitlash qoldig'i 'hodim balansida turadi va keyingi oy hisobiga QO'SHILADI ... uzoq muddatda hodimga TO'LIQ hisoblangani to'lanadi'. Amalda: 1-oy qoldig'i 952.38 -> balans -952.38. 2-oy (AC6 raqamlari): |-952.38 + 2380952.38| = 2380000.00 -> net 2380000, remainder 0.00. Ya'ni qoldiq QO'SHILMAYDI, AYIRILADI; qarz har oy o'sib boradi va HECH QACHON to'lanmaydi. Qoida 52 buzildi. (b) 04_employees.md §6.2 (645-qator): 'yakuniy to'lov, AVANS AYIRMASI va yaxlitlash - 08_finance'. Amalda: PayrollRunServiceTest.java:527-548 testi opening_balance = +150000 (qoida 5 bo'yicha 'hodim avans olgan') bo'lganda net 980000 -> 1130000 ga OSHISHINI qotiradi. Ya'ni avans olgan hodimga KO'PROQ to'lanadi. Qoida 5 saqlansa, to'g'ri formula `to_lanadigan = accrued_amount - opening_balance` bo'lardi. 🔴 SAVOL (PM/spec egasiga - §5 sikli): qaysi biri to'g'ri? (A) F7 + kontrakt matni `accrued_amount - opening_balance` ga tuzatiladi (qoida 5 va V46 izohi o'z kuchida qoladi), YOKI (B) `payroll_run_lines.opening_balance` snapshot'i TESKARI ishorada saqlanadi (musbat = biz qarzdormiz), ya'ni §2.12a va V46 migratsiya izohi ('manfiy -> biz qarzdormiz') tuzatiladi va S01 generateLines (PayrollRunService.java:256-267, `current_balance` ni xom o'qiydi) ham o'zgaradi. Ikkala variant ham MUZLATILGAN kontrakt matniga tegadi -> barg darajasida hal qilib bo'lmaydi. === DEFEKT 2 (blok yechilgach majburiy tuzatiladi) - `abs()` shoxobchasi sinalmagan === Mutant 7: PayrollRunService.java:525 dan `.abs()` BUTUNLAY olib tashlandi -> PayrollRunServiceTest 24/24 YASHIL qoldi (bytecode 3a79b982 != baseline 3a35c2a4, ya'ni mutant haqiqatan kompilyatsiya qilingan). TIRIK QOLDI. Sabab - fixture bo'shlig'i: `opening_balance + accrued_amount < 0` holati (|opening_balance| > accrued_amount) hech bir testda yo'q. PayrollRunServiceTest.java:503 (opening -150000, accrued 987654) va :527 (opening +150000) ikkalasida ham yig'indi musbat. Ayni shu shoxobcha uchun spec `| |` yozgan - u qamralmagan. Blok yechilgach shu holatga test qo'shilsin. Qamralgan (defekt emas): fixture xilma-xilligi yaxshi - worked_days 0 (:570) / to'liq oy tenglik chegarasi 20/20 (:477) / qisman (:436); opening_balance manfiy/musbat/nol; oylikbay+ishbay aralash (:436) va bitta hodimda ikkalasi (:477); yaxlitlash qoldig'i nol (:550) va nolmas. Assertion'lar BigDecimal isEqualByComparingTo - qism satr solishtiruvi YO'Q. Pul hisobida double/float YO'Q. `working_days_total <= 0` DB CHECK (V46:68-69) bilan to'silgan, nolga bo'lish mumkin emas. calculate() @Transactional (:512).

qa-ep-12-t05-s02 qabul mezonini belgiladi

✓ Qayta hisoblashda qatorlar yangilanadi, ledger'da yangi accrual paydo bo'lmaydi

qa-ep-12-t05-s02 qabul mezonini belgiladi

✓ Maosh 5 000 000, `working_days_total=21`, `worked_days=10` → to'lanadi 2 380 000, hodim balansida 952,38 qoladi (08 AC6)

coder-ep-12-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t05-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-12-t05-s02 izoh qoldirdi

calculate (POST /payroll-runs/{id}/calculate) qoshildi: draft|calculated -> calculated, F7 (oylikbay proratsiya + wage_entries yigindisi, 04 par6.2 - offset qilinmaydi, qoshiladi), FLOOR(|opening_balance+accrued|/10000)*10000 yaxlitlash, rounding_remainder. Ledger/xarajat yozuvi yoq (approve S03 ishi). opening_balance snapshot tegilmadi. worked_days>working_days_total (update keyin pasaytirilgan holatda ham) -> 400 VALIDATION_ERROR. PayrollRunServiceTest: 9 yangi test (AC4660 aynan misol, aralash oylikbay+ishbay+davr filtri, ishora musbat/manfiy, yaxlitlash qoldiq 0, worked_days=0, qayta hisoblash+balans ozgarmasligi, approved/period_closed 409, oob 400). mvn -Dtest=PayrollRunServiceTest: 24/24 yashil. FinanceContractOperationCoverageTest tekshirildi: calculate endi boglangan (unbound royxatida yoq), qolgan unbound (approve/return-to-calculated/pay va boshqa modullar) shu bargga tegishli emas.

coder-ep-12-t05-s02 qabul mezonini belgiladi

✓ Qayta hisoblashda qatorlar yangilanadi, ledger'da yangi accrual paydo bo'lmaydi

coder-ep-12-t05-s02 qabul mezonini belgiladi

✓ Maosh 5 000 000, `working_days_total=21`, `worked_days=10` → to'lanadi 2 380 000, hodim balansida 952,38 qoladi (08 AC6)

coder-ep-12-t05-s02 fayllarni qayd etdi

4 ta fayl qayd etildi

coder-ep-12-t05-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t05-s02 ishga oldi

team-lead-pm yangiladi

Yangilandi: estimate_hours

pm-agent yaratdi

Hisoblash (F7) — proratsiya, yaxlitlash, qoldiq