Kapital yaxshilash (F5c) va qayta baholash (F5b)

finalize-ep-12 yangiladi

Yangilandi: pr_url

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

team-lead-pm yangiladi

Yangilandi: estimate_hours

qa-ep-12-t04-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-12-t04-s03 izoh qoldirdi

QA qayta tekshiruv (da9b94b, izolyatsiyalangan worktree) — OTDI. MUTANT-1 (FixedAssetDepreciationService.java:261,269 — adjustedBase -> acquisition_cost-salvage_value): ENDI OLADI. revaluationRunsToCompletionUsingAdjustedBaseAsUpperBound:305 yiqildi — [2031-03 uchun bitta qator kutilgan] expected 1 but was 0 (mutant chegarani 516 mln orniga 480 mln qiladi, 45-oydan yozuv toxtaydi). javap: mutant bytecodeda processAsset ichida getAcquisitionCost 4 marta (tiklangach 2), yani mutatsiya kompilyatsiyaga tushgan. MUTANT-2 (FixedAssetRevaluationService.java:139 — .add(priorDifferenceSum) olib tashlandi): ENDI OLADI. secondRevaluationAccountsForPriorDifferenceSum yiqildi — expected 900000.00 but was 800000.00. javap: computeCurrentBookValue bytecodeida BigDecimal.add YOQ (subtract -> areturn), sumDifferenceByAssetId natijasi ishlatilmay qolgan — mutatsiya haqiqiy. Yangi testlar haqiqiy: (a) oxirigacha yuritish 2027-07..2031-06 = 48 oyni toliq yuritadi, har oy created==1, har qator 8 750 000, yigindi 420 000 000, accumulated 516 000 000 = 96 000 000 + (420 000 000 - 0), va 2031-07 da runForPeriod()==0 (chegaradan keyin yozuv yoq); (b) ikkinchi baholashda old_book_value=900 000 aynan birinchi baholashdan keyingi qoldiq, keyingi oylik 118 750 = (1 150 000-200 000)/8 ikkala farqni hisobga oladi. Hamma pul davosi isEqualByComparingTo bilan; qism-satr (contains) solishtiruvi yoq; fixturelar xilma-xil (salvage 0 va 100 000, 480 mln/60 oy va 1 mln/10 oy, musbat va manfiy farq). Testlar: FixedAssetImprovementRevaluationServiceTest 7/7 + FixedAssetImprovementRevaluationControllerTest 7/7 = 14/14 yashil (mutantlar tiklangandan KEYIN). Regressiya: FixedAssetDepreciationServiceTest 6/6 + FixedAssetDepreciationControllerTest 3/3 + FixedAssetDisposalServiceTest 9/9 = 18/18 yashil. AC4189 (improvementExample, improvementWithZeroExtraLifeMonthsOnlyChangesRate, improvementRestartsDepreciationAfterAssetIsFullyDepreciated) va AC4191 (revaluationExample: 384->420 mln, 8 750 000) buzilmagan. grep -rn MUTANT src/ bosh, .orig fayl qolmagan, git status toza, worktree olib tashlandi.

qa-ep-12-t04-s03 qabul mezonini belgiladi

✓ Qayta baholashda F9 foydasi O'ZGARMAYDI; faqat qoldiq qiymat va keyingi oylardagi amortizatsiya o'zgaradi (08 AC22)

coder-ep-12-t04-s03 yangiladi

Yangilandi: commit_sha

coder-ep-12-t04-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t04-s03 qabul mezonini belgiladi

✓ Qayta baholashda F9 foydasi O'ZGARMAYDI; faqat qoldiq qiymat va keyingi oylardagi amortizatsiya o'zgaradi (08 AC22)

coder-ep-12-t04-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

coder-ep-12-t04-s03 ishga oldi

qa-ep-12-t04-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-12-t04-s03 izoh qoldirdi

QA (qa-EP-12-T04-S03) — izolyatsiyalangan worktree, commit aed7cab. TESTLAR YASHIL: S03 12/12 (ServiceTest 5 + ControllerTest 7). S02 REGRESSIYASI YASHIL: 18/18 (FixedAssetDepreciationServiceTest 6, FixedAssetDepreciationControllerTest 3, FixedAssetDisposalServiceTest 9) — dvigatel o'zgarishi eski bargni buzmagan. MUTATSIYA TEKSHIRUVI: 7 mutant, 5 O'LDIRILDI, 2 TIRIK QOLDI (har biri javap bilan bytecode'da tasdiqlangan). O'ldirilgan: (1) revalue() expense_entries ga qator yozadi -> ServiceTest:250 va :301 (AC4190); (2) o'tgan oyni yangi stavkaga qayta hisoblash -> ServiceTest:162 (AC4189); (3) salvage_value ayirilmaydi -> salvage>0 fixture'i ushladi; (4) qolgan muddat o'rniga to'liq useful_life_months -> 5/5 test, F5c 7 400 000 va F5b 8 750 000 ikkalasi; (5) acquisition_cost += amount tushirildi -> 3 test. === QAYTARISH SABABI: 2 TIRIK MUTANT = QOPLANMAGAN MEZON (kod TO'G'RI, TEST YO'Q) === [1] AC4190 — qayta baholashdan KEYINGI chegara (qoida 29) hech qanday test bilan qo'riqlanmagan. Fayl: src/main/java/uz/erpbom/finance/service/FixedAssetDepreciationService.java:261 va :269 261: if (runningAccumulated.compareTo(adjustedBase) >= 0) 269: BigDecimal remaining = adjustedBase.subtract(runningAccumulated); Mutant: ikkala `adjustedBase` ni ESKI formulaga (`acquisition_cost - salvage_value`) qaytardim. Natija: FixedAssetImprovementRevaluationServiceTest (5) + FixedAssetDepreciationServiceTest (6) = 11/11 YASHIL o'tdi (BUILD SUCCESS). Nega bu jim pul xatosi: F5b misolida to'g'ri chegara = 96 000 000 + (420 000 000 - 0) = 516 000 000, eski formula 480 000 000 beradi -> 96 000 000 + 44*8 750 000 = 481 000 000 da `break` ishlaydi, aktiv ~35 000 000 KAM eskiradi va qayta baholash foydasi hech qachon to'liq amortizatsiyaga kirmaydi (AC4190 "farq 48 oy davomida asta kiradi" buziladi). KERAK (yangi test): revaluationExample fixture'ini OXIRIGACHA yuritish — 2027-07 dan 2031-06 gacha davr yopilishi, so'ng tasdiqlash: (a) qayta baholashdan keyingi qatorlar yig'indisi = 420 000 000, (b) fixed_assets.accumulated_depreciation = 516 000 000, (c) 2031-07 uchun runForPeriod() = 0 qator. Qadrsizlanish fixture'ida ham (salvage 100 000, adjustedBase 780 000): yig'indi = 600 000, accumulated = 780 000, 11-oyda yozuv yo'q. [2] AC4190 / §2.9f ("jadval faqat insert, oxirgisi joriy") — IKKINCHI qayta baholash qoplanmagan. Fayl: src/main/java/uz/erpbom/finance/service/FixedAssetRevaluationService.java:138-139 (computeCurrentBookValue -> `.add(priorDifferenceSum)`). Mutant: `.add(priorDifferenceSum)` olib tashlandi -> S03 12/12 YASHIL o'tdi, chunki hech bir testda bitta aktiv IKKI marta qayta baholanmaydi. Oqibat: 2-baholashda old_book_value va difference xato chiqadi, xato adjustedBase orqali BARCHA keyingi amortizatsiyaga ko'chadi. KERAK (yangi test): bitta aktivga ketma-ket 2 qayta baholash — 480 000 000 / 60 oy, 12 oy o'tgan (accumulated 96 000 000): 1) revalue -> 420 000 000 (difference +36 000 000); 2) revalue -> 400 000 000, kutilgan old_book_value = 420 000 000 (384 000 000 EMAS), difference = -20 000 000; keyin 2027-07 oylik = 400 000 000 / 48 = 8 333 333.33. === TEKSHIRILDI VA MOS (qaytarish sababi EMAS) === - revalue() na ledger_entries, na money_movements, na expense_entries ga TEGMAYDI: kodda ExpenseEntryService chaqiruvi yo'q; test expenseEntryRepository.count() ni musbat VA manfiy farq uchun ALOHIDA tekshiradi (M1 mutanti aynan shu ikkala assertion bilan o'ldi). Javobda expense_entry_id maydoni ham yo'q (ControllerTest). - revalue() acquisition_cost / accumulated_depreciation ni O'ZGARTIRMAYDI — FixedAsset umuman save qilinmaydi; ServiceTest 480 000 000 / 96 000 000 ni aniq tasdiqlaydi. - Huquqlar kontrakt bo'yicha: improvements -> fixed_asset.edit (fixed_asset.revalue bilan 403), revaluations -> fixed_asset.revalue (fixed_asset.edit bilan 403), reason @NotBlank (majburiy). - F5c 7 400 000, F5b 8 750 000, E19 (to'liq eskirgandan keyin amortizatsiya qayta boshlanadi) — hammasi isEqualByComparingTo bilan, qism-satr solishtiruvi ishlatilmagan. - Fixture xilma-xilligi YAXSHI: extra_life_months=0, salvage_value>0, manfiy difference (qadrsizlanish), E19 — har biri alohida fixture (M3 aynan salvage fixture'i tufayli o'ldi). - Kontrakt: 4 operatsiya (listFixedAssetImprovements / addFixedAssetImprovement / listFixedAssetRevaluations / revalueFixedAsset), required maydonlar va sxemalar DTO'lar bilan mos. - Cross-cutting: o'qishda @Transactional(readOnly=true), tenant_id yo'q, snake_case ko'plik nomlar, numeric(18,2), insert-only tarix (DELETE yo'q), log'da maxfiy ma'lumot yo'q. Kod o'zgartirilmadi; barcha mutantlar tiklandi (`grep -rn MUTANT src/` bo'sh, `git status` toza), worktree olib tashlandi.

qa-ep-12-t04-s03 qabul mezonini belgiladi

✗ Qayta baholashda F9 foydasi O'ZGARMAYDI; faqat qoldiq qiymat va keyingi oylardagi amortizatsiya o'zgaradi (08 AC22)

qa-ep-12-t04-s03 qabul mezonini belgiladi

✓ F5b misoli (384 → 420 mln, yangi oylik 8 750 000) test bilan tasdiqlangan

qa-ep-12-t04-s03 qabul mezonini belgiladi

✓ Yaxshilashdan keyin yangi oylik summa keyingi oydan qo'llanadi, o'tgan oylar o'zgarmaydi (08 AC18)

coder-ep-12-t04-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t04-s03 izoh qoldirdi

Dvigatelga (FixedAssetDepreciationService.processAsset) kiritilgan o'zgarish: eski 'base = acquisition_cost - salvage; oylik = base/useful_life_months (doim konstant)' o'rniga endi har chaqiruvda: revaluationDifferenceSum = SUM(fixed_asset_revaluations.difference, aktiv bo'yicha, barcha vaqt, FixedAssetRevaluationRepository#sumDifferenceByAssetId); adjustedBase = (acquisition_cost - salvage) + revaluationDifferenceSum; monthsElapsed = COUNT(fixed_asset_depreciations, aktiv bo'yicha, FixedAssetDepreciationRepository#countByAssetId); remainingMonths = useful_life_months - monthsElapsed; monthlyAmount = (adjustedBase - accumulated_depreciation) / remainingMonths. Qoida-29 chegara tekshiruvi ham 'base' o'rniga 'adjustedBase' bilan (bu V45 izohidagi 'accumulated <= revaluation paytidagi accumulated + (new_book_value - salvage)' formulasiga matematik teng - FixedAssetRevaluationService javodocida isbot bor). Hodisasiz (revaluation yo'q) holatda bu chiziqli amortizatsiyada asl formulaga MATEMATIK teng qoladi, shu sabab S02 regressiyasi (FixedAssetDepreciationServiceTest, 6 test) yashil qoldi - alohida o'zgartirishsiz. acquisition_cost/useful_life_months FAQAT yaxshilashda (FixedAssetImprovementService) mutatsiyalanadi; qayta baholash (FixedAssetRevaluationService) FixedAsset entityni umuman save qilmaydi - faqat revaluationDifferenceSum orqali adjustedBase'ga ta'sir qiladi (qoida 53). E19 (to'liq eskirgan aktivga yaxshilash - amortizatsiya qayta boshlanadi) maxsus kodsiz, faqat adjustedBase oshishi orqali tabiiy ishlaydi (test bilan tasdiqlangan). Yangi FixedAssetRevaluationRepository#sumDifferenceByAssetId va FixedAssetDepreciationRepository#countByAssetId - keyingi barglar buni bilishi kerak bo'lsa shu ikki metod haqiqat manbai. Testlar: FixedAssetImprovementRevaluationServiceTest (5) - F5c/F5b misollari, extra_life_months=0, salvage_value>0+qadrsizlanish (manfiy difference), E19 restart; FixedAssetImprovementRevaluationControllerTest (7) - fixed_asset.edit vs .revalue huquq ajratilishi, 404/409, expense_entry_id yo'qligi. Jami 21/21 yashil (4 klass birga: yangi 2 + FixedAssetDepreciationServiceTest + FixedAssetDepreciationControllerTest regressiya).

coder-ep-12-t04-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-12-t04-s03 qabul mezonini belgiladi

✓ F5b misoli (384 → 420 mln, yangi oylik 8 750 000) test bilan tasdiqlangan

coder-ep-12-t04-s03 qabul mezonini belgiladi

✓ Qayta baholashda F9 foydasi O'ZGARMAYDI; faqat qoldiq qiymat va keyingi oylardagi amortizatsiya o'zgaradi (08 AC22)

coder-ep-12-t04-s03 qabul mezonini belgiladi

✓ Yaxshilashdan keyin yangi oylik summa keyingi oydan qo'llanadi, o'tgan oylar o'zgarmaydi (08 AC18)

coder-ep-12-t04-s03 fayllarni qayd etdi

15 ta fayl qayd etildi

coder-ep-12-t04-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t04-s03 ishga oldi

pm-agent yaratdi

Kapital yaxshilash (F5c) va qayta baholash (F5b)