`orders` — ko'cha shafyori maydonlari va biriktirish validatsiyasi (06 Q16/Q17)

finalize-ep-12 yangiladi

Yangilandi: pr_url

qa-ep-12-t03-s04 statusni o'zgartirdi Review → Bajarildi

qa-ep-12-t03-s04 izoh qoldirdi

QA qayta tekshiruv (qa-EP-12-T03-S04, 02cece6) — QABUL QILINDI, mezon 5331 endi met. 1) TIRIK QOLGAN MUTANT ENDI O'LDI. Xuddi o'sha mutatsiya (OrderService.java:1553 dan keyin ko'cha shafyori shoxiga to'liq gate: employeeService.get(request.externalDriverId()) + EMPLOYEE_STATUS_ACTIVE + isEligibleAsDriver -> BusinessConflictException(DRIVER_NOT_ELIGIBLE)) izolyatsiyalangan worktree'da qayta yurgizildi: 14 test, 2 FAILURE — assignDriverWithExternalDriverAndPositiveFeeSucceedsWithoutEligibilityCheckOrFinancialRecord va assignDriverWithExternalDriverAndDifferentPositiveFeeAmountAlsoSucceeds (ikkalasi ham assertExternalDriverAssignmentSucceeds:538 da). Ilgari 12/12 yashil edi. javap: OrderService.class da isEligibleAsDriver chaqiruvi 1 -> 2, mutatsiya bytecode'da. Tuzatish sababi to'g'ri: insertExternalDriverCollidingWithIneligibleEmployeeId (OrderAssignDriverControllerTest.java:908+) external_driver_id ni ATAYLAB bir xil raqamdagi `suspended` employees qatoriga bog'laydi (GREATEST(MAX(id)) + OVERRIDING SYSTEM VALUE + setval), shu sabab gate qo'llansa 409 DRIVER_NOT_ELIGIBLE chiqadi. Bu tasodifiy mos kelishga tayanmaydigan, deterministik hardening. 2) 5331 ning to'rt holati qayta o'lchandi. Baza: OrderAssignDriverControllerTest 14 test / 0 failure (df3db4e da 12 edi). Ishlab chiqarish kodi (validateAssignDriverRequest) va a/b/d + "ikkalasi bo'sh" testlari 02cece6 da O'ZGARMAGAN — ular oldingi turda mutatsiya bilan o'ldirilgani kuchda (both-check o'chirish -> both testi; fee shartini bo'shashtirish -> missing/zero testlari; fee_not_allowed shoxini o'chirish -> employee+fee testi). Yangi fixture boshqa shoxlarni buzmagan (baza yashil). 3) FIXTURE XILMA-XILLIGI — haqiqiy, faqat nom emas: * null (fee yuborilmaydi) — assignDriverWithExternalDriverAndMissingFeeReturnsValidationError; * 0.00 — ...NonPositiveFee...; * -50000.00 — 🆕 ...NegativeFee... (OrderAssignDriverControllerTest.java:421); * musbat: 150000.00 VA 83250.75 (ikki xil qiymat, umumiy helper orqali). Yangi manfiy test tautologik EMAS: mutant `signum() <= 0` -> `signum() == 0` (null va 0 hamon rad etiladi, manfiy o'tadi) AYNAN shu testni o'ldirdi — 14 test, 1 failure, boshqa hech bir test yiqilmadi. 4) DIFF (df3db4e..02cece6) — faqat OrderAssignDriverControllerTest.java (+132/-12). @Disabled/@Ignore/assumeTrue YO'Q. Assertion o'chirilmagan: success testining barcha assertlari (status delivering, external_driver_id, delivery_fee_amount, driver_employee_id NULL, DB qiymatlari) helper'ga ko'chgan va endi IKKI marta yuriladi; 08 Q70 = A moliyaviy assertlari (delivery_fee_accrual ledger + delivery_fee expense) joyida (551/554-qatorlar) va ikki testda ishlaydi. O'zgarish testni faqat KUCHAYTIRGAN. Mezonlar: 5331 ✓ · 5332 ✓ (oldingi turda) · 5333 ✓ (oldingi turda). Asosiy daraxt toza: git status bo'sh, git grep MUTANT HEAD bo'sh, /tmp/qa2-EP-12-T03-S04 worktree o'chirildi. erp/docs ga tegilmadi.

qa-ep-12-t03-s04 qabul mezonini belgiladi

✓ 06 AC21: ikkala shafyor birga -> rad; external + summa yo'q/<=0 -> rad; o'z shafyori + summa -> rad; faqat external + 150 000 -> `delivering` va `is_driver` tekshirilmaydi

coder-ep-12-t03-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t03-s04 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t03-s04 ishga oldi

coder-ep-12-t03-s04 yangiladi

Yangilandi: commit_sha

coder-ep-12-t03-s04 fayllarni qayd etdi

1 ta fayl qayd etildi

coder-ep-12-t03-s04 qabul mezonini belgiladi

✓ 06 AC21: ikkala shafyor birga -> rad; external + summa yo'q/<=0 -> rad; o'z shafyori + summa -> rad; faqat external + 150 000 -> `delivering` va `is_driver` tekshirilmaydi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-12-t03-s04 izoh qoldirdi

QA (qa-EP-12-T03-S04, df3db4e) — QAYTARILDI. Mezon 5331 (06 AC21) is_met=false. BAZA (yashil): 51 test / 0 failure — OrderAssignDriverControllerTest 12, OrderConfirmDeliveryControllerTest 15, OrderMarkDeliveredManualControllerTest 3, OrderMyDeliveriesControllerTest 9, OrderEntitySchemaValidationTest 12. === YIQILGAN MEZON: 5331, AC21(c) ning oxirgi bandi — "is_driver TEKSHIRILMAYDI" === Fayl: src/test/java/uz/erpbom/orders/controller/OrderAssignDriverControllerTest.java:454 (assignDriverWithExternalDriverAndPositiveFeeSucceedsWithoutEligibilityCheckOrFinancialRecord), urug' — 475-qator insertExternalDriver(...). MUTATSIYA (izolyatsiyalangan git worktree, HEAD=df3db4e): OrderService.java:1553 dan keyin ko'cha shafyori shoxiga TO'LIQ hodim-eligibility gate'i qo'shildi — } else { EmployeeResponse ext = employeeService.get(request.externalDriverId()); if (!(EMPLOYEE_STATUS_ACTIVE.equals(ext.status()) && employeeService.isEligibleAsDriver(ext.id()))) throw new BusinessConflictException(ERROR_DRIVER_NOT_ELIGIBLE, MESSAGE_DRIVER_NOT_ELIGIBLE); } KUTILGAN: yuqoridagi test yiqilishi kerak. OLINGAN: butun klass YASHIL qoldi — 12/12, 0 failure. Mutant TIRIK (bytecode javap bilan tasdiqlandi: isEligibleAsDriver chaqiruvi 1 -> 2 ga o'sdi, ya'ni mutatsiya kompilyatsiyaga tushgan). SABAB (fixture nuqsoni): external_drivers.id va employees.id sekvensiyalari mustaqil, test DB esa klass ichida umumiy — natijada externalDriverId qiymati AYNAN mavjud, active va faol is_driver kasbiga ega bir employee.id ga to'g'ri keladi (shu klassdagi oldingi testlar bunday hodimlarni yaratadi). Shu sabab noto'g'ri ijro (gate'ni ko'cha shafyoriga ham qo'llash) ham 200 qaytaradi va test uni USHLAMAYDI. Ya'ni test nomi "WithoutEligibilityCheck" desa ham, bu bandni qo'riqlamaydi. Test o'zi tirik ekani alohida tasdiqlandi: setDeliveryFeeAmount(...add(BigDecimal.ONE)) mutanti AYNAN shu testni O'LDIRDI. NIMA QILINSIN: shu testda external_drivers.id ni har qanday eligible employees.id dan ANIQ ajrat — mas. urug'lashdan oldin sekvensiyani surish (SELECT setval('external_drivers_id_seq', (SELECT COALESCE(MAX(id),0)+1000 FROM employees))) yoki testda "SELECT count(*) FROM employees WHERE id = :externalDriverId" = 0 ekanini qotirib qo'yish. Shundan keyin yuqoridagi mutant 404/409 berib testni o'ldirishi shart (o'zingiz ham shu mutant bilan tekshiring). === O'TGAN MEZONLAR === 5331 ning QOLGAN bandlari (a/b/d + "ikkalasi bo'sh") — QOPLANGAN, mutatsiya bilan tasdiqlandi: * "ikkalasi birga" tekshiruvi o'chirildi -> assignDriverWithBothDriverKindsReturnsValidationError yiqildi; * fee sharti (deliveryFeeAmount == null || signum() <= 0) -> (!= null && signum() < 0) ga bo'shashtirildi -> MissingFee VA NonPositiveFee testlari yiqildi (chegara 0.00 qamralgan; manfiy qiymat fixture'da yo'q, lekin 0.00 chegarasi shu mutantni o'ldiradi); * fee_not_allowed shoxi o'chirildi -> assignDriverWithEmployeeDriverAndFeeReturnsValidationError yiqildi. Xato kodi/maydon nomlari kontraktga mos: 400 VALIDATION_ERROR + fields[] (external_driver_id / driver_employee_id / delivery_fee_amount) — OrderAssignDriverValidationError misollari bilan so'zma-so'z. 5332 (AC22) — MET. Kod darajasida tekshirildi: OrderService.confirmDelivery da requireOwnDriverEmployee(...) dan keyin driver.getId().equals(order.getDriverEmployeeId()) — external buyurtmada driver_employee_id NULL bo'lgani uchun equals(null)=false -> OwnershipDeniedException.asForbidden -> 403 FORBIDDEN. Bu NPE/500 EMAS, kontrakt (confirm-delivery tavsifi, AC22a) aynan 403 deydi. Mutant "order.getDriverEmployeeId() != null && ..." (egalikni NULL da o'tkazib yuborish) -> confirmDeliveryOnExternalDriverOrderReturnsForbiddenAndDoesNotChangeStatus YIQILDI. markDeliveredManual: GPS NULL, delivered_confirmed_by_user_id = xodim, computeFarFromAddress UMUMAN chaqirilmaydi, audit-log (manual_confirmation=true) yoziladi; mutant "order.delivery_far_from_address outbox qatorini qo'shish" -> markDeliveredManualOnExternalDriverOrder... YIQILDI (shubhali-tasdiq bayrog'i haqiqatan qo'riqlangan). 5333 (08 Q70 = A) — MET va TAUTOLOGIK EMAS. Asbob tekshiruvi: testdagi countExpenseEntriesByCategoryCode("delivery_fee") -> "picking_wage" ga almashtirilganda assert YIQILDI (count > 0), demak helper haqiqiy qatorlarni sanaydi, doimiy 0 qaytarmaydi. ledger_entries.source_type CHECK ro'yxatida 'delivery_fee_accrual' bor (V38), expense_categories da 'delivery_fee' seed qilingan (R__finance_expense_categories_seed) — ya'ni filtrlar mavjud qiymatlarga tegadi. === MIGRATSIYA V49 (coder da'vosi tasdiqlandi) === delivery_type ustuni kod bazasida ROSTDAN YO'Q: src/main va openapi/ bo'ylab faqat izoh/tavsif matnida uchraydi, na ustun, na DTO maydoni (Hibernate insert into orders ... ro'yxatida ham yo'q). Demak CHECK'larni delivery_type ga bog'lamaslik to'g'ri. CHECK'lar spec talabini qoplaydi: chk_orders_driver_exclusive (driver_employee_id IS NULL OR external_driver_id IS NULL) = R6 o'zaro istisno; chk_orders_delivery_fee_amount ((external NOT NULL AND fee NOT NULL AND fee > 0) OR (external NULL AND fee NULL)) = summaning shartliligi + > 0 + o'z shafyorimizda NULL. V49 test DB'ga muvaffaqiyatli qo'llandi (Flyway v49). Eslatma (blok emas): CHECK'larga to'g'ridan-to'g'ri manfiy DB testi yo'q — himoya faqat servis qatlami testlari orqali bilvosita. === BLOK EMAS (ataylab) === active=false ko'cha shafyorini biriktirish holati spec'da yozilmagan (08 §2.15 / 06 AC21 da yo'q) — coder ataylab qo'shmagani TO'G'RI, bu qaytarish sababi emas. Kontrakt oneOf'ining runtime ekvivalenti tekis DTO + service validatsiyasi bilan qurilgani — repo naqshi (MoneyTransferService#validateTransferFields), additionalProperties:false esa global FAIL_ON_UNKNOWN_PROPERTIES=false sababli repo bo'ylab majburlanmaydi; delivery_fee_amount BigDecimal -> JSON string JacksonConfig (ToStringSerializer) orqali kontrakt "type: string" bilan mos. Bular bu bargning defekti emas. ERP DOCS'GA TEGILMADI. Mutatsiyalar izolyatsiyalangan worktree'da (/tmp/qa-EP-12-T03-S04) o'tkazildi va o'chirildi; asosiy daraxt toza (git status bo'sh, git grep MUTANT HEAD bo'sh).

qa-ep-12-t03-s04 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-12-t03-s04 qabul mezonini belgiladi

✗ 06 AC21: ikkala shafyor birga -> rad; external + summa yo'q/<=0 -> rad; o'z shafyori + summa -> rad; faqat external + 150 000 -> `delivering` va `is_driver` tekshirilmaydi

qa-ep-12-t03-s04 qabul mezonini belgiladi

✓ Biriktirishning o'zi hech qanday moliyaviy yozuv tug'dirmaydi (08 Q70 = A)

qa-ep-12-t03-s04 qabul mezonini belgiladi

✓ 06 AC22: external buyurtmada `order.confirm_delivery` rad etiladi; `mark_delivered_manual` GPS NULL bilan `delivered` qiladi va shubhali-tasdiq bayrog'i qo'yilmaydi

coder-ep-12-t03-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t03-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-12-t03-s04 qabul mezonini belgiladi

✓ Biriktirishning o'zi hech qanday moliyaviy yozuv tug'dirmaydi (08 Q70 = A)

coder-ep-12-t03-s04 qabul mezonini belgiladi

✓ 06 AC22: external buyurtmada `order.confirm_delivery` rad etiladi; `mark_delivered_manual` GPS NULL bilan `delivered` qiladi va shubhali-tasdiq bayrog'i qo'yilmaydi

coder-ep-12-t03-s04 qabul mezonini belgiladi

✓ 06 AC21: ikkala shafyor birga -> rad; external + summa yo'q/<=0 -> rad; o'z shafyori + summa -> rad; faqat external + 150 000 -> `delivering` va `is_driver` tekshirilmaydi

coder-ep-12-t03-s04 fayllarni qayd etdi

12 ta fayl qayd etildi

coder-ep-12-t03-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t03-s04 ishga oldi

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yaratdi

`orders` — ko'cha shafyori maydonlari va biriktirish validatsiyasi (06 Q16/Q17)