Picking ishbayi xarajati (`picking_wage`, 64b)

finalize-ep-12 yangiladi

Yangilandi: pr_url

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

qa-ep-12-t03-s03 izoh qoldirdi

QA 2-tur (788128d) — QABUL. M8b qayta o'tkazildi izolyatsiyalangan worktree'da (/tmp/qa2-EP-12-T03-S03, endi olib tashlangan): OrderService.java:1574-1575 dagi pickingWageExpensePort.onPickingWageAccrued(...) chaqirig'i o'chirildi. javap dalili: mutant OrderService.class da onPickingWageAccrued invocation = 0, toza daraxtda = 1 (mutatsiya haqiqatan kompilyatsiya bo'lgan). Natija: OrderAssignDriverControllerTest:185 YIQILDI — "expected: 1 but was: 0" (Tests run: 6, Failures: 1) → M8b O'LDI, AC4644 endi isbotlangan. Assert halolligi: source_ref_id DB dan olinadi (readWageEntryId(workId) → wage_entries.id), qo'lda yozilgan konstanta EMAS; amount DB↔DB solishtiriladi (wage.amount() ham wage_entries dan o'qilgan); kategoriya expense_categories.code JOIN orqali 'picking_wage'; is_cash=false; money_movement_id rs.wasNull() bilan. git show --stat: 1 fayl, +130/-0 — birorta mavjud assert zaiflashtirilmagan, src/main ga tegilmagan. Kosmetik eslatma (defekt EMAS, tuzatish talab qilinmaydi): expenseEntrySourceType() so'rovi WHERE source_type='wage_entries' bilan filtrlab, keyin o'sha qiymatni assert qiladi — tautologik/ortiqcha; lekin xossaning o'zi count so'rovi (DB dan o'qilgan source_ref_id bilan) orqali allaqachon isbotlangan. Toza daraxtda test: rm -rf target/surefire-reports; flock ostida mvn -Dtest=OrderAssignDriverControllerTest,FinancePickingWageExpenseAdapterTest,WageAccrualPortTest,PickingWageAccrualPortTest test → Tests run: 21, Failures: 0, Errors: 0, Skipped: 0 — BUILD SUCCESS. Gigiyena: `git grep MUTANT HEAD` bo'sh · @Disabled/assumeTrue yo'q · openapi/ ga tegilmagan · FinanceContractOperationCoverageTest o'zgarmagan · commit xabarida AI atributi yo'q · worktree'lar olib tashlangan (git worktree list = faqat asosiy daraxt) · git status toza.

qa-ep-12-t03-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-12-t03-s03 qabul mezonini belgiladi

✓ Picking accrual'i xarajat qatori tug'diradi, ishlab chiqarish accrual'i esa YO'Q (08 AC31 ning bir qismi)

coder-ep-12-t03-s03 izoh qoldirdi

QA qaytarishi tuzatildi: OrderAssignDriverControllerTest asosiy testiga HTTP oqim orqali uchidan-uchiga assert qo'shildi (expense_entries: picking_wage, source_type=wage_entries, source_ref_id=DB dan o'qilgan wage_entries.id, is_cash=false, money_movement_id NULL, amount/organization_id/entry_date accrual'niki bilan solishtirildi). Izolyatsiyalangan worktree'da OrderService#assignDriver dagi onPickingWageAccrued chaqirig'ini o'chirib tekshirdim - yangi assert MUVAFFAQIYATSIZ bo'ldi (expected 1, was 0), ya'ni M8b mutant o'ldirilgan. 16/16 test yashil (OrderAssignDriverControllerTest 6, FinancePickingWageExpenseAdapterTest 5, WageAccrualPortTest 5). Commit 788128d.

coder-ep-12-t03-s03 yangiladi

Yangilandi: commit_sha

coder-ep-12-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t03-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-12-t03-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-12-t03-s03 izoh qoldirdi

QA (mutatsiya tekshiruvi bilan) — QAYTARILDI. Baseline yashil: 21 test (FinancePickingWageExpenseAdapterTest 5, WageAccrualPortTest 5, PickingWageAccrualPortTest 5, OrderAssignDriverControllerTest 6), 0 failure. == AC4645 (takroriy accrual) — O'TDI == FinancePickingWageExpenseAdapterTest#secondCallWithSameAccrualIdWritesNoSecondExpenseEntry haqiqiy tuzoqni qoplaydi: idempotentlik pre-check'ini olib tashlaganimda (M7) test DataIntegrityViolationException (uq_expense_entries_source_type_source_ref_id_active) bilan yiqildi. Ikkinchi chaqiruvda ataylab boshqa summa uzatilgani (7000.00 -> 99999.99) qatorning O'ZGARMAGANINI ham isbotlaydi. Yaxshi ish. == AC4644 — YIQILDI (yarmi qoplanmagan) == AC ikki qismdan iborat. "Ishlab chiqarishda YO'Q" qismi qoplangan (WageAccrualPortTest#productionWageAccrualDoesNotCreateExpenseEntry — men ishlab chiqarish yo'liga xarajat yozuvini ataylab yoqib yuborganimda AYNAN shu assert yiqildi). Lekin "Picking accrual'i xarajat qatori TUG'DIRADI" qismini HECH BIR test qo'riqlamaydi: src/main/java/uz/erpbom/orders/service/OrderService.java:1574-1576 dagi pickingWageExpensePort.onPickingWageAccrued(new PickingWageExpenseCommand(...)) chaqiruvini BUTUNLAY o'chirib tashladim (javap bilan tasdiqladim: OrderService.class da onPickingWageAccrued chaqiruvi 0 ta qoldi) va shundan keyin ham 10 ta test YASHIL qoldi: OrderAssignDriverControllerTest (6), OrderAssignDriverSupplierOnSaleLiabilityControllerTest (2), OrderAssignDriverCustomerLedgerRealAdapterControllerTest (2). Ya'ni butun feature assign-driver oqimidan uzilib qolsa ham CI yashil bo'ladi. Sabab: uchala assign-driver controller testida 'expense' so'zi umuman yo'q — ular faqat insertActivePeriod() fixture'ini oldi, hech qanday assert qo'shilmadi. FinancePickingWageExpenseAdapterTest esa portni QO'LDA tuzilgan command bilan chaqiradi — u ulanish nuqtasini isbotlamaydi. Bundan kelib chiqib, argument mapping (accrual.id() -> source_ref_id, accrual.amount() -> amount, accrual.organizationId(), accrual.workDate() -> entry_date) ham umuman qoplanmagan: chaqiruvning o'zi qoplanmagan bo'lsa, uning argumentlari ham qoplanmagan. KERAKLI TUZATISH (kod emas, TEST): OrderAssignDriverControllerTest#assignDriverRealizesStockAccruesWageAndEnqueuesNotificationInOneTransaction ichiga (yoki yangi test) assign-driver'dan KEYIN quyidagini tasdiqlovchi assert qo'shing: - expense_entries da source_type='wage_entries' AND source_ref_id = tug'ilgan wage_entries.id bo'yicha AYNAN 1 qator bor; - uning amount'i o'sha wage_entries.amount ga TENG (raqamgacha, F4 natijasi — qotirilgan konstanta emas); - category code = 'picking_wage', is_cash = false, money_movement_id IS NULL, organization_id = buyurtma node'i, entry_date = wage_entries.work_date. Shu assert bilan yuqoridagi mutant o'ladi. == Qolgan mutantlar (hammasi o'ldi) == M1a xarajat yozuvini o'chirish -> 2 failure; M2 is_cash=true -> 3 error; M3 kategoriya 'salary_monthly' -> 1 failure; M4 source_ref_id = accrualId+1 -> 2 failure + 1 error; M5 amount.negate() -> 2 failure; M6b ishlab chiqarish yo'lida xarajat yozuvi -> AC4644 assert'i yiqildi; M7 idempotentlik pre-check olib tashlandi -> DataIntegrityViolationException. Mutatsiyalar izolyatsiyalangan worktree'da (6b20497) o'tkazildi, worktree olib tashlandi, asosiy daraxt toza, `git grep MUTANT HEAD` bo'sh. == Fixture xilma-xilligi — YAXSHI == FinancePickingWageExpenseAdapterTest da summalar xilma-xil (18345.67 kasrli, 7000.00, 99999.99, 5000.00, 1000.00), sanalar turlicha, har testda alohida organization va accrualId. Kasrli 18345.67 aynan M5 (negate) ni o'ldirdi. Muammo yo'q. == Uchta o'zgartirilgan mavjud test — TOZA == OrderAssignDriverControllerTest, OrderAssignDriverSupplierOnSaleLiabilityControllerTest, OrderAssignDriverCustomerLedgerRealAdapterControllerTest: numstat bo'yicha har birida 25 qo'shildi / 0 o'chirildi. Faqat insertActivePeriod() helper + uning chaqiruvi. Hech bir assert zaiflashtirilmagan, o'chirilmagan, @Disabled/assumeTrue yo'q. == Commit gigiyenasi — TOZA == openapi/ ostida o'zgargan fayl yo'q (kontrakt muzlatilgan holida qoldi), begona fayl yo'q, MUTANT yo'q, commit xabarida AI atributi yo'q. == SPEC BO'SHLIG'I (tuzatish emas, PM uchun savol) == Coder ogohlantirishi TASDIQLANDI: FinancePickingWageExpenseAdapter.java:87-91 dagi accountingPeriodRepository.findByIsActiveTrue()...orElseThrow(IllegalStateException) assign-driver tranzaksiyasi ICHIDA ishlaydi, ya'ni aktiv accounting_periods qatori bo'lmasa shafyor biriktirish BLOKLANADI. Empirik dalil: uchala mavjud testga insertActivePeriod() qo'shishga majbur bo'lingan, va mutatsiya yurgizganimda testlar aynan "Aktiv amaliyot oyi topilmadi" xatosi bilan yiqildi. Bloklashning O'ZI coder ixtirosi EMAS — qoida 64b (picking wage_entries tug'ilsa xarajat qatori shartsiz yoziladi) + qoida 40 (har expense_entries hujjatiga aktiv davr muhrlanadi) birgalikda buni MAJBUR qiladi. Lekin spec JAVOB BERMAYDIGAN joy: aktiv davr UMUMAN yo'q bo'lganda assign-driver qanday xato qaytarishi kerak? Hozir IllegalStateException -> 500, kodsiz. Muzlatilgan kontraktda (openapi/v1/orders.yaml, assignOrderDriver) 500 e'lon qilinmagan; spec'dagi yagona davr xatosi 409 PERIOD_CLOSED (E4) esa "entry_date yopilgan davrda" holatiga tegishli, "aktiv davr yo'q" holatiga emas. Savol PM ga: (1) aktiv davr yo'qligida assign-driver 409 kodli biznes xatosi qaytarishi kerakmi (qaysi kod?), yoki (2) logistika amali moliya davri holatiga bog'lanmasligi kerakmi (u holda xarajat yozuvi kechiktirilishi kerak)? Bu bargni o'zgartirmasdan alohida hal qilinsin — men kodga ham, docs ga ham tegmadim.

qa-ep-12-t03-s03 qabul mezonini belgiladi

✗ Picking accrual'i xarajat qatori tug'diradi, ishlab chiqarish accrual'i esa YO'Q (08 AC31 ning bir qismi)

qa-ep-12-t03-s03 qabul mezonini belgiladi

✓ Takroriy accrual ishlanishida ikkinchi xarajat qatori yozilmaydi

coder-ep-12-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t03-s03 izoh qoldirdi

Yangi port PickingWageExpensePort (orders.service) + Noop + FallbackConfig + FinancePickingWageExpenseAdapter (finance.service), CustomerLedgerPort bilan bir xil naqsh. assignDriver() ichida pickingWageAccrualPort.accrue(...) dan KEYIN, AYNI tranzaksiyada chaqiriladi. Idempotentlik — ExpenseEntryRepository#findFirstBySourceTypeAndSourceRefIdOrderByIdDesc bilan (PayrollRunService#accrueExpenseSalaryMonthly naqshi). Muhim: bu yangi qadam expense_entries yozuvi uchun aktiv accounting_periods talab qiladi (qoida 40, mavjud FinanceExpenseAdapter naqshi) — shu sababli assign-driver ni 200 gacha yurgizadigan 3 ta mavjud test (OrderAssignDriverControllerTest, OrderAssignDriverSupplierOnSaleLiabilityControllerTest, OrderAssignDriverCustomerLedgerRealAdapterControllerTest) ham insertActivePeriod() fixture oldi (aks holda 500 berardi). Testlar: FinancePickingWageExpenseAdapterTest (5 ta - wiring/AC4644/AC4645/rollback/no-active-period), WageAccrualPortTest ga qoshilgan productionWageAccrualDoesNotCreateExpenseEntry (AC4644 ishlab chiqarish yarmi). Jami tekshirilgan: 26/26 yashil (assign-driver oilasi + yangi testlar).

coder-ep-12-t03-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-12-t03-s03 fayllarni qayd etdi

11 ta fayl qayd etildi

coder-ep-12-t03-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t03-s03 ishga oldi

team-lead-pm yangiladi

Yangilandi: estimate_hours

pm-agent yaratdi

Picking ishbayi xarajati (`picking_wage`, 64b)