Tasdiqlash — tasdiqlovchining kassasi, qoldiq gate'i, atomiklik

finalize-ep-12 yangiladi

Yangilandi: pr_url

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

team-lead-pm yangiladi

Yangilandi: estimate_hours

worker-ep-12-t02 yangiladi

Yangilandi: commit_sha

worker-ep-12-t02 statusni o'zgartirdi Review → Bajarildi

worker-ep-12-t02 qabul mezonini belgiladi

✓ Ikki parallel tasdiqda kassadan faqat bir marta yechiladi (E26)

worker-ep-12-t02 qabul mezonini belgiladi

✓ `draft` hujjat kassaga/jurnalga/foydaga ta'sir qilmaydi; `confirmed` lahzada uchalasi bitta tranzaksiyada o'zgaradi (08 AC24)

worker-ep-12-t02 qabul mezonini belgiladi

✓ Qoldiq 500 000, frozen 400 000 bo'lganda 300 000 lik hujjat tasdiqlanmaydi va `draft` da qoladi (08 AC26)

worker-ep-12-t02 qabul mezonini belgiladi

✓ Kassasi yo'q user `expense.approve` huquqi bilan ham tasdiqlay olmaydi (08 AC25)

worker-ep-12-t02 izoh qoldirdi

REGRESSIYA SWEEP (worker-pm, HEAD e08aa6e, paket bo'yicha bo'laklab, hammasi YASHIL): expense invoice confirm+reversal 40 | expense invoice service/list/entry 34 | expense entry query/adapter 20 | expense category + money account query 24 | money account/movement service 31 | money transfer/counterparty/hold 75 | counterparty controllerlar 37 | money/cash controllerlar 32 | ledger + payment reverse 18 | accounting period 9 | finance outbox worker + integrity job 10 | permission katalogi + expense migratsiyalari 55 | qolgan migratsiyalar 214 | payment controllerlar 51. ESLATMA: FinanceContractOperationCoverageTest KUTILGAN holda qizil - yetishmayotgan operatsiyalar FAQAT fixed-assets, payroll-runs, accounting-periods close/reopen, reconciliations, me/finance (T04/T05/T06 qamrovi). expense-invoices ning 9 ta operatsiyasi ham RO'YXATDA YO'Q, ya'ni hammasi register qilingan.

worker-ep-12-t02 izoh qoldirdi

SPEC SAVOLI (blok emas): qoida 55c price >= 0 ga ruxsat beradi, demak total_amount = 0.00 li hujjat YARATILADI. Uni tasdiqlashda MoneyMovementService summa musbatligini talab qiladi va umumiy ValidationException beradi — bu kod kontraktdagi confirmExpenseInvoice 400 sabablari ro'yxatida YO'Q. Savol: 0 summali xarajat hujjati tasdiqlanadimi (a) yo'q — qaysi xato kodi bilan; (b) ha — pul harakati yozilmay faqat jurnal qatorimi? Hozir bu yo'l na specda, na testda bor.

worker-ep-12-t02 izoh qoldirdi

Tuzatilgan mutant sinflari: movement/entry snapshot maydonlari (source_type, source_ref_id, org/period/category/entry_date), status log user_id (yaratuvchi != tasdiqlovchi), AC4168 atomiklik (qisman unique indeks bilan yiqitilgan tranzaksiyada pul harakati ham qolmaydi), qoida 57 node-lokallik (kassa meniki, boshqa filialda -> 403), qoida 58 chegarasi (1 tiyin oshiq rad; frozen>0 bilan musbat yo'l), ko'p qatorli kasrli hujjat (jami olinadi, yaxlitlanmaydi). Testlar 16 -> 21, yashil.

worker-ep-12-t02 izoh qoldirdi

QA 2-raund holati: ishlab chiqarish kodi toza edi, 8 tirik mutant test qamrovida. Tuzatildi commit e08aa6e (faqat testlar).

worker-ep-12-t02 fayllarni qayd etdi

1 ta fayl qayd etildi

worker-ep-12-t02 statusni o'zgartirdi Ishlanyapti → Review

worker-ep-12-t02 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

worker-ep-12-t02 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-12-t02-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-12-t02-s02 izoh qoldirdi

QA (mutatsiya bilan tekshirildi, izolyatsiyalangan worktree /tmp/qa-EP-12-T02-S02, HEAD c39e741). Baza: `mvn -Dtest=ExpenseInvoiceConfirmServiceTest test` -> Tests run: 16, Failures: 0, Errors: 0 (BUILD SUCCESS). ISBOTLANGAN (mutant o'ldi, javap bilan bytecode tasdiqlangan): - AC4166: `resolveConfirmerCashAccount` dagi `candidates.isEmpty()` gate olib tashlandi -> `confirmByUserWithoutCashAccountIsForbiddenEvenWithApprovePermission` yiqildi. - AC4167: `MoneyMovementService.rejectIfInsufficientFunds` da `.subtract(getFrozenAmount())` olib tashlandi -> `confirmRejectsWhenAvailableBalanceBelowTotalAmountAndKeepsInvoiceDraft` yiqildi. Fixture'da `frozen_amount=400000` (0 EMAS) -> mezon VACUOUS emas. - AC4168: `expenseEntryService.record(...)` tashlab ketildi -> 8 test yiqildi (shu jumladan `confirmWritesMoneyMovementExpenseEntryAndStatusLogAtomically`). - AC4169: `findByIdForUpdate` -> `findById` -> `concurrentConfirmDebitsCashExactlyOnce` yiqildi. Test HAQIQIY parallel (ExecutorService + CountDownLatch, 2 thread), teatr emas. QAYTARISH SABABI - QOPLANMAGAN MEZON (qoida 57, node-lokal): MUTANT: `src/main/java/uz/erpbom/finance/service/ExpenseInvoiceService.java:571` `boolean nodeMatches = organizationId.equals(account.getOrganizationId());` -> `boolean nodeMatches = true;` NATIJA: 16/16 test YASHIL QOLDI (mutant TIRIK). `javap -c -p ExpenseInvoiceService` tasdiqladi: `requireOwnCashAccountInNode` bytecode'idan `MoneyAccount.getOrganizationId` chaqiruvi butunlay yo'qolgan, faqat `getResponsibleEmployeeId` qolgan - ya'ni mutatsiya kuchga kirgan, lekin uni HECH BIR test ushlamadi. SABAB (fixture xilma-xilligi): `ExpenseInvoiceConfirmServiceTest` dagi 41 ta fixture havolasining HAMMASI bitta tashkilotni (`rootOrgId`) ishlatadi - ikkinchi `organization_id` umuman yo'q. `confirmRejectsForeignCashAccountExplicitlyRequested` (359-qator) begona kassani AYNAN `rootOrgId` ichida yaratadi, ya'ni u faqat `responsibleMatches` yarmini sinaydi, `nodeMatches` yarmini emas. SPEC/KONTRAKT talabi: 08_finance.md qoida 57 ("Hisob node-lokal bo'lishi shart - hujjat `organization_id` si bilan bir xil"), board technical_notes ("Hisob node-lokal ... va `responsible_employee_id` = tasdiqlovchi"), muzlatilgan kontrakt `confirmExpenseInvoice` (finance.yaml): "Hisob node-lokal (hujjat organization_id si bilan bir xil) va responsible_employee_id = tasdiqlovchi (qoida 36) - aks holda 403". KERAK: ikkinchi `organizations` qatorini yaratuvchi fixture + test: tasdiqlovchining O'ZIGA biriktirilgan (`responsible_employee_id` = tasdiqlovchi) `cash` hisobi BOSHQA node'da bo'lsin, u `money_account_id` sifatida yuborilsin -> `403 OwnershipDeniedException` kutiladi va hujjat `draft` da qolsin. QO'SHIMCHA (shu bilan birga tuzatilsin, alohida qaytarishga arzimaydi): `src/test/java/uz/erpbom/finance/service/ExpenseInvoiceConfirmServiceTest.java:149` (AC4166) BO'SH `money_accounts` jadvali ustida ishlaydi - u "tasdiqlovchining kassasi yo'q" holatini "umuman kassa yo'q" holatidan AJRATA OLMAYDI. Nazorat mutanti (avto-tanlash so'rovidan `responsible_employee_id` filtri olib tashlandi) shu testni EMAS, tasodifan `concurrentConfirmDebitsCashExactlyOnce` ni yiqitdi. Tuzatish: shu testga O'SHA node'dagi BOSHQA hodimga tegishli bitta `cash` hisobi qo'shilsin - o'shanda 403 aynan "kassa MENIKI emas" sababidan chiqadi. TEKSHIRILGAN VA MUAMMOSIZ: - qoida 60 (SoD YO'Q): kodda "yaratuvchi != tasdiqlovchi" taqig'i YO'Q; `confirmAllowsCreatorToApproveOwnInvoice` (438-qator) qoplaydi. Defekt emas. - `source_type` BIRLIK/KO'PLIK masalasi: MUAMMO YO'Q. Spec qoida 54 so'zma-so'z `source_type=expense_invoices` (KO'PLIK) deydi, §2.13b ro'yxati ham `expense_invoices`. Kod ikkala joyda ham `MoneyMovementService.SOURCE_TYPE_EXPENSE_INVOICES = "expense_invoices"` yozadi (`money_movements` va `expense_entries`), test 273-qatorda tasdiqlaydi. Birlik `expense_invoice` faqat `OUTBOX_OBJECT_TYPE` (finance_outbox.object_type) - BOSHQA maydon, spec bilan ziddiyat yo'q. - V48 migratsiyasi: ADDITIVE (V39 dagi 4 qiymat + `expense_invoices`), raqam to'qnashuvi yo'q (oldingi maksimum V47), `expense_entries` CHECK'i (V42) `expense_invoices` ni allaqachon ruxsat bergan. - `INSUFFICIENT_FUNDS` xabari spec so'zi bilan boshlanadi: "Kassangizda yetarli summa mavjud emas (qoida 14) - mavjud=..., so'ralgan=...". - Kontrakt (`confirmExpenseInvoice`) status/kodlari mos: 403 (kassasiz/begona kassa), 400 VALIDATION_ERROR `fields[].field=money_account_id`, 409 INSUFFICIENT_FUNDS / INVALID_STATUS_TRANSITION / PERIOD_CLOSED / ACCOUNT_BUSY. - Cross-cutting: `confirm` bitta `@Transactional` da, `get` `readOnly=true`, `tenant_id` yo'q, fizik DELETE yo'q, `expense.approved` outbox biznes yozuv bilan bir tranzaksiyada, summalar numeric(18,2). Asosiy daraxtga TEGILMADI (mutatsiya faqat worktree'da); `git grep MUTANT HEAD` bo'sh, worktree o'chirilgan.

coder-ep-12-t02-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-12-t02-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-12-t02-s02 izoh qoldirdi

Yechim: MoneyMovementService#record qayta ishlatildi (qoida 58 FOR UPDATE + INSUFFICIENT_FUNDS AYNAN shu servisdan). money_movements.source_type CHECK ustiga expense_invoices qiymati YANGI migratsiya (V48) bilan qo'shildi — V39 (money_movements) V44 (expense_invoices) dan OLDIN yozilgani uchun bu qiymat yo'q edi; kontrakt matni bu maydonni majburiy demaydi, lekin V29 additiv-CHECK naqshiga ergashib to'g'ri manba (allaqachon mavjud draft hujjat) biriktirildi. Qoida 57 kassa nomzodlari hujjat organization_id + responsible_employee_id kesimida qidiriladi (node-lokal). expense_invoice_status_logs uchun YANGI entity/repository qo'shildi (draft->confirmed yozuvi) — reverse/cancel/remark hamon S03 ishi. Test: ExpenseInvoiceConfirmServiceTest 16/16 yashil; ExpenseInvoiceServiceTest 19/19 va ExpenseInvoiceListServiceTest 6/6 regressiyasiz. FinanceContractOperationCoverageTest confirmExpenseInvoice endi bog'langan (qizil ro'yxatda yo'q) — qolgan qizil S03/boshqa epiklar kutilgan.

coder-ep-12-t02-s02 qabul mezonini belgiladi

✓ Ikki parallel tasdiqda kassadan faqat bir marta yechiladi (E26)

coder-ep-12-t02-s02 qabul mezonini belgiladi

✓ `draft` hujjat kassaga/jurnalga/foydaga ta'sir qilmaydi; `confirmed` lahzada uchalasi bitta tranzaksiyada o'zgaradi (08 AC24)

coder-ep-12-t02-s02 qabul mezonini belgiladi

✓ Qoldiq 500 000, frozen 400 000 bo'lganda 300 000 lik hujjat tasdiqlanmaydi va `draft` da qoladi (08 AC26)

coder-ep-12-t02-s02 qabul mezonini belgiladi

✓ Kassasi yo'q user `expense.approve` huquqi bilan ham tasdiqlay olmaydi (08 AC25)

coder-ep-12-t02-s02 fayllarni qayd etdi

10 ta fayl qayd etildi

coder-ep-12-t02-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-12-t02-s02 ishga oldi

pm-agent yaratdi

Tasdiqlash — tasdiqlovchining kassasi, qoldiq gate'i, atomiklik