`money_transfers` egalik qatlami — shafyor uchun `list` istisnosi va `update` qo'riqchisi

finalize-ep-11 yangiladi

Yangilandi: pr_url

qa-ep-11-t06-s05 statusni o'zgartirdi Review → Bajarildi

qa-ep-11-t06-s05 izoh qoldirdi

QA 2-RAUND (qa-EP-11-T06-S05, commit ff670c6) -> DONE. 1-raundda tirik qolgan M2 va M3 mutantlari YOPILDI, eski mutantlar (M1/M4) regressiyaga uchramadi. [O'LCHOV] Tests run: 91, Failures: 0, Errors: 0, Skipped: 0 (29 controller + 62 service), izolyatsiyalangan worktree /tmp/qa2-EP-11-T06-S05 (ff670c6). Coder aytgan 91 bilan mos. [SRC/MAIN O'ZGARMAGANI TASDIQLANDI] `git diff 2ddef22 ff670c6 -- src/main/` = 0 qator. Faqat 2 ta test fayli (+155/-1). `openapi/` diff = 0 qator (kontrakt tegilmagan). [MUTATSIYA - 4/4 O'LDI, hammasi javap bilan tasdiqlangan] - M2 (MoneyTransferRepository.java:85 dan `OR t.toAccountId IN (:ownedAccountIds)` olib tashlandi) -> O'LDI, 1 test: MoneyTransferServiceTest.listIncludesTransfersWhereOwnEmployeeHoldIsTheToLeg:1540. javap tasdig'i: kompilyatsiya qilingan @Query konstantasi `... AND (t.fromAccountId IN (:ownedAccountIds))` bo'lib qolgan, `toAccountId` YO'Q. (1-raundda shu mutant 88/88 yashil bilan TIRIK o'tgan edi.) - M3 (MoneyTransferService.java:492 - ESKI from_account_id tekshiruvi olib tashlandi) -> O'LDI, 2 test: MoneyTransferControllerIntegrationTest.updatingForeignDraftByRedirectingToOwnAccountReturnsForbidden:617 va MoneyTransferServiceTest.updateRejectsHijackingForeignDraftByRedirectingToOwnAccount:554. javap tasdig'i: update() bytecode'ida requireFromAccountOwnership chaqiruvi 2 -> 1 (klass jami 6 -> 5). (1-raundda TIRIK edi.) - M1 (searchOwned -> cheklanmagan search) -> O'LDI, endi 5 test (avvalgi 4 + yangi to-leg testi): listingForDriverAudienceReturnsOnlyOwnEmployeeHoldTransfers, listingForDriverAudienceIgnoresForeignFromAccountIdFilter, listRestrictsToOwnEmployeeHoldTransfersForDriverAudience, listIgnoresForeignFromAccountIdFilterForDriverAudience, listIncludesTransfersWhereOwnEmployeeHoldIsTheToLeg. javap: mutant .class da searchOwned = 0 ta (aslida 1 ta). - M4 (MoneyTransferService.java:305 requirePermission(finance.view) olib tashlandi) -> O'LDI, 2 test: listingWithoutViewPermissionReturnsForbiddenAndAudits:129, listWithoutViewPermissionForNonDriverAudienceThrowsForbidden:1415. javap: klassda requirePermission chaqiruvi 2 -> 1. Ya'ni yangi testlar eski mutant-o'ldirishni BUZMAGAN - regressiya yo'q. [MEZON 4249 - YOPILDI] listIncludesTransfersWhereOwnEmployeeHoldIsTheToLeg (MoneyTransferServiceTest.java:1519). Assertion EGALIKKA tayanadi: containsExactly(toLegTransferId) + doesNotContain(foreignToLegTransferId). Fixture'da IKKINCHI shafyorning employee_hold i ham `to` oyog'ida - manfiy nazorat bor, ya'ni test faqat "qator qaytdi" emas, FILTR ishlayotganini isbotlaydi. [MEZON 4252 - YOPILDI] Uchinchi kombinatsiya qamrab olindi: ESKI = begona, YANGI = chaqiruvchining O'ZINIKI. Bu holda ikkinchi (yangi hisob) tekshiruvi MUVAFFAQIYATLI o'tadi, himoya BUTUNLAY :492 dagi eski tekshiruvga tayanadi - technical_notes'dagi "begona draftni o'ziga ko'chirish" hujumi aynan shu. Ikkala qatlamda ham test bor (unit :527 + HTTP :604) va ikkalasi ham yon ta'sirni tekshiradi (draft qurbon hisobida qolgani). [XOM SQL FIXTURE (insertTransferDirect) - QABUL QILINDI, sabab:] (a) HA, band kontraktga muvofiq: openapi/v1/finance.yaml listMoneyTransfers tavsifi `from_account_id` YOKI `to_account_id` oyog'ini OCHIQ talab qiladi. Ya'ni `OR` sharti spekulyativ emas, kontrakt majburiyati - va u qoida 24 ning kuchda qolishiga TAYANMASLIGI kerak (himoya qatlami: qoida 24 kelajakda yumshasa, `from`-only filtr jimgina sizdirardi). (b) YO'Q, hech qanday DB cheklovi chetlab o'tilmagan. V41__money_transfers_cash_counts_external_drivers.sql:33-37 ochiq yozadi: qabul qiluvchi hisob TURI cheklovini DB CHECK qilib bo'lmaydi ("Postgres CHECK boshqa jadvalga murojaat qilolmaydi, trigger loyihada ishlatilmaydi") va u ATAYLAB ilova qatlamida tekshiriladi. Ya'ni INSERT faqat ILOVA validatsiyasini (validateTransferFields, qoida 24 - MoneyTransferService.java) chetlab o'tadi; qator DB nuqtai nazaridan butunlay QONUNIY (barcha FK va NOT NULL to'ldirilgan). Test javodoci buni ochiq yozgan - talab bajarilgan. (c) YO'Q, boshqa testlarga ta'siri yo'q: helper FAQAT shu bitta testda chaqiriladi (MoneyTransferServiceTest.java:1533, :1535) va @BeforeEach (:97) har testdan oldin money_transfers ni TRUNCATE qiladi. Klassdagi hasSize() assertionlari money_movements ustida (send/receive testlari), bu fixture ularga tegmaydi. Muqobil yo'l yo'q edi: qoida 24 tufayli `to_account_id = employee_hold` API orqali PRINSIPIAL erishib bo'lmaydi, shuning uchun kontrakt talab qilgan `OR` shoxobchasini boshqa yo'l bilan mustaqil tasdiqlab bo'lmaydi. [QOLGAN XAVF - kichik, bloklovchi emas] insertTransferDirect xom ustun ro'yxatiga bog'langan: kelajakda money_transfers ga default'siz NOT NULL ustun qo'shilsa, bu test assertion emas, SQL xatosi bilan yiqiladi (sabab darhol ko'rinmaydi). Helper javodocida "boshqa hech bir testda ishlatilmasin" cheklovi bor - shu qoida saqlansa xavf shu bitta test bilan chegaralanadi. [1-RAUNDDAN O'ZGARMAGAN XULOSALAR] aud TOKEN'dan (JwtAuthenticationFilter.java:105), so'rovdan emas; non-driver + finance.view siz -> 403 + auth_logs deny (M4 bilan qo'riqlangan); noRollbackFor naqshi PaymentService.java:427/:581 bilan bir xil; update() da from_account_id @NotNull; cross-cutting (tranzaksiya, migratsiya yo'q, outbox tegilmagan, soft-delete, log'da token yo'q) toza. [IZOLYATSIYA] Butun ish /tmp/qa2-EP-11-T06-S05 worktree'da; mutantlar `cp <fayl>.orig` bilan tiklandi (stash/reset/checkout ISHLATILMADI); yakunda grep -rn MUTANT src/ = 0, .orig fayllar o'chirildi, worktree o'chirildi, asosiy daraxt git status --short BO'SH, git grep MUTANT HEAD natijasiz, openapi/ va erp/docs tegilmadi.

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Egalik filtrini olib tashlash (mutatsiya) kamida bitta testni yiqitadi — sanoqqa emas, EGALIKKA tayanadigan assertion bilan

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ `PUT /money-transfers/{id}` begona `draft` ustida 403 beradi — ham eski, ham yangi `from_account_id` bo'yicha; o'z draftida ishlayveradi

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Shafyor `from_account_id` filtrini BOSHQA hisob bilan ochiq yuborsa ham begona o'tkazma qaytmaydi (filtr server tomonda majburlanadi)

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Kassir/buxgalter uchun `GET /money-transfers` xatti-harakati O'ZGARMAYDI (`finance.view` bilan to'liq ro'yxat) — regressiya testi bilan tasdiqlangan

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ `aud='driver'` bilan `GET /money-transfers` chaqirilganda `finance.view` TALAB QILINMAYDI va javobda FAQAT chaqiruvchining `employee_hold` i oyoq bo'lgan o'tkazmalar qaytadi — boshqa shafyorniki ham, kassirlar orasidagi o'tkazma ham YO'Q

coder-ep-11-t06-s05 izoh qoldirdi

QA topgan M2/M3 ikkalasi ham testlar bilan yopildi (kod o'zgarmadi, HEAD=2ddef22 bilan bir xil, faqat testlar qo'shildi commit ff670c6 da). M2 (searchOwned to_account_id OR): javap bilan tasdiqlandi - bytecode'dagi @Query satridan 'toAccountId IN' satri yo'qoldi (grep -o bo'sh qaytdi); shu mutant bilan aynan 1 ta test yiqildi - listIncludesTransfersWhereOwnEmployeeHoldIsTheToLeg (kutilgan [2L], actual []). M3 (update() eski from_account_id tekshiruvi): javap -c bilan update() metodi ichida requireFromAccountOwnership chaqiruvi soni 2 dan 1 ga tushgani tasdiqlandi; shu mutant bilan 2 ta test yiqildi - updateRejectsHijackingForeignDraftByRedirectingToOwnAccount (unit, kutilgan throwable kelmadi) va updatingForeignDraftByRedirectingToOwnAccountReturnsForbidden (HTTP, 200 kelib qoldi, 403 kutilgan edi). Ikkala mutant navbat bilan cp bilan tiklandi, git grep MUTANT bo'sh, git diff asosiy fayllarda 0 (faqat test fayllari o'zgargan). Yakuniy: 91/91 test yashil (62 ServiceTest + 29 ControllerIntegrationTest).

coder-ep-11-t06-s05 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ `PUT /money-transfers/{id}` begona `draft` ustida 403 beradi — ham eski, ham yangi `from_account_id` bo'yicha; o'z draftida ishlayveradi

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ `aud='driver'` bilan `GET /money-transfers` chaqirilganda `finance.view` TALAB QILINMAYDI va javobda FAQAT chaqiruvchining `employee_hold` i oyoq bo'lgan o'tkazmalar qaytadi — boshqa shafyorniki ham, kassirlar orasidagi o'tkazma ham YO'Q

coder-ep-11-t06-s05 yangiladi

Yangilandi: commit_sha

coder-ep-11-t06-s05 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-11-t06-s05 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-11-t06-s05 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-11-t06-s05 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-11-t06-s05 izoh qoldirdi

QA (qa-EP-11-T06-S05, commit 2ddef22) -> in_progress. KOD TO'G'RI, TEST QOPLAMASI YETARLI EMAS: ikki mutatsiya butun to'plamdan TIRIK o'tdi (javap bilan tasdiqlangan). O'lchov: Tests run: 88, Failures: 0, Errors: 0 (mvn -Dtest=MoneyTransferServiceTest,MoneyTransferControllerIntegrationTest, izolyatsiyalangan worktree). [NUQSON 1 - mezon 4249 (+ kontrakt finance.yaml listMoneyTransfers)] `to_account_id` OYOG'I umuman qoplanmagan. - Kod TO'G'RI: MoneyTransferRepository.java:85 -> `(t.fromAccountId IN (:ownedAccountIds) OR t.toAccountId IN (:ownedAccountIds))`. - MUTATSIYA M2: `OR t.toAccountId IN (:ownedAccountIds)` olib tashlandi. javap tasdig'i - kompilyatsiya qilingan @Query konstantasi `... AND (t.fromAccountId IN (:ownedAccountIds))` bo'lib qoldi. Natija: 88/88 test YASHIL, mutant TIRIK. - SABAB (fixture xilma-xilligi): hamma fixture'da shafyorning employee_hold hisobi FAQAT `from` oyog'ida. MoneyTransferServiceTest.java:1386 (listRestrictsToOwnEmployeeHoldTransfersForDriverAudience) va MoneyTransferControllerIntegrationTest.java:143 - ikkalasida ham employee_hold -> cash. - KUTILGAN: AC4249 "employee_hold i OYOQ bo'lgan" + kontrakt "from_account_id YOKI to_account_id oyog'i". KERAK: fixture'ga `cash -> employee_hold` o'tkazmasi qo'shilsin (uni kassa mas'uli kassir yaratadi, qoida 36) va shafyor ro'yxatida o'sha id BOR ekani assert qilinsin. Shundan keyin M2 yiqilishi shart. [NUQSON 2 - mezon 4252] ESKI `from_account_id` tekshiruvi qoplanmagan - technical_notes'dagi aynan o'sha hujum yo'li testsiz. - Kod TO'G'RI: MoneyTransferService.java:492 (eski) + :493 (yangi). - MUTATSIYA M3: :492 (eski hisob tekshiruvi) olib tashlandi. javap tasdig'i - update() bytecode'ida requireFromAccountOwnership chaqiruvi 2 dan 1 ga tushdi (klass jami 6 -> 5). Natija: 88/88 test YASHIL, mutant TIRIK. - SABAB: mavjud ikkala test ham so'rovda from_account_id ni draftning ESKI qiymati bilan yuboradi (MoneyTransferServiceTest.java:461 updateRejectsWhenActorDoesNotOwnCurrentFromAccount; MoneyTransferControllerIntegrationTest.java:533 updatingForeignDraftWithUnchangedFromAccountReturnsForbidden). Bunda YANGI hisob tekshiruvi AYNAN o'sha begona hisob ustida ishlab, o'zi 403 beradi - eski tekshiruv borligi natijaga ta'sir qilmaydi. - QOPLANMAGAN SSENARIY (faqat eski tekshiruv ushlaydi): begona user BEGONA draftga PUT yuboradi va from_account_id da O'ZINING hisobini beradi. Eski tekshiruvsiz -> 200 va begona draft hujumchining hisobiga KO'CHADI (technical_notes: "begona draftni o'ziga ko'chirish yo'li"). - KERAK: shu ssenariy uchun test - stranger (o'z cash/employee_hold hisobi + money_transfer.create) PUT /money-transfers/{begona draft id} body.from_account_id = O'Z hisobi -> 403 va DB da money_transfers.from_account_id O'ZGARMAGAN. Shundan keyin M3 yiqilishi shart. [O'TGAN MEZONLAR] - 4250 OK: listReturnsFullResultForViewerAudienceRegardlessOfOwnership (MoneyTransferServiceTest.java:1466) + listingForViewerAudienceStillReturnsFullResultRegardlessOfOwnership. - 4251 OK: from_account_id filtri driver yo'lida umuman e'tiborga olinmaydi (MoneyTransferService.java:302-303 searchOwned ga fromAccountId/toAccountId UZATILMAYDI); M1 bu testlarni yiqitdi. - 4253 OK (harfma-harf): M1 (searchOwned -> cheklanmagan search) 4 ta testni yiqitdi - listingForDriverAudienceReturnsOnlyOwnEmployeeHoldTransfers, listingForDriverAudienceIgnoresForeignFromAccountIdFilter, listRestrictsToOwnEmployeeHoldTransfersForDriverAudience, listIgnoresForeignFromAccountIdFilterForDriverAudience. javap: mutant .class da searchOwned = 0 ta. Assertion EGALIKKA tayanadi (containsExactly(id) + doesNotContain(boshqa shafyor id, kassirlararo id)), sanoqqa emas. Fixture'da IKKINCHI shafyor VA kassirlararo (cash->cash) o'tkazma BOR - tekshirildi. [XAVFSIZLIK REGRESSIYASI - TEKSHIRILDI, TESHIK YO'Q] - @RequirePermission("finance.view") kontrollerdan olib tashlangani XAVFSIZ: tekshiruv servisga ko'chgan (MoneyTransferService.java:305 requirePermission(userId, "finance.view")). MUTATSIYA M4 (shu qatorni olib tashlash) 2 testni YIQITDI: listingWithoutViewPermissionReturnsForbiddenAndAudits (MoneyTransferControllerIntegrationTest.java:126, aud=web + huquqsiz -> 403 FORBIDDEN + auth_logs deny = 1) va listWithoutViewPermissionForNonDriverAudienceThrowsForbidden. Ya'ni non-driver + finance.view siz -> 403, teshik YO'Q. - `aud` TOKEN'dan olinadi, so'rovdan EMAS: JwtAuthenticationFilter.java:105 -> new AuthenticatedUser(claims.userId(), claims.sessionId(), claims.audience()), claims JwtService.parse dan. Istisno teshikka aylanmaydi. - Hodimi/hisobi yo'q driver token: resolveActingEmployeeId -> null -> findEmployeeHoldAccountIdsByHolder(null) -> List.of() -> BO'SH sahifa (MoneyTransferService.java:298-301), xato ham, to'liq ro'yxat ham emas. (Testi yo'q - majburiy emas, lekin qo'shilsa yaxshi.) - readOnly=true olib tashlanishi va noRollbackFor = ForbiddenException.class: asoslangan (deny-audit INSERT) va repo'dagi mavjud naqsh bilan bir xil (PaymentService.java:427, :581; MoneyTransferService.java:689 reject). noRollbackFor faqat ForbiddenException ni qamraydi; OwnershipDeniedException ErpException dan meros oladi va list() yo'lida umuman otilmaydi. - update() da from_account_id null bo'la olmaydi: MoneyTransferUpdateRequest da @NotNull + kontrakt required -> bean validation 400 beradi; eski hisob baribir :492 da BIRINCHI tekshiriladi. - "har endpoint @RequirePermission ga ega" degan global qamrov testi repo'da YO'Q - jimgina zaiflashgan test topilmadi. [CROSS-CUTTING] @Transactional bor; migratsiya yo'q (tenant_id/FK/precision/nomlash tegilmagan); outbox tegilmagan; fizik DELETE yo'q; resolveActingEmployeeId soft-delete'ni hisobga oladi (findByUserIdAndDeletedAtIsNull); log/audit'ga token yozilmaydi (faqat rule kodi). [IZOLYATSIYA] Butun ish /tmp/qa-EP-11-T06-S05 git worktree'da; yakunda `grep -rn MUTANT src/` = 0, worktree o'chirildi, asosiy daraxt `git status --short` BO'SH, `git grep MUTANT HEAD` natijasiz. openapi/ va erp/docs ga TEGILMADI.

qa-ep-11-t06-s05 qabul mezonini belgiladi

✗ `PUT /money-transfers/{id}` begona `draft` ustida 403 beradi — ham eski, ham yangi `from_account_id` bo'yicha; o'z draftida ishlayveradi

qa-ep-11-t06-s05 qabul mezonini belgiladi

✗ `aud='driver'` bilan `GET /money-transfers` chaqirilganda `finance.view` TALAB QILINMAYDI va javobda FAQAT chaqiruvchining `employee_hold` i oyoq bo'lgan o'tkazmalar qaytadi — boshqa shafyorniki ham, kassirlar orasidagi o'tkazma ham YO'Q

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Egalik filtrini olib tashlash (mutatsiya) kamida bitta testni yiqitadi — sanoqqa emas, EGALIKKA tayanadigan assertion bilan

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Shafyor `from_account_id` filtrini BOSHQA hisob bilan ochiq yuborsa ham begona o'tkazma qaytmaydi (filtr server tomonda majburlanadi)

qa-ep-11-t06-s05 qabul mezonini belgiladi

✓ Kassir/buxgalter uchun `GET /money-transfers` xatti-harakati O'ZGARMAYDI (`finance.view` bilan to'liq ro'yxat) — regressiya testi bilan tasdiqlangan

coder-ep-11-t06-s05 izoh qoldirdi

88/88 test yashil (60 ServiceTest + 28 ControllerIntegrationTest). Mutatsiya sinovi: egalik filtrini olib tashlash (searchOwned -> search fromAccountId/toAccountId bilan) 4 ta testni yiqitdi (AC4253 tasdiqlandi), mutant tiklandi va git grep MUTANT bo'sh. Muhim qaror: list() readOnly=true bo'la olmadi - requirePermission() deny yo'lida auth_logs ga yozadi (AuditService ambient-tranzaksiya siyosati, R30), shu sabab @Transactional(noRollbackFor=ForbiddenException.class) qo'llanildi (reject() bilan bir xil naqsh).

coder-ep-11-t06-s05 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-11-t06-s05 yangiladi

Yangilandi: branch, commit_sha

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ Egalik filtrini olib tashlash (mutatsiya) kamida bitta testni yiqitadi — sanoqqa emas, EGALIKKA tayanadigan assertion bilan

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ `PUT /money-transfers/{id}` begona `draft` ustida 403 beradi — ham eski, ham yangi `from_account_id` bo'yicha; o'z draftida ishlayveradi

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ Shafyor `from_account_id` filtrini BOSHQA hisob bilan ochiq yuborsa ham begona o'tkazma qaytmaydi (filtr server tomonda majburlanadi)

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ Kassir/buxgalter uchun `GET /money-transfers` xatti-harakati O'ZGARMAYDI (`finance.view` bilan to'liq ro'yxat) — regressiya testi bilan tasdiqlangan

coder-ep-11-t06-s05 qabul mezonini belgiladi

✓ `aud='driver'` bilan `GET /money-transfers` chaqirilganda `finance.view` TALAB QILINMAYDI va javobda FAQAT chaqiruvchining `employee_hold` i oyoq bo'lgan o'tkazmalar qaytadi — boshqa shafyorniki ham, kassirlar orasidagi o'tkazma ham YO'Q

coder-ep-11-t06-s05 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-11-t06-s05 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-11-t06-s05 ishga oldi

unknown-agent yaratdi

`money_transfers` egalik qatlami — shafyor uchun `list` istisnosi va `update` qo'riqchisi