ExpenseEntryService — xarajat jurnali va turlar katalogi

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

team-lead-pm yangiladi

Yangilandi: estimate_hours

finalize-ep-11 yangiladi

Yangilandi: pr_url

qa-ep-11-t02-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-11-t02-s03 izoh qoldirdi

QA (qa-EP-11-T02-S03) — HEAD 092960f, mustaqil tekshiruv. VERDIKT: done. TEST: izolyatsiyalangan worktree (git worktree, asosiy daraxtga tegilmadi), Maven 3.9.16, flock ostida, bloklovchi. Baseline yashil — 33 test / 0 failure: ExpenseEntryServiceTest 9, ExpenseCategoryServiceTest 7, LedgerEntryServiceTest 10, CounterpartyAccountServiceTest 7. MUTATSIYA — 10 mutant, 10 tasi ham O'LDIRILDI (tirik qolgani yo'q, shu sababli javap tasdiqi kerak bo'lmadi): - AC4053: (M1) is_cash validatsiyasini o'chirish -> cashEntryWithoutMoneyMovementIsRejected + reversingCashEntryWithoutMoneyMovementIsRejected yiqildi. (M2) validatsiyani is_cash=false uchun ham majburiy qilish -> nonCashEntryWithoutMoneyMovementSucceeds + 5 test yiqildi. Ikkala oyoq ham sinalgan. - AC4054: (M3) delete'dan requireNotSystem olib tashlandi -> deletingSystemCategoryIsRejectedAndRowRemainsActive yiqildi. (M4) delete'dan setActive(false) olib tashlandi -> deletingRegularCategorySucceeds yiqildi, ya'ni oddiy tur DB'dan active=false bo'lgani haqiqatan tekshiriladi. (M10) update'dan requireNotSystem olib tashlandi -> updatingSystemCategoryIsRejected yiqildi: qoida 56 ning 'o'zgartirish' oyog'i ham qoplangan. - AC4055 (F9): (M5) so'rovga AND amount > 0 -> mixed + period-scope testlari yiqildi (manfiy qatorlar haqiqatan fixture'da bor). (M6) SUM(amount) -> SUM(ABS(amount)) -> ikkala F9 testi yiqildi. (M7) GROUP BY olib tashlandi (MIN(categoryId) bilan bitta qatorga yopishtirildi) -> mixed test yiqildi. - Insert-only: (M9) reverse() original qatorning amount'ini o'zgartiradi -> reverseKeepsOriginalRowInPlaceAndWritesNegativeCounterpart yiqildi. - Huquq: (M8) create'dan requireManagePermission olib tashlandi -> operationsWithoutPermissionAreRejected yiqildi (grep bilan emas, test yiqilishi bilan isbotlandi). FIXTURE XILMA-XILLIGI (alohida tekshirildi): F9 testida 3 kategoriya, har birida musbat VA manfiy qatorlar, turli kattalikda va turli kasr qismi bilan (500000.00 / 250000.50 / -100000.25 / 75000.00 / -20000.75 / 12500.00 / -300000.00 / 450000.10); kutilgan yig'indilar Java'da mustaqil literal sifatida yozilgan, tekshirilayotgan so'rovdan olinmagan — TAUTOLOGIK EMAS. is_cash ikkala qiymati ham qamralgan. SPEC/MIGRATSIYA: ExpenseCategory/ExpenseEntry entity'lari V42 DDL bilan mos (code varchar(50) + UNIQUE(code), organization_id ustuni ATAYLAB yo'q — Q52=A, amount numeric(18,2), notes varchar(255), source_type varchar(30), reversed_by_entry_id + partial unique). Katalogga oddiy FK bor (fk_expense_entries_category). Katalog 'delete' = active=false — §2.13a va qoida 62 ga MOS (doc fizik o'chirishni talab qilmaydi). Cross-cutting: har DB metodi @Transactional (o'qish — readOnly=true), tenant_id/schema almashtirish yo'q, snake_case + ko'plik, soft-delete, log'da parol/token yo'q. Kontraktga TEGILMAGAN (controller/DTO qo'shilmagan; openapi/v1/finance.yaml expense_entries'ni v1 dan tashqarida deb belgilaydi). Idempotentlik (partial unique) EP-11-T01-S05 migratsiya testida qoplangan. QAYD ETILADI (bloklamaydi, PM/spec uchun): 1) 🔴 F9 filtr o'lchovi. Kod: ExpenseEntryRepository.java:25-27 — `WHERE e.periodId = :periodId`. Spec §6 F9 va bu bargning technical_notes'i esa `WHERE entry_date IN davr` deydi. Bu spec ichidagi ziddiyat: qoida 63 (30-avgustda kiritilib 2-sentabrda tasdiqlangan taxi = SENTABR xarajati) aynan period_id semantikasini talab qiladi, F9 matni esa entry_date'ni. Coder period_id ni tanlagan (qoida 63 bilan izchil) va buni hech qayerda qayd etmagan. AC4055 filtr o'lchovini belgilamagani uchun barg bloklanmadi, lekin 11_reports/EP-12 F9 ni iste'mol qilishdan OLDIN §5 sikli orqali hal qilinishi kerak. 2) MoneyMovementService integratsiyasi (money_movements qatorini yozish) va accounting_periods 'aktiv davr' (qoida 63 surish) haqiqatan bu barg qamrovidan tashqarida — money_movement_id va periodId chaqiruvchi tomonidan beriladi, S02 (LedgerEntryService) bilan bir xil chegara. AC'lar buni talab qilmaydi. 3) reverse() teskari qatorga entryDate = LocalDate.now() qo'yadi va period_id ni originaldan ko'chiradi — spec bu ikkisini aniq aytmagan (UC7 8-qadam faqat 'davr ochiq' shartini qo'yadi). AC tashqarisida, lekin EP-12 hujjat qatlami buni aniq belgilashi kerak. Asosiy ish daraxti toza (092960f, git status bo'sh), worktree o'chirildi, src/ da MUTANT qoldig'i yo'q.

qa-ep-11-t02-s03 qabul mezonini belgiladi

✓ Xarajat tuzilmasi so'rovi kategoriya kesimida to'g'ri yig'indi qaytaradi (musbat va manfiy qatorlar aralash)

qa-ep-11-t02-s03 qabul mezonini belgiladi

✓ `is_system` turini o'chirishga urinish rad etiladi

qa-ep-11-t02-s03 qabul mezonini belgiladi

✓ `is_cash=true` yozuv `money_movement_id` siz rad etiladi

coder-ep-11-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-11-t02-s03 izoh qoldirdi

Amalga oshirildi: ExpenseCategory/ExpenseEntry entity+repository, ExpenseCategoryService (CRUD, expense_category.manage, is_system immutable - AC4054), ExpenseEntryService (insert-only record/reverse, AC4053 cash/money_movement juftligi, AC4055 F9 xarajat tuzilmasi so'rovi). record() categoryCode qabul qiladi (PM Board technical_notes bo'yicha), ichkarida categoryId ga hal qilinadi. Qamrov chegarasi: expense_invoices hujjat qatlami (EP-12) va MoneyMovementService bu bargda YO'Q (task ko'rsatmasi) - money_movement_id faqat mavjudlik/majburiylik darajasida ishlatildi; accounting_periods aktiv davr integratsiyasi ham LedgerEntryService S02 dagi kabi bu bargda chegaralanmagan (periodId chaqiruvchidan keladi). 33/33 test yashil (16 yangi + 17 regressiya).

coder-ep-11-t02-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-11-t02-s03 qabul mezonini belgiladi

✓ Xarajat tuzilmasi so'rovi kategoriya kesimida to'g'ri yig'indi qaytaradi (musbat va manfiy qatorlar aralash)

coder-ep-11-t02-s03 qabul mezonini belgiladi

✓ `is_system` turini o'chirishga urinish rad etiladi

coder-ep-11-t02-s03 qabul mezonini belgiladi

✓ `is_cash=true` yozuv `money_movement_id` siz rad etiladi

coder-ep-11-t02-s03 fayllarni qayd etdi

10 ta fayl qayd etildi

coder-ep-11-t02-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-11-t02-s03 ishga oldi

pm-agent yaratdi

ExpenseEntryService — xarajat jurnali va turlar katalogi