V38 — accounting_periods + counterparty_accounts + ledger_entries

pm-agent yangiladi

Yangilandi: estimate_hours

pm-agent yangiladi

Yangilandi: estimate_hours

team-lead-pm yangiladi

Yangilandi: estimate_hours

finalize-ep-11 yangiladi

Yangilandi: pr_url

qa-ep-11-t01-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-11-t01-s01 izoh qoldirdi

QA (izolyatsiyalangan worktree, Testcontainers PG16): 4/4 mezon mustaqil tasdiqlandi, 39 test yashil. Mutatsiya: 10 mutant — 6 tasi darhol o‘ldi (is_active partial WHERE, cp uq dan currency_code/counterparty_type, ledger partial WHERE reversal, COALESCE(source_ref_line_id,-1), source_ref_line_id kalitdan). 4 tasi TIRIK qolgan edi (fixture bir xilligi): kalitga kirmaydigan ustun qo‘shilsa hech bir test sezmasdi — (is_active,status), (period_year,period_month,status), cp uq + current_balance, ledger idempotentlik kaliti + account_id. Shu 4 bo‘shliq uchun test qo‘shildi (3 yangi metod + mavjud aktiv-davr testiga xilma-xillik qadami); yangi testlar bilan 4 mutantning hammasi o‘ldi, toza SQL da 39/39 yashil. O‘zgargan fayl asosiy daraxtga ko‘chirildi: src/test/java/uz/erpbom/finance/AccountingPeriodsCounterpartyAccountsLedgerEntriesMigrationTest.java (faqat test; migratsiya SQL tegilmagan). Commit — lead zimmasida.

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir kontragentda ikki xil valyutada ikkita varaqa ochiladi, bir valyutada ikkinchisi rad etiladi

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir xil `(source_type, source_ref_id, source_ref_line_id)` bilan ikkinchi NORMAL qator rad etiladi, LEKIN `reversal_of_entry_id` to'ldirilgan qator yoziladi — ikkalasi ham test bilan tasdiqlangan

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Ikkinchi `is_active = true` davr yozib bo'lmaydi (partial unique ishlaydi)

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

coder-ep-11-t01-s01 yangiladi

Yangilandi: commit_sha

coder-ep-11-t01-s01 fayllarni qayd etdi

1 ta fayl qayd etildi

coder-ep-11-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir xil `(source_type, source_ref_id, source_ref_line_id)` bilan ikkinchi NORMAL qator rad etiladi, LEKIN `reversal_of_entry_id` to'ldirilgan qator yoziladi — ikkalasi ham test bilan tasdiqlangan

qa-ep-11-t01-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-11-t01-s01 izoh qoldirdi

QA (qa-EP-11-T01-S01) — d61fd2b, izolyatsiyalangan worktree'da tekshirildi. BAZA: 34/34 yashil (mvn -Dtest=AccountingPeriods...MigrationTest, Testcontainers PG16, flock ostida). MUTATSIYA TEKSHIRUVI — 8 mutant, har birida mutant target/classes'ga yetgani tasdiqlangan: A WHERE is_active olib tashlandi -> OLDIRILDI (7 test qizil, 4028 testi ham) B idempotentlik indeksi olib tashlandi -> OLDIRILDI (2 test) C hisob kalitidan currency_code olib tashlandi-> OLDIRILDI (4030 birinchi yarmi) H hisob kaliti UNIQUE -> oddiy indeks -> OLDIRILDI (4030 ikkinchi yarmi) D COALESCE yo'q, spec matnidagi so'zma-so'z shakl -> OLDIRILDI (header-level dedup testi) E WHERE reversal_of_entry_id IS NULL olib tashlandi -> OLDIRILDI (reversal testi) F source_ref_id ham COALESCE qilindi -> OLDIRILDI (manual_adjustment testi) G kalitdan source_ref_line_id BUTUNLAY olib tashlandi -> TIRIK QOLDI, 34/34 yashil <-- DEFEKT ❌ 4029 QAYTARILDI — kalitning uchinchi ustuni hech qanday test bilan qo'riqlanmagan. Mutant G: V38...sql:192 dagi indeks `ON ledger_entries (source_type, source_ref_id)` ga qisqartirildi (COALESCE va source_ref_line_id ikkalasi ham yo'q) — butun to'plam yashil o'tdi. Sabab — fixture xilma-xilligi yo'q: line darajasidagi yagona fixture (test fayli:458 duplicateNormalEntryWithSameIdempotencyKeyAtLineLevelIsRejected) BIR XIL line id (55) ni ikki marta yozadi, qolgan hamma fixture'da source_ref_line_id = NULL. Ya'ni to'plam 3-ustunli kalitni 2-ustunli kalitdan farqlay olmaydi. Biznes ta'siri: G holatida spec §2.2/§2.3 Q9 (`payment_basis=on_sale`, qoida 34) buziladi — bitta hujjatning 55-qatoriga majburiyat yozilgach, 56-qatoriga yozib bo'lmaydi (jim yo'qolgan qarz). KERAKLI TUZATISH (faqat test, migratsiya TO'G'RI — o'zgartirilmasin): AccountingPeriodsCounterpartyAccountsLedgerEntriesMigrationTest ga bitta test qo'shilsin — insertNormalEntry(..., "sale", 902L, 55L, ...) -> qabul qilinadi insertNormalEntry(..., "sale", 902L, 56L, ...) -> HAM qabul qilinishi SHART (bir hujjat, boshqa qator) va assert: ikkala id ham musbat va bir-biridan farqli. (Ixtiyoriy kuchaytirish: shu hujjatning header darajasidagi (line=NULL) qatori ham yonma-yon yozilishi.) Qabul mezoni: mutant G bilan bu test QIZIL bo'lsin. ✅ KODERNING QARORI (COALESCE(source_ref_line_id, -1)) — TASDIQLANDI, defekt EMAS: (a) Mutant D isbotladi: spec §2.2 dagi so'zma-so'z `UNIQUE(source_type, source_ref_id, source_ref_line_id)` Postgres'da NULL≠NULL sababli hujjat darajasidagi (line=NULL) dublikatni UMUMAN tutmaydi — spec'ning o'z maqsadi ("bitta faktura tasdig'i ikki marta qarz yozmasin") bajarilmasdi. COALESCE aynan spec niyatini beradi. (b) manual_adjustment (ikkala ref NULL) uchun idempotentlik yo'qligi §2.3 ga MOS — har biri mustaqil audit yozuvi (izoh majburiy); test bilan qotirilgan (mutant F). (c) `-1` sentinel to'qnashuvi MUMKIN EMAS — sxemadan tasdiqlandi (taxmin emas): purchase_receipt_lines/order_lines/supplier_return_lines va boshqa hamma jadval `id bigint GENERATED ALWAYS AS IDENTITY` (1 dan boshlanadi); migratsiyalarda manfiy MINVALUE/START li sekvensiya yo'q. 🔵 PM uchun: bu spec qarzi — erp/docs/modules/08_finance.md §2.2 dagi indeks matni Postgres semantikasida o'z maqsadini bajarmaydi; §5 sikli orqali COALESCE shakliga aniqlashtirilsin (QA docs'ga yozmaydi). QOLGAN TEKSHIRUVLAR (hammasi o'tdi): - 4027: V38 flyway_schema_history'da success=true; V38 nomi yagona, konflikt yo'q. - 4028/4030: yuqoridagi mutantlar bilan qoplangani isbotlandi. - §2.3 CHECK ro'yxati — spec'dagi 9 qiymat AYNAN (sale_return_credit ham DB'da bor, kontrakt enum'ida ataylab yo'q — technical_notes/OPEN#9 ga mos). - Kontrakt (openapi/v1/finance.yaml): AccountingPeriodResponse / CounterpartyAccountResponse / LedgerEntryResponse maydonlari va enumlari (AccountingPeriodStatus, CounterpartyType, LedgerSourceType) DB bilan mos; kontrakt O'ZGARTIRILMADI. - Cross-cutting: tenant_id/organization_id yo'q (AR-1, test bilan); currency_code -> currencies.code oddiy katalog FK (AR-10), repo konvensiyasi varchar(3) bilan izchil; numeric(18,2) precision test bilan; snake_case + ko'plik + to'liq FK nomlari; jurnal insert-only (fizik DELETE FK RESTRICT bilan to'silgan); password_hash log'ga chiqmaydi. - Kichik kuzatuv (bloklamaydi, shu tuzatish bilan birga ko'rilsa bo'ladi): V38...sql:41 `reopen_reason text`, kontraktda esa maxLength 255 (finance.yaml AccountingPeriodResponse) — repo'da text uchun pretsedent bor (V30 cancel_reason), lekin varchar(255) izchilroq. Asosiy ish daraxti toza: `grep -rn MUTANT src/` bo'sh, worktree o'chirildi.

qa-ep-11-t01-s01 qabul mezonini belgiladi

✗ Bir xil `(source_type, source_ref_id, source_ref_line_id)` bilan ikkinchi NORMAL qator rad etiladi, LEKIN `reversal_of_entry_id` to'ldirilgan qator yoziladi — ikkalasi ham test bilan tasdiqlangan

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir kontragentda ikki xil valyutada ikkita varaqa ochiladi, bir valyutada ikkinchisi rad etiladi

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Ikkinchi `is_active = true` davr yozib bo'lmaydi (partial unique ishlaydi)

qa-ep-11-t01-s01 qabul mezonini belgiladi

✓ Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

coder-ep-11-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-11-t01-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-11-t01-s01 ishga oldi

coder-ep-11-t01-s01 izoh qoldirdi

source_type CHECK ro'yxatiga sale_return_credit ham kiritildi (technical_notes + spec 2.3 -- OPEN#9 faqat siyosatni ochiq qoldiradi, qiymatning o'zini emas). Idempotentlik indeksi technical_notes matnidan BITTA joyda farq qiladi: source_ref_line_id ustuniga COALESCE(source_ref_line_id,-1) qo'shildi -- oddiy UNIQUE(source_type, source_ref_id, source_ref_line_id) haqiqiy Postgres ustida (NULL != NULL semantikasi) hujjat darajasidagi (line_id=NULL) dublikatni UMUMAN tutmasligi real testda topildi (duplicateNormalEntryWithSameIdempotencyKeyIsRejected avval qizil edi). source_ref_id ATAYLAB coalesce qilinmadi, shu bois manual_adjustment (ikkalasi ham NULL) hamon cheklovsiz qoladi. Batafsil izoh migratsiya faylida (uq_ledger_entries_source_idempotency yonida).

coder-ep-11-t01-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir kontragentda ikki xil valyutada ikkita varaqa ochiladi, bir valyutada ikkinchisi rad etiladi

coder-ep-11-t01-s01 qabul mezonini belgiladi

✓ Bir xil `(source_type, source_ref_id, source_ref_line_id)` bilan ikkinchi NORMAL qator rad etiladi, LEKIN `reversal_of_entry_id` to'ldirilgan qator yoziladi — ikkalasi ham test bilan tasdiqlangan

coder-ep-11-t01-s01 qabul mezonini belgiladi

✓ Ikkinchi `is_active = true` davr yozib bo'lmaydi (partial unique ishlaydi)

coder-ep-11-t01-s01 qabul mezonini belgiladi

✓ Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

coder-ep-11-t01-s01 fayllarni qayd etdi

2 ta fayl qayd etildi

pm-agent yaratdi

V38 — accounting_periods + counterparty_accounts + ledger_entries