Yetkazishni tasdiqlash — shafyor va qo'lda yo'l (R19c, R23)

finalize-ep-10 yangiladi

Yangilandi: commit_sha, pr_url

qa-ep-10-t05-s04 statusni o'zgartirdi Review → Bajarildi

qa-ep-10-t05-s04 izoh qoldirdi

QA 2-yurish (commit 91211fe, izolyatsiyalangan worktree). VERDIKT: done. 1-yurishdagi YAGONA defekt YOPILDI. Mutatsiya bilan tasdiqlandi (3/3 mutant O'LDI): - e2 OrderService.java:2192 (list toResponse) customer.address() -> "MUTANT-ADDR": OrderListControllerTest.orderListShowsReadinessRatioForEachRowWithoutNPlusOne:276 YIQILDI (expected "Jizzax sh., Sharof Rashidov kochasi 2" but was "MUTANT-ADDR"). Avval TIRIK edi. - e3 shu qatorda customer.lat() -> BigDecimal("41.311081") (ataylab BOSHQA test faylining koordinatasi): :278 YIQILDI (expected "40.125431" but was "41.311081") -> assert tautologik emas, fixture xilma-xilligi haqiqiy. - e4 OrderResponse.customerLat BigDecimal -> double (JSON raqam bo'lib chiqadi): :277 isTextual() YIQILDI -> kontrakt "string decimal" sharti HAQIQATAN qo'riqlangan (asText() yolg'on ijobiyi yopilgan). Har uch mutatsiya kompilyatsiyaga tushgani tasdiqlangan (javac 812 manba fayl qayta kompilyatsiya + xato matni mutant qiymatini ko'rsatmoqda). Detal yo'li (OrderService.java:520) mutatsiya qilinmagan - list yo'li izolyatsiya qilingan. TESTLAR (toza daraxt, 91211fe): 30/30 YASHIL - OrderConfirmDeliveryControllerTest 14, OrderListControllerTest 14, OrderMarkDeliveredManualControllerTest 2. REGRESSIYA (3715/3716/3717) qayta tasdiqlandi: - chegara: FAR_FROM_ADDRESS_THRESHOLD_METERS=5000.0, qat'iy ">" (OrderService.java:1610); 5150 m -> true + outbox 1 qator; 4870 m -> false + outbox 0. Fixture xilma-xilligi: Toshkent (+/+, bearing 35) va Sidney (-/+, bearing 200); destinationPoint production GeoDistance bilan bir xil sharsimon geometriyada. - GPS null -> far_from_address = null (has()=true, isNull()=true), hisob yurgizilmaydi, outbox 0. - tasdiq BLOKLANMAYDI: ikkala holatda ham status=delivered. - so'rov tanasida masofa/bayroq maydoni YO'Q: OrderDeliveryConfirmRequest = (gpsLat, gpsLng, confirmedAt) - xolos. - ombor koordinatasi ishtirok etmaydi: computeFarFromAddress faqat customers.lat/lng + so'rov GPS. - snapshot EMAS: mijoz manzili UPDATE qilingach GET /orders/{id} yangi qiymatni qaytaradi (Fargona -> Namangan). - mark-delivered-manual: far_from_address maydoni javobda YO'Q (has()=false), GPS null, auth_logs allow + details->>'manual_confirmation'='true', far outbox 0. - AC3717: CustomerLedgerPort.onOrderDelivered times(1), captor bilan customerId/orderId/amount/dueDate; base (days=0) va price_type 15 kun ikkala holat; delivering holatida verifyNoInteractions; 403 va status-xato yo'llarida ham verifyNoInteractions. NoopCustomerLedgerPort da TODO(08_finance) bor. - kontrakt: far_from_address boolean nullable readOnly; customer_lat/lng type: string - haqiqiy JSON e4 mutanti bilan tasdiqlandi (DTO tipiga ishonilmadi). - git show --stat 91211fe: faqat OrderListControllerTest.java (+10), openapi/ TEGILMAGAN, MUTANT/@Disabled/assumeTrue/.orig yo'q. Kuzatuv (bloklamaydi): aynan 5000.0 m nuqtasida test yo'q, shuning uchun ">" -> ">=" mutanti nazariy jihatdan tirik qolardi; haversine bilan aniq 5000.0 m ni urish amaliy emas, 5150/4870 qamrovi yetarli deb qabul qilindi. Tozalash: mutantlar cp <fayl>.orig bilan tiklandi, .orig fayllar o'chirildi, grep -rn MUTANT src/ BO'SH, worktree o'chirildi, asosiy daraxt toza.

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `delivered` tranzaksiyasida `CustomerLedgerPort` yozuv metodi chaqiriladi (mock bilan tasdiqlangan) — Noop da 08_finance TODO si bor

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `mark_delivered_manual` da GPS NULL qoladi va audit yozuvi qo'lda tasdiq bayrog'i bilan tushadi

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ Shafyor o'ziga biriktirilmagan buyurtmani tasdiqlay olmaydi (403); 5 km dan uzoq tasdiq BLOKLANMAYDI, notification port chaqiriladi (AC13)

coder-ep-10-t05-s04 yangiladi

Yangilandi: commit_sha

coder-ep-10-t05-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t05-s04 fayllarni qayd etdi

1 ta fayl qayd etildi

coder-ep-10-t05-s04 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t05-s04 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-10-t05-s04 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-10-t05-s04 izoh qoldirdi

QA (worktree /tmp/qa-EP-10-T05-S04, feade20) — QAYTARILDI: 1 ta tirik mutant (test bo'shligi). Uchala mezon (3715/3716/3717) KOD darajasida BAJARILGAN va 4 mutant bilan qo'riqlangani isbotlandi; qaytarish sababi — bitta qamrab olinmagan kontrakt yo'li. YURGIZILGAN TESTLAR (bloklovchi, flock, tor doira): OrderConfirmDeliveryControllerTest 14/14 · OrderMarkDeliveredManualControllerTest 2/2 · OrderOutboxWorkerTest 28/28 · OrderListControllerTest 14/14 · OrderCreateControllerTest 11/11 = 69/69 YASHIL. MUTATSIYA (har biri javap bilan bytecode'da tasdiqlangan): (a) GeoDistance EARTH_RADIUS_METERS 6_371_000 -> 12_742_000 => OLDI (confirmDeliveryWithGpsLessThan5km...:255) (b) FAR_FROM_ADDRESS_THRESHOLD_METERS 5000 -> 50000 => OLDI (confirmDeliveryWithGpsMoreThan5km...:225) (c) GPS null yo'lida return null -> Boolean.FALSE => OLDI (confirmDeliveryWithoutGps...:281) (d) enqueueIfAbsent(order.delivery_far_from_address) olib tashlandi => OLDI (…:227, outbox count) (e1) OrderService.java:2123 toDetailResponse'da customer_address hardcode => OLDI (…:322) (e2) OrderService.java:2192 toResponse'da (GET /orders LIST yo'li) customer_address hardcode => TIRIK QOLDI — OrderListControllerTest 14/14 baribir yashil. >>> QAYTARISH SABABI (yagona band): Fayl: src/main/java/uz/erpbom/orders/service/OrderService.java:2189-2193 (toResponse -> orderMapper.toResponse, list yo'li). Kod TO'G'RI (customer.address()/lat()/lng() uzatilyapti), lekin HECH BIR test uni tekshirmaydi: butun src/test da customer_address/customer_lat/customer_lng assert'i FAQAT OrderConfirmDeliveryControllerTest da (satr 304-306, 322-324) — ya'ni confirm-delivery javobi va GET /orders/{id} detali. GET /orders LIST javobi qopqoqsiz. Nega muhim: openapi/v1/orders.yaml:2104-2105 da customer_address/customer_lat/customer_lng OrderResponse ning `required` ro'yxatida; kontrakt (satr 673-680) aynan shu list javobini shafyor ilovasining OFFLINE 5 km ogohlantirishi manbai deb belgilaydi, GET /orders/me/deliveries esa hali qurilmagan (grep: yo'q). Regressiya jim o'tadi. KUTILGAN TUZATISH (kichik): OrderListControllerTest da mavjud findItemById(page.get("items"), orderId) item'iga 3 ta assert qo'shilsin — item.get("customer_address").asText() fixture manziliga teng; item.get("customer_lat").asText()/customer_lng — JSON'da STRING decimal (asText, asDouble EMAS) va fixture qiymatiga teng. Shundan keyin (e2) mutanti o'ladi. KUZATUVLAR (bloklamaydi, tuzatish talab qilinmaydi): 1. Aynan 5000.0 m chegara uchun test yo'q (bor: ~5150 m -> true, ~4870 m -> false). Kod `> 5000.0` (OrderService.java:253, 1610) — spec 'uzoq' talabiga mos; HTTP orqali float aniqligida 5000.000 ni barqaror sinash amalda mumkin emas, shuning uchun talab qilinmayapti. 2. requireOwnDriverEmployee dagi 'nofaol hodim -> 403' shoxobchasi (OrderService.java:~1470) confirm-delivery testlarida qamralmagan (qamralgan: boshqa shafyor, hodim yozuvi yo'q). Bu kod shu commit'da yozilmagan. TASDIQLANGAN BOSHQA BANDLAR: so'rov tanasi faqat gps_lat/gps_lng/confirmed_at (masofa/bayroq maydoni YO'Q — kontrakt 2486-2503 bilan aynan mos, bayroq FAQAT server hisobidan); tasdiq BLOKLANMAYDI (Janubiy Amerika GPS bilan ham 200 + delivered); ombor koordinatasi ishtirok etmaydi (GeoDistance yagona chaqiruv nuqtasi OrderService.java:1609, customers.lat/lng); yangi migratsiya YO'Q (order.delivery_far_from_address V34:118 va V36:40 CHECK ro'yxatida allaqachon bor); outbox qatori AYNI @Transactional confirmDelivery ichida, dedupKey bilan idempotent; worker uni notificationPort ga uzatadi (OrderOutboxWorker.process); mark-delivered-manual javobida far_from_address maydoni YO'Q va outbox'da hodisa yo'q (test:115, 125); snapshot EMAS — mijoz manzili UPDATE qilingach GET yangi qiymatni qaytaradi (test:308-324); customer_lat/lng JSON'da string decimal (JacksonConfig ToStringSerializer, test asText '40.389167'); fixture xilma-xilligi bor (Toshkent +/+, Sidney -/+, Buenos-Ayres -/-, bearing 35 va 200). Worktree tozalandi: grep -rn MUTANT src/ bo'sh, git status bo'sh, .orig fayllar o'chirilgan, worktree olib tashlandi. Asosiy ish daraxtiga tegilmadi.

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `delivered` tranzaksiyasida `CustomerLedgerPort` yozuv metodi chaqiriladi (mock bilan tasdiqlangan) — Noop da 08_finance TODO si bor

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `mark_delivered_manual` da GPS NULL qoladi va audit yozuvi qo'lda tasdiq bayrog'i bilan tushadi

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ Shafyor o'ziga biriktirilmagan buyurtmani tasdiqlay olmaydi (403); 5 km dan uzoq tasdiq BLOKLANMAYDI, notification port chaqiriladi (AC13)

coder-ep-10-t05-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t05-s04 statusni o'zgartirdi Backlog → Ishlanyapti

coder-ep-10-t05-s04 izoh qoldirdi

Mezon 3715 (5 km nazorati) yopildi — spec bo'shligi 2026-09-03 da Q9c variant A bilan hal qilingandan keyin. Qo'shildi: OrderResponse/OrderDetailResponse ga denormal customer_address/customer_lat/customer_lng (05 customers dan JORIY qiymat, snapshot emas); yangi OrderDeliveryConfirmResponse (OrderDetailResponse + far_from_address); GeoDistance (haversine, R=6371000) — request GPS vs mijozning joriy lat/lng, chegara 5 km (qat'iy >). true bo'lsa order.delivery_far_from_address outbox qatori order.delivered bilan bir xil tranzaksiyada enqueueIfAbsent orqali (V34 CHECK da allaqachon bor, migratsiya qo'shilmadi). GPS yo'q bo'lsa hisob umuman yurgizilmaydi (far_from_address=null). mark-delivered-manual o'zgarmadi (GPS yo'q, OrderDetailResponse qaytaradi). Test: OrderConfirmDeliveryControllerTest 14/14, OrderMarkDeliveredManualControllerTest 2/2, OrderListControllerTest 14/14, OrderOutboxWorkerTest 28/28 — hammasi yashil. Qo'shimcha regressiya tekshiruvi: OrderCreateControllerTest 11/11, OrderUpdateControllerTest 19/19, OrderReceiveControllerTest 10/10, OrderReceiveCreditGateControllerTest 12/12, OrderRepriceControllerTest 11/11, OrderSplitControllerTest 5/5 — hammasi yashil (mapper/DTO signature o'zgarishi barcha order javob yo'llariga tegadi edi). Commit feade205.

coder-ep-10-t05-s04 yangiladi

Yangilandi: commit_sha

coder-ep-10-t05-s04 qabul mezonini belgiladi

✓ Shafyor o'ziga biriktirilmagan buyurtmani tasdiqlay olmaydi (403); 5 km dan uzoq tasdiq BLOKLANMAYDI, notification port chaqiriladi (AC13)

team-lead-pm statusni o'zgartirdi Bloklangan → Backlog

BLOK YECHILDI (2026-09-03, biznes qarori olindi — 05_customers Q9 + 06_orders Q9c = variant A). (1) Koordinata manbai: customers.address + customers.lat/lng — UCHALASI MAJBURIY, qolda kiritiladi (05 §2.1, AC13). (2) Snapshot YOQ: manzil ozgarsa ochiq buyurtma ham joriy koordinata bilan tekshiriladi. (3) 5 km hisobi: klient ogohlantirishni ozi korsatadi (offline, faqat korsatuv, tasdiqni BLOKLAMAYDI), lekin shubhali tasdiq bayrogini va order.delivery_far_from_address notificationini SERVER qoyadi — sorovdagi GPS bilan customers.lat/lng orasidagi masofani qayta hisoblab; klient yuborgan masofa/bayroq QABUL QILINMAYDI. Qolda tasdiqlangan yolda (GPS NULL) hisob yurgizilmaydi. (4) Ombor koordinatasi bu tekshiruvda ISHTIROK ETMAYDI — warehouses ga ustun qoshilmaydi. Doc: 06_orders R19c + AC13, 05_customers §2.1/UC1/AC13/Q9. KETMA-KETLIK: avval kontrakt (customers.yaml + orders.yaml) yangilanadi, keyin EP-10-T05-S07 (customers ustunlari), keyin shu barg.

qa-ep-10-t05-s04 statusni o'zgartirdi Review → Bloklangan

3716 va 3717 BAJARILDI (test yashil, 7 mutant o'ldirildi). 3715 QISMAN: shafyor egaligi (403, haqiqiy 'boshqa faol shafyor' fixture'i bilan) va 'masofa BLOKLAMAYDI' qismi bor, LEKIN 5 km ogohlantirishi va order.delivery_far_from_address notification triggeri QURILMADI. Sababi - yetkazish manzili/koordinatasi hech bir modelda saqlanmaydi: 06_orders §2.1 orders da manzil ustuni yo'q, 05_customers §2.1 customers da ham yo'q (openapi/v1/orders.yaml SPEC BO'SHLIQLARI p.1/p.2). Turi: BIZNES BO'SHLIG'I - kod bilan yopilmaydi, erp §5 savol-javob sikli yopadi. EP-10-T09-S02 (mobil) bilan BIR XIL ildiz. Coder masofa hisobini TO'QIMAGAN (migratsiya tegilmagan, haversine yo'q, koordinata manbasi taxmin qilinmagan) - bu to'g'ri qaror.

qa-ep-10-t05-s04 izoh qoldirdi

QA (izolyatsiyalangan worktree, c9c1b74). TEST: baseline yashil — OrderConfirmDeliveryControllerTest 8/8, OrderMarkDeliveredManualControllerTest 2/2. Regressiya (8 klass, T05 qo'shnilari + OrderReceiveCreditGate): 50 test, 0 failure. 3716 BAJARILDI. mark-delivered-manual: GPS lat/lng NULL (javob + DB), delivered_confirmed_by_user_id = SHU user (shafyor EMAS, DB darajasida isNotEqualTo(driverUserId)), auth_logs'da result=allow + details.manual_confirmation=true, action/rule_code=order.mark_delivered_manual. @Transactional bor, permission R__permissions_and_currencies_seed.sql:113 da seed qilingan. 3717 BAJARILDI. markDelivered() ichida CustomerLedgerPort#onOrderDelivered AYNI tranzaksiyada, mock times(1) bilan tasdiqlangan; due_date = delivered_at + price_types.days (base=0 va days=15 fixture'lari bilan qoplangan); Noop'da 08_finance TODO bor; order.delivered outbox qatori dedup kalit bilan (V34 CHECK ro'yxatida bor). 3715 QISMAN (is_met=false qoladi). BAJARILGAN qismi: shafyor faqat o'ziga biriktirilgan buyurtmani tasdiqlaydi — begona shafyorga 403 + holat delivering'da qoladi + ledger chaqirilmaydi; masofa gate'i UMUMAN yo'q (Buenos-Aires koordinatasi bilan tasdiq 200 qaytaradi). QURILMAGAN qismi: 5 km ogohlantirishi va order.delivery_far_from_address triggeri. KOORDINATA TO'QILMAGAN — tekshirildi: commit birorta migratsiyaga TEGMAGAN (delivery_gps_lat/lng V32__orders.sql:124-125 da OLDINDAN bor), src/main da haversine/distance/radius hisobi YO'Q, order.delivery_far_from_address hech qayerda enqueue QILINMAYDI (faqat izohda), mijoz/node'dan manzil taxmin qilinmagan, hardcode koordinata yo'q. Coder bo'shliqni ONGLI hujjatlagan (OrderService#confirmDelivery javadoc + commit xabari). MUTATSIYA (9 mutant, hammasi worktree'da; javap bilan bytecode tasdiqlangan; asosiy daraxtga tegilmagan, grep MUTANT src/ bo'sh): O'LDIRILDI (7): egalik solishtiruvi o'chirildi -> byDifferentDriver 403 kutilgan, olingan 200 · delivering holat gate'i o'chirildi -> ikkala klassda 409 testi yiqildi · due_date plusDays(days)->plusDays(0) -> 2026-09-16 kutilgan · manual yo'lda GPS NULL o'rniga qiymat yozildi -> delivery_gps_lat isNull yiqildi · onOrderDelivered chaqiruvi olib tashlandi -> 3 test yiqildi · audit manual_confirmation TRUE->FALSE -> yiqildi · manual tasdiqlovchi = shafyorning useri -> yiqildi. Egalik fixture'i HAQIQIY: "boshqa shafyor" = alohida active employee + active driver professiya + order.confirm_delivery huquqi (yolg'on ijobiy emas; hodimsiz user uchun alohida test bor). TIRIK QOLDI (3, javap bilan tasdiqlangan qamrov bo'shliqlari, kod TO'G'RI — test yetishmaydi): 1) requireOwnDriverEmployee'dagi EMPLOYEE_STATUS_ACTIVE gate'i butunlay o'chirilsa hech bir test yiqilmaydi (javap: metodda 'active' ldc va getStatus YO'Q) — birorta test nofaol/ishdan bo'shatilgan shafyor yaratmaydi, hamma fixture 'active'. 2) markDeliveredManual'dagi setDeliveryGpsLat(null)/setDeliveryGpsLng(null) olib tashlansa test yiqilmaydi (javap: metodda setDeliveryGps* YO'Q) — FIXTURE XILMA-XILLIGI: buyurtma har doim GPS'siz insert qilinadi, shuning uchun "NULL qoladi" faqat "qiymat yozib yuborish"dan himoyalangan, "oldingi GPS o'chmay qolishi"dan emas. Hozir jonli defekt yo'q (bu commit'da fail-delivery/R19d yo'q, delivered'gacha GPS yozadigan yo'l yo'q) — R19d qo'shilganda test kerak. 3) onOrderDelivered assignDriver ichiga ham qo'shilsa (qarz delivering'da tug'ilsa) hech bir test yiqilmaydi (javap: assignDriver'da onOrderDelivered BOR) — OrderAssignDriverControllerTest CustomerLedgerPort'ni mock qilmaydi (real Noop ishlaydi), yangi klasslar esa buyurtmani to'g'ridan-to'g'ri SQL bilan 'delivering' holatida insert qiladi, assign-driver yo'lini yurgizmaydi. R23'ning "delivering'da EMAS" yo'nalishi faqat bilvosita (403/409 yo'llaridagi verifyNoInteractions) qoplangan. Tavsiya: OrderAssignDriverControllerTest'ga @MockitoBean CustomerLedgerPort + verifyNoInteractions. Bu 3 ta bo'shliq bargni qaytarish sababi EMAS (mezon matnlari bajarilgan) — keyingi bargda yopilsin.

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `delivered` tranzaksiyasida `CustomerLedgerPort` yozuv metodi chaqiriladi (mock bilan tasdiqlangan) — Noop da 08_finance TODO si bor

qa-ep-10-t05-s04 qabul mezonini belgiladi

✓ `mark_delivered_manual` da GPS NULL qoladi va audit yozuvi qo'lda tasdiq bayrog'i bilan tushadi

coder-ep-10-t05-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t05-s04 izoh qoldirdi

3715 qisman: shafyor egaligi (403) va 'bloklanmaydi' qismi bajarildi; 5 km ogohlantirishi va order.delivery_far_from_address triggeri QURILMADI — yetkazish manzili/koordinatasi 06_orders §2.1 va 05_customers §2.1 da saqlanmaydi (orders.yaml SPEC BO'SHLIQLARI p.1/p.2). Masofa hisobining bazasi yo'q.

coder-ep-10-t05-s04 qabul mezonini belgiladi

✓ `delivered` tranzaksiyasida `CustomerLedgerPort` yozuv metodi chaqiriladi (mock bilan tasdiqlangan) — Noop da 08_finance TODO si bor

coder-ep-10-t05-s04 qabul mezonini belgiladi

✓ `mark_delivered_manual` da GPS NULL qoladi va audit yozuvi qo'lda tasdiq bayrog'i bilan tushadi

coder-ep-10-t05-s04 fayllarni qayd etdi

8 ta fayl qayd etildi

coder-ep-10-t05-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-10-t05-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t05-s04 ishga oldi

pm-agent yaratdi

Yetkazishni tasdiqlash — shafyor va qo'lda yo'l (R19c, R23)