Yig'ish tugadi -> picked

finalize-ep-10 yangiladi

Yangilandi: commit_sha, pr_url

qa-ep-10-t05-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-10-t05-s02 izoh qoldirdi

QA 2-yurish (f5e12f2, izolyatsiyalangan worktree) — QABUL QILINDI. MUTATSIYA QAYTA TEKSHIRUVI — ikkala tirik mutant endi O'LADI: [MUTANT-A / TIRIK-1] OrderService#completePicking dagi buyurtma-holati gate'i o'chirildi. javap tasdig'i: gate xabari bytecode'da 0 marta, claimPicking gate'i 1 marta (mutatsiya izolyatsiyalangan, kesh emas). Natija: completePickingOnCancelledOrderWithClaimedWorkReturnsInvalidStatusTransitionAndLeavesWorkClaimed YIQILDI — "expected: 409 CONFLICT but was: 200 OK". 🔴 Yiqilish SABABI to'g'ri: so'rov TaskService gate'idan O'TIB ketdi va 200 qaytardi, ya'ni fixture'da picking work HAQIQATAN claim qilingan (test uni alohida assert qiladi: claim -> 200 OK, works.status = "claimed"). Demak test aynan buyurtma HOLATI gate'ini qo'riqlaydi, "claim qilinmagan" shoxobchasini emas. Eski test (completePickingFromNonPickingStatus...) mutant ostida hamon yashil qoldi — birinchi yurishdagi TIRIK-1 diagnozi tasdiqlandi, yangi test uni to'g'ri qopladi. [MUTANT-B / TIRIK-2] TaskService#claimPickingWork dagi tasks.status o'tishi + qty_claimed o'sishi o'chirildi -> test YIQILDI ("in_progress" kutilgan, "new" olingan). Assert'lar ketma-ket bo'lgani uchun qo'shimcha MUTANT-B2 yuritildi (FAQAT qty_claimed o'chirildi, status o'tishi QOLDIRILDI) -> mustaqil YIQILDI ("3.0000" kutilgan, "0.0000" olingan). javap: claimPickingWork tanasida (bytecode 210..292) Task.setStatus=1, Task.setQtyClaimed=0 — mutatsiya aniq va qo'shni createPickingTask'ga tegmagan. Ikkala mezon MUSTAQIL qoplangan. ISHLAB CHIQARISH KODI: f5e12f2 = FAQAT 2 test fayl, +71 qator (main/ ga tegilmagan). Yangi biznes qoidasi TO'QILMAGAN — test R20 ga tayanadi (06_orders.md §4.1 q.387-388: `cancelled` — `created`…`picked` oralig'idagi istalgan holatdan), `order.cancel` endpoint hali yo'qligi fixture javodocida ochiq hujjatlangan (to'g'ridan-to'g'ri UPDATE — simulyatsiya). REGRESSIYA (bitta bloklovchi yurish, 33 test, 0 failure / 0 error): OrderStartPickingControllerTest (S01) 8 fail=0 OrderClaimPickingControllerTest (S02) 7 fail=0 OrderCompletePickingControllerTest (S02) 8 fail=0 OrderAssignDriverControllerTest (S03) 4 fail=0 OrderAssignDriverRollbackTest (S03) 1 fail=0 PickingWageAccrualPortTest (S03) 5 fail=0 S03 barg'i bilan umumiy fayllar (OrderService, TaskService) regressiyasiz. AC3708 ✓ — mutatsiya bilan isbotlangan (yuqorida). AC3709 ✓ — countWageEntries() before/after + countWageEntriesByWorkId == 0; baseline NOLGA TENG EMAS (insertWageEntry fixture mavjud), ya'ni "har doim 0" tufayli o'tadigan bo'sh assert emas. CROSS-CUTTING: @Transactional 4/4 (claimPicking, completePicking, claimPickingWork, completePickingWork); tenant_id/schema almashtirish YO'Q (33 ta matn ilinishi — hammasi AR-1 ni tasdiqlovchi javadoc); fizik DELETE 0; token/parol log 0; tashqi broker/kesh 0 (AR-4); V35 indeks migratsiyasi snake_case; picked uchun outbox ataylab yo'q (§10 da hodisa yo'q — javodocda asoslangan). Mutant izolyatsiyasi: git worktree /tmp/qa2-EP-10-T05-S02 (f5e12f2), tiklash cp .orig orqali, yakunda `grep -rn MUTANT src/` BO'SH (worktree'da ham, asosiy daraxtda ham), worktree o'chirildi. Asosiy daraxtga tegilmagan.

qa-ep-10-t05-s02 qabul mezonini belgiladi

✓ `picked` da hali ishbay accrual YOZILMAGAN (u `delivering` da — R18)

qa-ep-10-t05-s02 qabul mezonini belgiladi

✓ Picking taski tugaganda buyurtma `picked` ga o'tadi

coder-ep-10-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t05-s02 izoh qoldirdi

QA qaytarishi (2-urinish) yopildi: TIRIK-1 (order-status gate, R20 picking->cancelled fixture bilan sinaldi) va TIRIK-2 (tasks.status/qty_claimed DB assert) uchun test qoplamasi qo'shildi. Ikkalasi ham alohida mutatsiya bilan tasdiqlandi (kod vaqtincha buzilganda faqat shu testlar qizarib, qolganlari yashil qoldi). Ishlab chiqarish kodi o'zgartirilmadi. mvn -Dtest=OrderClaimPickingControllerTest,OrderCompletePickingControllerTest test -> 15/15 yashil.

coder-ep-10-t05-s02 yangiladi

Yangilandi: commit_sha

coder-ep-10-t05-s02 qabul mezonini belgiladi

✓ Picking taski tugaganda buyurtma `picked` ga o'tadi

coder-ep-10-t05-s02 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-10-t05-s02 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t05-s02 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-10-t05-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-10-t05-s02 izoh qoldirdi

QA (qa-EP-10-T05-S02) — izolyatsiyalangan worktree /tmp/qa-EP-10-T05-S02 @ ce29c2a. VERDIKT: QAYTARILDI (2 ta tirik mutant = qoplanmagan mezon). == TEST (bloklovchi, tor doira) == OrderClaimPickingControllerTest 7/7 + OrderCompletePickingControllerTest 7/7 = 14 yashil (0 fail / 0 err). REGRESSIYA (V35 + TaskService/TaskRepository/WorkRepository/PayrollService/EmployeeProfessionRepository tegilgani uchun): TaskGatingServiceTest 7, ProductionRunCreationServiceTest 11, WorkClaimGatingIntegrationTest 3, WorkReviewServiceAccrualOrderTest 3, TaskMineListIntegrationTest 6, ProductionCostDetailIntegrationTest 7, WorkReviewWipIntegrationTest 6, ProductionRunTaskWorkRepositoryIntegrationTest 1, OrderStartPickingControllerTest 8, OrdersMigrationTest 17, OrderOutboxMigrationTest 18, PickingRatesMigrationTest 12 = 99 yashil. REGRESSIYA YO'Q. == MUTATSIYA: 8 mutant, 6 o'ldi, 2 TIRIK QOLDI == O'LDI: M1 setStatus(PICKED)->PICKING (2 test); M2b wage_entries yozuvi (work_date=kecha, lines_done_today ni ataylab tegmaydi) -> 151-qatorda; M3 claimed_qty=Sigma qty (6) vs pozitsiya (3) -> 142-qator; M4 bonus stavkasiz (45000 vs 55000) -> 139-qator; M5 egalik gate'i olib tashlandi -> 219-qator; M7 so'rovdan is_picking sharti olib tashlandi -> 217-qator. TIRIK-1 (M6) — QAYTARISH SABABI #1. OrderService.java:895-899 dagi order-status gate'ini (`if (!STATUS_PICKING.equals(order.getStatus())) throw ...`) BUTUNLAY o'chirdim -> 14 test ham YASHIL qoldi. javap tasdig'i: OrderService bytecode'ida "yig'ish tugatilishi mumkin" konstantasi 0 marta (mutatsiya haqiqatan kuchga kirgan). SABAB: yagona qopluvchi test completePickingFromNonPickingStatusReturnsInvalidStatusTransition (OrderCompletePickingControllerTest.java:158-175) fixture'ida CLAIM YO'Q — shu sabab TaskService.completePickingWork o'zi AYNAN SHU kod bilan (INVALID_STATUS_TRANSITION / MESSAGE_PICKING_NOT_CLAIMED, TaskService.java:305) 409 qaytaradi. Test NOTO'G'RI SABABDAN o'tadi; AC3708 ning gate tomoni ("FAQAT picking dan picked") aslida qoplanmagan. BIZNES TA'SIRI: 06_orders.md §4.1/R20 bo'yicha picking -> cancelled RUXSAT ETILGAN. Brom qilingan (works.status='claimed') buyurtma cancelled bo'lsa, bu gate regressiyaga uchraganda complete-picking bekor qilingan buyurtmani picked ga TIRILTIRADI va hech bir test sezmaydi. KERAK (aniq): OrderCompletePickingControllerTest ga yangi test — (1) picking buyurtma + muvaffaqiyatli claim (works.status='claimed'), (2) DB da UPDATE orders SET status='cancelled', (3) POST /complete-picking -> 409 INVALID_STATUS_TRANSITION, (4) assert: orders.status hamon 'cancelled' VA works.status hamon 'claimed'. TIRIK-2 (M8) — QAYTARISH SABABI #2. TaskService.claimPickingWork (TaskService.java:255-260) dagi `tasks.status new->in_progress` VA `tasks.qty_claimed += claimedQty` ni butunlay o'chirdim -> 14 test ham YASHIL. javap tasdig'i: claimPickingWork metodi ichida setStatus/setQtyClaimed chaqiruvi 0 ta (qolgan setQtyClaimed createPickingTask da, S01 niki). Ya'ni picking taskining O'Z hayot sikli (07 R29) umuman assert qilinmagan — task abadiy 'new' da qolib qty_claimed=0 bo'lsa ham hech kim sezmaydi. KERAK (aniq): OrderClaimPickingControllerTest.claimPickingCreatesWorkRowWithPositionCountAndLeavesOrderStatusUnchanged ga tasks jadvalidan assert qo'shilsin: status='in_progress' VA qty_claimed=3.0000. == MEZONLAR == AC3709 = TASDIQLANDI (is_met=true). Salbiy assert HAQIQIY, "yiqilmadi" emas: OrderCompletePickingControllerTest.java:151-152 — countWageEntries()==wageEntriesBefore (wageEntriesBefore fixture'dagi 36-pozitsiyalik qatordan KEYIN olingan, ya'ni 0 emas) + countWageEntriesByWorkId(picking work)==0. M2b mutanti AYNAN 151-qatorda o'ldi. AC3708 = QISMAN (is_met=false). Musbat yo'l qoplangan (M1 o'ldi), gate tomoni qoplanmagan (M6 tirik). == TO'RTTA "MUHANDISLIK QARORI" == (a) claimed_qty = order_lines soni — QIYMAT TO'G'RI, DA'VO NOTO'G'RI. Coder "kontrakt lines_total izohiga tayanib SPEC BO'SHLIQLARI p.9 ni yopdim" deydi; kontraktni o'qidim: orders.yaml:2678-2681 dagi lines_total izohi ("Yig'iladigan pozitsiya soni — F4 ning asosiy birligi") ISHBAY birligi haqida, works.claimed_qty haqida EMAS. orders.yaml:203 (p.9) hamon "brom miqdori picking uchun nimaga teng ekani spec'da yozilmagan -> server qoidasi keyin aniqlanadi" deydi, orders.yaml:181 esa p.9 ni OCHIQ deb sanaydi — muzlatilgan kontraktdagi bu izohni coder yopa olmaydi. Lekin qiymatning O'ZI F4 dan HOSILA (accrual bazasi = pozitsiya; boshqa qiymat, mas. 1, F4/wage_entries.qty ni buzardi) — yangi BIZNES qoidasi to'qilmagan, shu sabab BLOK EMAS. PM uchun: p.9 hamon ochiq, §5 sikli orqali 06_orders.md ga yozilishi kerak. (Qo'shimcha: order.update faqat 'created' da ruxsat (OrderService.java:511) — shu sabab claim-time snapshot eskirmaydi, bu tomondan xavf yo'q.) (b) 403 FORBIDDEN (faol is_picking kasbi yo'q) — QABUL QILINDI. Kontrakt claimOrderPicking uchun 403 ni HUJJATLAGAN (orders.yaml:987) va OrderClaimPickingConflict (orders.yaml:1792-1798) faqat 2 kodli YOPIQ ro'yxat — yangi 409 to'qish drift bo'lardi. OGOHLANTIRISH (PM uchun, coder aybi emas): simmetrik holat assign-driver da 409 DRIVER_NOT_ELIGIBLE deb hujjatlangan (orders.yaml:1811-1814) — kontrakt asimmetriyasi. (c) works.status faqat submitted, tasks.status/wage_entries tegilmaydi — QABUL QILINDI. Board technical_notes ("picking taskda nazoratchi review YO'Q — tasdiq = buyurtma holati", 07 R29/AC20) va R18 (accrual picked->delivering) bilan mos. QARZ (EP-10-T05-S03 uchun): assign-driver works.status->confirmed VA tasks.status->completed ni bajarmasa, picking works abadiy 'submitted', task abadiy 'in_progress' qoladi. (d) picked da outbox yozuvi yo'q — TO'G'RI, SPEC BILAN TASDIQLANDI. 06_orders.md §10 da 06 chiqaradigan hodisalar sanalgan (order.created/received/ready_to_deliver/repriced/picking_started/delivering/delivered/delivery_failed/cancelled/delivery_far_from_address) — picked YO'Q; V34 chk_order_outbox_event_type ro'yxati shularga (+order.recheck) AYNAN mos. Taxmin emas. == CROSS-CUTTING (8/8) == 1 @Transactional bor, o'qishlar readOnly=true (findPickingTaskSummary, sumPickingQtyDoneToday) OK · 2 tenant_id/schema ajratish yo'q OK · 3 katalog FK — yangi katalog ustuni qo'shilmagan OK · 4 outbox — bu bargda asinxron ish yo'q, (d) bo'yicha to'g'ri OK · 5 nomlash snake_case, idx_tasks_order_id OK · 6 qty (18,4) / narx (18,2) — claimed_qty setScale(4), amount setScale(2) OK · 7 fizik DELETE yo'q OK · 8 parol/token log'da yo'q OK. Qulflash: tasks FOR UPDATE (ota, works hali yo'q) + works FOR UPDATE + orders FOR UPDATE — tartib izchil. == TOZALIK == Hamma mutatsiya faqat worktree'da; tiklash `cp <fayl>.orig <fayl>` bilan (checkout/reset/stash ISHLATILMADI). Yakunda: `grep -rn MUTANT src/` BO'SH, `git status --porcelain` BO'SH, HEAD=ce29c2a. Asosiy daraxtga (/var/www/apps/erpbom-backend) TEGILMADI.

qa-ep-10-t05-s02 qabul mezonini belgiladi

✗ Picking taski tugaganda buyurtma `picked` ga o'tadi

qa-ep-10-t05-s02 qabul mezonini belgiladi

✓ `picked` da hali ishbay accrual YOZILMAGAN (u `delivering` da — R18)

coder-ep-10-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t05-s02 izoh qoldirdi

claim-picking (work.claim) va complete-picking (work.submit) qo'shildi. claimed_qty = buyurtma order_lines soni (F4 asosiy birlik, OrderPickingItemResponse.lines_total izohiga mos). complete-picking javobida PickingWageEstimate F4 formulasi bo'yicha hisoblanadi (picking_rates + wage_entries "kun boshidagi jami"); wage_entries hech narsa yozmaydi (AC3709). OrderService#toDetailResponse endi picking_task_id/picking_claimed_by_employee_id ni haqiqiy holat bilan to'ldiradi. V35 migratsiya: tasks.order_id ga indeks. 14/14 test yashil (7 claim + 7 complete), shu jumladan F4 spec misoli (55000) end-to-end tekshirilgan.

coder-ep-10-t05-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-10-t05-s02 qabul mezonini belgiladi

✓ `picked` da hali ishbay accrual YOZILMAGAN (u `delivering` da — R18)

coder-ep-10-t05-s02 qabul mezonini belgiladi

✓ Picking taski tugaganda buyurtma `picked` ga o'tadi

coder-ep-10-t05-s02 fayllarni qayd etdi

13 ta fayl qayd etildi

coder-ep-10-t05-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t05-s02 ishga oldi

pm-agent yaratdi

Yig'ish tugadi -> picked