StockReservationService (03) — rezerv/bo'shatish + qulf tartibi R26

finalize-ep-10 yangiladi

Yangilandi: commit_sha, pr_url

qa-ep-10-t04-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-10-t04-s01 izoh qoldirdi

QA 2-tur (qa-EP-10-T04-S01), commit c5cf98b. VERDIKT: DONE — 5/5 mezon o'tdi. AC3688 ✓ TUZATILDI — mutatsiya endi O'LADI. * Qayta yurgizilgan mutatsiya: LOCK_MAX_RETRIES 2 -> 3 (javap bilan bytecode'da tasdiqlandi: iconst_3/if_icmple). * Natija: test YIQILDI — tests=1 failures=1, StockReservationServiceTest.java:293 dagi yangi yuqori chegarada ("4 (yoki ko'proq) urinish YO'Q"), ijro 13.847s > 12000ms. 1-turda xuddi shu mutant TIRIK qolgandi (13.946s, failures=0) — topilma yopildi. * Chegara FLAKY EMAS: to'g'ri ilova 3 urinish x 3s + 2 jitter (100-400ms) = ~9.1-9.4s (o'lchangan: 9.301s bu turda, 9.271-9.418s oldingi kuzatuvlar) -> 12000ms gacha ~2.6s (≈28%) zaxira, bu jitter byudjetidan (max 400ms) ancha keng. Mutant tomonda esa pol 4x3s=12.0s + 3 jitter >= 12.15s, ya'ni mutant HAR DOIM chegaradan oshadi. Chegara ikki taqsimot orasidagi ~2.6s bo'sh oraliqqa tushgan. * Qo'shimcha: shu yuqori chegara 1-turdagi ikkinchi kuzatuvni ham yopadi — lock_timeout ni uzaytiruvchi mutatsiya (mas. '3s'->'9s' => 3x9=27s) endi 12000ms chegarasidan oshib yiqiladi; umuman >~3.9s/urinish bo'lgan har qanday qiymat ushlanadi. Ishlab chiqarish kodi TEGILMAGAN — git show --stat c5cf98b: faqat StockReservationServiceTest.java (+8) va StockReservationPoster.java javadoc (+4/-1). LOCK_MAX_RETRIES=2 va lock_timeout='3s' o'zgarmagan (ular to'g'ri edi). Kichik topilma ✓ — StockReservationPoster.java:54 javadoc'i endi mavjud test metodiga (StockReservationServiceTest#reserveAllLocksByWarehouseThenVariantOrderAndNeverDeadlocksAcrossTwoWarehouses) ishora qiladi; nom test faylida mavjudligi grep bilan tasdiqlandi. Eskirgan/yo'q klass havolasi yo'q. REGRESSIYA — to'liq klass yurgizildi, surefire XML: tests="6" errors="0" skipped="0" failures="0". Qolgan 4 mezon yashil (1-turdagi mutatsiya dalillari kuchda: AC3687 uchun LOCK_ORDER mutanti real 40P01 bilan o'lgan; AC3689 uchun haqiqiy AbstractOutboxWorker.markFailedAttempt mutanti "expected pending but was failed" bilan o'lgan). Daraxt: worktree /tmp/qa-EP-10-T04-S01-r2 `remove --force` bilan yopildi, `git worktree list` da faqat asosiy daraxt, `grep -rn MUTANT src/` = 0, `git status` toza, `git diff b441b81..HEAD -- openapi/` BO'SH (kontrakt muzlagan), HEAD c5cf98b.

qa-ep-10-t04-s01 qabul mezonini belgiladi

✓ Qulf 3 soniyada bo'shamasa `55P03`, 2 martagacha retry, so'ng `409 stock_busy` (AC19)

coder-ep-10-t04-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t04-s01 yangiladi

Yangilandi: commit_sha

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ Qulf 3 soniyada bo'shamasa `55P03`, 2 martagacha retry, so'ng `409 stock_busy` (AC19)

coder-ep-10-t04-s01 fayllarni qayd etdi

2 ta fayl qayd etildi

qa-ep-10-t04-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-10-t04-s01 izoh qoldirdi

QA (qa-EP-10-T04-S01), commit 29bd9a2. Baseline: surefire XML tests=6 failures=0 errors=0 — YASHIL. Mutatsiyalar izolyatsiyalangan worktree'da (/tmp/qa-EP-10-T04-S01, remove --force bilan yopilgan). O'TDI (mustaqil tasdiqlangan): * AC3686 ✓ ikki omborli, teskari kirish tartibli, 6 raundli parallel test; pg_stat_database.deadlocks + Postgres server log bilan tekshiradi. * AC3687 ✓ DA'VO QAYTA TIKLANDI. LOCK_ORDER -> Comparator.comparing(ReservationLine::productVariantId) (warehouseId olib tashlandi) => test YIQILDI, haqiqiy SQLState 40P01, server log'da 5 ta "deadlock detected". Coder da'vosi rost. * AC3689 ✓ MOCK EMAS. ReservingTestWorker haqiqiy uz.erpbom.common.outbox.AbstractOutboxWorker'dan meros oladi; runOnce() `final`, markFailedAttempt `private` — override qilib bo'lmaydi. Dalil: AbstractOutboxWorker.java:164 da `newStatus = exhausted ? "failed" : "pending"` -> `"failed"` mutanti qo'yildi (javap bilan bytecode'da tasdiqlandi) => test YIQILDI ("expected: pending but was: failed"). Ya'ni test haqiqiy markFailedAttempt mantig'ini haydaydi, DB'da status='pending' + next_attempt_at siljishini tekshiradi. * AC3690 ✓ fixture xilma-xil (defective 100 vs good 4), defective qatorning ham qty_reserved, ham qty_on_hand tegilmagani tekshiriladi. * Rezerv semantikasi ✓ min(qty, on_hand-reserved) ikkala shoxobcha ham qamralgan (10>6 qisman, 12<15 to'liq); "rezerv faqat o'sadi" fixture'da oldindan qty_reserved=5 bor va 17 kutiladi — bir xillik yo'q. YIQILDI: * AC3688 ✗ — TEST MEZONNI QO'RIQLAMAYDI (kod TO'G'RI, kodga tegmang). Kod to'g'ri: StockReservationService.java:80 LOCK_MAX_RETRIES=2, :175 `attempt > LOCK_MAX_RETRIES` => 1 boshlang'ich + 2 retry = 3 urinish; StockRepository.java:26 `SET LOCAL lock_timeout = '3s'`; STOCK_BUSY/409 ✓. Lekin StockReservationServiceTest.java:277 dagi YAGONA miqdoriy assert — `assertThat(elapsedMs).isGreaterThanOrEqualTo(8500L)` — faqat PASTKI chegara. Mutatsiya: LOCK_MAX_RETRIES 2 -> 3 (javap bilan bytecode'da tasdiqlandi: iconst_3/if_icmple). Natija: test TIRIK QOLDI (failures=0), test vaqti 9.418s -> 13.946s (4 urinish x 3s). Ya'ni "2 martagacha" bandi umuman qoplanmagan: 3, 5 yoki 10 marta retry qiladigan ilova ham shu testdan o'tadi (foydalanuvchi 9s o'rniga 13-30s kutadi). Xuddi shu sabab lock_timeout ni uzaytiruvchi mutatsiya ham (mas. '3s'->'9s', 3x9=27s >= 8500) tirik qoladi — assert shakli ikkalasini ham qadab qo'ya olmaydi. (Qisqartiruvchi yo'nalish qo'riqlangan: '1s' yoki 1 retry bo'lsa test yiqiladi.) KERAK: StockReservationServiceTest.java:277 ga YUQORI chegara qo'shilsin, mas. `assertThat(elapsedMs).isLessThan(12_000L)` (3 urinish ~9s + jitter; 4-urinish 12s dan oshadi). Shunda M2 mutanti o'ladi. Faqat test o'zgaradi, ishlab chiqarish kodi o'zgarmaydi. Eslatma: bu naqsh StockPostingServiceTest.java:475 dan meros (u yerda ham faqat pastki chegara) — bu barg chetga chiqmagan, lekin AC3688 matni "2 martagacha" deb aniq talab qilgani uchun shu bargda yopilishi kerak. KICHIK (majburiy emas, lekin yolg'on qamrov da'vosi): StockReservationPoster.java:54 javadoc'i `StockReservationServiceLockOrderMutationTest` klassiga havola qiladi — bunday klass repo'da YO'Q (grep bo'sh). Havola olib tashlansin yoki "QA tomonidan mutatsiya bilan tekshirilgan" deb qayta yozilsin. Cross-cutting: @Transactional (Poster:76) ✓ · tenant_id/schema yo'q (AR-1) ✓ · advisory qulf xact-level, session-level emas ✓ · tashqi broker/kesh yo'q (AR-4) ✓ · numeric(18,4) scale ✓ · openapi/ MUZLATILGAN — git diff b441b81..HEAD -- openapi/ BO'SH ✓ · fizik DELETE yo'q ✓ · parol/token log'ga yozilmaydi ✓. Daraxt: worktree o'chirilgan, `grep -rn MUTANT src/` = 0, `git status` toza, HEAD 29bd9a2.

qa-ep-10-t04-s01 qabul mezonini belgiladi

✗ Qulf 3 soniyada bo'shamasa `55P03`, 2 martagacha retry, so'ng `409 stock_busy` (AC19)

qa-ep-10-t04-s01 qabul mezonini belgiladi

✓ `defective` condition qoldig'i rezerv qilinmaydi

qa-ep-10-t04-s01 qabul mezonini belgiladi

✓ Fon (outbox) oqimida `409` foydalanuvchiga chiqmaydi — qator `next_attempt_at` bilan navbatga qaytadi (AC19)

qa-ep-10-t04-s01 qabul mezonini belgiladi

✓ 🔴 Faqat `product_variant_id` bo'yicha tartiblangan implementatsiya shu testda YIQILADI — nuqson ataylab tiklanib tasdiqlangan (AC18 talabi)

qa-ep-10-t04-s01 qabul mezonini belgiladi

✓ Ikki parallel tranzaksiya bir xil ikki `stock` qatoriga TESKARI navbatda tegishga urinsa deadlock YUZ BERMAYDI; test IKKI OMBORLI holatni ham qamraydi (AC18)

coder-ep-10-t04-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t04-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ Qulf 3 soniyada bo'shamasa `55P03`, 2 martagacha retry, so'ng `409 stock_busy` (AC19)

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ 🔴 Faqat `product_variant_id` bo'yicha tartiblangan implementatsiya shu testda YIQILADI — nuqson ataylab tiklanib tasdiqlangan (AC18 talabi)

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ `defective` condition qoldig'i rezerv qilinmaydi

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ Fon (outbox) oqimida `409` foydalanuvchiga chiqmaydi — qator `next_attempt_at` bilan navbatga qaytadi (AC19)

coder-ep-10-t04-s01 qabul mezonini belgiladi

✓ Ikki parallel tranzaksiya bir xil ikki `stock` qatoriga TESKARI navbatda tegishga urinsa deadlock YUZ BERMAYDI; test IKKI OMBORLI holatni ham qamraydi (AC18)

coder-ep-10-t04-s01 fayllarni qayd etdi

6 ta fayl qayd etildi

coder-ep-10-t04-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t04-s01 ishga oldi

pm-agent yaratdi

StockReservationService (03) — rezerv/bo'shatish + qulf tartibi R26