CustomerLedgerPort + Noop — limit va overdue seam (R24)

finalize-ep-10 yangiladi

Yangilandi: commit_sha, pr_url

qa-ep-10-t03-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-10-t03-s02 izoh qoldirdi

QA qayta tekshiruvi (qa-EP-10-T03-S02, commit b647cef) — QABUL QILINDI: done. == TUZATISH TASDIQLANDI == b647cef faqat test faylini o'zgartirgan (+31 qator, ishlab chiqarish kodiga tegilmagan) — `git show --stat` bilan tasdiqlangan. Yangi test: OrderReceiveCreditGateControllerTest.overrideOverdueDoesNotBypassCreditLimitReturns409AndLeavesOrderUnchanged (test:204-233). 🔴 ASOSIY DALIL — men tirik qoldirgan MUTANT ENDI O'LDI (izolyatsiyalangan worktree /tmp/qa-EP-10-T03-S02b, b647cef): Mutant: OrderService.java:495 `if (contract.creditLimit() != null)` -> `if (contract.creditLimit() != null && !overrideOverdue)` Natija: Tests run: 12, Failures: 1 — yiqilgan test AYNAN yangisi (expected: 409 CONFLICT but was: 200 OK, test:228). javap tasdig'i (yolg'on xulosa emas): mutant bytecode'da haqiqatan bor — `192: ifnull 242; 195: iload 5; 197: ifne 242`. Failures: 1 bo'lishi yangi test boshqa hech bir test qilmaydigan ishni qilayotganini ham isbotlaydi (dublikat emas). == BASELINE (b647cef, flock ostida, bloklovchi) == OrderReceiveCreditGateControllerTest — Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 (11 -> 12) OrderReceiveControllerTest (S01 regressiya) — Tests run: 10, Failures: 0, Errors: 0, Skipped: 0 — S02 buzmagan == TEST HAQIQIYLIGI == Assert'lar chinakam, tautologiya yo'q — HTTP javob va REAL DB holati o'qiladi: 409 CONFLICT + body code = CREDIT_LIMIT_EXCEEDED; orders.status = 'created' (o'zgarmagan); order_outbox qatori 0; auth_logs `allow` (order.override_overdue) yozuvi 0. Fixture: qarz 60000.00 + overdue=true, contract credit_limit 100000.00, order total_amount 50000.00 -> 110000 > 100000. Pul qiymatlari mavjud receivingOrderExceedingCreditLimit... testi bilan bir xil, LEKIN farqlovchi o'lchov yangi va aynan kerakligi: hasOverdueDebt=true + overrideToken + so'rov tanasi. Ya'ni bu dublikat emas, override shoxobchasi. @Disabled / assumeTrue / izohga olingan assertion — YO'Q. == OLDINGI TEKSHIRUVLAR KUCHDA == O'lgan mutantlar (673aba4 da o'lchangan, kod o'zgarmagan): port chaqiruvi (OrderService:494), chegara <= -> < (:498), sabab validatsiyasi (:481), overdue bloki (:504), audit details sabab matni (:515). Uchala mezon (3680/3681/3682) tasdiqlangan. R24(a) manbasi customer_contracts.credit_limit faol versiyadan (05 F2/R11); credit_limit IS NULL -> limitsiz qoplangan; mijoz tenant-umumiy (currentDebt(customerId), org-node bo'ylab yig'ish yo'q); gate mock port bilan bloklaydigan qiymatlarda sinalgan. AC3681 = 422 masalasi yopilgan (kontrakt hakam) — qaytilmadi. Kod o'zgartirilmadi, commit qilinmadi, erp/docs ga yozilmadi. Worktree /tmp/qa-EP-10-T03-S02b o'chirildi; asosiy daraxtda MUTANT/.orig qolmadi, git status toza.

coder-ep-10-t03-s02 yangiladi

Yangilandi: commit_sha

coder-ep-10-t03-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t03-s02 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-10-t03-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-10-t03-s02 izoh qoldirdi

QA (qa-EP-10-T03-S02) — QAYTARILDI: in_progress. Uchala board mezoni (3680/3681/3682) bajarilgan, testlar yashil, LEKIN muzlatilgan kontrakt ANIQ e'lon qilgan bitta R24 invarianti QOPLANMAGAN — mutatsiya tirik qoldi. == O'TGAN TEKSHIRUVLAR == Baseline (izolyatsiyalangan worktree, 673aba4, Testcontainers/PG16): OrderReceiveCreditGateControllerTest — Tests run: 11, Failures: 0, Errors: 0 OrderReceiveControllerTest (S01 regressiya) — Tests run: 10, Failures: 0, Errors: 0 @Disabled / assumeTrue / izohga olingan assertion — YO'Q. Mutatsiya natijalari (hammasi worktree'da, javap bilan tasdiqlangan): M1 port chaqiruvi olib tashlandi (OrderService.java:494) -> O'LDI (4 test) M2 chegara <= -> < (OrderService.java:498, compareTo>0 => >=0) -> O'LDI (receivingOrderAtExactCreditLimitBoundarySucceeds) M3 sabab validatsiyasi olib tashlandi (OrderService.java:481) -> O'LDI (2 test) M5 overdue bloki olib tashlandi (OrderService.java:504) -> O'LDI M6 audit details sabab matni almashtirildi (OrderService.java:515) -> O'LDI AC3682 — NoopCustomerLedgerPort.java:14-31: TODO(08_finance) bor, R24(a) currentDebt=0 va R24(b) hasOverdueDebt=false qaysi qoidani qoplashi aniq yozilgan. OK. R24(a) manbasi TO'G'RI: customer_contracts.credit_limit faol versiyadan (05 F2/R11), customers cache'dan emas. credit_limit IS NULL -> limitsiz — qoplangan. Mijoz TENANT-UMUMIY: CustomerLedgerPort.currentDebt(Long customerId) — org-node/tree bo'ylab yig'ish YO'Q, test verify(eq(customerId)) bilan tasdiqlangan. OK. Gate MOCK port bilan sinalgan (@MockitoBean), faqat Noop bilan emas — bloklaydigan qiymatlar berilgan. Fixture xilma-xilligi yetarli: qarz 0.00 / 50000 / 60000 / 999999999, limit null / 200000 / 150000 / 100000, overdue true/false. == 🔴 NUQSON (yagona, bitta test bilan yopiladi) == Qaysi mezon: AC3681 doirasidagi R24 invarianti + muzlatilgan kontrakt openapi/v1/orders.yaml OrderReceiveRequest.override_overdue tavsifi so'zma-so'z: "⚠️ **Limit** blokini (R24a) o'tkazib bo'lmaydi — u har doim bloklovchi" (06_orders.md §5 R24: override FAQAT (b) ni o'tkazadi). Fayl:qator — src/main/java/uz/erpbom/orders/service/OrderService.java:495 Mutatsiya: `if (contract.creditLimit() != null)` -> `if (contract.creditLimit() != null && !overrideOverdue)` Natija: TIRIK QOLDI — Tests run: 11, Failures: 0. Ya'ni `order.override_overdue` huquqi kredit limitini ham o'tkazib yuboradigan qilib buzilsa, hech bir test buni ushlamaydi. Bytecode tasdig'i (javap, yolg'on "survived" emas): asl `192: ifnull 237` -> mutant `192: ifnull 242; 195: iload 5; 197: ifne 242` — qo'shimcha overrideOverdue shoxobchasi haqiqatan kompilyatsiya qilingan. Sabab: R24(a) limit testlarining HAMMASI (OrderReceiveCreditGateControllerTest.java:159/174/188/205) editorToken bilan va so'rov TANASIZ yuboriladi -> overrideOverdue doim false; override + limit kombinatsiyasi umuman yo'q. KUTILGAN: OrderReceiveCreditGateControllerTest ga bitta test qo'shilsin — overrideToken (order.receive + order.override_overdue), body {"override_overdue": true, "override_reason": "<sabab>"}, mock: new CustomerDebtSnapshot(new BigDecimal("60000.00"), true) (limit ham oshgan, overdue ham bor), contract credit_limit = "100000.00", order total_amount = "50000.00". OLINISHI KERAK: 409 CREDIT_LIMIT_EXCEEDED (kontrakt tartibi §8.2-2: qadam 2 limit, qadam 3 overdue — limit birinchi), orders.status = 'created' o'zgarmagan, order_outbox qatori 0, allow audit-log YO'Q. Shu test M4 mutantini o'ldiradi. == 📌 PM uchun qayd (kod nuqsoni EMAS) == Board AC3681 matni "sabab bo'sh bo'lsa 400 VALIDATION_ERROR" deydi, muzlatilgan kontrakt (openapi/v1/orders.yaml, OverrideReasonRequired) esa "400 emas, 422 OVERRIDE_REASON_REQUIRED". Kontrakt hakam — coder 422 ni to'g'ri bajargan, bu defekt deb hisoblanmadi; board AC matni kontraktga moslashtirilsin. Kod O'ZGARTIRILMADI, commit qilinmadi, erp/docs ga yozilmadi. Worktree /tmp/qa-EP-10-T03-S02 o'chirildi; asosiy daraxtda MUTANT/.orig qolmadi (git status toza).

qa-ep-10-t03-s02 qabul mezonini belgiladi

✓ Noop implementatsiyada 08_finance uchun TODO izohi bor va u qaysi qoidani (R24 a/b) qoplashi yozilgan

qa-ep-10-t03-s02 qabul mezonini belgiladi

✓ `override_overdue` yo'li: sabab bo'sh bo'lsa `400 VALIDATION_ERROR`, sabab berilsa audit yozuvi tushadi

qa-ep-10-t03-s02 qabul mezonini belgiladi

✓ Qabul oqimida port CHAQIRILADI — mock bilan tasdiqlangan

coder-ep-10-t03-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-10-t03-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-10-t03-s02 izoh qoldirdi

AC3681 matni "sabab bo'sh bo'lsa 400 VALIDATION_ERROR" deydi, lekin MUZLATILGAN kontrakt (openapi/v1/orders.yaml, OverrideReasonRequired javob tavsifi, ~1728-1746 qator) buni ANIQ: "Shartli majburiy maydon uchun 400 emas, 422" (suppliers.yaml REVIEW_COMMENT_REQUIRED bilan bir xil naqsh) deb belgilaydi. Kod/test kontraktga (422 OVERRIDE_REASON_REQUIRED, UnprocessableEntityException) moslab yozildi -- kontraktni o'zgartirmadim, faqat AC matnidagi "400" so'zini e'tiborsiz qoldirdim, chunki topshiriqda "kontraktdan chetga chiqmasin" ko'rsatilgan edi. Bloklashga arzimaydi deb hisobladim (bitta HTTP status raqami, ikkala manba ham xatolik kodini OVERRIDE_REASON_REQUIRED deb bir xil ataydi) -- QA/PM tasdiqlasa AC matni tuzatilsin. Yo'l davomida topilgan ikkinchi qism (kod bilan tuzatildi, alohida topilma emas): order.override_overdue uchun deny audit-log + ForbiddenException bitta @Transactional receive() ichida yozilsa, throw butun tranzaksiyani (audit yozuvi bilan birga) rollback qilar edi -- LoginService/RefreshService dagi @Transactional(noRollbackFor = ForbiddenException.class) naqshi qo'llanildi (OrderService#receive javodociga qara).

coder-ep-10-t03-s02 qabul mezonini belgiladi

✓ Noop implementatsiyada 08_finance uchun TODO izohi bor va u qaysi qoidani (R24 a/b) qoplashi yozilgan

coder-ep-10-t03-s02 qabul mezonini belgiladi

✓ `override_overdue` yo'li: sabab bo'sh bo'lsa `400 VALIDATION_ERROR`, sabab berilsa audit yozuvi tushadi

coder-ep-10-t03-s02 qabul mezonini belgiladi

✓ Qabul oqimida port CHAQIRILADI — mock bilan tasdiqlangan

coder-ep-10-t03-s02 fayllarni qayd etdi

7 ta fayl qayd etildi

coder-ep-10-t03-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-10-t03-s02 ishga oldi

pm-agent yaratdi

CustomerLedgerPort + Noop — limit va overdue seam (R24)