📋 PM Board
Sub-task EP-10-T01-S01 Kritik 06_orders erpbom-backend

V32 — orders + order_lines + order_number sequence

Bajarildi
Status:

Tavsif

§2.1 `orders` va §2.2 `order_lines` jadvallari to'liq ustun ro'yxati bilan; `order_number` uchun sequence va DEFAULT.

Texnik ko'rsatma

Agent uchun

* `order_number varchar(20) NOT NULL UNIQUE`, qiymat `'ORD-' || to_char(nextval('order_number_seq'), 'FM000000')`. 🔴 `lpad` ISHLATILMAYDI — 6 xonadan oshganda kesib to'qnashuv yasaydi; `to_char(...,'FM000000')` esa `ORD-1000000` ga tabiiy uzayadi (R25). Sequence bo'shliqlari NORMAL. * `status` enum qiymatlari: created, received, in_progress, ready_to_deliver, picking, picked, delivering, delivered, cancelled — CHECK bilan (loyihada enum tipi emas, varchar + CHECK naqshi — V25__tasks.sql precedenti). * `organization_id`, `warehouse_id`, `customer_id`, `contract_id` — FK; `price_type_id` NULL = `base`. * Snapshot ustunlari: `contract_id`, `payment_term_days_snapshot`, `price_type_id`. * `order_lines`: `UNIQUE(order_id, product_variant_id)`, `qty numeric(18,4)`, `unit_price numeric(18,2)`, `qty_reserved numeric(18,4) NOT NULL DEFAULT 0` + CHECK `0 <= qty_reserved <= qty`. `line_amount` SAQLANMAYDI (hosila). * `parent_order_id` self-FK (R17), `delivery_attempts int NOT NULL DEFAULT 0`, GPS `numeric(9,6)`. * Indekslar: `ready_at` (ish navbati), `received_at` (rezerv navbati R10), `status`, `customer_id`, `driver_employee_id`. * O'chirish YO'Q — `cancelled` (soft, CROSS_CUTTING H); `customers`/`product_variants`/`warehouses` -> RESTRICT.

Qabul mezonlari (DoD)

4 / 4 bajarildi

  • Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

    qa-ep-10-t01-s01 · 1 о аввал

  • Birinchi INSERT `ORD-000001` beradi; sequence 999999 dan oshganda qiymat kesilmaydi (`ORD-1000000`) — test bilan tasdiqlangan (AC17)

    qa-ep-10-t01-s01 · 1 о аввал

  • `order_lines` ga bitta buyurtmada takroriy `product_variant_id` yozib bo'lmaydi

    qa-ep-10-t01-s01 · 1 о аввал

  • `qty_reserved > qty` yozishga urinish CHECK bilan rad etiladi

    qa-ep-10-t01-s01 · 1 о аввал

O'zgargan fayllar

2 ta

  • modified src/test/java/uz/erpbom/orders/OrdersMigrationTest.java
  • modified src/main/resources/db/migration/V32__orders.sql

Izoh qoldirish

Tarix

18 yozuv

  • ✎

    finalize-ep-10 yangiladi

    Yangilandi: commit_sha, pr_url

  • ⇄

    qa-ep-10-t01-s01 statusni o'zgartirdi Review → Bajarildi

  • 💬

    qa-ep-10-t01-s01 izoh qoldirdi

    QA (mustaqil tekshiruv) — QABUL QILINDI. Baza: 17/17 yashil (surefire XML: tests=17 errors=0 failures=0, o'zim yurgizdim). Mutatsiya (izolyatsiyalangan worktree, 3/3 mutant O'LDI): 1) lpad(...,GREATEST(6,len)) -> lpad(...,6): orderNumberDoesNotTruncateAfterSixDigits YIQILDI (expected ORD-1000000, was ORD-100000) + 4 ta collateral. 2) UNIQUE(order_id,product_variant_id) -> oddiy indeks: FAQAT duplicateProductVariantInSameOrderIsRejected yiqildi. 3) CHECK dan qty_reserved <= qty olib tashlandi: FAQAT qtyReservedGreaterThanQtyIsRejected yiqildi. Coder da'vosi mustaqil tasdiqlandi (jonli PG 16.15): to_char(1000000,'FM000000') = '######', lpad('1000000',6) = '100000'. Alohida scratch DB da: toza sequence -> ORD-000001/000002/000003; setval(999999) -> ORD-1000000, ORD-1000001; 5 insertdan keyin last_value=1000001 => nextval har qatorda ATIGI BIR marta sarflanadi (funksiya tanasi ham bitta chaqiruv). order_number: varchar(20) NOT NULL, DEFAULT next_order_number(), uq_orders_order_number UNIQUE. Spec'ga ustunma-ustun: §2.1 = 31 ustun, §2.2 = 8 ustun — AYNAN mos, ortiqcha ustun YO'Q. Manzil/koordinata ustuni TO'QILMAGAN (delivery_gps_lat/lng spec'da bor — bor; customer_address yo'q — yo'q). line_amount saqlanmagan (to'g'ri). status CHECK = orders.yaml OrderStatus enum bilan 9/9 mos. Kontrakt fayllari commit'da o'zgarmagan (git show --stat: faqat 2 fayl). Fixture xilma-xilligi: qty_reserved = 0 / qty (chegara, qabul) / qty+1 (rad) / -1 (rad) — chegara qamralgan. ⚠️ LEAD uchun eslatma (bloklamaydi, doc qarzi): PM Board technical_notes va u iqtibos qilgan R25 formulasi (to_char(...,'FM000000') 1 000 000-da tabiiy uzayadi) FAKTIK NOTO'G'RI — yuqorida jonli DB da tasdiqlandi. Kod AC17 biznes maqsadini saqlagan holda to'g'ri formulani qo'llagan. 06_orders.md R25 matni erp/docs da tuzatilishi kerak (QA erp/docs ga yozmaydi).

  • ✓

    qa-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ `qty_reserved > qty` yozishga urinish CHECK bilan rad etiladi

  • ✓

    qa-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ `order_lines` ga bitta buyurtmada takroriy `product_variant_id` yozib bo'lmaydi

  • ✓

    qa-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ Birinchi INSERT `ORD-000001` beradi; sequence 999999 dan oshganda qiymat kesilmaydi (`ORD-1000000`) — test bilan tasdiqlangan (AC17)

  • ✓

    qa-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

  • ⇄

    coder-ep-10-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

  • ✎

    coder-ep-10-t01-s01 yangiladi

    Yangilandi: branch, commit_sha

  • 💬

    coder-ep-10-t01-s01 izoh qoldirdi

    Board technical_notes dagi order_number formulasi (`to_char(nextval(...), 'FM000000')`) real Postgres 16da ISHLAMAYDI: son 6 xonadan oshganda to_char uni cho'zmaydi, hash belgilar bilan to'ldiradi (`######`) — bu AC17ni buzadi (999999dan keyin har buyurtma bir xil '######' oladi, uq_orders_order_number bilan darhol to'qnashadi). Docker erpbom-dev-postgres ustida tasdiqlandi. Tuzatildi: `next_order_number()` yordamchi funksiyasi (`lpad(v::text, GREATEST(6, length(v::text)), '0'), '0')` formulasi) — nextval bir marta chaqiriladi, 6 xonagacha nol bilan to'ldiradi, 999999dan keyin tabiiy o'sadi, hech qachon kesmaydi/to'qnashmaydi. Test (AC17) shu holatni aynan tekshiradi va yashil. erp/docs ga tegilmadi — bu sof texnik SQL implementatsiya tuzatishi, R25ning biznes maqsadi (format ORD-NNNNNN, cheklovsiz o'sish) o'zgarmadi.

  • ✓

    coder-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ `qty_reserved > qty` yozishga urinish CHECK bilan rad etiladi

  • ✓

    coder-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ `order_lines` ga bitta buyurtmada takroriy `product_variant_id` yozib bo'lmaydi

  • ✓

    coder-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ Birinchi INSERT `ORD-000001` beradi; sequence 999999 dan oshganda qiymat kesilmaydi (`ORD-1000000`) — test bilan tasdiqlangan (AC17)

  • ✓

    coder-ep-10-t01-s01 qabul mezonini belgiladi

    ✓ Flyway migratsiya toza bazada xatosiz o'tadi va takroriy yurgizishda idempotent

  • 📄

    coder-ep-10-t01-s01 fayllarni qayd etdi

    2 ta fayl qayd etildi

  • ⇄

    coder-ep-10-t01-s01 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-10-t01-s01 ishga oldi

  • ✦

    pm-agent yaratdi

    V32 — orders + order_lines + order_number sequence

Ma'lumot

Agent
coder-ep-10-t01-s01
Olingan
1 о аввал
Boshlandi
28.08.2026 10:56
Tugadi
28.08.2026 11:43
Baho
5 soat
Spec
erp/docs/modules/06_orders.md#2.1
Branch
feat/EP-10-erpbom-backend
Commit
b6a7516c9f5d
Pull request →

Bog'liqliklar

Bundan oldin tugashi kerak

Yo'q — bu ish mustaqil.

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-10-T01-S01/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-10-T01-S01/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'