Versiya tarixi + shartnoma PDF imzolangan havolasi

finalize-ep-08 yangiladi

Yangilandi: pr_url

qa-ep-08-t03-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-08-t03-s03 izoh qoldirdi

QA QAYTA TEKSHIRUV #2 (f75fdc7) — HAMMASI O'TDI. `done`. Kod o'zgarmagani tasdiqlandi: `git diff fc0edf0 f75fdc7 --name-only -- src/main openapi/` = BO'SH; faqat CustomerContractHistoryAndFileControllerTest.java (+20/-5). Baza (yashil, toza daraxt): History tests=15 0F · Versioning tests=11 0F · Cancellation tests=12 0F. Mutatsiya (worktree /tmp/qa-EP-08-T03-S03-r3, har biri javap bytecode bilan tasdiqlangan): ✅ (a) ASOSIY — CustomerContractFileService.java:40 ofMinutes(5) -> ofMinutes(60) = ENDI O'LDI (1F), aynan yangi assertiyada (test:346, xabar 'expires_at — yaratilishdan ~5 daqiqa keyin'). Ikki marta qaytarilgan nuqson YOPILDI. ✅ (b) FileDownloadService.java:48 ofMinutes(5) -> ofMinutes(60) = O'LDI (1F), boshqa qatorda (test:331: expected "300" but was "3600"). Ikkala konstanta MUSTAQIL qo'riqlanadi — biri ikkinchisini yashirmaydi (har biri o'z assertiyasida yiqiladi). ✅ (c) NULL kalit tekshiruvi olib tashlandi = O'LDI (1F, 404 -> 500). ✅ (e) fayl endpointi -> customer_document.view = O'LDI (5F), jumladan mezonga xos 'expected: 403 FORBIDDEN but was: 404 NOT_FOUND' (Q47 qoidasi). ✅ (a-ord) version DESC -> ASC = O'LDI (2F, expected 3 but was 1) · (g) version DESC -> id DESC = O'LDI (2F, expected 3 but was 2) — fixture id/version tartibini haqiqatan ajratadi. Regressiya YO'Q: yangi assertiya bitta test metodi ichida additive, boshqa mutantlarni susaytirmagan. Yangi assertiya soxta-ijobiy EMAS (savol (c)): · Tautologik emas — mutant (a) aynan shu assertiyada yiqiladi. · Flaky emas — `expires_at` server tomonda `Instant.now()+5min` bilan hisoblanadi, test esa AYNI JVM da (SpringBootTest RANDOM_PORT, embedded server) o'lchaydi, ya'ni soat siljishi (clock skew) yo'q. Surefire bo'yicha bu testning to'liq davomiyligi 0.417 s, `isBetween(4,6 daq)` esa 60 s zaxira beradi — ~140x запас. Sekin CI da ham 4 daqiqadan pastga tushmaydi. · Qoldiq (bloklamaydi, ma'lumot uchun): oraliq ±60 s bo'lgani uchun CustomerContractFileService konstantasining SEKUNDLIK siljishi (mas. 5 daq -> 5 daq 30 s) bu assertiyadan o'tib ketardi. Biznes xavfi yo'q: havolaning HAQIQIY amal qilish muddati X-Amz-Expires=300 bilan ANIQ qotirilgan; bu maydon faqat klientga ko'rsatiladigan qiymat. Wall-clock tekshiruvi uchun ±1 daqiqa oqilona murosa. Mezonlar (uchalasi mutatsiya bilan isbotlangan): AC3475 — tartib (a-ord/g mutantlari) + status filtri + sahifalash kontrakt Page sxemasiga mos · AC3476 — NULL kalitda 404 va ERROR-log YO'Qligi (oldingi yurishda (h) `handleNotFound`+log.error mutanti bilan alohida isbotlangan) · AC3477 — ikkala endpoint ham bytecode darajasida @RequirePermission("customer_contract.view"), `customer_document.view` OCHMAYDI (05_customers §7, 09_auth Q47). Tozalik: worktree /tmp/qa-EP-08-T03-S03-r3 o'chirildi — `git worktree list` toza, `grep -rn MUTANT src/` bo'sh, `*.orig` yo'q, `git status` toza. `openapi/` va `erp/docs` ga TEGILMADI.

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ `customer_contract.view` huquqisiz chaqiruv 403; `customer_document.view` huquqi buni OCHMAYDI (alohida test)

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ `contract_file_key` bo'sh versiyada havola so'ralsa aniq 404/holat qaytadi, xato log'ga tushmaydi

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ Versiyalar tarixi `version` bo'yicha tartiblangan holda qaytadi (status va `effective_from` bilan)

coder-ep-08-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t03-s03 yangiladi

Yangilandi: commit_sha

coder-ep-08-t03-s03 izoh qoldirdi

QA 2-qaytarish yopildi — expires_at TTL mutanti. Nuqson: CustomerContractFileService.PRESIGNED_URL_TTL (javobdagi expires_at) FileDownloadService.PRESIGNED_URL_TTL (imzodagi X-Amz-Expires) dan mustaqil edi; test faqat hasNonNull(expires_at) deb qiymatni olchamagan, shuning uchun ofMinutes(5)->ofMinutes(60) mutanti 0 test yiqitgan. Tuzatish FAQAT testda (ishlab chiqarish kodi tegilmadi): fileUrlForVersionWithFileKeyReturnsPresignedUrlWithFiveMinuteExpiry ga expires_at QIYMATI tekshiruvi qoshildi (OffsetDateTime.parse(...).toInstant(), Duration.between(now, expiresAt) 4..6 daq oynasida), mavjud X-Amz-Expires=300 tekshiruvi joyida qoldi. Olchov: toza daraxt tests=15 failures=0; izolyatsiyalangan worktree (/tmp/coder-EP-08-T03-S03-ttl, HEAD=fc0edf0) da ofMinutes(60) mutanti -> tests=15 failures=1, aynan shu test yiqildi. Worktree ochirildi, grep -rn MUTANT src/ bosh, *.orig yoq. Commit f75fdc7 (faqat 1 test fayli). Texnik qarz (lead hal qiladi): PRESIGNED_URL_TTL 5 joyda takrorlangan (common/storage/FileDownloadService, customers/CustomerContractFileService, suppliers/SupplierContractFileService, suppliers/SupplierDocumentService, products/ProductVariantImageService) — har biri mustaqil, drift xavfi saqlanadi; yagona manba (FileDownloadService dan public konstanta yoki metod) tavsiya etiladi.

coder-ep-08-t03-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-08-t03-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-08-t03-s03 izoh qoldirdi

QA QAYTA TEKSHIRUV (fc0edf0) — nuqson 2 YOPILDI, nuqson 1 YARIM yopilgan. Yana qaytariladi (1 qator assertiya yetishmayapti). Kod o'zgarmagani tasdiqlandi: git diff 72ccdd4 fc0edf0 --name-only -- src/main openapi/ = BO'SH; faqat CustomerContractHistoryAndFileControllerTest.java (+113/-5). Baza (yashil): History tests=15 0F (14 -> 15, yangi 200-yo'l testi) · Versioning tests=11 0F · Cancellation tests=12 0F — regressiya YO'Q, yangi fixture eski testlarni buzmagan. Mutatsiya (worktree /tmp/qa-EP-08-T03-S03-r2, har biri javap bytecode bilan tasdiqlangan): ✅ (g) ORDER BY version DESC -> id DESC = ENDI O'LDI (2F) — INSERT tartibi (v3,v1,v2) tuzatishi ISHLADI. ✅ (a) version DESC -> ASC = O'LDI (2F) · (b) status filtri e'tiborsiz = O'LDI (2F) · (c) contract_file_key IS NULL olib tashlandi = O'LDI (1F) · (e) fayl endpointi -> customer_document.view = O'LDI (5F) · (f) tarix huquqi olib tashlandi = O'LDI (2F). Hech biri susaymagan. ✅ (h, qo'shimcha) handleNotFound ichiga log.error qo'shildi = O'LDI (1F) — demak AC3476 ning 'ERROR log bo'lmasin' assertiyasi HAQIQATAN tishli (mutant (c) faqat status kodida yiqilgani uchun buni alohida isbotladim). ✅ Yangi 200-yo'l testi cheklovlarni buzmaydi — u ALOHIDA mijoz yaratadi (fileCustomerId, version=1, active), shu sabab UNIQUE(customer_id, version) ham, qisman UNIQUE(customer_id) WHERE status='active' ham tegilmagan (baza 15/0F buni tasdiqlaydi). === 🔴 QOLGAN YAGONA NUQSON: mutant (d) HALI HAM TIRIK === (d) CustomerContractFileService.java:40 `PRESIGNED_URL_TTL = ofMinutes(5)` -> `ofMinutes(60)` = TIRIK QOLDI (0F, bytecode'da `long 60l` tasdiqlangan). Sabab — coder ikkita HAR XIL konstantani adashtirgan: · FileDownloadService.java:48 `PRESIGNED_URL_TTL` -> imzoning O'ZIGA (X-Amz-Expires) ketadi. Yangi test AYNAN shuni qo'riqlaydi. Buni (d2) mutant bilan tasdiqladim: FileDownloadService:48 ni 60 daq qilsam test QIZIL bo'ladi (1F) — ya'ni yangi test foydali, lekin BOSHQA konstantani qo'riqlaydi. · CustomerContractFileService.java:40 `PRESIGNED_URL_TTL` -> FAQAT javobdagi `expires_at` maydonini hisoblaydi (63-qator: `Instant.now().plus(PRESIGNED_URL_TTL)`). Test uni faqat `hasNonNull("expires_at")` bilan ko'radi (test:321) — QIYMATINI tekshirmaydi. Shuning uchun bu konstanta hech narsa bilan qo'riqlanmagan. Amaliy oqibat: `expires_at` klientga '60 daqiqa' deb yolg'on gapirishi mumkin, holbuki havola 5 daqiqada o'ladi (yoki teskarisi) — javob va imzo bir-biridan ajralib ketadi va CI buni ko'rmaydi. Bu men birinchi qaytarishda AYNAN ogohlantirgan drift. KERAK (faqat test, kodga tegilmaydi) — fileUrlForVersionWithFileKeyReturnsPresignedUrlWithFiveMinuteExpiry (test:309) ichiga X-Amz-Expires=300 tekshiruvidan TASHQARI `expires_at` QIYMATI tekshiruvi qo'shilsin, mas.: Instant expiresAt = Instant.parse(json.get("expires_at").asText()); assertThat(Duration.between(Instant.now(), expiresAt)).isBetween(Duration.ofMinutes(4), Duration.ofMinutes(6)); Qabul mezoni (men qayta o'lchayman): CustomerContractFileService.java:40 dagi ofMinutes(5) -> ofMinutes(60) qilinsa test QIZIL bo'lishi SHART. Hozir 0 failure. Qolgan hammasi joyida. openapi/ va erp/docs ga TEGILMADI. Worktree /tmp/qa-EP-08-T03-S03-r2 o'chirildi (git worktree list toza, grep MUTANT src/ bo'sh, *.orig yo'q, git status toza).

coder-ep-08-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t03-s03 izoh qoldirdi

QA topilmalari tuzatildi (faqat test/fixture, kod O'ZGARMADI): (1) yangi test fileUrlForVersionWithFileKeyReturnsPresignedUrlWithFiveMinuteExpiry — contract_file_key BOR versiya uchun 200-yo'l, presigned URL'ning O'ZIDAGI X-Amz-Expires=300 tekshiriladi (expires_at emas). (2) setUp() INSERT tartibi ataylab versiya tartibidan farqli (v3,v1,v2) — id DESC endi version DESC bilan chalkashmaydi. Ikkala mutant qo'lda tasdiqlandi: TTL FileDownloadService.PRESIGNED_URL_TTL 5->60 daq qilinganda test QIZIL (expected 300, got 3600), ORDER BY version DESC -> id DESC qilinganda ikki tartib testi QIZIL (expected 3, got 2/1) — ikkalasida ham keyin asl faylga tiklandi (grep MUTANT bo'sh, diff bo'sh). CustomerContractHistoryAndFileControllerTest endi 15/15 yashil, butun customers paketi (8 klass, 146 test) ham yashil. commit fc0edf0.

coder-ep-08-t03-s03 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-08-t03-s03 ishga oldi

coder-ep-08-t03-s03 yangiladi

Yangilandi: commit_sha

coder-ep-08-t03-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

qa-ep-08-t03-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-08-t03-s03 izoh qoldirdi

QA (mutatsiya bilan) — 3 mezon TASDIQLANDI, lekin bargning ikkinchi yarmi (imzolangan havola) test bilan QO'RIQLANMAGAN. Qaytariladi. Baza (yashil): CustomerContractHistoryAndFileControllerTest tests=14/0F, CustomerContractVersioningTest tests=11/0F, CustomerContractCancellationTest tests=12/0F — regressiya YO'Q. Mutatsiya (izolyatsiyalangan worktree, har biri javap bilan bytecode'da tasdiqlangan): (a) ORDER BY c.version DESC -> ASC = O'LDI (2F: listReturnsAllVersionsOrderedByVersionDesc..., listRespectsPageSizeAndOrderAcrossPages) — coder da'vosi mustaqil takrorlandi. (b) status filtri e'tiborsiz (:status IS NULL OR :status IS NOT NULL) = O'LDI (2F). (c) contract_file_key IS NULL tekshiruvi olib tashlandi = O'LDI (1F, ERROR-log assertiyasi bilan birga). (e) fayl endpointida customer_contract.view -> customer_document.view = O'LDI (4F, jumladan fileUrlWithOnlyDocumentViewPermissionReturnsForbidden). (f) tarix endpointidan @RequirePermission olib tashlandi = O'LDI (2F). === YIQILGAN 2 BAND === 1) 🔴 (d) presigned muddat 5 daqiqa -> 60 daqiqa = TIRIK QOLDI (0F). Sabab: fayl endpointining 200-yo'li UMUMAN test qilinmagan — 14 testning hech biri url/expires_at ni ko'rmaydi. Ya'ni kontraktdagi 'AYNAN 5 daqiqa' (openapi/v1/customers.yaml GET /contracts/{contractId}/file summary + FileDownloadResponse, 09_auth R43, board technical_notes) HECH NARSA bilan qo'riqlanmagan — PII PDF uchun 60 daqiqalik havola jimgina ship bo'lardi. Qo'shimcha xavf: src/main/java/uz/erpbom/customers/service/CustomerContractFileService.java:40 dagi PRESIGNED_URL_TTL — FileDownloadService.PRESIGNED_URL_TTL ning NUSXASI, va expires_at (72-qator) imzoning haqiqiy muddatidan MUSTAQIL hisoblanadi; ikkisi ajralib ketsa javob yolg'on gapiradi va buni hech qaysi test ushlamaydi. KERAK: 200-yo'l testi — GET .../file 200 qaytarsin, javob FileDownloadResponse sxemasiga mos bo'lsin, imzoning O'ZIDA X-Amz-Expires == 300 va expires_at ~ now+5min tekshirilsin. Tayyor namuna shu repoda bor: src/test/java/uz/erpbom/suppliers/controller/SupplierContractFileControllerIntegrationTest.java:222-241 (real dev MinIO 127.0.0.1:9000, hozir ishlab turibdi). Mezon: CustomerContractFileService.java:40 dagi ofMinutes(5) o'zgartirilsa test YIQILISHI shart. 2) 🔴 Fixture xilma-xilligi — tartiblash testi 'version' ni 'id' dan ajrata olmaydi. Qo'shimcha mutant: ORDER BY c.version DESC -> ORDER BY c.id DESC = TIRIK QOLDI (0F, bytecode tasdiqlangan). Sabab: CustomerContractHistoryAndFileControllerTest.java:154/156/159 da versiyalar 1,2,3 aynan INSERT (id) tartibida kiritilgan, shu sabab 'id DESC' ham, 'insert tartibi teskarisi' ham testdan o'tib ketadi. status/effective_from/credit_limit XILMA-XIL — bu yaxshi; muammo faqat version ustunida. KERAK: insert tartibi version tartibidan FARQLI bo'lsin (mas. avval v3, keyin v1, keyin v2 kiritilsin) — shunda id DESK mutanti o'ladi. Kodga tegish shart emas, faqat fixture. Qolgan hammasi joyida: PageResponse page/size/total_items/total_pages kontrakt Page sxemasiga mos; list @Transactional(readOnly=true); fizik DELETE yo'q; ikkala endpoint ham bytecode darajasida @RequirePermission("customer_contract.view") bilan (javap: CustomerContractController.list va CustomerContractFileController.getDownloadUrl), 05_customers.md §7 va 09_auth Q47 ga mos. QA worktree /tmp/qa-EP-08-T03-S03 o'chirildi (git worktree list toza, grep MUTANT src/ bo'sh, *.orig yo'q, git status toza). openapi/ va erp/docs ga TEGILMADI.

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ `customer_contract.view` huquqisiz chaqiruv 403; `customer_document.view` huquqi buni OCHMAYDI (alohida test)

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ `contract_file_key` bo'sh versiyada havola so'ralsa aniq 404/holat qaytadi, xato log'ga tushmaydi

qa-ep-08-t03-s03 qabul mezonini belgiladi

✓ Versiyalar tarixi `version` bo'yicha tartiblangan holda qaytadi (status va `effective_from` bilan)

coder-ep-08-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t03-s03 izoh qoldirdi

GET /contracts (version DESC, status filtri) va GET /contracts/{contractId}/file (5 daq presigned, FileDownloadService qayta ishlatildi) qo'shildi. Yangi test klass CustomerContractHistoryAndFileControllerTest — 14/14 yashil (AC3475/3476/3477). Mutatsiya tekshiruvi: ORDER BY DESC->ASC qilib ikki tartib testini qasddan qizil qildim (2 ta muvaffaqiyatsizlik), keyin aynan asl faylga qaytardim (grep MUTANT bo'sh) va butun customers paketi (8 klass, 145 test) qayta yashil ekanini tasdiqladim. commit 72ccdd4.

coder-ep-08-t03-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-08-t03-s03 qabul mezonini belgiladi

✓ `customer_contract.view` huquqisiz chaqiruv 403; `customer_document.view` huquqi buni OCHMAYDI (alohida test)

coder-ep-08-t03-s03 qabul mezonini belgiladi

✓ `contract_file_key` bo'sh versiyada havola so'ralsa aniq 404/holat qaytadi, xato log'ga tushmaydi

coder-ep-08-t03-s03 qabul mezonini belgiladi

✓ Versiyalar tarixi `version` bo'yicha tartiblangan holda qaytadi (status va `effective_from` bilan)

coder-ep-08-t03-s03 fayllarni qayd etdi

7 ta fayl qayd etildi

coder-ep-08-t03-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-08-t03-s03 ishga oldi

pm-agent yaratdi

Versiya tarixi + shartnoma PDF imzolangan havolasi