Yangi versiya yaratish (atomik `replaced` → `active`) + cache sinxroni

finalize-ep-08 yangiladi

Yangilandi: pr_url

qa-ep-08-t03-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-08-t03-s01 izoh qoldirdi

QA QAYTA TEKSHIRUV (qa-EP-08-T03-S01) — HEAD 68c7fbb. Ikkala topilma HAQIQATAN yopilgan, mutatsiya bilan tasdiqlandi. VERDIKT: done. TEST: CustomerContractVersioningTest — surefire tests="11" errors="0" skipped="0" failures="0" (izolyatsiyalangan worktree /tmp/qa-EP-08-T03-S01-r2, Testcontainers PG16, flock ostida). MUTATSIYA — 6 mutant, HAMMASI O'LDI: - (f) `LocalDate.now()` -> `currentActive.map(CustomerContract::getEffectiveFrom).orElse(now)` (effective_from oldingi versiyadan MEROS) -> O'LDI: createVersionWithoutEffectiveFromDefaultsToToday. 🔴 Oldingi turda AYNAN shu mutant TIRIK qolgan edi — `insertContractV1` endi `effective_from=2020-01-15` yozgani uchun test endi "bugun" va "meros"ni farqlaydi. Topilma yopildi. - (b1) eski xatti-harakat tiklandi (`orElseThrow(this::versionConflict)` + `version = currentActive.getVersion()+1`) -> O'LDI: createVersionWhenNoActiveContractExistsStillCreatesNextVersion. Yangi test faol shartnomasiz yo'lni haqiqatan qo'riqlaydi. - (b2) `findMaxVersion` butun tarix o'rniga faqat `status='active'` bo'yicha -> O'LDI: createVersionWhenNoActiveContractExistsStillCreatesNextVersion (max bo'sh -> version=1 -> uq_customer_contracts_customer_version buzildi -> 409, test 201 kutadi). - (a2) `active.setStatus(STATUS_REPLACED)` + saveAndFlush olib tashlandi -> O'LDI (5 test). AC3467 regressiyasi yo'q. - (cache) `customer.setCreditLimit/setPaymentTermDays` olib tashlandi -> O'LDI (2 test, `null`/`0` chegarasi bilan). AC3468 regressiyasi yo'q. - (perm) `@RequirePermission("customer_contract.create")` olib tashlandi -> O'LDI: createVersionWithoutPermissionReturnsForbidden (javap: annotatsiya bytecode'da 0 marta). AC3470 regressiyasi yo'q. - (c3) 🔴 AC3469 ALOHIDA: refaktordan keyin konkurentlik yutqazgani endi `orElseThrow` emas, `else` tarmog'iga tushadi (max+1 hisoblaydi) va `uq_customer_contracts_customer_active`ga urilib DataIntegrityViolationException -> 409 oladi. Shu YAGONA qolgan qo'riqchini susaytirdim (409 -> 404) -> O'LDI: concurrentVersioningLeavesExactlyOneActiveContract. Ya'ni AC3469 yo'li SUSAYMAGAN: 409 kodi aynan `CONTRACT_VERSION_CONFLICT` deb tekshiriladi, oxirida DB'da `active` soni = 1 va jami 2 qator (yarim qolgan qator yo'q). SAVOL (d) — `max(version)` BUTUN tarix bo'yichami: HA. `CustomerContractRepository.findMaxVersion`: `SELECT MAX(c.version) FROM CustomerContract c WHERE c.customerId = :customerId` — status filtri YO'Q, ya'ni `replaced` va `cancelled` qatorlar ham sanaladi, versiya takrorlanmaydi. Statik o'qish + (b2) mutanti bilan tasdiqlandi. `UNIQUE(customer_id, version)` normal oqimda buzilmaydi (v1->v2->v3 va faol-shartnomasiz yo'l testlari yashil). ESLATMALAR (bloklamaydi): 1. `cancelled` qatorli tarix hozir QURIB BO'LMAYDI (bekor qilish — T03-S02), shuning uchun "cancelled ham sanaladi" sharti test bilan alohida qo'riqlanmaydi — faqat so'rov matni kafolatlaydi. T03-S02 da bekor qilingandan keyin versiya raqami davom etishiga test qo'shilsin. 2. Faol shartnoma YO'Q tarmog'ida qulf olinmaydi (`findActiveForUpdate` bo'sh qaytadi). Ikki parallel so'rov bir xil `max+1` hisoblab qolsa himoya `uq_customer_contracts_customer_version` + DataIntegrityViolationException -> 409 orqali ishlaydi — natija to'g'ri, kod izohda buni ochiq yozgan. Defekt emas. 3. `@Lock(PESSIMISTIC_WRITE)` ni olib tashlash mutanti oldingi turda TIRIK qolgan edi (javap bilan tasdiqlangan) — bu defekt emas, ortiqcha (belt-and-braces) qatlam; natija baribir qisman unikal indeks bilan to'g'ri. TEGILMASIN. CROSS-CUTTING: @Transactional ✓ · tenant_id yo'q (AR-1) ✓ · snake_case/ko'plik/to'liq FK nomi ✓ · numeric(18,2) ✓ · fizik DELETE yo'q ✓ · token/parol log'da yo'q ✓ · bu bargda asinxron ish yo'q (PDF — T05) ✓. KONTRAKT: 201 · snake_case · credit_limit decimal string, `null`=limitsiz · version/status/created_by_user_id so'rovda YO'Q · payment_term_days @NotNull @Min(0) · effective_from default = BUGUN (endi haqiqatan qo'riqlangan). TOZALIK: worktree o'chirildi (`git worktree list` da faqat asosiy daraxt), `grep -rn MUTANT src/` BO'SH, asosiy ish daraxti o'zgarishsiz (git status toza, HEAD 68c7fbb).

coder-ep-08-t03-s01 yangiladi

Yangilandi: commit_sha

coder-ep-08-t03-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t03-s01 izoh qoldirdi

QA 2 ta topilma tuzatildi: (1) createVersionWithoutEffectiveFromDefaultsToToday fixture'i — insertContractV1 endi effective_from=2020-01-15 (o'tmish) beradi, DEFAULT CURRENT_DATE ga suyanmaydi; mutatsiya LocalDate.now()->currentActive.get().getEffectiveFrom() endi testni qizil qiladi (izolyatsiyalab tekshirildi, fayl tiklandi). (2) CustomerContractService.createVersion — faol shartnoma yo'q holatda endi 409 emas, version=max(version)+1 (butun tarix) bilan yangi active qator yaratadi (findActiveForUpdate qulfi active mavjud bo'lganda AC3469 uchun o'zgarmadi; yo'q holatda himoya uq_customer_contracts_customer_version unique indeksi). Yangi repo metodi: CustomerContractRepository.findMaxVersion. Yangi test: createVersionWhenNoActiveContractExistsStillCreatesNextVersion (avval 409 bilan qizil ekanini tasdiqladim, keyin tuzatib yashil qildim). CustomerContractVersioningTest: 11/11 yashil.

coder-ep-08-t03-s01 fayllarni qayd etdi

3 ta fayl qayd etildi

qa-ep-08-t03-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-08-t03-s01 izoh qoldirdi

QA (qa-EP-08-T03-S01) — 4 mezon ham HAQIQATAN bajarilgan (mutatsiya bilan tasdiqlandi), lekin BITTA test-teshigi uchun qaytarilyapti. TEST: CustomerContractVersioningTest — tests=10, failures=0, errors=0 (surefire XML, izolyatsiyalangan worktree, Testcontainers PG16). MUTATSIYA NATIJALARI (git worktree /tmp/qa-EP-08-T03-S01, HEAD=b4d3b77): - (a) `currentActive.setStatus(STATUS_REPLACED)` + saveAndFlush olib tashlandi -> O'LDI (5 test yiqildi, shu jumladan AC3467 testi). - (b) `customer.setCreditLimit/setPaymentTermDays` olib tashlandi -> O'LDI (2 test; AC3468 chegara holati `null`/`0` bilan ham qamralgan). - (c2) 409 CONTRACT_VERSION_CONFLICT -> 404 ga susaytirildi (ikkala qatlamda) -> O'LDI (concurrentVersioningLeavesExactlyOneActiveContract). AC3469 kod darajasida haqiqatan qo'riqlanadi. - (d) `@RequirePermission("customer_contract.create")` olib tashlandi -> O'LDI (javap: annotatsiya bytecode'da 0 marta). AC3470 OK. - (c1) `@Lock(PESSIMISTIC_WRITE)` olib tashlandi -> TIRIK QOLDI, lekin bu DEFEKT EMAS: qulfsiz ham natija spec'ga mos (yutqazgan tranzaksiya `uq_customer_contracts_customer_active` / `uq_customer_contracts_customer_version` ga urilib 409 oladi, DB'da aynan bitta `active` qoladi). javap bilan tasdiqlandi (Lock annotatsiyasi 0). Ortiqcha himoya qatlami — tegilmasin. AC3469 alohida tekshirildi: test SOXTA parallellik EMAS — ikki thread + ikki real HTTP ulanish, xom JDBC `FOR UPDATE` qulfi bilan deterministik kontensiya; 409 kodi AYNAN `CONTRACT_VERSION_CONFLICT` deb tekshiriladi va oxirida DB'da `count(*) WHERE status='active' = 1` hamda jami 2 qator (yarim qolgan qator yo'q) tasdiqlanadi. KONTRAKTGA MOSLIK (openapi/v1/customers.yaml) — mos: 201; snake_case (application.yml property-naming-strategy: SNAKE_CASE); credit_limit decimal string (JacksonConfig ToStringSerializer) va `null` = limitsiz; version/status/created_by_user_id CustomerContractCreateRequest'da YO'Q — tizim qo'yadi; payment_term_days @NotNull + @Min(0). 🔴 QAYTARISH SABABI — 1 ta yolg'on (vacuous) test: fayl: src/test/java/uz/erpbom/customers/controller/CustomerContractVersioningTest.java:238-247 test: createVersionWithoutEffectiveFromDefaultsToToday Mutatsiya (f): CustomerContractService.java:78 da `request.effectiveFrom() != null ? request.effectiveFrom() : LocalDate.now()` -> `... : currentActive.getEffectiveFrom()` (ya'ni kontrakt buzilib, effective_from OLDINGI VERSIYADAN MEROS olinadi) natija: TIRIK QOLDI — 10/10 test yashil (javap bilan tasdiqlandi: getEffectiveFrom bytecode'da chaqirilyapti). SABABI — FIXTURE XILMA-XILLIGI YO'Q: `insertContractV1` (fayl:499-513) `effective_from` ni UMUMAN bermaydi, DB DEFAULT CURRENT_DATE ishlaydi => v1.effective_from = BUGUN. Shuning uchun "bugun" va "v1 dan meros" natijalari FARQLANMAYDI va test o'z nomidagi qoidani aslida tekshirmaydi. Kontrakt talabi (customers.yaml, CustomerContractCreateRequest.effective_from): "Berilmasa **bugun** — oldingi versiyadan MEROS OLINMAYDI." TUZATISH (1 qator): `insertContractV1` ga o'tmishdagi ANIQ sana bering (mas. `effective_from = DATE '2026-01-15'`), shunda default=bugun testi meros variantini yiqitadi. Kod TO'G'RI — faqat fixture/test tuzatiladi, servis kodiga tegish shart emas. ⚠️ KELAJAK UCHUN OGOHLANTIRISH (bu bargda bloklamaydi, T03-S02 ga): CustomerContractService.java:71 — `findActiveForUpdate(...).orElseThrow(this::versionConflict)`: faol shartnoma YO'Q bo'lsa 409 CONTRACT_VERSION_CONFLICT qaytadi. Hozir bu holat erishib bo'lmas (v1 mijoz yaratishda avto-seed qilinadi), LEKIN FP-7 (bekor qilish, T03-S02) kelgach `active -> cancelled` dan keyin mijozda faol shartnoma qolmaydi (05_customers.md §4.2) va o'shanda bu yo'l mijozni QAYTA tiklab bo'lmaydigan qilib qo'yadi. Shuningdek version hisobi `currentActive.getVersion()+1`, kontrakt esa `max(version)+1` deydi — bekor qilishdan keyin bu ikkisi ajralib ketadi. T03-S02 da qayta ko'rilsin. CROSS-CUTTING: @Transactional ✓ (yozuv, readOnly emas) · tenant_id yo'q (AR-1) ✓ · snake_case/ko'plik/to'liq FK nomi ✓ · numeric(18,2) ✓ · fizik DELETE yo'q ✓ · log'da token/parol yo'q ✓ · bu bargda asinxron ish yo'q (PDF — T05) ✓. Worktree o'chirildi (`git worktree list` toza), asosiy daraxtda `grep -rn MUTANT src/` BO'SH, ish daraxti o'zgarishsiz.

qa-ep-08-t03-s01 qabul mezonini belgiladi

✓ `customer_contract.create` huquqisiz chaqiruv 403

qa-ep-08-t03-s01 qabul mezonini belgiladi

✓ Ikki parallel yangi-versiya so'rovidan faqat bittasi muvaffaqiyatli bo'ladi (konkurentlik testi)

qa-ep-08-t03-s01 qabul mezonini belgiladi

✓ `customers.credit_limit`/`payment_term_days` yangi versiyaning qiymatiga teng

qa-ep-08-t03-s01 qabul mezonini belgiladi

✓ Yangi versiyadan keyin eski qator `replaced`, yangisi `active`, `version` bir birlik oshgan

coder-ep-08-t03-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t03-s01 izoh qoldirdi

POST /api/v1/customers/{id}/contracts — SupplierContractService (T02/EP-03-T03-S01) naqshi aynan takrorlandi: findActiveForUpdate (SELECT...FOR UPDATE) + uq_customer_contracts_customer_active ikkinchi himoya qatlami -> 409 CONTRACT_VERSION_CONFLICT. Migratsiyaga tegilmadi (V30 allaqachon barcha kerakli ustun/cheklovlarni beradi). printed_at/contract_file_key bu bargda toldirilmaydi (T05 fon ishi) — kontrakt tavsifiga mos. 10/10 test yashil (CustomerContractVersioningTest).

coder-ep-08-t03-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-08-t03-s01 qabul mezonini belgiladi

✓ `customer_contract.create` huquqisiz chaqiruv 403

coder-ep-08-t03-s01 qabul mezonini belgiladi

✓ Ikki parallel yangi-versiya so'rovidan faqat bittasi muvaffaqiyatli bo'ladi (konkurentlik testi)

coder-ep-08-t03-s01 qabul mezonini belgiladi

✓ `customers.credit_limit`/`payment_term_days` yangi versiyaning qiymatiga teng

coder-ep-08-t03-s01 qabul mezonini belgiladi

✓ Yangi versiyadan keyin eski qator `replaced`, yangisi `active`, `version` bir birlik oshgan

coder-ep-08-t03-s01 fayllarni qayd etdi

7 ta fayl qayd etildi

coder-ep-08-t03-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-08-t03-s01 ishga oldi

pm-agent yaratdi

Yangi versiya yaratish (atomik `replaced` → `active`) + cache sinxroni