`active` toggle — nofaol mijoz cheklovlari

finalize-ep-08 yangiladi

Yangilandi: pr_url

qa-ep-08-t02-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-08-t02-s03 izoh qoldirdi

QA (qayta tekshiruv — oldingi QA agenti mutatsiya o'rtasida uzilib qolgan edi; hamma mezon noldan tekshirildi). Test: CustomerToggleActiveTest — surefire tests=16, failures=0, errors=0 (izolyatsiyalangan worktree, bc01c93). MUTATSIYA TEKSHIRUVI (5 mutant, hammasi /var/tmp/qa-EP-08-T02-S03 worktree ichida, javap bilan bytecode tasdiqlangan): - A (ENG MUHIM, AC3463): setActive ichida R12(c) ataylab qo'llandi — native UPDATE users SET status/token_valid_after/perm_version → O'LDI (2 failure: deactivateDoesNotChangeLinkedUserRow, activateDoesNotChangeLinkedUserRow). - A2 (nozik variant): FAQAT last_login_at ustuniga tegildi (status'ga emas) → O'LDI (2 failure). Demak AC3463 testi "faqat status" emas, SELECT * + ResultSetMetaData bilan BUTUN qatorni solishtiradi; users da updated_at trigger yo'q (V4), shuning uchun solishtiruv turg'un. - B: setActive'da customer.setActive(active) olib tashlandi → O'LDI (7 failure). - C: @RequirePermission("customer.toggle_active") ikkala endpoint'dan olib tashlandi → O'LDI (4 failure — AC3465 ning to'rt testi). - D: CustomerController'ga @DeleteMapping("/{id}") qo'shildi → O'LDI (2 failure: physicalDeleteEndpointDoesNotExist, customerControllerHasNoDeleteMapping). Fixture xilma-xilligi: user_id BOR (linkCustomerToUser) va user_id NULL mijozlar, active=true va active=false boshlang'ich holatlari — ikkalasi ham qamralgan. Spec muvofiqligi: 05_customers.md §4.1 + §8 UC5 + §5 R12(c) — R12(c) spec'da 2026-08-06 da "taklif — tasdiq kutilmoqda" ga qaytarilgan, demak users'ga tegmaslik TO'G'RI. Kontrakt (openapi/v1/customers.yaml 369-424) bilan mos: activate/deactivate POST, 200/401/403/404, idempotent; /customers/{id} da faqat get+put (DELETE yo'q). Cross-cutting: @Transactional ikkala public metodda bor; tenant_id/schema mexanikasi qo'shilmagan (AR-1); customer.toggle_active — permissions katalogida bor va user_permissions.permission_code FK bilan bog'langan (AR-10, V5/R__seed); fizik DELETE yo'q (§5 R6); yangi migratsiya/outbox/log yo'q. Tozalash: worktree remove --force bajarildi, worktree list = faqat asosiy daraxt, grep -rn MUTANT src/ = BO'SH, git status toza.

qa-ep-08-t02-s03 qabul mezonini belgiladi

✓ `customer.toggle_active` huquqisiz chaqiruv 403

qa-ep-08-t02-s03 qabul mezonini belgiladi

✓ Mijozni o'chiradigan (DELETE) endpoint mavjud emas

qa-ep-08-t02-s03 qabul mezonini belgiladi

✓ `active=false` qilingach `users` jadvalidagi bog'langan qator O'ZGARMAGANI test bilan tasdiqlanadi

coder-ep-08-t02-s03 yangiladi

Yangilandi: commit_sha

coder-ep-08-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t02-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-08-t02-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-08-t02-s03 izoh qoldirdi

QA (qa-EP-08-T02-S03) — QAYTARILDI: AC3463 mutatsiya tekshiruvidan o'tmadi. TESTLAR YASHIL (baseline, main tree, flock ostida): CustomerCreateTest tests="11" F0 E0 · CustomerQueryTest tests="20" F0 E0 · CustomerToggleActiveTest tests="15" F0 E0 (jami 46). S01/S02 regressiyasi YO'Q. MUTATSIYA (izolyatsiyalangan git worktree, har biri javap bilan bytecode'da tasdiqlangan): (a) deactivate -> setActive(id,true) = O'LDIRILDI (6 test) (b) activate -> setActive(id,false) = O'LDIRILDI (3 test) (c1) @RequirePermission activate'dan olindi = O'LDIRILDI (aynan 2 ta activate-403 testi; deactivate-403 testlari YASHIL qoldi) (c2) @RequirePermission deactivate'dan olindi = O'LDIRILDI (aynan 2 ta deactivate-403 testi; activate-403 testlari YASHIL qoldi) (d1) deactivate users SET status='blocked', token_valid_after=now() = O'LDIRILDI (deactivateDoesNotChangeLinkedUserRow: expected "active" but was "blocked") (e) allaqachon nofaolda deactivate 409 otsin = O'LDIRILDI (deactivatingTwiceIsIdempotent) (d2) deactivate users SET perm_version = perm_version + 1, locked_until = now() = TIRIK QOLDI (15 test, 0 failure; javap: 'perm_version' string klassda bor -> mutatsiya haqiqatan kompilyatsiya bo'lgan) DEFEKT — AC3463 (`users` qatori O'ZGARMAGANI): Fayl: src/test/java/uz/erpbom/customers/controller/CustomerToggleActiveTest.java:222-236 (deactivateDoesNotChangeLinkedUserRow) Test `users` qatorining 17 ustunidan FAQAT 3 tasini solishtiradi: status (l.234), token_valid_after (l.235), updated_at (l.236). Mezon matni esa butun qator o'zgarmasligini talab qiladi. Kutilgan: `users` qatorining HAR QANDAY ustuni o'zgarsa test yiqilishi. Olingan: `perm_version`/`locked_until` o'zgarganda test YASHIL qoladi. Nega muhim (pedantik emas): `perm_version` — huquq keshining bekor qilish kaliti (PermissionEvaluatorImpl.java:50, EffectivePermissionsLoader `perm:{user_id}:v{perm_version}`), `locked_until` — auth ustuni. Ya'ni R12(c) "sessiyani bekor qilish" taklifini aynan shu ustunlar orqali amalga oshirgan kod testdan JIM o'tib ketadi. Qolgan qoplanmagan ustunlar: deleted_at, phone, full_name, failed_login_count, last_login_at, user_type, username, password_hash, created_at, created_by_user_id. TUZATISH (aniq, kichik): deactivate'dan OLDIN va KEYIN `SELECT * FROM users WHERE id=?` natijasini TO'LIQ (ResultSetMetaData bo'ylab hamma ustun) Map/String ko'rinishida o'qib, ikkalasini bitta assert bilan solishtir. Shunda ustun qo'shilganda ham qamrov o'z-o'zidan saqlanadi. Kod (main) TUZATISHNI TALAB QILMAYDI — faqat test. O'TGAN MEZONLAR: AC3464 = met. Kontraktda `DELETE /customers/{id}` YO'Q (3 ta `delete:` — customers.yaml:726 documents/{documentId}, :856 organizations/{organizationId}, :945 credentials — mijoz uchun EMAS). `grep -rn DeleteMapping src/main/java/uz/erpbom/customers/` = 0 natija. Test 405/404 + reflection bilan qo'shimcha qo'riqlaydi. AC3465 = met. activate VA deactivate uchun ALOHIDA 403 testlari borligi (c1)/(c2) mutantlari bilan ISBOTLANDI (har biri faqat o'z endpoint'ining testlarini yiqitdi). `customer.toggle_active` katalogda bor (R__permissions_and_currencies_seed.sql:98) -> `permission_code` FK (AR-10). KONTRAKT MUVOFIQLIGI (to'liq, defektsiz): Idempotentlik — activate faolda 200, deactivate nofaolda 200: BOR va (e) mutanti bilan qoplangani isbotlandi. 200 + CustomerResponse: bor. 404 noma'lum id: ikkala yo'l uchun ham bor. `users`/sessiya/notification/outbox yozuvi: CustomerService.java ichida YO'Q (setActive:236-244 faqat Customer entity'ga tegadi; servisda UserRepository/JdbcTemplate/EntityManager umuman yo'q). CROSS-CUTTING: @Transactional (activate:209, deactivate:224) ✓ · tenant_id qo'shilmagan (AR-1) ✓ · permission_code FK katalogga ✓ (AR-10) · outbox/broker ishlatilmagan, bu yerda kerak emas (AR-4) ✓ · fizik DELETE yo'q ✓ · token/parol log'ga yozilmaydi ✓ · migratsiya bu commit'da yo'q. FIXTURE XILMA-XILLIGI — YETARLI (EP-07 saboqi bo'yicha alohida tekshirildi): active=true VA active=false boshlang'ich holat (toggleCycle, deactivatingTwice), user_id BOR (l.216-237) VA user_id NULL (l.240-248, NPE bermasligi) mijozlar, 3 xil token (toggle huquqli / faqat customer.update / huquqsiz). DOIRA: buzilmagan — commit faqat 3 faylga tegadi (CustomerController, CustomerService, CustomerToggleActiveTest). contracts/documents/organizations/credentials (T03-T07) yoki outbox PDF (T05) qo'shilmagan. QOLGAN ISH: FAQAT yuqoridagi bitta test tuzatishi. Kod, kontrakt va migratsiya tegilmasin.

qa-ep-08-t02-s03 qabul mezonini belgiladi

✓ `customer.toggle_active` huquqisiz chaqiruv 403

qa-ep-08-t02-s03 qabul mezonini belgiladi

✓ Mijozni o'chiradigan (DELETE) endpoint mavjud emas

coder-ep-08-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t02-s03 izoh qoldirdi

activate/deactivate qo'shildi (customer.toggle_active, idempotent). users jadvaliga TEGILMAGAN (kontrakt VA'DA QILMAGANI bo'yicha, §5 R12(c) hali taklif). DELETE endpoint yaratilmadi. CustomerToggleActiveTest — 15/15 yashil; CustomerCreateTest 11/11 va CustomerQueryTest 20/20 buzilmagan.

coder-ep-08-t02-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-08-t02-s03 fayllarni qayd etdi

3 ta fayl qayd etildi

coder-ep-08-t02-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-08-t02-s03 ishga oldi

pm-agent yaratdi

`active` toggle — nofaol mijoz cheklovlari