`customer_documents` + `customer_organizations` jadvallari

finalize-ep-08 yangiladi

Yangilandi: branch, commit_sha, pr_url

qa-ep-08-t01-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-08-t01-s02 izoh qoldirdi

QA (qa-EP-08-T01-S02) — QAYTA TEKSHIRUV: ✅ QABUL QILINDI (done). 1) YANGI DELETE-RESTRICT TESTLARI (CustomerDocumentsAndOrganizationsMigrationTest.java:452-616) — 7 ta, hammasi HAQIQIY assert bilan (assertThatThrownBy → SQLException + SQLState 23503), tautologik/assert'siz yo'q. Har FK uchun ALOHIDA test, oltala FK qamrab olingan: :463 deletingCustomerReferencedByDocumentIsRestricted → fk_customer_documents_customer :484 deletingContractReferencedByDocumentIsRestricted → fk_customer_documents_contract :506 deletingUserReferencedByDocumentUploadedByIsRestricted → fk_customer_documents_uploaded_by_user :527 deletingCustomerReferencedBySoftDeletedDocumentIsStillRestricted → fk_customer_documents_customer (SOFT-DELETE holati) :558 deletingCustomerReferencedByOrganizationLinkIsRestricted → fk_customer_organizations_customer :579 deletingOrganizationReferencedByCustomerLinkIsRestricted → fk_customer_organizations_organization :600 deletingUserReferencedByOrganizationLinkCreatedByIsRestricted → fk_customer_organizations_created_by_user Har testda ota qator ALOHIDA yaratiladi va faqat bitta bola qator unga havola qiladi — 23503 atributsiyasi aniq, boshqa FK dan kelib chiqmaydi. 🔴 SOFT-DELETE HOLATI ALOHIDA SINALGAN (:527): `UPDATE customer_documents SET deleted_at = now()` dan KEYIN ham `DELETE FROM customers` 23503 bilan rad etiladi. Ya'ni soft-delete FK'ni "bo'shatib yubormaydi" — DB darajasida qator fizik saqlanadi (CROSS_CUTTING H bilan izchil). Bu aynan so'ralgan holat. 2) 🔴 (e) CASCADE MUTANTI ENDI O'LADI — izolyatsiyalangan worktree /tmp/qa-EP-08-T01-S02b, mutatsiya target/classes/db/migration/V30__customers.sql da TASDIQLANDI: (e-full) doiradagi OLTALA FK `ON DELETE RESTRICT` → `ON DELETE CASCADE` (6/6 tasdiqlandi) → O'LDI: 28 testdan 7 tasi yiqildi — aynan yuqoridagi 7 ta DELETE-RESTRICT testi, boshqa hech biri emas. (e-single) FAQAT `fk_customer_organizations_organization` → CASCADE (1/1 tasdiqlandi) → O'LDI: 28 testdan ANIQ 1 tasi yiqildi — `deletingOrganizationReferencedByCustomerLinkIsRestricted`. Ikkinchisi ATRIBUTSIYANI isbotlaydi: testlar bir-biriga bog'lanib ommaviy yiqilmaydi, har FK ni o'z testi qo'riqlaydi. Oldingi review'dagi YAGONA qamrov teshigi YOPILDI. 3) YAKUNIY KOMBINATSIYALANGAN YURISH (toza fayllar, izolyatsiyalangan worktree, toza Testcontainers PG16): mvn -Dtest=CustomersAndContractsMigrationTest,CustomerDocumentsAndOrganizationsMigrationTest test → BUILD SUCCESS (exit=0), **Tests run: 61, Failures: 0, Errors: 0, Skipped: 0** CustomerDocumentsAndOrganizationsMigrationTest — 28 test, 0 xato CustomersAndContractsMigrationTest — 33 test, 0 xato Flyway: 'Migrating schema "public" to version "30 - customers"' → 'Successfully applied 34 migrations ... now at version v30'. V30 butunligicha (4 jadval) toza bazada muammosiz qo'llanadi. ℹ️ Aniqlik uchun: surefire haqiqiy sonlari 28 va 33 (worker-pm xabarida 29 va 34 deyilgan — `grep -c "@Test"` javadoc/izohdagi matnni ham sanagan; @Test bilan belgilangan metodlar 28 ta). Nuqson emas, faqat hisob aniqligi. 4) GIGIYENA: mutatsiya FAQAT worktree da o'tkazildi, worktree o'chirildi (`worktree list` — faqat asosiy daraxt). `grep -rn MUTANT /var/www/apps/erpbom-backend/src/` — BO'SH. `.orig` qoldiq yo'q. V30 da 13 ta `ON DELETE RESTRICT`, 0 ta `ON DELETE CASCADE`. Asosiy daraxtda faqat kutilgan 2 untracked yo'l. erp/docs va openapi/ TEGILMADI. Uch qabul mezoni (3451/3452/3453) oldingi review'da mustaqil isbotlangan (har biri o'z mutanti bilan o'lgan) — qayta baholanmadi, `true` qoladi. Barg `done`.

coder-ep-08-t01-s02 izoh qoldirdi

QA topilmasi (mutant e, ON DELETE RESTRICT -> CASCADE tirik qolgan) yopildi: CustomerDocumentsAndOrganizationsMigrationTest.java ga 7 ta yangi DELETE RESTRICT guard test qo'shildi (SupplierChangeProposalsMigrationTest#deletingSupplierReferencedByProposalIsRestricted naqshi) — customer_documents (customer_id, contract_id, uploaded_by_user_id) va customer_organizations (customer_id, organization_id, created_by_user_id) uchun HAR FK alohida, + 1ta qo'shimcha test: deleted_at to'ldirilgan (soft-deleted) hujjat ham ota customer'ni DELETE dan RESTRICT bilan himoya qilishini isbotlaydi. Jami 28/28 yashil. O'z-o'zini tekshirish: V30 dagi 6 ta S02 FK'sini qo'lda ON DELETE CASCADE ga o'zgartirib test yurgizdim — barcha 7 yangi test aniq shu joyda yiqildi (mutant o'ldi, tasdiqlangan), so'ng V30 asl RESTRICT holatiga qaytarildi (cp orqali restore kutilganidek ishlamagani uchun aniq 6 qatorni qo'lda sed bilan tuzatib, to'liq fayl diff/mazmuni bilan qayta tekshirildi — hozir grep MUTANT/CASCADE bo'sh, 217 qator, S01 qismi (customers/customer_contracts) tegilmagan). CustomersAndContractsMigrationTest.java ga tegilmadi.

coder-ep-08-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

qa-ep-08-t01-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-08-t01-s02 izoh qoldirdi

QA (qa-EP-08-T01-S02) — QAYTARILDI: DDL to'g'ri, TEST QAMROVIDA TESHIK. DDL (V30__customers.sql 131-216) technical_notes bilan qatorma-qator mos: ustunlar aynan, ORTIQCHA/YETISHMAYDIGAN yo'q. Tasdiqlandi: deleted_at timestamptz NULL (155-161) · qisman indeks (customer_id, doc_type) WHERE deleted_at IS NULL (179-180) · CHECK (doc_type IN ('passport','receipt_note','other')) + DEFAULT 'other' (154, 168-169) · UNIQUE(customer_id, organization_id) (209-210) · 6 ta FK ham ON DELETE RESTRICT · original fayl nomi ustuni YO'Q (Q29=C) · organization_id faqat customer_organizations da, customers ga ko'chirilmagan. Kontrakt openapi/v1/customers.yaml (DocumentType enum, CustomerDocumentResponse) bilan zid emas — kontrakt TEGILMADI. organization_id uchun alohida idx — ASOSLI (composite UNIQUE'da leftmost emas, V10 naqshi, postgresql skill §4), chetga chiqish emas. Kombinatsiyalangan yurish (izolyatsiyalangan worktree, toza Testcontainers PG16): mvn -Dtest=CustomersAndContractsMigrationTest,CustomerDocumentsAndOrganizationsMigrationTest test → BUILD SUCCESS, Tests run: 48 (27+21), Failures: 0, Errors: 0. V30 toza bazada muammosiz qo'llandi ('Successfully applied 34 migrations ... now at version v30'). Mutatsiya tekshiruvi (har mutant target/classes/db/migration/V30__customers.sql da tasdiqlandi): (a1) CHECK'dan 'receipt_note' olib tashlandi → O'LDI (documentCanBeInsertedWithReceiptNoteTypeAndContractId, documentWithUnknownContractIsRejected) (a2) CHECK → CHECK (doc_type IS NOT NULL) → O'LDI (documentWithInvalidDocTypeIsRejected) (b) qisman indeksdan WHERE deleted_at IS NULL → O'LDI (customerDocumentsCustomerIdDocTypeIndexIsPartialOnNonDeletedRows) (c) UNIQUE INDEX → oddiy INDEX → O'LDI (duplicateCustomerOrganizationPairIsRejected) (d) deleted_at ustuni olib tashlandi → O'LDI (documentDefaultsToNotDeleted, softDeletedDocumentIsExcludedByActiveFilterButRowRemains, ...IndexIsPartial...) (e) ON DELETE RESTRICT → ON DELETE CASCADE → 🔴 TIRIK QOLDI: 21/21 yashil Fixture xilma-xilligi TEKSHIRILDI va yetarli: doc_type uchala qiymati ishlatilgan (passport/receipt_note/other) · contract_id NULL va NOT NULL ikkalasi · size_bytes turli (111/222/1000/4096/33000/51200/204800) · deleted_at NULL va NOT NULL ikkalasi. 🔴 QAYTARISH SABABI — bitta qamrov teshigi (mutant e): 05_customers.md §3 ("O'chirish") va Board technical_notes talabi: **Barcha FK — RESTRICT**. DDL da RESTRICT BOR, lekin uni HECH BIR test qo'riqlamaydi. Ikkala FK ni (customer_documents.customer_id → customers, customer_organizations.organization_id → organizations) ON DELETE CASCADE ga o'zgartirganda CustomerDocumentsAndOrganizationsMigrationTest 21/21 YASHIL qoldi. Mavjud 6 ta FK testi (documentWithUnknownCustomerIsRejected va h.k.) faqat INSERT paytidagi 23503 ni tekshiradi — bu FK MAVJUDLIGI, DELETE xatti-harakati EMAS. Ya'ni CASCADE regressiyasi (mijoz o'chirilsa hujjatlari jimgina yo'q bo'ladi — CROSS_CUTTING H soft-delete qoidasining teskarisi) hech qachon ushlanmaydi. NIMA QILISH KERAK (fayl: src/test/java/uz/erpbom/customers/CustomerDocumentsAndOrganizationsMigrationTest.java): DELETE-RESTRICT testlari qo'shilsin — repo'da NAQSH BOR: src/test/java/uz/erpbom/suppliers/SupplierChangeProposalsMigrationTest.java:494 `deletingSupplierReferencedByProposalIsRestricted` (DELETE FROM ... → SQLState 23503). Kamida 2 ta test: 1. hujjati bor customer ni `DELETE FROM customers WHERE id = ?` → SQLException, SQLState 23503 (fk_customer_documents_customer); 2. biriktirilgan organization ni `DELETE FROM organizations WHERE id = ?` → SQLState 23503 (fk_customer_organizations_organization). Qolgan 4 FK (contract_id, uploaded_by_user_id, customer_organizations.customer_id, created_by_user_id) uchun ham shu naqshda qo'shilsa — to'liq bo'ladi. Uch qabul mezoni (3451/3452/3453) MUSTAQIL tasdiqlandi va `true` qoldirildi — har biri o'ziga mos mutant bilan o'lganligi isbotlandi. Gigiyena: mutatsiya faqat `git worktree` /tmp/qa-EP-08-T01-S02 da o'tkazildi, worktree o'chirildi; `grep -rn MUTANT src/` — BO'SH; asosiy daraxtda faqat kutilgan 2 untracked yo'l; erp/docs va openapi/ TEGILMADI.

qa-ep-08-t01-s02 qabul mezonini belgiladi

✓ `deleted_at` to'ldirilgan hujjat qisman indeksga tushmaydi

qa-ep-08-t01-s02 qabul mezonini belgiladi

✓ Bir mijoz + bir node juftligi ikki marta biriktirilsa DB xato beradi

qa-ep-08-t01-s02 qabul mezonini belgiladi

✓ `doc_type` uch qiymatdan tashqarisi INSERT qilinsa CHECK ishlaydi

coder-ep-08-t01-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-08-t01-s02 izoh qoldirdi

V30__customers.sql fayl OXIRIGA customer_documents (2.3) va customer_organizations (2.4) qo'shildi — S01 qismi (customers, customer_contracts) o'zgartirilmadi, faqat APPEND. Barcha FK ON DELETE RESTRICT. customer_documents: CHECK(doc_type IN passport/receipt_note/other) DEFAULT other, deleted_at soft-delete + qisman indeks idx_customer_documents_customer_id_doc_type (customer_id, doc_type) WHERE deleted_at IS NULL (V13 supplier_documents naqshi). customer_organizations: UNIQUE(customer_id, organization_id), organization_id FK ustuniga alohida indeks (composite UNIQUE leftmost emas). Test: CustomerDocumentsAndOrganizationsMigrationTest — 21/21 yashil (Testcontainers PG16), 3ta acceptance criteria (doc_type CHECK, customer+node UNIQUE, deleted_at qisman indeks — ta'rif VA xatti-harakat darajasida) qoplandi.

coder-ep-08-t01-s02 qabul mezonini belgiladi

✓ `deleted_at` to'ldirilgan hujjat qisman indeksga tushmaydi

coder-ep-08-t01-s02 qabul mezonini belgiladi

✓ Bir mijoz + bir node juftligi ikki marta biriktirilsa DB xato beradi

coder-ep-08-t01-s02 qabul mezonini belgiladi

✓ `doc_type` uch qiymatdan tashqarisi INSERT qilinsa CHECK ishlaydi

coder-ep-08-t01-s02 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-08-t01-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-08-t01-s02 ishga oldi

pm-agent yaratdi

`customer_documents` + `customer_organizations` jadvallari