Nazoratchi review ekrani (tasdiq/qisman/rad/brak)

unknown-agent yangiladi

Yangilandi: branch, commit_sha, pr_url

qa-ep-07-t09-s04 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t09-s04 izoh qoldirdi

QA (mustaqil tekshiruv) — QABUL QILINDI. KOMPILYATSIYA: S03 xabar qilgan `const WorkReviewRequest(confirmedQty: Decimal.zero)` nuqsoni TUZALGAN — work_review_detail_cubit_test.dart:21 endi `const`siz. `flutter analyze` — No issues found; `flutter test test/features/employee/tasks` — 108/108 YASHIL (butun katalog blokdan chiqdi). AC3315 (ok): menyu — employee_work_review_entry.dart:31 denied/checking -> SizedBox.shrink(); marshrut — work_review_queue_screen.dart:37-73 ekranning OZI WorkReviewAccessCubit bilan qayta tekshiradi, deniedda WorkReviewQueueCubit umuman yaratilmaydi (GET /works ketmaydi, test worksRequested==false bilan pinlaydi) -> togridan-togri navigatsiyada ham kirib bolmaydi. Rule nomi kod oqib tasdiqlandi: work_review_access_cubit.dart:27 `static const _requiredRule = work.review;` — 07_tasks.md §7 jadvali va tasks.yaml:854 bilan AYNAN bir xil. AC3316 (ok): work_review_screen.dart:178-188 — _reasonRequired = (parse ok) && !toliq tasdiq && diapazon ichida -> qisman/rad/terminal-brak uchun izoh majburiy, _canSubmit tugmani bloklaydi. Toliq tasdiq izohsiz BLOKLANMAYDI (ortiqcha qattiqlik yoq) — test toliq tasdiqda tugma faol va sorov tanasida reject_reason YOQ ekanini tekshiradi. Server 422 REJECT_REASON_REQUIRED submitError -> AppFormErrorBanner orqali korsatiladi (work_review_detail_cubit_test.dart testi bor). AC3317 (ok): kontrakt tekshirildi — auth.yaml UserResponse/MeResponse (1438-1481) da `employee_id` YOQ, faqat user `id`; WorkResponse dagi `employee_id` esa hodim idsi. Yani client-side taqqoslash aynan "employee_id ni user_id bilan solishtirish" nuqsoniga olib kelardi — coder buni ATAYLAB qilmagan va work_review_detail_cubit.dart:17-26 da kontrakt havolasi bilan hujjatlashtirgan. Togri qaror. Serverning 409 SELF_REVIEW_NOT_ALLOWED xatosi forma bannerida chiqadi, work holati ozgarmaydi (forma joyida qoladi) — widget + cubit testlari ikkalasini ham tekshiradi. KONTRAKT MOSLIGI (maydonma-maydon): WorkReviewRequest = confirmed_qty (required, 18.4 string -> Decimal + DecimalConverter), is_brak (bool, default false), reject_reason (String?, maxLength 255 TextFieldda ham cheklangan). OYLAB TOPILGAN ENUM YOQ — tort amal (tasdiq/qisman/rad/brak) kontraktdagi confirmed_qty+is_brak matritsasidan kelib chiqadi: _effectiveIsBrak = toliq->false, qty=0->radio (rework vs terminal brak), qisman->true (R22/R23 ga mos). Pul/miqdor hamma joyda Decimal (double yoq). Offline kesh/queue yoq (queue cubit izohida online-only aniq yozilgan). Yangi rol/audience qoshilmagan. MUTATSIYA SINOVI (4/4 oldirildi, har safar faqat bitta fayl `git checkout --` bilan tiklandi): (a) huquq tekshiruvi olib tashlandi (rules.contains -> true) -> 3 test yiqildi (access cubit x2, queue screen x1); (b) bosh izohda yuborishga ruxsat (_canSubmit dan izoh sharti olib tashlandi) -> 2 test yiqildi (work_review_screen_test AC3316 x2); (c) SoD/server xatosi yutib yuborildi (submitError: null) -> 3 test yiqildi (409 SELF_REVIEW_NOT_ALLOWED, 422 REJECT_REASON_REQUIRED, widget banner testi); (d) qoshimcha — rule nomi work.review -> works.review -> 3 test yiqildi (nom testlar bilan pinlangan, tasodifiy otib ketmaydi). KUZATUV (mezonni yiqitmaydi, kelajak uchun): `/employee/work-review/:id` detal marshruti (WorkReviewScreen) oz access gateiga ega emas — ilova ichida faqat gate qilingan navbatdan ochiladi, AndroidManifestda LAUNCHERdan boshqa intent-filter yoq (tashqi deep-link mumkin emas), amalning ozi serverda 403 bilan himoyalangan, va repodagi mavjud naqsh (purchase_receipt/stock_return/write_off forma ekranlari) ham shunday. Agar keyinchalik deep-link yoqilsa, bu marshrutga ham gate qoshilishi kerak.

qa-ep-07-t09-s04 qabul mezonini belgiladi

✓ O'z work'i uchun tasdiq amali bloklanadi (SoD)

qa-ep-07-t09-s04 qabul mezonini belgiladi

✓ Qisman tasdiq va brakda izoh maydoni majburiy

qa-ep-07-t09-s04 qabul mezonini belgiladi

✓ Ekran faqat `work.review` huquqi bo'lganda ko'rinadi

coder-ep-07-t09-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t09-s04 izoh qoldirdi

TasksApi.listWorks qo'shildi (GET /works?status=submitted, S01 ustiga). WorkReviewAccessCubit — work.review rule (/auth/me) bilan butun ekranni (ro'yxat+marshrut) gate qiladi, AC3315. WorkReviewQueueScreen — nazoratchi navbati, to'rt holat. WorkReviewScreen — bitta yo'l uch natija (confirmed_qty/is_brak/reject_reason), qisman/rad/brakda izoh majburiy (submit disabled bo'ladi, AC3316); confirmed_qty=0 da rework vs terminal-brak aniq tanlanadi. SoD (AC3317): mobil ilovada joriy foydalanuvchining employee_id'si HECH QANDAY kontrakt endpoint orqali kelmaydi (users jadvalida employee_id ustuni yo'q, FK egaligi employees.user_id tomonida, 09_auth) — shuning uchun taxminiy/noaniq client-side taqqoslash ATAYLAB qilinmagan; SoD faqat serverda tekshiriladi, 409 SELF_REVIEW_NOT_ALLOWED forma banner'ida tushunarli ko'rsatiladi va amal bloklanadi (work holati o'zgarmaydi). flutter analyze toza, flutter test test/features/employee/tasks — 107/107 yashil (build muhiti ishladi, APK build qilinmadi — talab qilinmagan).

coder-ep-07-t09-s04 qabul mezonini belgiladi

✓ O'z work'i uchun tasdiq amali bloklanadi (SoD)

coder-ep-07-t09-s04 qabul mezonini belgiladi

✓ Qisman tasdiq va brakda izoh maydoni majburiy

coder-ep-07-t09-s04 qabul mezonini belgiladi

✓ Ekran faqat `work.review` huquqi bo'lganda ko'rinadi

coder-ep-07-t09-s04 fayllarni qayd etdi

21 ta fayl qayd etildi

coder-ep-07-t09-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t09-s04 ishga oldi

pm-agent yaratdi

Nazoratchi review ekrani (tasdiq/qisman/rad/brak)