Tekshiruv navbati va review modali

unknown-agent yangiladi

Yangilandi: branch, commit_sha, pr_url

team-lead-pm izoh qoldirdi

📌 KEYINGI SESSIYA UCHUN QAYD (blok emas, barg `done` qoladi) — team-lead-pm 2026-08-25. T08-S02 QA'si shu bargda ham bir xil turdagi zaiflik borligini ko'rdi: `WorkReviewQueueView.spec.ts` dagi `work.review` gate'i faqat SALBIY yo'nalishda assert qilingan ("huquqsiz ko'rsatilmaydi"). `v-can` elementni O'CHIRMAYDI, faqat `display:none` qiladi — shuning uchun `.exists()` yoki faqat salbiy assert rule kodi mutatsiyasini ushlamaydi (S02 da aynan shu mutatsiya 12/12 yashil holda omon qolgan edi). TAVSIYA ETILGAN TUZATISH (kichik): S02 dagi naqshni qo'lla — (a) rule berilganda `display !== 'none'`, (b) BOSHQA rule berilganda `display === 'none'`. Shunda assert aynan `work.review` kodiga bog'lanadi, umumiy 'auth bor' holatiga emas. Kod xato EMAS — gate ishlaydi; faqat test uni himoya qilmaydi.

qa-ep-07-t08-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t08-s01 izoh qoldirdi

QA OK — 4/4 mezon kod darajasida tasdiqlandi (commit 87576bd). AC3296: WorkReviewDialog.vue:137-140 resetForm() confirmed_qty = work.claimed_qty, visible watch (151-158) har ochilishda tiklaydi; reasonRequired = hasShortfall (115), reasonMissing canSubmit ni bloklaydi (116/124). Server 422 REJECT_REASON_REQUIRED -> work-review-errors.ts:15 xaritasi -> Izoh maydoni ostida (WorkReviewDialog.vue:308-310). compareMoney Decimal (money.ts:45-47) — 4 xona aniqlik saqlanadi (3.9999 < 4.0000 shortfall deb tanilади). AC3297: is_brak checkbox WorkReviewDialog.vue:288-291 (faqat confirmed_qty=0, R22-d/kontrakt: qisman tasdiqda server baribir true yozadi); shu holatda hasShortfall=true -> izoh majburiy, submit disabled. AC3298: WorkReviewQueueView.vue:364 :disabled=isSelfWork, sabab — Siz Tag (308-313) + title/aria-label (354-363), openReview guard (193-196). Manba: works.api.ts listMyWorks -> store loadMySubmittedWorkIds (work-review-queue.store.ts:63-78). 409 SELF_REVIEW_NOT_ALLOWED: work-review-errors.ts:39 -> dialog conflict -> onReviewConflict (view 221-225). AC3299: 30 ta yangi test (dialog 10 / store 9 / view 11). Test: npx vitest run src/modules/production -> 9 fayl, 94 test yashil. npm run lint toza, npx vue-tsc -b --noEmit exit 0. Kontrakt smoke (Prism :4010): GET /works, GET /works/me, POST /works/1/review 200. MUTATSIYA SINOVI (6/6 ushlandi, har biri git checkout bilan tiklandi): 1) confirmed_qty default = 0 -> 4 test yiqildi; 2) canSubmit dan !reasonMissing olib tashlandi -> AC3296 + brak testi yiqildi; 3) is_brak hech qachon yuborilmaydi -> 2 test yiqildi; 4) view :disabled=false + openReview guard olib tashlandi -> 2 ta AC3298 testi yiqildi; 5) 422/409 kod xaritasi buzildi -> 2 test yiqildi; 6) /works/me natijasi tashlandi -> store + 2 view testi yiqildi. Hech bir mutatsiya survive qilmadi. Repo toza: git status bosh, HEAD = 87576bd.

qa-ep-07-t08-s01 qabul mezonini belgiladi

✓ Vitest: qisman tasdiq va brak stsenariylari

qa-ep-07-t08-s01 qabul mezonini belgiladi

✓ O'z work'i qatorida tasdiq amali o'chirilgan (SoD)

qa-ep-07-t08-s01 qabul mezonini belgiladi

✓ Brak belgisi qo'yilganda izohsiz yuborib bo'lmaydi

qa-ep-07-t08-s01 qabul mezonini belgiladi

✓ `confirmed_qty` default = `claimed_qty`; kamaytirilganda izoh maydoni MAJBURIY bo'ladi

coder-ep-07-t08-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t08-s01 izoh qoldirdi

SoD (AC3298) oldindan tekshiruvi: MeResponse/auth.store da employee_id YO'Q, shu sabab GET /works/me?status=submitted (EGALIK, rule yo'q) orqali joriy user'ning O'Z submitted ishlari olinib (work-review-queue.store.ts loadMySubmittedWorkIds), navbatdagi qator id shu to'plamda bo'lsa Tekshirish tugmasi disabled + aria-label/title bilan sabab tushuntirilgan. Haqiqiy himoya server 409 SELF_REVIEW_NOT_ALLOWED (WorkReviewDialog.vue conflict yo'li bilan ushlanadi). is_brak checkbox FAQAT confirmed_qty=0 (to'liq rad) holatida ko'rsatiladi — qisman tasdiqda tasks.yaml izohiga ko'ra server brak_qty>0 bo'lsa is_brak ni baribir true deb yozadi, shuning uchun klient bu holatda is_brak yubormaydi. Testlar: npx vitest run src/modules/production (94/94 o'tdi), to'liq suite 1181/1181, lint va vue-tsc toza, npm run build muvaffaqiyatli.

coder-ep-07-t08-s01 qabul mezonini belgiladi

✓ Vitest: qisman tasdiq va brak stsenariylari

coder-ep-07-t08-s01 qabul mezonini belgiladi

✓ O'z work'i qatorida tasdiq amali o'chirilgan (SoD)

coder-ep-07-t08-s01 qabul mezonini belgiladi

✓ Brak belgisi qo'yilganda izohsiz yuborib bo'lmaydi

coder-ep-07-t08-s01 qabul mezonini belgiladi

✓ `confirmed_qty` default = `claimed_qty`; kamaytirilganda izoh maydoni MAJBURIY bo'ladi

coder-ep-07-t08-s01 fayllarni qayd etdi

12 ta fayl qayd etildi

coder-ep-07-t08-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t08-s01 ishga oldi

pm-agent yaratdi

Tekshiruv navbati va review modali