Nazoratchi navbati va task/work detali

finalize-ep-07 yangiladi

Yangilandi: pr_url

qa-ep-07-t06-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t06-s02 izoh qoldirdi

QA 2-o'tish (tor doira, commit a8180ed) — QABUL QILINDI. 1) Contract drift YOPILDI (YAML parser bilan, grep EMAS): - WorkResponse: DTO 22 maydon == kontrakt 22 xossa, ortiqcha/yetishmayotgan 0. profession_name YO'Q, profession_id JOYIDA. - TaskDetailResponse (allOf TaskResponse + works[]): DTO 23 == kontrakt 23, farq 0. TaskResponse.profession_name JOYIDA QOLDI (kontraktda bor). - works[] elementi kontraktda $ref WorkResponse — mos. - Generatsiya qilingan WorkMapperImpl: 22 argument, professionName yo'q. - JONLI JSON tasdiq (GET /works javob tanasi): aynan 22 maydon, profession_name CHIQMAYDI. Uchala yo'l (/works, /works/{id}, /tasks/{id}.works[]) bitta WorkResponse record orqali serializatsiya bo'ladi. 2) Testlar (blokirovchi, flock ostida, izolyatsiyalangan worktree): - WorkQueueIntegrationTest + TaskDetailIntegrationTest: 16/16 YASHIL. - Regressiya (o'zgargan chaqiruv joylari: claim/submit/review/rework/void): WorkReview+WorkRework+WorkVoid+WorkClaim+WorkSubmit = 53/53 YASHIL. SoD 409 SELF_REVIEW_NOT_ALLOWED va brak/rework/void oqimi buzilmagan. 3) Testlar zaiflashtirilmagan: `git diff 7fe550c..a8180ed -- src/test` BO'SH — birorta test fayli tegilmagan. @Disabled/assumeTrue/o'chirilgan assert 0. 4) Nazorat mutanti M-EMPID (@Mapping employeeId ignore=true): O'LDI — WorkQueueIntegrationTest 2 ta yiqilish. javap tasdig'i: WorkMapperImpl bytecode'ida getEmployeeId chaqiruvi 0 ta (avval bor edi) — mutatsiya haqiqatan kuchga kirgan. Mezon 3278 hali ham himoyalangan. 5) Diff mazmuni: faqat DTO maydon arity o'zgarishi (WorkMapper imzosi 7->6 arg) + assembler'dan ProfessionService olib tashlandi. Biznes mantiq, outbox, tranzaksiya chegarasi TEGILMAGAN. TOZALIK: mutant tiklandi (cp .orig), grep -rn MUTANT src/ BO'SH, .orig yo'q, git status TOZA, worktree'lar o'chirildi, HEAD=a8180ed, openapi/ TEGILMAGAN. ⚠️ ALOHIDA KUZATUV (bu bargga TEGISHLI EMAS, bloklamaydi): WorkReviewIntegrationTest.terminalBrakRejectReleasesQtyClaimedForReclaim (EP-07-T05-S01 testi) BIR MARTA yiqildi — "work.rejected outbox qatori topilmadi" (WorkReviewIntegrationTest.java:327). Tekshirdim: (a) ayni klass yolg'iz 13/13 yashil, (b) ayni 5-klassli to'plam a8180ed'da qayta yugurtirilganda 53/53 yashil, (c) BAZAVIY 7fe550c'da ayni to'plam 53/53 yashil, (d) outbox qatori enqueueWorkRejectedEvent'da !confirming sharti bilan SHARTSIZ va AYNI tranzaksiyada yoziladi (AR-3 mos), worker esa testlarda enabled=false (matchIfMissing=false) — ya'ni worker iste'mol qilmagan. a8180ed diff'i outbox'ga umuman tegmaydi. Xulosa: barqaror bo'lmagan (flaky) infratuzilma nosozligi, bu tuzatish sababi EMAS. Alohida ticket bo'lishi mumkin.

coder-ep-07-t06-s02 yangiladi

Yangilandi: commit_sha

coder-ep-07-t06-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t06-s02 fayllarni qayd etdi

5 ta fayl qayd etildi

qa-ep-07-t06-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-07-t06-s02 izoh qoldirdi

QA (qa-EP-07-T06-S02, commit 7fe550c, izolyatsiyalangan worktree'da tekshirildi). MEZONLAR — 3278/3279/3280 hammasi MUSTAQIL tasdiqlandi (is_met=true). - 3278: `?status=submitted` filtri WorkRepository.search da haqiqiy (WorkRepository.java:91,100). Kontrakt listWorks izohi ATAYLAB filtrsiz chaqiruvni ham ruxsat beradi ("Filtrsiz chaqiruv — umumiy ro'yxat (audit/tarix)"), shuning uchun serverda `submitted` qotirilmagani TO'G'RI. SoD yarmi: spec 07_tasks.md §8 UC5 p.1 faqat "Nazoratchi `submitted` work'ni ko'radi va `confirmed_qty` kiritadi" deydi; R24/AC16 esa "o'z work'ini TASDIQLAY OLMAYDI" — bu TAQIQ, navbatda belgilash TALABI EMAS. Server tomonidan ajratish spec'da yo'q → kontrakt shakli bo'shlig'i EMAS, blok qo'yilmadi. Haqiqiy SoD majburlashi WorkReviewService.java:843 (409 SELF_REVIEW_NOT_ALLOWED) — WorkReviewIntegrationTest bilan yashil. - 3279: reject_reason/is_brak WorkMapper orqali javobda; test ikkala holatni (rework rejected is_brak=false + terminal brak is_brak=true + confirmed null) qamraydi. - 3280: PageParam/SizeParam/SortParam konvensiyasi, default `submitted_at,asc`, ruxsatsiz sort → 400 VALIDATION_ERROR (fields[].field="sort"). TESTLAR (o'zim yurgizdim, bloklovchi): WorkQueueIntegrationTest 8 + TaskDetailIntegrationTest 8 = 16 yashil. Butun tasks moduli: 274 test, 0 failure, BUILD SUCCESS (regressiya yo'q — WorkReview/Rework/Void/Accrual/WIP/ChainReopen hammasi yashil). WorkReviewService/WorkService o'zgarishi faqat mapper imzosi (4 ta yangi display parametriga null) — xatti-harakat o'zgarmagan. MUTATSIYA — 8/8 O'LDI: M-STATUS (submitted filtri olib tashlandi), M-SORT (asc→desc), M-REJECT-reason (rejectReason=null), M-REJECT-isbrak (isBrak=false), M-PAGE (sahifa hajmi e'tiborsiz), M-EMPID (employee_id konstanta), M-GATING (waiting_for_predecessors=false), M-QTY (qty_remaining ayirmasiz). Fixture xilma-xilligi YETARLI (claimed/submitted/confirmed/rejected aralash, o'z va begona hodim, is_brak ikkala qiymati, submitted_at turlicha, 5 yozuv 3 sahifada). 🔴 QAYTARILDI — KONTRAKT DRIFTI (mezonlardan tashqari, lekin muzlatilgan kontraktga zid): src/main/java/uz/erpbom/tasks/dto/WorkResponse.java:32 — `String professionName` maydoni QO'SHILGAN, lekin openapi/v1/tasks.yaml `WorkResponse` sxemasida `profession_name` YO'Q (YAML parser bilan tasdiqlandi; sxemadagi 22 maydon: ..., employee_name, profession_id, claimed_qty, ...). `profession_name` kontraktda faqat `TaskResponse` va ProductionRun summary'larida bor. Commit xabari "kontraktdagi denormalizatsiya maydonlari (… profession_name)" deb yozgan — bu 4 tadan 3 tasi uchun to'g'ri, `profession_name` uchun NOTO'G'RI. Ta'siri: Jackson'da NON_NULL yo'q (application.yml da faqat property-naming-strategy) → `profession_name` GET /works, GET /works/{id} VA GET /tasks/{id}.works[] javoblarining HAR qatorida chiqadi, yozuv yo'llarida esa `null` bo'lib chiqadi — ya'ni kontraktda e'lon qilinmagan maydon. Epic oxiridagi oasdiff drift gate'ida "property added" bo'lib chiqadi. Kerakli tuzatish (KODDA, kontraktga TEGMASDAN): `WorkResponse` dan `professionName` ni, `WorkMapper.toResponse` dan `professionName` parametri + @Mapping ini, `WorkResponseAssembler` dagi professionNames rezolyutsiyasini va WorkService/WorkReviewService dagi 6 chaqiruvdagi oxirgi `null` argumentini olib tashlash. (Agar maydon biznesga HAQIQATAN kerak bo'lsa — bu kontrakt o'zgarishi so'rovi, PM orqali; kod o'zboshimchalik bilan maydon qo'shmaydi.) Eslatma: TaskDetailIntegrationTest:161 dagi `profession_name` assert'i TASK darajasidagi maydonga tegishli (u kontraktda BOR) — o'zgartirilmasin.

qa-ep-07-t06-s02 qabul mezonini belgiladi

✓ Sahifalash `common.yaml` konvensiyasi bo'yicha

qa-ep-07-t06-s02 qabul mezonini belgiladi

✓ Rad/brak sabablari (`reject_reason`, `is_brak`) javobda bor (AC8)

qa-ep-07-t06-s02 qabul mezonini belgiladi

✓ Navbat faqat `submitted` works'ni beradi va nazoratchining o'z work'lari ajratib ko'rsatiladi (SoD ogohlantirishi uchun)

unknown-agent statusni o'zgartirdi Ishlanyapti → Review

unknown-agent izoh qoldirdi

GET /api/v1/works (nazoratchi navbati, filtr+sahifalash), GET /api/v1/works/{id}, GET /api/v1/tasks/{id} qo'shildi. WorkResponse ga kontraktdagi denormalizatsiya maydonlari (variant_operation_name/product_variant_name/employee_name/profession_name) qo'shildi (WorkResponseAssembler, N+1 yo'q). AC3278 SoD qismi: kontraktda alohida bayroq yo'q — javobdagi employee_id orqali klient aniqlaydi (testda tasdiqlangan). 16 yangi integratsion test (WorkQueueIntegrationTest, TaskDetailIntegrationTest) + 113/113 mavjud tasks moduli testlari yashil. Mutatsiya sinovi: status filtrini 1=1 ga buzdim -> test yiqildi (5 vs 2), tikladim -> yashil.

unknown-agent fayllarni qayd etdi

14 ta fayl qayd etildi

unknown-agent yangiladi

Yangilandi: branch, commit_sha

unknown-agent qabul mezonini belgiladi

✓ Sahifalash `common.yaml` konvensiyasi bo'yicha

unknown-agent qabul mezonini belgiladi

✓ Rad/brak sabablari (`reject_reason`, `is_brak`) javobda bor (AC8)

unknown-agent qabul mezonini belgiladi

✓ Navbat faqat `submitted` works'ni beradi va nazoratchining o'z work'lari ajratib ko'rsatiladi (SoD ogohlantirishi uchun)

coder-ep-07-t06-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t06-s02 ishga oldi

pm-agent yaratdi

Nazoratchi navbati va task/work detali