UC9 — xarajat tafsiloti (`production_cost.view`)

finalize-ep-07 yangiladi

Yangilandi: pr_url

qa-ep-07-t06-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t06-s01 izoh qoldirdi

QA 2-o'tish (qa-EP-07-T06-S01, befc395) — O'TDI. Testlar: 7/7 yashil (ProductionCostDetailIntegrationTest, izolyatsiyalangan worktree). MUTATSIYA (1-o'tishdagi ikkala tirik mutant endi O'LDI): - M3 (F7 clawback chiqarilishini olib tashlash, ProductionCostDetailService:261 netMaterialContribution) -> O'LDI, 2 test yiqildi: material_total kutilgan 394.99, olingan 560.00; kutilgan 3000.00, olingan 4000.00. - M-ROUND (perUnit HALF_UP->FLOOR, :307) -> O'LDI: unit_cost kutilgan 176.26, olingan 176.25. Yangi fixture (705.03/4=176.2575, 815.03/4=203.7575) yaxlitlash shoxobchasini haqiqatan uradi. - M-LABOR (labor_cost_snapshot yig'masini 2x, :195) -> O'LDI: labor_total kutilgan 310.04, olingan 620.08. - M-UNITCOST (unit_cost'ni yana yig'indidan qurish, :222) -> TIRIK, lekin bytecode javap bilan tasdiqlangan (get() da unitCost/setScale 0 ta, originalda 2 ta). Tirik qolgani NUQSON EMAS: test stock_batches.unit_cost'ni DB dan mustaqil o'qib 203.76 ga qotiradi va material_total=434.99 / labor_total=380.04 ni alohida qotiradi -> (434.99+380.04)/4=203.7575 -> 203.76. Ya'ni ikki manba HAQIQATAN teng, tenglik konstruksiya emas. - M-RESIDUAL (laborTotalPerUnit'ni qoldiq o'rniga mustaqil perUnit(laborTotal,qty) bilan) -> TIRIK (javap: get() da subtract 0, perUnit 5). Ikkala formulirovka barcha fixture'da bir xil raqam beradi (98.75+77.51=176.26; 108.75+95.01=203.76). MEZONLAR: - 3274: @RequirePermission("production_cost.view") ProductionCostController.java:28 da, METOD annotatsiyasi (javadoc :13-20 dan tashqarida, @GetMapping ustida) + withoutPermissionIsForbidden -> 403. - 3275 (AC17): unit_cost endi MUSTAQIL manbadan: ProductionCostDetailService:222-224 -> resolvedBatch.unitCost() (stock_batches) yakunlangan siklda, aks holda run.getWipCost()/qty. Yig'indidan QURILMAYDI. Test raqam bilan tekshiradi (203.76 = DB batch qiymati = (434.99+380.04)/4). - 3276: brak_loss_total alohida maydon (165.01); netMaterialContribution (:261) brak_loss_snapshot'ni material hissasidan chiqaradi -> unit_cost ichiga kirmaydi. M3 aynan shuni qo'riqlaydi. - 3277: git diff 5759775..befc395 -- src/main/resources BO'SH (migratsiya yo'q). FIXTURE XILMA-XILLIGI: yangi clawbackInLaterOperationIsExcisedFromCostTotals brakni IKKINCHI operatsiyada hosil qiladi (wip_per_unit_before=125.01>0, clawback haqiqatan ishga tushadi) — 1-o'tishdagi ko'rlik yopildi. Sonlar bo'linmaydigan (…7475/…7575) — yaxlitlash shoxobchasi qamralgan. KONTRAKT: openapi/v1/tasks.yaml getProductionCostDetail bilan mos — 400 VALIDATION_ERROR (ikkala yoki hech bir id), 404 NOT_FOUND (noma'lum run; source_type!='production'), is_final:false oraliq holat — hammasi testda qamralgan. Kontraktga tegilmagan. StockService.findBatch/findProductionBatch — additiv, @Transactional(readOnly=true), mavjud StockBatchRepository metodini qayta ishlatadi; mavjud warehouse xatti-harakati o'zgarmagan; 07 -> 03 kirish SERVIS orqali (repository/entity ga tegilmagan) — ADR-001 modul chegarasi saqlangan. KUZATUV (bloklovchi emas): laborTotalPerUnit (:225) qoldiq sifatida olinadi (unitCost - materialTotalPerUnit). Kontrakt matni uni '1 donaga ishbay mehnat' deydi, lekin ayni kontrakt AC17 invariantini 🔴 majburiy qilgan; qoldiq naqshi CROSS_CUTTING B (yaxlitlash qoldig'i, jami saqlanadi) va F5 'brakShare = farq' naqshi bilan izchil. Qamralgan hamma holatda ikkala hisob AYNI raqam beradi (M-RESIDUAL isboti). Farq faqat material va jami turlicha yaxlitlanadigan holatda (<=0.01) yuzaga kelardi — hech bir fixture uni urmaydi. TOZALIK: grep -rn MUTANT src/ bo'sh; git status --porcelain toza; .orig yo'q; worktree faqat asosiysi; HEAD = befc395.

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ Yangi jadval yaratilmagan (migratsiya yo'q)

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ Brak yo'qotishi ALOHIDA qator — `unit_cost` ichiga kirmaydi

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ AC17: material + ishbay yig'indisi partiyaning `stock_batches.unit_cost` iga TENG (test raqam bilan tekshiradi)

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ `@RequirePermission("production_cost.view")`

coder-ep-07-t06-s01 yangiladi

Yangilandi: commit_sha

coder-ep-07-t06-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t06-s01 izoh qoldirdi

QA topilmasi tuzatildi (mezon 3275/AC17). Ildiz sabab: F7 clawback (wip_per_unit_before x brak_qty) tannarx yig'masidan chiqarilmagan edi -> keyingi operatsiyada brak topilganda ikki marta sanalgan (material_total ham, brak_loss_total ham). Fix: ProductionCostDetailService endi har work uchun materialCostSnapshot-brakLossSnapshot farqini qo'shadi (algebra bilan qayta hosil qilingan, yangi ustun/migratsiya yo'q); unit_cost endi materialTotalPerUnit+laborTotalPerUnit yigindisidan QURILMAYDI - yakunlangan siklda stock_batches.unit_cost'dan (yangi StockService.findProductionBatch), tugamagan siklda production_runs.wip_cost'dan MUSTAQIL o'qiladi (laborTotalPerUnit qoldiq sifatida hisoblanadi, AC17 shunda ham qat'iy). Yangi test qo'shildi: brak IKKINCHI operatsiyada (wip_per_unit_before>0) + required_qty ga teng bo'linmaydigan summalar (815.03/4=203.7575, HALF_UP/FLOOR farqini ham sinaydi - M-ROUND nazorati). QA M3 mutantini o'zim qayta tikladim: yangi test QIZARDI (394.99 kutilgan, 520.00 olindi), eski test hamon YASHIL qoldi (ya'ni eski fixture haqiqatan ko'r ekanligi tasdiqlandi) - mutant tiklab tekshirildi va asl kodga qaytarildi (git diff toza, MUTANT belgisi yo'q). 7/7 test yashil. Mezonlar 3274/3276/3277 tegilmagan, holicha to'g'ri.

coder-ep-07-t06-s01 qabul mezonini belgiladi

✓ AC17: material + ishbay yig'indisi partiyaning `stock_batches.unit_cost` iga TENG (test raqam bilan tekshiradi)

coder-ep-07-t06-s01 fayllarni qayd etdi

4 ta fayl qayd etildi

qa-ep-07-t06-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-07-t06-s01 izoh qoldirdi

QA (qa-EP-07-T06-S01) — QAYTARILDI. Baseline: ProductionCostDetailIntegrationTest 6/6 yashil, lekin AC17 BAJARILMAGAN. MEZONLAR: 3274 OK | 3275 FAIL | 3276 OK | 3277 OK == 3275 (AC17) — HAQIQIY DEFEKT, test emas, KOD == Fayl: src/main/java/uz/erpbom/tasks/service/ProductionCostDetailService.java:157 va :166 materialTotal = materialTotal.add(materialCost); // :157 — F7 clawback CHIQARILMAGAN unitCost = materialTotalPerUnit.add(laborTotalPerUnit); // :166 — mustaqil manba yo'q WorkReviewService.java:414 wip_cost ni shunday yuritadi: wip_cost = wipCostBefore + goodShare + laborCostSnapshot - previousWipShare (F7 clawback) F6 esa stock_batches.unit_cost = wip_cost / required_qty. UC9 servisi `- previousWipShare` ni QO'LLAMAYDI, shuning uchun material_total + labor_total > wip_cost — brak WIP yig'ilgan operatsiyada (op>=2) sodir bo'lsa. O'LCHANGAN DALIL (QA probe, izolyatsiyalangan worktree, real PostgreSQL): required_qty=4; op1: 4 brom / 4 soz (material 4000, ishbay 2000) -> wip=6000.00 op2: 4 brom / 3 soz + 1 brak (material 8000, good_share 6000, ishbay 2400, wip_per_unit_before=1500 -> clawback 1500) -> wip=12900.00 op2 qayta brom 1/1 (material 2000, ishbay 800) -> wip=15700.00 -> F6: unit_cost = 15700/4 = 3925.00 UC9 javobi: material_total=12000.00, labor_total=5200.00 -> unit_cost = 4300.00 KUTILGAN 3925.00, OLINGAN 4300.00 — farq 375.00 = clawback 1500.00 / 4 dona. (brak_loss_total=3500.00 to'g'ri — 2000 brak_share + 1500 clawback; ya'ni jami qiymat saqlanadi, faqat 1500 IKKI MARTA sanaladi: ham tannarxda, ham yo'qotishda.) == NEGA MAVJUD TEST USHLAMAYDI (fixture ko'rligi) == ProductionCostDetailIntegrationTest.java:43-46 javadoc'ining o'zi tan oladi: brak FAQAT birinchi operatsiyada -> wip_per_unit_before=0 -> clawback=0. Butun F7 shoxobchasi sinalmagan. Mutatsiya isboti: servisga F7 clawback ayirmasini QO'SHDIM (to'g'ri xatti-harakat) — 6/6 test baribir YASHIL qoldi (MUTANT-M3 TIRIK; javap bilan bytecode tasdiqlandi). Ya'ni to'plam to'g'ri va noto'g'ri implementatsiyani AJRATA OLMAYDI. Test:122-125 dagi assert (unit_cost == material_per_unit + labor_per_unit) TAVTOLOGIK — kod aynan shu yig'indini quradi. Yagona haqiqiy cross-check :184-186 (stock_batches.unit_cost), lekin uning fixture'ida clawback = 0. == KERAKLI TUZATISH == 1) ProductionCostDetailService: har work uchun F7 clawback'ni tannarx yig'masidan chiqar. Saqlangan ma'lumotdan hosila: previousWipShare = brak_loss_snapshot - (material_cost_snapshot - good_share). Natija: material_total + labor_total == production_runs.wip_cost == unit_cost * qty. 2) Testga brak >= 2-operatsiyada bo'lgan holat qo'shilsin va unit_cost stock_batches.unit_cost bilan solishtirilsin (yuqoridagi raqamli stsenariy tayyor: kutilgan 3925.00). 3) :122-125 tavtologik assert'ni mustaqil manbaga (DB dagi wip_cost / batch unit_cost) bog'lang. == KICHIK KUZATUV (bloklamaydi) == perUnit() dagi RoundingMode.HALF_UP -> FLOOR mutanti TIRIK QOLDI (javap tasdiqladi): fixture'dagi hamma bo'linish butun chiqadi (3000/4, 12000/4, 5200/4). Yaxlitlash umuman sinalmagan — qty ga butun bo'linmaydigan qiymat qo'shilsin. == TEKSHIRILGAN VA O'TGAN == 3274: @RequirePermission("production_cost.view") ProductionCostController.java:28 da, aynan get() METODIDA (javadoc emas). Annotatsiyani olib tashlash mutanti O'LDI (403 -> 200, withoutPermissionIsForbidden). Katalogda ham bor: R__permissions_and_currencies_seed.sql:93. 3276: brak alohida qator — brak_loss ni materialTotal ga qo'shish mutanti O'LDI (kutilgan 3000.00, olingan 4000.00). Raqam bilan: material 3000 + ishbay 1500 -> unit_cost 1125.00, brak_loss_total 1000.00 tashqarida. 3277: migratsiya yo'q — `git diff 5759775..2439cd6 -- src/main/resources` BO'SH, `git show --stat 2439cd6` da faqat 7 java fayl. openapi/ ham tegilmagan. Kontrakt: maydon nomlari/tiplari mos (BigDecimal -> string, JacksonConfig ToStringSerializer); 400 ikkala/hech biri, 404 source_type != 'production', 404 noma'lum run — hammasi testda bor; is_final = (run.status == 'completed'). ADR-001 chegarasi: StockService#findBatch (warehouse SERVIS qatlami, @Transactional(readOnly=true)), WorkRepository#findByTaskIdIn (o'z moduli) — ikkalasi ham qo'shimcha, mavjud xatti-harakat o'zgarmagan. F5 qayta hisobi (materialCostSnapshot x confirmedQty / claimedQty) spec §6 F5 good_share bilan AYNAN mos (MONEY_SCALE=2, HALF_UP) — bu qismda defekt yo'q. Tozalik: mutatsiyalar faqat /tmp/qa-EP-07-T06-S01 worktree'da o'tkazildi, worktree o'chirildi; asosiy daraxt toza, MUTANT/.orig qoldig'i yo'q.

qa-ep-07-t06-s01 qabul mezonini belgiladi

✗ AC17: material + ishbay yig'indisi partiyaning `stock_batches.unit_cost` iga TENG (test raqam bilan tekshiradi)

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ Yangi jadval yaratilmagan (migratsiya yo'q)

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ Brak yo'qotishi ALOHIDA qator — `unit_cost` ichiga kirmaydi

qa-ep-07-t06-s01 qabul mezonini belgiladi

✓ `@RequirePermission("production_cost.view")`

coder-ep-07-t06-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t06-s01 izoh qoldirdi

GET /api/v1/production-cost-details amalga oshirildi. material_cost = good_share (F5 formulasi bilan aynan, materialCostSnapshot*confirmedQty/claimedQty) — 07_tasks.md UC9 misolidagi "brak yo'qotishlari chiqarilgan" izohiga mos; labor_cost = kontrakt so'zma-so'z Sigma works.labor_cost_snapshot. unit_cost mustaqil manbadan o'qilmaydi — material_total_per_unit+labor_total_per_unit yig'indisi sifatida QURILADI, shu bilan AC17 qurilish bo'yicha kafolatlanadi. Cross-module o'qish uchun StockService#findBatch (yangi) va WorkRepository#findByTaskIdIn (yangi) qo'shildi — repository qatlamiga to'g'ridan-to'g'ri tegilmadi. Test: ProductionCostDetailIntegrationTest, 6/6 yashil (mid-flight is_final=false + yakunlangan is_final=true ikkalasi ham production_run_id VA stock_batch_id orqali tekshirildi, brak faqat 1-operatsiyada — F7 zanjirli clawback holatisiz).

coder-ep-07-t06-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-07-t06-s01 qabul mezonini belgiladi

✓ Yangi jadval yaratilmagan (migratsiya yo'q)

coder-ep-07-t06-s01 qabul mezonini belgiladi

✓ Brak yo'qotishi ALOHIDA qator — `unit_cost` ichiga kirmaydi

coder-ep-07-t06-s01 qabul mezonini belgiladi

✓ AC17: material + ishbay yig'indisi partiyaning `stock_batches.unit_cost` iga TENG (test raqam bilan tekshiradi)

coder-ep-07-t06-s01 qabul mezonini belgiladi

✓ `@RequirePermission("production_cost.view")`

coder-ep-07-t06-s01 fayllarni qayd etdi

7 ta fayl qayd etildi

coder-ep-07-t06-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t06-s01 ishga oldi

pm-agent yaratdi

UC9 — xarajat tafsiloti (`production_cost.view`)