`ProductionOutboxWorker` + notification hodisalari (R3/R30, §10)

finalize-ep-07 yangiladi

Yangilandi: pr_url

qa-ep-07-t05-s04 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t05-s04 izoh qoldirdi

QA qayta tekshiruv (qa-EP-07-T05-S04), commit 5759775 — QABUL QILINDI, 6/6 mezon. Status: done. === AC3323 ✓ (D1 tuzatildi — endi HAQIQIY dalil bor) === Yangi test: ProductionOutboxWorkerTest#createFromOrderEvent_failsAfterRunAndTasksAreStaged_rollsBackAllThreeTables_thenRetriesWithBackoff. Xato endi zanjirning ENG OXIRGI operatorida (OP2 `task.available`) `@MockitoSpyBean` orqali inject qilinadi — bu paytda `production_runs`, IKKALA `tasks` va OP1 ning `task.available` qatori ALLAQACHON haqiqatan yozilgan (spy sukut bo'yicha real metodni chaqiradi). Ikki mutant bilan tekshirildi (izolyatsiyalangan worktree /tmp/qa2-EP-07-T05-S04 @ 5759775): - M3b (`createFromOrder` ning birinchi qatoriga shartsiz `throw`) — a70a373 da TIRIK qolgan edi, endi O'LDI: rollback testi `verify(times(2)) enqueueIfAbsent(task.available...)` da yiqiladi ("Argument(s) are different / Wanted but not invoked"). Demak "yozuvlar haqiqatan bajarilgan" da'vosi qoplangan. - M11 (`@Transactional(noRollbackFor = RuntimeException.class)`) — O'LDI aynan kerakli assertion bilan: ProductionOutboxWorkerTest.java:297 `[production_runs rollback bo'lishi kerak] expected: 0 but was: 1`. Demak rollback assertion'ining o'zi ham yuk ko'taryapti, tautologik emas. Test endi UCHALA jadvalni tekshiradi: `production_runs`, `tasks` (order_id bo'yicha) va `production_outbox` (`task.available`, yozilgan task id'lari bo'yicha) — hammasi 0; 10 urinishdan keyin ham qoldiq yo'q. === AC3327 ✓ (D2 tuzatildi) === ProductionRunCreationService: `createManual` (~203-qator) endi `createFromOrder` (~285-qator) bilan AYNI yordamchi metodni — `enqueueTaskAvailableEvent(task)` — chaqiradi; ikkala metod ham `@Transactional` (159 / 237-qator), dedup kaliti bir xil format (`task.available:task:{id}`), payload bir xil (`task_id`, `production_run_id`, `variant_operation_id`, `profession_id`). Klass javadoci spec asosini (R2 "har ikkalasida keyingi jarayon bir xil", §8 UC2 3-qadam "Notification", R3) to'g'ri keltirgan. Eski `verifyNoInteractions(productionOutboxRepository)` MUSBAT tasdiqqa aylantirilgan (zaif emas — captor bilan event_type/object_type/object_id/dedup_key/payload maydonlari tekshiriladi). Mutantlar: - M10 (`createManual` dan `enqueueTaskAvailableEvent` olib tashlandi) — O'LDI, ProductionRunCreationServiceTest'ning 3 ta testi yiqildi (`createManual_createsRunAndOneTaskPerOperation...`, `createManual_writesWarningOutboxRowWhenNormMissing...`, `createManual_writesNoWarningWhenBothNormAndRatePresent`). - M12 (dedup kaliti `task.available:task:{id}` -> `task:{id}`) — O'LDI (kalit formati qoplangan). - M13 (payload'dan `profession_id` olib tashlandi) — O'LDI IKKALA test klassida (unit: NPE ProductionRunCreationServiceTest:210; integratsion: ProductionOutboxWorkerTest:212). Demak "kasbi bo'yicha hodimlarga" qismi ham qoplangan. R28 qayta ochilishi avvalgidek `chain.reopened` bilan qoplangan (WorkReviewService#enqueueChainReopenedEvent, payload'da `profession_id`; V28 shu hodisani R28 ga biriktirgan) — worker uni NotificationPort'ga uzatadi. === REGRESSIYA (o'zim yurgizdim, 5759775, qulf ostida, bloklovchi) === `createManual` o'zgargani uchun production_outbox/createManual ga tegadigan HAMMA test klassi yurgizildi — 13 klass, JAMI 96 test, 0 failure / 0 error: ProductionOutboxWorkerTest 5/5 · ProductionRunCreationServiceTest 11/11 · AbstractOutboxWorkerTest 5/5 · WorkReviewIntegrationTest 13/13 · ProductionOutboxNormOrRateMissingMigrationTest 5/5 · ProductionRunControllerIntegrationTest 7/7 · ProductionOutboxMigrationTest 17/17 · WorkReviewChainReopenIntegrationTest 7/7 · WorkReviewProductionInIntegrationTest 4/4 · WorkReworkIntegrationTest 6/6 · WorkSubmitIntegrationTest 6/6 · ProductionOrderIntakePortTest 7/7 · WorkReviewServiceAccrualOrderTest 3/3. Oldingi 4 mezon (AC3324/3325/3326/3328) a70a373 da mutatsiya bilan tasdiqlangan edi, bu commit ularga tegmagan — qayta tekshirilmadi. Asosiy ish daraxti tegilmagan (5759775, toza), worktree o'chirildi, `grep -rn MUTANT src/` bo'sh, `.orig` qoldiq yo'q.

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ `task.available` hodisasi task yaratilganda va R28 qayta ochilishida kasbi bo'yicha hodimlarga mo'ljallanadi

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ AC10: hodisa qatorlari biznes yozuv bilan BIR tranzaksiyada yoziladi (rollback bo'lsa outbox qatori ham yo'q)

coder-ep-07-t05-s04 yangiladi

Yangilandi: commit_sha

coder-ep-07-t05-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t05-s04 fayllarni qayd etdi

3 ta fayl qayd etildi

coder-ep-07-t05-s04 ishga oldi

qa-ep-07-t05-s04 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-07-t05-s04 izoh qoldirdi

QA (qa-EP-07-T05-S04), commit a70a373 — QAYTARILDI: 4/6 mezon o'tdi, 2 ta yiqildi. O'TDI: AC3324, AC3325, AC3326, AC3328 (mutatsiya bilan tasdiqlandi — pastga qara). === ✗ AC3327 — `task.available` FAQAT order oqimida yoziladi, QO'LDA yaratishda YO'Q === Fayl: src/main/java/uz/erpbom/tasks/service/ProductionRunCreationService.java - createFromOrder() (~277-qator) har task uchun enqueueTaskAvailableEvent(task) chaqiradi; - createManual() (~189-201-qator) CHAQIRMAYDI — faqat checkNormAndRateAvailability(). - Buni test ham qotirgan: src/test/java/uz/erpbom/tasks/service/ProductionRunCreationServiceTest.java:184 — `verifyNoInteractions(productionOutboxRepository)`. Spec BO'SHLIG'I EMAS, spec ANIQ javob beradi (07_tasks.md): - §8 UC2 (qo'lda sikl) 3-qadam: "Notification."; - §5 R2: "Har ikkalasida keyingi jarayon BIR XIL"; - §5 R3: "Yaratilishda: yangi task status=new; tizim shu operatsiya kasbi bo'yicha ... hodimlarga notification yuboradi" — origin bo'yicha cheklanmagan. KUTILGAN: createManual() ham har yaratilgan task uchun `task.available` outbox qatorini AYNI tranzaksiyada yozsin (dedup kaliti bir xil format), ProductionRunCreationServiceTest:184 mos ravishda yangilansin (verifyNoInteractions -> verify(...times(N)) va payload/dedup_key tekshiruvi). R28 qayta ochilishi qismi QOPLANGAN (defekt emas): WorkReviewService#enqueueChainReopenedEvent `chain.reopened` yozadi, payload'da `profession_id` bor, worker uni NotificationPort'ga uzatadi (V28 izohi shu hodisani R28 ga biriktirgan). === ✗ AC3323 — rollback/atomiklik testi BO'SH (vacuous) === Fayl: src/test/java/uz/erpbom/tasks/service/ProductionOutboxWorkerTest.java:200-243 `createFromOrderEvent_failsAtomically_noRunTaskOrOutboxRowLeaksOnRollback_thenRetriesWithBackoff` fixture'i `bogusVariantId = 999_999_999` ishlatadi -> createFromOrder() BIRINCHI operatorida (productVariantService.get) yiqiladi, ya'ni HECH QANDAY yozuv boshlanmaydi. `assertThat(runCount).isZero()` (226-qator) shu sabab har doim to'g'ri — u "rollback bo'ldi" ni "umuman yozilmadi" dan AJRATA OLMAYDI. Test nomida `noRunTaskOrOutboxRowLeaks` deyilgan bo'lsa-da, `tasks` va `production_outbox` (`task.available`) qatorlari UMUMAN tekshirilmaydi. ISBOT (mutatsiya M3b, izolyatsiyalangan worktree'da): createFromOrder() ning eng birinchi qatoriga shartsiz `throw new BusinessConflictException(...)` qo'yildi -> shu rollback testi BARIBIR YASHIL o'tdi (faqat happy-path testi yiqildi). Demak AC3323 ni hech bir assert qo'riqlamayapti. KUTILGAN: xato run+tasklar+`task.available` qatorlari YOZILGANDAN KEYIN yuz beradigan test kerak (masalan mavjud bo'lmagan organization_id -> tasks INSERT'da FK buzilishi, yoki required_qty CHECK buzilishi), va assert: `production_runs` (order_id bo'yicha) = 0, `tasks` (shu run bo'yicha) = 0 VA `production_outbox WHERE event_type='task.available'` = 0. Ishlab chiqarish kodi o'zi to'g'ri (@Transactional createFromOrder ustida turibdi) — yetishmayotgani DALIL. === TEST NATIJALARI (o'zim yurgizdim, worktree /tmp/qa-EP-07-T05-S04 @ a70a373) === ProductionOutboxWorkerTest 5/5 · ProductionRunCreationServiceTest 11/11 · AbstractOutboxWorkerTest 5/5 · WorkReviewIntegrationTest 13/13 · ProductionOutboxNormOrRateMissingMigrationTest 5/5 · ProductionRunControllerIntegrationTest 7/7 — jami 46, 0 failure. Coder da'vosi tasdiqlandi. === MUTATSIYA TEKSHIRUVI (9 mutant, izolyatsiyalangan worktree) === O'LDIRILDI (mezon haqiqatan qoplangan): - M1 `FOR UPDATE SKIP LOCKED` -> `FOR UPDATE` (AbstractOutboxWorker:142) -> skipLocked testi 3s timeout bilan yiqildi. AC3324 ✓ - M2a backoffDelay() -> Duration.ZERO -> "eksponensial backoff" asserti yiqildi (test:220). AC3325 ✓ - M2b maxAttempts 10 -> 12 (OutboxWorkerConfig.defaults) -> "10-urinishdan keyin failed" yiqildi. AC3325 ✓ - M4 repository'dan `ON CONFLICT ... DO NOTHING` olib tashlandi -> ProductionOutboxWorkerTest TIRIK QOLDI (5/5 yashil), lekin ProductionOutboxNormOrRateMissingMigrationTest DataIntegrityViolationException bilan yiqildi -> AC3326 mavjud test bilan qoplangan ✓ (eslatma: bu bargning o'z testi dedup'ni O'ZI yozgan SQL bilan tekshiradi, ishlab chiqarish yozuvchisi bilan emas). - M5 createFromOrder run.origin -> 'manual' -> yiqildi. AC3328 ✓ - M6 task.order_id -> null -> yiqildi (test:164). AC3328 ✓ - M8 created_by_user_id -> system EMAS boshqa user -> yiqildi ("R31 — avto oqim muallifi"). AC3328 ✓ (diqqat: system user id = 1, shuning uchun `1L` qattiq yozilgan mutant EKVIVALENT bo'lardi) - M9 `new BigDecimal(qty.asText())` -> `qty.decimalValue()` -> yiqildi (aniqlik yo'li qoplangan). ✓ TIRIK QOLDI (qoplanmagan): - M3b createFromOrder boshida shartsiz throw -> rollback/atomiklik testi yashil qoldi. AC3323 ✗ === PM SHUBHALARIGA JAVOB === (a) `erpbom.outbox.production.enabled` sukut=false worker'ni testda O'LIK QILMAGAN: ProductionOutboxWorkerTest worker'ni `new ProductionOutboxWorker(...)` bilan qurib `runOnce()` chaqiradi, ya'ni HAQIQIY claim/process/finalize yo'li yuradi — buni M1/M2a/M2b (AbstractOutboxWorker ichidagi mutantlar) o'ldirgani isbotlaydi. deploy/docker-compose.yml:115 `SPRING_PROFILES_ACTIVE: prod` -> application-prod.yml `enabled: true`, demak prod'da worker yoqiq. Bu nuqta bo'yicha defekt YO'Q (faqat @Scheduled tick() wiring'i test bilan qoplanmagan — kichik, bloklovchi emas). (b) createManual bo'yicha shubha O'RINLI — yuqoridagi AC3327 ga qara. Spec noaniq emas, shuning uchun `blocked` emas, `in_progress`. Cross-cutting (8 tekshiruv): @Transactional ✓ (createFromOrder; SystemUserLookupService readOnly=true) · tenant_id/schema yo'q ✓ (AR-1) · yangi katalog FK yo'q ✓ · outbox naqshi ✓ (bir tranzaksiya, SKIP LOCKED, retry/failed jadvalda, tashqi broker yo'q — AR-3/AR-4/AR-12) · nomlash ✓ · precision — yangi migratsiya yo'q ✓ · fizik DELETE yo'q, soft-delete hurmat qilingan (findByUsernameAndDeletedAtIsNull) ✓ · log'da parol/token yo'q (LogNotificationPort faqat event_type/object/payload) ✓. openapi/ tegilmagan, yangi endpoint yo'q ✓. Fixture xilma-xilligi eslatmasi (bloklovchi emas, lekin keyingi testda hisobga oling): happy-path fixture'da faqat BITTA holat bor — 2 operatsiyali marshrut, qty=15.0000, bitta org. Kasrli qty (mas. 15.5000), bitta operatsiyali marshrut va bir nechta org qamralmagan. Asosiy ish daraxti tegilmagan (a70a373, toza), worktree o'chirildi, `grep -rn MUTANT src/` bo'sh.

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ R31 avto oqim muallifi va manbasi: yaratilgan `production_runs` qatorida `origin=order`, `order_id` to`ldirilgan, `created_by_user_id` = `system` texnik useri. (EP-07-T02-S04 dan ko`chirildi 2026-08-25 — qator yaratish shu bargda bo`lgani uchun; aks holda R31 hech bir mezon bilan qoplanmasdi.)

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ Dedup (foydalanuvchi qarori 2026-08-25): kalit = `{event_type}:{entity}:{id}`; UNIQUE faqat `status IN (pending, processing)` oynasida; yozuv `INSERT ... ON CONFLICT DO NOTHING` — R8 tasdiq tranzaksiyasi unique violation bilan rollback BO`LMASIN. Yakunlangan (sent/failed) qatordan keyin ayni entity uchun yangi hodisa yozilaveradi (R11 rework, R25 recheck, R28 zanjir).

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ Xato -> `attempts+1` va eksponensial `next_attempt_at`; maks urinishdan keyin `status='failed'`

qa-ep-07-t05-s04 qabul mezonini belgiladi

✓ Worker `FOR UPDATE SKIP LOCKED` bilan oladi; ikki parallel worker bir qatorni ikki marta olmaydi (test)

coder-ep-07-t05-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-07-t05-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t05-s04 izoh qoldirdi

Muhim qarorlar: (1) production_run.create_from_order ni bajarish uchun ProductionRunCreationService ga YANGI createFromOrder(...) metodi qo'shildi (createManual bilan bir xil validatsiya tartibi, farqi origin=order/order_id/task.available enqueue). createManual O'ZI ATAYLAB o'zgartirilmadi: R3 (task.available) UC2 (qo'lda oqim) uchun ham talab qilingan (§8 UC2 3-qadam), lekin mavjud ProductionRunCreationServiceTest bir nechta joyda verifyNoInteractions(productionOutboxRepository)/times(1) bilan aniq outbox chaqiruv sonini tasdiqlaydi (T02-S02 dan, allaqachon review/done) — bu kontraktni buzmaslik uchun task.available FAQAT createFromOrder (order oqimi) uchun yozildi. UC2 uchun R3 qamrovi ochiq qoldi — CAPTURE/keyingi ish sifatida qayd etilsin. (2) production_outbox worker (@Scheduled fixedDelay) erpbom.outbox.production.enabled bilan boshqariladi, SUKUT FALSE — agar sukut yoqilgan bo'lsa boshqa modul integratsion testlari (WorkSubmitIntegrationTest va h.k., production_outbox.status='pending' ni to'g'ridan-to'g'ri DB'dan tekshiradi) flaky bo'lib qolardi (StockReconciliationJob kunlik cron bilan bu muammoni yashiradi, fixedDelay bilan yashirmaydi). application-dev.yml/application-prod.yml ANIQ enabled=true qo'yadi. (3) production_run.create_from_order payload'idagi qty BigDecimal — JacksonConfig global BigDecimal->String serializer tufayli JSON matn sifatida keladi ("15.0000"), shuning uchun worker JsonNode.decimalValue() EMAS, asText()+new BigDecimal(...) bilan o'qiydi.

coder-ep-07-t05-s04 fayllarni qayd etdi

10 ta fayl qayd etildi

coder-ep-07-t05-s04 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t05-s04 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

coder-ep-07-t05-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t05-s04 ishga oldi

unknown-agent izoh qoldirdi

[lead/EP-07-T04-S04 QA dan] OUTBOX WORKER UCHUN IKKI TOPILMA — shu bargda hisobga olinsin: 1) 🔴 V28 dedup indeksi `processing` holatini ham qamraydi. Ya'ni worker qatorni olib `processing` ga o'tkazgandan KEYIN kelgan `order.recheck` hodisasi `ON CONFLICT DO NOTHING` bilan sassiz TUSHIB QOLADI — 06_orders eskirgan holat bilan qoladi. Worker yozilayotganda bu hal qilinsin (mas. dedup oynasini faqat `pending` ga qisqartirish, yoki `processing` da kelgan hodisani qayta navbatga qo'yish). 2) V24 da `origin='order' -> order_id NOT NULL` CHECK constrainti yo'q — `origin='order'` sikl `order_id` siz yaratilsa, R25 hodisasi manzilsiz qoladi. Shuningdek avvalroq yozilgan qamrov bo'shlig'ini ham eslatib qo'yaman (yuqoridagi izoh): arxiv variant gate'i faqat QO'LDA sikl ochish yo'lida ishlaydi; buyurtmadan/outbox orqali AVTO ochilish yo'li qoplanmagan.

team-lead-pm izoh qoldirdi

📥 QAMROV KENGAYTIRILDI (team-lead-pm, 2026-08-25) — ikki o'zgarish: 1) YANGI mezon 3328: R31 (origin='order', order_id, created_by_user_id=system) EP-07-T02-S04 dan shu yerga ko'chirildi. Sabab: T02 worker'i R31 qamrov teshigini topdi — production_runs qatorini shu barg yaratadi, T02-S04 esa faqat port interfeysini e'lon qiladi. Ko'chirilmasa R31 hech bir mezon bilan qoplanmasdi. 2) Mezon 3326 (eski 3270) matni yangilandi: dedup kaliti endi {event_type}:{entity}:{id}, UNIQUE faqat pending/processing oynasida, ON CONFLICT DO NOTHING — foydalanuvchi qarori 2026-08-25 (to'liq matn EP-07-T01-S05 izohida). Eski {entity}:{id} matni bekor. ⚠️ Doc qarzi: 07_tasks §5 R30 matni hali eski — §5 sikli bilan yangilanadi.

pm-agent yaratdi

`ProductionOutboxWorker` + notification hodisalari (R3/R30, §10)