Rad yo'llari — rework rad (R9a) va terminal brak (R9b/R23)

finalize-ep-07 yangiladi

Yangilandi: pr_url

unknown-agent izoh qoldirdi

[lead] QA topgan M8 qamrov bo'shlig'i yopildi — commit 0aedcd2. QA yozgan test (u ishchi daraxtda commit qilinmagan qoldirgan edi) qo'llandi. Lead mustaqil tasdig'i: (1) toza kodda WorkReviewWipIntegrationTest 6/6 yashil, exit 0; (2) M8 mutanti (WorkReviewService.java:325 dagi S03 WIP sharti -> `if(true)`) qo'yilganda test YIQILADI; (3) mutant tiklandi, `grep -rn MUTANT src/` toza, daraxtda faqat `A openapi/v1/tasks.yaml`. Eslatma jamoaga: bu bo'shliq 27 ta testdan o'tib ketgan edi — sabab barcha rework fixture'larida `wip_cost = 0` bo'lgani. Fixture bir xil qiymatda qotib qolsa, mutatsiya o'sha shoxobchani umuman sinamaydi.

qa-1 statusni o'zgartirdi Review → Bajarildi

qa-1 izoh qoldirdi

QA (qa-1) — mustaqil tekshiruv, HEAD 6636163. TEST: toza surefire, `uz.erpbom.tasks.**` = 224/224 (0 failure/0 error) — bazaviy 223 + QA yozgan 1 yangi test. MUTATSIYA SINOVI (izolyatsiyalangan git worktree, javap bilan bytecode tasdiqlangan, worktree o'chirildi). Coder da'vosi ("mavjud testlar qoplaydi") 7/8 mutantda TASDIQLANDI: M1 S01 sharti -> `if(true)` (rework radida material sarflanadi): O'LDI — WorkReviewMaterialConsumptionIntegrationTest#reworkRejectDoesNotConsumeMaterial (AC3255 ombor). M3 qty_claimed sharti -> `if(confirming)` (terminal brak bo'shatmaydi): O'LDI — WorkReviewIntegrationTest#terminalBrakRejectReleasesQtyClaimedForReclaim (AC3258). M4 `enqueueWorkRejectedEvent` chaqiruvi olib tashlandi: O'LDI — WorkReviewIntegrationTest#reworkRejectKeepsQtyClaimedOnSameWork VA #terminalBrakRejectReleasesQtyClaimedForReclaim (ikkala rad yo'li). M5 F7 ikkinchi hadi (`+ previousWipShare`) olib tashlandi: O'LDI — WorkReviewWipIntegrationTest#sequentialOperationChainAccumulatesAndExcisesBrakLoss (AC3256 brak_loss = 5 + 150). M6 outbox sharti -> faqat rework yo'li: O'LDI — #terminalBrakRejectReleasesQtyClaimedForReclaim (terminal brakda ham qator chiqishi qo'riqlangan). M7 `brak_loss_snapshot = ZERO`: O'LDI — 2 ta WIP testi. M2 accrual sharti -> `if(confirming || effectiveIsBrak)`: SURVIVED, lekin EKVIVALENT mutant — `WageAccrualPortImpl` (04, AC2900) `qty.signum()==0` da `noAccrual` qaytaradi, qator yozilmaydi; kuzatiladigan mezon (wage_entries qatori yo'q, labor_cost_snapshot=0) `WorkReviewAccrualIntegrationTest#terminalBrakDoesNotCreateWageEntryAndSnapshotsZero` bilan qo'riqlangan. Nuqson EMAS. TOPILMA (yopildi): M8 — S03 (F5/F7 WIP bloki) sharti `confirming || effectiveIsBrak` -> `if(true)` mutanti 27 testda TIRIK QOLDI (javap bilan tasdiqlandi: bazada `iload 8 / ifne / iload 9 / ifeq` qulfi bor, mutantda yo'q). Sabab: barcha mavjud rework testlarida fixture `wip_cost = 0`, shuning uchun farq ko'rinmaydi. Holbuki `wip_cost > 0` bo'lganda shartsiz S03 rework radida `brak_qty = claimed_qty` deb hisoblab `wip_per_unit_before x claimed_qty` ni WIP'dan JIM ayiradi (84 000 -> 67 200) va yo'q brakni xarajatga yozadi — R9-a/UC6-a va F5/F7 buzilishi. ISHLAB CHIQARISH KODI TO'G'RI, bu test qamrovi bo'shlig'i edi. QA yozgan test (qopqoq): `src/test/java/uz/erpbom/tasks/controller/WorkReviewWipIntegrationTest.java` -> `reworkRejectLeavesWipCostAndSnapshotsUntouched` — 4 brom/3 soz tasdiqdan keyin wip_cost=84000, so'ng ikkinchi bromni rework rad qiladi va tekshiradi: wip_cost 84000 (o'zgarmagan), `brak_loss_snapshot` NULL, `material_cost_snapshot` NULL. Toza kodda YASHIL, M8 mutantida O'LADI (tasdiqlandi). ⚠️ Bu test ish daraxtida COMMIT QILINMAGAN (QA push/commit qilmaydi) — keyingi commit'ga kiritilsin. CROSS-CUTTING (8/8): (1) `review()` @Transactional, outbox qatori shu tranzaksiyada — AR-3; (2) tenant_id/schema qo'shilmagan — AR-1; (3) yangi ustun/FK yo'q; (4) outbox: `enqueueIfAbsent` = `ON CONFLICT (dedup_key) WHERE status IN ('pending','processing') DO NOTHING`, worker `FOR UPDATE SKIP LOCKED` + `next_attempt_at` retry + `status='failed'`, tashqi broker yo'q — AR-3/AR-4/AR-12; `work.rejected` V28 CHECK ro'yxatida bor; (5) nomlash snake_case; (6) precision o'zgarmagan; (7) fizik DELETE yo'q; (8) payload'da parol/token yo'q (work_id/task_id/production_run_id/employee_id/is_brak/reject_reason). Spec muvofiqligi: R9-a (rework — ombor/accrual/WIP tegilmaydi), R9-b/R23 (terminal brak — `production_out` claimed_qty bo'yicha, accrual yo'q, brak_loss = material_out_cost + WIP ulushi, qty_claimed -= claimed_qty), R7/R22-d (izoh majburiy, 422), §10 (`work.rejected` ikkala yo'lda ham) — hammasi kod va test bilan tasdiqlandi. Eslatma (nuqson emas, T05 outbox worker bargi uchun): rework zanjirida ayni `work_id` qayta rad etilsa va oldingi `work.rejected` qatori hali `pending` bo'lsa, ikkinchi rad qatori dedup bilan tushib qoladi (hodim eski `reject_reason`ni ko'radi). Bu V28 QARORIdagi ataylab qilingan qisman-indeks siyosati va `work.submitted` bilan bir xil naqsh, shuning uchun bu bargda qaytarilmadi.

qa-1 qabul mezonini belgiladi

✓ Terminal brakdan keyin `qty_claimed` kamayadi va o'sha miqdor qayta brom qilinadi

qa-1 qabul mezonini belgiladi

✓ Ikkala yo'lda ham `reject_reason` bo'sh bo'lolmaydi (`422`)

qa-1 qabul mezonini belgiladi

✓ Terminal brak: `production_out` bor, accrual yo'q, `brak_loss_snapshot` = butun `material_out_cost` + WIP ulushi

qa-1 qabul mezonini belgiladi

✓ Rework rad: `stock_movements` va `wage_entries` da yangi qator YO'Q (test)

backend-1 statusni o'zgartirdi Ishlanyapti → Review

backend-1 izoh qoldirdi

SEAM (S01-S04, WorkReviewService.review) T04'da allaqachon ikkala rad tarmog'ini (rework R9-a, terminal brak R9-b/R23) to'g'ri shartlagan edi (confirming || effectiveIsBrak trigger): material FIFO, accrual, F5/F7 WIP, qty_claimed R22/R23. Yagona yetishmayotgan qism — hodimga work.rejected outbox qatori (07_tasks.md UC6/§10) — shu bargda qo'shildi (WorkReviewService#enqueueWorkRejectedEvent, !confirming, ikkala tarmoq HAM). Yangi test: terminalBrakWithoutReasonReturnsRejectReasonRequired (AC3257). pendingOutboxRow assertlari reworkRejectKeepsQtyClaimedOnSameWork va terminalBrakRejectReleasesQtyClaimedForReclaim testlariga qo'shildi. AC3255/3256/3258 avvaldan mavjud testlar (WorkReviewMaterialConsumptionIntegrationTest, WorkReviewAccrualIntegrationTest, WorkReviewWipIntegrationTest) bilan qamrab olingan edi. Natija: uz.erpbom.tasks.** 223/223, uz.erpbom.employees.** 252/252 (0 failure/0 error). Commit 6636163.

backend-1 fayllarni qayd etdi

2 ta fayl qayd etildi

backend-1 yangiladi

Yangilandi: branch, commit_sha

backend-1 qabul mezonini belgiladi

✓ Terminal brakdan keyin `qty_claimed` kamayadi va o'sha miqdor qayta brom qilinadi

backend-1 qabul mezonini belgiladi

✓ Ikkala yo'lda ham `reject_reason` bo'sh bo'lolmaydi (`422`)

backend-1 qabul mezonini belgiladi

✓ Terminal brak: `production_out` bor, accrual yo'q, `brak_loss_snapshot` = butun `material_out_cost` + WIP ulushi

backend-1 qabul mezonini belgiladi

✓ Rework rad: `stock_movements` va `wage_entries` da yangi qator YO'Q (test)

backend-1 statusni o'zgartirdi Backlog → Ishlanyapti

pm-agent yaratdi

Rad yo'llari — rework rad (R9a) va terminal brak (R9b/R23)