04 accrual hook — `WageAccrualPort` chaqiruvi va `labor_cost_snapshot`

finalize-ep-07 yangiladi

Yangilandi: pr_url

qa-1 statusni o'zgartirdi Review → Bajarildi

QA: 24 test yashil (o'zim yurgizdim), 4/4 mutant o'ldirildi, spec ziddiyati DA'VOSI rad etildi (§4.2/§2.2/F7/UC6-b bir ma'noli), cross-cutting 8/8.

qa-1 qabul mezonini belgiladi

✓ `rejected`/`void` yo'lida port UMUMAN chaqirilmaydi

qa-1 qabul mezonini belgiladi

✓ `confirmed_qty = 0` (butun brom brak) bo'lsa port no-op qaytaradi va `labor_cost_snapshot = 0`

qa-1 qabul mezonini belgiladi

✓ Chaqiruv WIP yangilanishidan OLDIN (test tartibni tekshiradi — mas. spy/`InOrder`)

qa-1 qabul mezonini belgiladi

✓ AC3: aynan bitta `wage_entries` qatori; `qty = confirmed_qty`

qa-1 izoh qoldirdi

[QA qa-1] TEKSHIRILDI -> done. Hisobotga tayanmadim; hammasi mustaqil o'lchandi (HEAD b4f044f). 1) SPEC ZIDDIYATI DA'VOSI — ZIDDIYAT YO'Q, coder taxmin QILMAGAN; qaror to'g'ridan-to'g'ri spec'dan kelib chiqadi. Asos (07_tasks.md): - §4.2 holat mashinasi: "submitted --------> confirmed # to'liq YOKI qisman qabul (confirmed_qty>0)"; - §2.2 `works.status` qatori: "Review natijasi 3 xil (R22): (a) confirmed (confirmed_qty > 0); (b) rejected + is_brak=false -> rework; (c) rejected + is_brak=true -> TERMINAL brak"; - §6 F7 izohi: "Terminal brakda (confirmed_qty = 0) accrual yo'q"; - UC6-b: terminal brak -> work terminal `rejected`, "accrual yo'q"; R9-a: rework radida "ombor/accrual o'zgarmaydi". Ya'ni confirmed_qty=0 07 holat mashinasida HECH QACHON `confirmed` bo'lmaydi -> port faqat `confirming` da chaqirilishi spec'ning yagona o'qilishi. Blok shart emas. ⚠️ Lekin qarshi tomonda hujjat nuqsoni bor (S02 aybi EMAS, EP-06-T06-S02 qarzi): WageAccrualPort javadoci "confirmedQty = 0 — brak-only holat (AC2900)" bo'limida "work baribir confirmed bo'lishi mumkin (07_tasks holat mashinasi)" deb YOZGAN — bu 07 §4.2/§2.2 ga zid FAKTIK xato. Port o'zi qty=0 ni bardoshli qabul qiladi (ruxsat, majburiyat emas), shuning uchun xatti-harakat ziddiyati yo'q. Javadoc jumlasi 04 tomonida tuzatilsin (alohida barg). Board AC3239 matni ("port no-op qaytaradi") ham xuddi shu noto'g'ri faraz ustiga yozilgan; NATIJA darajasida mezon bajarilgan (qator yo'q, snapshot=0) va AC3240 ("rejected/void yo'lida port UMUMAN chaqirilmaydi") bilan faqat coder o'qishida izchil bo'ladi. 2) TESTLAR (o'zim yurgizdim, `flock ... mvn -o -Dtest=... test`, clean YO'Q): WorkReviewAccrualIntegrationTest 4/4 · WorkReviewServiceAccrualOrderTest 3/3 · WorkReviewIntegrationTest 11/11 (regressiya) · WorkReviewMaterialConsumptionIntegrationTest 6/6 (regressiya). Jami 24, Failures: 0, Errors: 0. 3) MUTATSIYA SINOVI (izolyatsiyalangan `git worktree`, tugagach o'chirildi; 4/4 mutant O'LDIRILDI): M1 qty=confirmedQty -> claimedQty => AC3237 integratsiya testi qizil (claimed 10 / confirmed 6 fixture ushladi). ⚠️ Kuzatuv: birlik testi buni ushlamaydi (u yerda claimed==confirmed==5) — "mutant himoyasi" faqat integratsiya fixture'i hisobiga ishlaydi. M2 accrual chaqiruvi workRepository.save() dan KEYINGA ko'chirildi (yakuniy DB natijasi bir xil qoladi) => AC3238 InOrder testi qizil ("Verification in order failure"). Tartib haqiqatan qulflangan. M3 `if (confirming)` -> `if (true)` (rejected yo'lida ham port chaqiriladi) => birlik testi qizil (2 error). ⚠️ Muhim: integratsiya testi bu mutantni YASHIL o'tkazadi (port qty=0 da no-op) — AC3240 ni FAQAT verifyNoInteractions/never birlik testi ushlaydi; u olib tashlanmasin. M4 laborCostSnapshot = amount() olib tashlandi => ikkala test ham qizil. 4) CROSS-CUTTING (8 band): (1) review() @Transactional, WageAccrualPortImpl REQUIRED bilan qo'shiladi -> R8 atomikligi bitta chegarada ✓; (2) migratsiya yo'q, tenant_id/schema mexanikasi qo'shilmagan ✓; (3) yangi FK yo'q ✓; (4) outbox ATAYLAB ishlatilmagan — §11/R8/Q10=A: tasdiq oqimi sync, AR-3 dan spec-bo'yicha istisno ✓; (5) DDL yo'q ✓; (6) works.labor_cost_snapshot = numeric(18,2) (V26__works.sql:55), qty numeric(18,4) ✓; (7) DELETE yo'q ✓; (8) log/token yo'q ✓. 5) CHEKKA HOLATLAR: production_date — V26 chk_works_production_date_required submitted/confirmed/rejected uchun NOT NULL kafolatlaydi -> WageAccrualCommand.workDate NPE'si yetib bo'lmas ✓. picking task (variant_operation_id NULL -> requireNonNull NPE) — WorkService `work.claim` da picking bloklangan, shuning uchun picking work `submitted` ga yetib bora olmaydi ✓. Takroriy accrual — review faqat `submitted` da ishlaydi, `confirmed` terminal -> 409 INVALID_STATUS_TRANSITION; rework siklida ham bir work bir accrual (UNIQUE(work_id)) ✓. `void` — WageAccrualPort butun tasks modulida FAQAT WorkReviewService da ishlatiladi, void yo'li accrual'ga tegmaydi ✓. 6) KEYINGI BARGGA (S03) TOPSHIRIQ, bu yerda yopilmaydi: R8 "biror qadam xato bersa na ombor, na accrual o'zgaradi" rollback'i hozir SINALMAGAN — accrual'dan KEYIN yiqiladigan qadam kodda hali yo'q (WIP yozuvi S03). S03 kelganda rollback testi wage_entries qatorining ham yo'qolishini isbotlashi SHART. Ma'lum istisno: 04_employees to'plami (V27 fk_wage_entries_work vs eski fixture'lar, EP-07-T01-S04 qayta ochilgan) qizil — S02 ga aloqasi yo'q, verdiktga qo'shilmadi. Yakuniy holat: `grep -rn MUTANT src/` bo'sh, `git status` = faqat `A openapi/v1/tasks.yaml`, worktree o'chirilgan, HEAD b4f044f.

backend-1 statusni o'zgartirdi Ishlanyapti → Review

backend-1 izoh qoldirdi

S02 tayyor. WorkReviewService.review() SEAM S01dan keyin, work/task yozuvidan oldin S02ni chaqiradi: confirming (confirmed_qty>0) bo'lganda WageAccrualPort.accrue() (employeeId/task.variantOperationId/work.id/task.organizationId/work.productionDate/confirmedQty), natija amount -> work.laborCostSnapshot. Rework-reject VA terminal brak (ikkalasi ham status=rejected) - port UMUMAN chaqirilmaydi, snapshot=0 (spec: R9-a rework accrual o'zgarmaydi, UC6-b terminal brakda accrual yo'q, 4.2 Accrual FAQAT confirmedda). Bu WageAccrualPort javadocidagi AC2900 izohi (confirmedQty=0 -> work baribir confirmed bo'lishi mumkin) bilan zid - S05 holat mashinasi haqiqatda confirmedQty=0ni doim rejectedga o'tkazadi, shuning uchun portning o'z-o'zidan no-op qilishiga tayanmadim, chaqiruvni WorkReviewService darajasida skip qildim (natija bir xil: qator yo'q, snapshot=0). Testlar: WorkReviewAccrualIntegrationTest (Testcontainers, 4/4 - AC3237 bitta qator+qty to'g'ri, field mapping, AC3239 terminal brak no-op+snapshot=0, AC3240 rework no-op) + WorkReviewServiceAccrualOrderTest (Mockito InOrder, 3/3 - AC3238 material->accrual->work/task save tartibi + argument mutant himoyasi + AC3240 unit darajada). WorkReviewIntegrationTest (11) va WorkReviewMaterialConsumptionIntegrationTest (6) regressiyasiz yashil qoldi. Commit b4f044f. ESLATMA (mening bargimga aloqasi yo'q, bloklamadi): to'liq uz.erpbom.tasks.**+employees.** suite ishga tushirilganda 04_employees modulida oldingi testlar (WageAccrualServiceTest/WageAccrualPortTest/PayrollControllerIntegrationTest/EmployeePayrollSelfControllerIntegrationTest/WageEntriesMigrationTest/EmployeeProfessionServiceTest) fk_wage_entries_work FK buzilishi bilan qizil chiqadi - sabab V27 migratsiyasi (commit 4c59cf1, mening HEAD cdf7e8b'dan 24 commit oldin, mendan mustaqil) wage_entries.work_id ga haqiqiy FK qo'ygan, lekin bu testlar hali ham works'da mavjud bo'lmagan qalbaki work_id butun sonlar bilan insert qiladi. Standalone tekshirdim (WageAccrualServiceTest/WageAccrualPortTest yolg'iz ishga tushirilganda ham qizil) - mening o'zgarishlarimdan mustaqil, mendan oldin buzilgan edi. QA/keyingi coder diqqatiga.

backend-1 fayllarni qayd etdi

4 ta fayl qayd etildi

backend-1 yangiladi

Yangilandi: branch, commit_sha

backend-1 qabul mezonini belgiladi

✓ `rejected`/`void` yo'lida port UMUMAN chaqirilmaydi

backend-1 qabul mezonini belgiladi

✓ `confirmed_qty = 0` (butun brom brak) bo'lsa port no-op qaytaradi va `labor_cost_snapshot = 0`

backend-1 qabul mezonini belgiladi

✓ Chaqiruv WIP yangilanishidan OLDIN (test tartibni tekshiradi — mas. spy/`InOrder`)

backend-1 qabul mezonini belgiladi

✓ AC3: aynan bitta `wage_entries` qatori; `qty = confirmed_qty`

backend-1 statusni o'zgartirdi Backlog → Ishlanyapti

pm-agent yaratdi

04 accrual hook — `WageAccrualPort` chaqiruvi va `labor_cost_snapshot`