`work.submit` — topshirish, `production_date` va taxminiy ish haqi (R26)

finalize-ep-07 yangiladi

Yangilandi: pr_url

qa-ep-07-t03-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-07-t03-s03 izoh qoldirdi

QA raund 2 — AC3225 YOPILDI. Test: submitEstimatesBonusQuantityWhenPriorAccrualExceedsRemainingNorm (commit 62f27ad) — 04_employees §6.1 kanonik "Task B" misolini aynan qamraydi: norm_per_day=10, rate=10000, bonus_rate=13000, oldindan wage_entries qty=8 -> normal_qty=2, bonus_qty=8, amount=124000.00. Hamma qiymat ANIQ satr sifatida assert qilinadi (qty/rate/bonus_rate/norm_per_day/normal_qty/bonus_qty/amount) — "0 dan katta" kabi bo’sh assert yo’q. wage_entries ga qator yozilmasligi (R26) ham shu testda tekshirilgan. Ishlab chiqarish kodi o’zgarmagan (commit faqat test faylga tegdi, 1 file changed); estimateWage (WorkService.java:474-503) hamon WageAccrualService#accrue:125-136 bilan qator-ma-qator mos. MUTATSIYA TEKSHIRUVI — o’tgan raundda omon qolgan ikkalasi ham endi O’LADI: (a) normalQty = claimedQty.min(remainingNormal) -> claimedQty : yangi test yiqildi — WorkSubmitIntegrationTest:190, expected "2.0000" but was "10.0000". (b) bonusRateAmount fallback olib tashlandi (rate.bonusRate() ?: rateAmount -> rate.bonusRate()) : eski bonus_rate=NULL fixture NPE bilan 500 berdi — submitTransitionsClaimedToSubmittedWithEstimatedWageAndNoWageEntry, expected 200 OK but was 500. Ya’ni NULL tarmog’i ham qoplangan. (b2) qo’shimcha semantik variant bonusRateAmount = rateAmount (bonus_rate umuman ishlatilmaydi — eski fixture buni HECH QACHON ushlay olmasdi): yangi test yiqildi — :188, expected "13000.00" but was "10000.00". Har mutatsiya darhol teskari tahrir bilan tiklandi; yakunda git diff BO’SH va grep -rn MUTANT src/ bo’sh (git checkout/reset/stash ishlatilmadi). Testlar: WorkSubmitIntegrationTest 6/6 yashil (tiklashdan keyin qayta yurgizilgan); regressiya WorkReworkIntegrationTest 6/6 va WorkClaimIntegrationTest 14/14 yashil.

qa-ep-07-t03-s03 qabul mezonini belgiladi

✓ Taxminiy summa hisoblanadi, javobda "taxminiy" belgisi bilan; `wage_entries` da qator YO'Q (test)

coder-ep-07-t03-s03 yangiladi

Yangilandi: commit_sha

coder-ep-07-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t03-s03 qabul mezonini belgiladi

✓ Taxminiy summa hisoblanadi, javobda "taxminiy" belgisi bilan; `wage_entries` da qator YO'Q (test)

coder-ep-07-t03-s03 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-07-t03-s03 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-07-t03-s03 izoh qoldirdi

QA (qa-EP-07-T03-S03) — qaytarildi: AC3225 yopilmadi. Testlar: WorkSubmitIntegrationTest 5/5, WorkClaimIntegrationTest 14/14, WorkReworkIntegrationTest 6/6 — yashil. ✅ AC3223 — WorkController.java:58 `@RequirePermission("work.submit")` HAQIQIY annotatsiya (javadoc emas, @PostMapping ustida). Egalik: WorkService.java:245-248 (403 OwnershipDeniedException). Testlar: submitWithoutPermissionIsForbidden, submitOfAnotherEmployeesWorkIsForbidden. ✅ AC3224 — WorkSubmitRequest.java `@NotNull @PastOrPresent`; V26__works.sql:73 chk_works_production_date_required. MUTATSIYA: @PastOrPresent olib tashlandi → submitWithFutureProductionDateIsRejectedWithValidationError:170 YIQILDI (200 + production_date=2026-08-26). Tiklandi. ❌ AC3225 — FORMULA TO'G'RI, LEKIN TEST FORMULANING YARMINI USHLAMAYDI. WorkService.java:474-503 `estimateWage` WageAccrualService#accrue (satr 125-136) bilan qator-ma-qator bir xil (bir xil sumQtyByAggregateKey, findActiveByKey, remaining_normal/normal/bonus bo'linishi, scale 4/2) — chetga chiqish YO'Q. is_estimate=true va wage_entries=0 ham isbotlangan (mutatsiya Boolean.TRUE→FALSE → test YIQILDI). MUAMMO: marginal bonus tarmog'i (04 §6.1 — prior_qty>0, bonus_qty>0, bonus_rate!=NULL) HECH BIR TEST bilan qoplanmagan. Isbot — mutatsiya OMON QOLDI: WorkService.java:490 normalQty = claimedQty.min(remainingNormal)… → normalQty = claimedQty… (norm chegarasi butunlay olib tashlandi) WorkService.java:487 bonusRateAmount = rate.bonusRate() != null ? rate.bonusRate() : rateAmount → = rateAmount (bonus stavka olib tashlandi) Natija: WorkSubmitIntegrationTest 5/5 YASHIL va WorkReworkIntegrationTest 6/6 YASHIL. Ya'ni ish haqi formulasining bonus yarmi buzilsa ham CI jim turadi. SABAB: ikkala klassdagi newFixture() — norm_per_day=5, piece_rate=5000.00, bonus_rate=NULL, claimed_qty=3 va oldindan hech qanday wage_entries yo'q → hisob har doim "hammasi normal, bonus=0, bonus_rate=rate" tarmog'idan o'tadi. KERAK (WorkSubmitIntegrationTest ga): 04 §6.1 ishlangan misolining aynan o'zi bilan kamida bitta test — bonus_rate NOT NULL fixture (mas. insertPieceRate(…, "10000.00", "13000.00"), insertNorm(…, "10.0000", …)), shu (employee × variant_operation × production_date) uchun OLDINDAN wage_entries qatori (qty=8) qo'yiladi, keyin claimed_qty=10 bilan submit → javobda normal_qty="2.0000", bonus_qty="8.0000", amount="124000.00", norm_per_day="10.0000", rate="10000.00", bonus_rate="13000.00". Shu test yuqoridagi ikkala mutatsiyani ham o'ldiradi. ⚠️ Eslatma: prior_qty fixture'i wage_entries.work_id NOT NULL/UNIQUE va fk_wage_entries_work ni talab qiladi — boshqa (allaqachon confirmed) work bilan bog'lansin. ✅ AC3226 — WorkService.java:261 enqueueWorkSubmittedEvent(saved, task) @Transactional submitWork ICHIDA (satr 239). dedup_key = "work.submitted:work:{id}" (satr 432) — V28 qoidasiga mos; ProductionOutboxRepository.enqueueIfAbsent = INSERT … ON CONFLICT (dedup_key) WHERE status IN ('pending','processing') DO NOTHING (satr 29-32), V28:108-110 qisman UNIQUE indeksi bilan mos. MUTATSIYA: satr 261 olib tashlandi → test:159 YIQILDI ("outbox qatori topilmadi"). Tiklandi. Kontrakt: HTTP javobi kontraktga mos — snake_case, decimal string, is_estimate:true, work.status=submitted; `claimed` bo'lmaganda 409 INVALID_STATUS_TRANSITION (test bilan). Cross-cutting: @Transactional bor, tenant_id yo'q, soft-delete (findByUserIdAndDeletedAtIsNull), qty(18,4)/pul(18,2), token/parol log'ga yozilmaydi — hammasi o'tdi. Kuzatuv (bloklovchi EMAS, ma'lumot uchun): estimateWage enqueue'dan KEYIN chaqiriladi va norm/stavka claim bilan submit orasida o'chirilsa 409 NORM_OR_RATE_MISSING bilan BUTUN tranzaksiya (submit + outbox) rollback bo'ladi. Sxema buzilmaydi (409 ErrorResponse generik), spec bu chekka holatni aytmaydi — hozircha defekt deb hisoblamadim. Ish daraxti: mutatsiyalar teskari tahrir bilan tiklandi, `git diff` BO'SH, `grep -rn MUTANT src/` bo'sh (faqat oldindan staged openapi/v1/tasks.yaml qoldi).

qa-ep-07-t03-s03 qabul mezonini belgiladi

✗ Taxminiy summa hisoblanadi, javobda "taxminiy" belgisi bilan; `wage_entries` da qator YO'Q (test)

qa-ep-07-t03-s03 qabul mezonini belgiladi

✓ `work.submitted` outbox qatori shu tranzaksiyada yoziladi

qa-ep-07-t03-s03 qabul mezonini belgiladi

✓ `production_date` NOT NULL bo'lib yoziladi; kelajak sanaga ruxsat berilmaydi

qa-ep-07-t03-s03 qabul mezonini belgiladi

✓ `@RequirePermission("work.submit")`; faqat o'z work'ini topshira oladi

coder-ep-07-t03-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t03-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-07-t03-s03 qabul mezonini belgiladi

✓ `work.submitted` outbox qatori shu tranzaksiyada yoziladi

coder-ep-07-t03-s03 qabul mezonini belgiladi

✓ Taxminiy summa hisoblanadi, javobda "taxminiy" belgisi bilan; `wage_entries` da qator YO'Q (test)

coder-ep-07-t03-s03 qabul mezonini belgiladi

✓ `production_date` NOT NULL bo'lib yoziladi; kelajak sanaga ruxsat berilmaydi

coder-ep-07-t03-s03 qabul mezonini belgiladi

✓ `@RequirePermission("work.submit")`; faqat o'z work'ini topshira oladi

coder-ep-07-t03-s03 fayllarni qayd etdi

6 ta fayl qayd etildi

coder-ep-07-t03-s03 statusni o'zgartirdi Tayyor → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t03-s03 ishga oldi

system statusni o'zgartirdi Ishlanyapti → Tayyor

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

system bo'shatdi

Avtomatik bo'shatildi: 60 daqiqa signal yo'q

coder-ep-07-t03-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t03-s03 ishga oldi

pm-agent yaratdi

`work.submit` — topshirish, `production_date` va taxminiy ish haqi (R26)