📋 PM Board
Sub-task EP-07-T03-S02 Kritik 07_tasks erpbom-backend

`work.claim` — over-claim, normativ tavani, band-task gate

Bajarildi
Status:

Tavsif

Brom: `tasks` qatoriga `SELECT ... FOR UPDATE`, `qty_claimed + qty <= required_qty` (R4), `qty <= norm_per_day` (F3 — operatsiya × org-node), band-task gate KASB kesimida (R5: shu kasbda non-terminal work yo'q), hodim gate'i (R12: `employees.status='active'` + shu kasbda `employee_professions` active), R16 (normativ/stavka yo'q yoki 0 -> aniq xato bilan BLOK, default yo'q).

Texnik ko'rsatma

Agent uchun

🔴 Band-task gate'ning yagona haqiqat manbai — DB (`works.status`); kesh ishlatilsa faqat ko'rsatkich sifatida (§3 p.6). 🔴 `norm_per_day` — YUMSHOQ kunlik chegara: BITTA brom uni oshira olmaydi, lekin kunlik JAMI oshishi MUMKIN (oshgan qism 04 bonus stavkasida) — kunlik jamiga tekshiruv QO'YILMAYDI.

Qabul mezonlari (DoD)

6 / 6 bajarildi

  • `@RequirePermission("work.claim")`; `suspended`/`fired` hodim `403`

    qa-ep-07-t03-s02 · 1 о аввал

  • `qty > norm_per_day` -> rad; kunlik jami normativdan oshsa -> RUXSAT (test ikkalasini ham qamraydi)

    qa-ep-07-t03-s02 · 1 о аввал

  • Band-task: bitta kasbda ikkinchi brom rad, ikkinchi kasbda parallel brom ruxsat (AC11)

    qa-ep-07-t03-s02 · 1 о аввал

  • `submitted` yoki `rejected` work ham band ushlaydi; `confirmed` bo'lgach ozod bo'ladi

    qa-ep-07-t03-s02 · 1 о аввал

  • R16: normativ qatori yo'q -> brom aniq xato kodi bilan bloklanadi, default norm ishlatilmaydi

    qa-ep-07-t03-s02 · 1 о аввал

  • Parallel brom testi (2 thread): jami `qty_claimed` hech qachon `required_qty` dan oshmaydi

    qa-ep-07-t03-s02 · 1 о аввал

O'zgargan fayllar

9 ta

  • modified src/test/java/uz/erpbom/tasks/controller/WorkClaimIntegrationTest.java
  • modified src/main/java/uz/erpbom/employees/repository/EmployeeProfessionRepository.java
  • modified src/main/java/uz/erpbom/tasks/repository/WorkRepository.java
  • modified src/main/java/uz/erpbom/tasks/repository/TaskRepository.java
  • modified src/main/java/uz/erpbom/tasks/service/WorkService.java
  • modified src/main/java/uz/erpbom/tasks/mapper/WorkMapper.java
  • modified src/main/java/uz/erpbom/tasks/dto/WorkResponse.java
  • modified src/main/java/uz/erpbom/tasks/dto/WorkClaimRequest.java
  • modified src/main/java/uz/erpbom/tasks/controller/WorkController.java

Izoh qoldirish

Tarix

21 yozuv

  • ✎

    finalize-ep-07 yangiladi

    Yangilandi: pr_url

  • ⇄

    qa-ep-07-t03-s02 statusni o'zgartirdi Review → Bajarildi

  • 💬

    qa-ep-07-t03-s02 izoh qoldirdi

    QA (qa-EP-07-T03-S02) — 553394b tekshirildi, 6/6 mezon O'TDI, done. TESTLAR: WorkClaimIntegrationTest — 14 test, 0 failure, 0 error (37.3s, Testcontainers PG16, flock ostida). MEZON KESIMIDA: - 3217: @RequirePermission("work.claim") HAQIQIY annotatsiya (WorkController.java:40, javadoc emas). suspended/fired -> 403: OwnershipDeniedException.asForbidden (HttpStatus.FORBIDDEN) + GlobalExceptionHandler#handleOwnershipDenied — naqsh mavjudligi tasdiqlandi (EmployeePayrollSelfService / PurchaseReceiptSelfService / SupplierSelfService da ayni naqsh). Runtime log: "Completed 403 FORBIDDEN". 3 ta test (huquqsiz / suspended / fired). - 3218: ikkala yo'nalish ham qamralgan. F3 chegarasi MUTATSIYA bilan pinlangan: '>' -> '>=' qilinganda dailyTotalAboveNormAcrossTwoClaimsIsAllowed YIQILDI (5.0000 = norm da 409 CLAIM_EXCEEDS_NORM). Ya'ni faqat '>' ikkala testni qanoatlantiradi. - 3219: bir kasbda 2-brom -> 409 EMPLOYEE_HAS_ACTIVE_WORK; ikkinchi kasbda parallel brom -> 201. Gate KASB kesimida (WorkRepository so'rovida professionId sharti bor). - 3220: BAND-TASK GATE FORMULASI KONTRAKTGA MOS — faol = claimed/submitted/(rejected+is_brak=false), terminal = confirmed/void/(rejected+is_brak=true). Eski "non-confirmed, non-void" formulasi kodda YO'Q. MUTATSIYA: is_brak=false sharti olib tashlanganda (= eski formula) terminalBrakRejectedWorkReleasesTheGate YIQILDI — deadlock defekti test bilan ushlanadi. 'submitted' olib tashlanganda submittedWorkHoldsTheGate YIQILDI. - 3221: normativ qatori yo'q -> 409 NORM_OR_RATE_MISSING; norm bor, piece_rate yo'q -> ayni kod. DEFAULT ishlatilmagani isbotlangan (default bo'lsa 201 bo'lardi). norm_per_day=0 DB darajasida imkonsiz: V21 chk_profession_norms_norm_per_day_positive CHECK (norm_per_day > 0) — coder da'vosi tasdiqlandi; signum()<=0 himoya qatlami sifatida qoladi. - 3222: test TAUTOLOGIK EMAS. MUTATSIYA: @Lock(PESSIMISTIC_WRITE) olib tashlanganda concurrentClaims... YIQILDI — IKKALA so'rov ham 201 qaytardi (lost update), ya'ni 2 thread haqiqiy poyga yaratadi. Qulf bilan: 1x201 + 1x409 TASK_OVER_CLAIM, qty_claimed=6 <= required_qty=10. Mutatsiyalar IZOLYATSIYALANGAN git worktree'da (553394b) o'tkazildi — feat/EP-07-erpbom-backend ishchi daraxti TEGILMADI (qo'shni S01 agenti ayni paytda WorkService.java ni tahrirlayotgani uchun). Worktree o'chirildi. TEKSHIRUV TARTIBI kontraktdagidek: task turi/holati (prerekvizit) -> 1 R12 -> 2 R5 band-task -> 3 R20 gating -> 4 R16 -> 5 F3 -> 6 R4 (row-lock). Xato kodlari kontraktdan chetga chiqmagan. Javob DTO'si kontraktga mos (log'dagi 201 tanasi: task_id / production_run_id / claimed_qty:"6.0000" / status:"claimed" — snake_case + string decimal). R20 stub (isWaitingForPredecessors -> false) BU BARG mezoni emas (EP-07-T03-S01) — chaqiruv nuqtasi to'g'ri tartibda turibdi, shu tasdiqlandi. CROSS-CUTTING: claimWork @Transactional; tenant_id/schema mexanikasi qo'shilmagan; migratsiya yo'q; async/outbox yo'q (R8 sinxron); fizik DELETE yo'q (findByUserIdAndDeletedAtIsNull soft-delete'ga rioya qiladi); parol/token log'ga yozilmaydi. === KEYINGI BARGGA (bu bargni bloklamaydi) === 1. QAMROV BO'SHLIG'I: 409 EMPLOYEE_NOT_ELIGIBLE (R12 ning KASB yarmi, kontraktda 1-tekshiruv) uchun BIRORTA test yo'q — hech bir test hodimni operatsiya kasbisiz sozlamaydi (newActiveActor har doim biriktiradi). requireEligibleProfession o'chirilsa hech qaysi test yiqilmaydi; bu noto'g'ri kasbda brom -> noto'g'ri stavkada accrual degani. Test arzon: insertEmployeeProfession(..., false) helper allaqachon bor. 2. INVALID_STATUS_TRANSITION (task cancelled/completed) va BUSINESS_CONFLICT (task_type='picking') — shu bargda amalga oshirilgan, kontraktda e'lon qilingan, testsiz. 3. ⚠️ BEGONA QIZIL TEST (bu barg AYBI EMAS): EmployeeProfessionServiceTest#unassigningProfessionLeavesExistingWageEntriesUntouched — ERROR, fk_wage_entries_work FK buzilishi (insertWageEntry soxta work_id yozadi, EmployeeProfessionServiceTest.java:371). Sabab — EP-07-T01-S04 (V27__wage_entries_work_fk.sql, 0fbf8e4). 553394b na bu testni, na migratsiyani tegmagan. Egasiga yo'naltirilsin. Regressiya qolgani toza: ProfessionNormServiceTest 15/15, ProfessionNormControllerIntegrationTest 17/17.

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ Parallel brom testi (2 thread): jami `qty_claimed` hech qachon `required_qty` dan oshmaydi

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ R16: normativ qatori yo'q -> brom aniq xato kodi bilan bloklanadi, default norm ishlatilmaydi

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `submitted` yoki `rejected` work ham band ushlaydi; `confirmed` bo'lgach ozod bo'ladi

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ Band-task: bitta kasbda ikkinchi brom rad, ikkinchi kasbda parallel brom ruxsat (AC11)

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `qty > norm_per_day` -> rad; kunlik jami normativdan oshsa -> RUXSAT (test ikkalasini ham qamraydi)

  • ✓

    qa-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `@RequirePermission("work.claim")`; `suspended`/`fired` hodim `403`

  • ⇄

    coder-ep-07-t03-s02 statusni o'zgartirdi Ishlanyapti → Review

  • ✎

    coder-ep-07-t03-s02 yangiladi

    Yangilandi: branch, commit_sha

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ Parallel brom testi (2 thread): jami `qty_claimed` hech qachon `required_qty` dan oshmaydi

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ R16: normativ qatori yo'q -> brom aniq xato kodi bilan bloklanadi, default norm ishlatilmaydi

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `submitted` yoki `rejected` work ham band ushlaydi; `confirmed` bo'lgach ozod bo'ladi

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ Band-task: bitta kasbda ikkinchi brom rad, ikkinchi kasbda parallel brom ruxsat (AC11)

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `qty > norm_per_day` -> rad; kunlik jami normativdan oshsa -> RUXSAT (test ikkalasini ham qamraydi)

  • ✓

    coder-ep-07-t03-s02 qabul mezonini belgiladi

    ✓ `@RequirePermission("work.claim")`; `suspended`/`fired` hodim `403`

  • 📄

    coder-ep-07-t03-s02 fayllarni qayd etdi

    9 ta fayl qayd etildi

  • ⇄

    coder-ep-07-t03-s02 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-07-t03-s02 ishga oldi

  • ✦

    pm-agent yaratdi

    `work.claim` — over-claim, normativ tavani, band-task gate

Ma'lumot

Agent
coder-ep-07-t03-s02
Olingan
1 о аввал
Boshlandi
25.08.2026 11:56
Tugadi
25.08.2026 12:57
Baho
6 soat
Spec
erp/docs/modules/07_tasks.md#5
Branch
feat/EP-07-erpbom-backend
Commit
553394bc53b5
Pull request →

Bog'liqliklar

Bundan oldin tugashi kerak

Yo'q — bu ish mustaqil.

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-07-T03-S02/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-07-T03-S02/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'