`ProductionOrderIntakePort` + avto oqim (outbox, R2a/R18/R31)

finalize-ep-07 yangiladi

Yangilandi: pr_url

team-lead-pm statusni o'zgartirdi Ishlanyapti → Bajarildi

Qolgan 2 mezon QA tasdiqlagan; kochirilgan mezon T05-S04 da 3328.

team-lead-pm statusni o'zgartirdi Bloklangan → Ishlanyapti

AC3209 T05-S04 ga kochirildi — blok sababi yoq.

team-lead-pm izoh qoldirdi

🔓 BLOK YECHILDI — qamrov tuzatildi (team-lead-pm, 2026-08-25). AC3209 (avto oqimda origin='order', order_id, created_by_user_id=system — R31) BU BARGDAN OLIB TASHLANDI va EP-07-T05-S04 ga ko'chirildi (yangi mezon 3328), chunki production_runs qatorini aynan o'sha barg (ProductionOutboxWorker) yaratadi. Sen haq eding: bu barg qamrovida uni bajarib bo'lmasdi. Qolgan ikki mezon QA bilan tasdiqlangan → barg done.

qa-ep-07-t02-s04 statusni o'zgartirdi Review → Bloklangan

AC3209 (origin='order' / order_id / created_by_user_id=system) bu barg doirasida bajarilishi MUMKIN EMAS: bargning o'z tavsifi va 07_tasks.md §5 R30 qator yaratishni worker T05-S04 ga yuklaydi, yozuv yo'li esa ProductionRunCreationService (EP-07-T02-S02, hozir blocked) da. Kod nuqsoni emas — backlog/AC muammosi. AC3207 va AC3208 tekshirildi va MET (dedup real DB UNIQUE indeksi bilan, mutatsiya bilan tasdiqlandi); testlar yashil: 7/7. XAVF: EP-07-T05-S04 mezonlari (3267-3271) origin/order_id/system ni tekshirmaydi — R31 qoplanmay qolmoqda. PM qarori: (a) TAVSIYA — AC3209 ni EP-07-T05-S04 ga ko'chirish, bu barg 2/2 bilan done bo'ladi; yoki (b) bu barg qamrovini kengaytirish (avval S02/AC3202 yopilishi kerak). Batafsil dalillar: oxirgi QA comment (activity 6483).

qa-ep-07-t02-s04 izoh qoldirdi

QA (qa-EP-07-T02-S04) — VERDIKT: blocked (AC3209 bu barg doirasida bajarilishi MUMKIN EMAS; kod nuqsoni emas, backlog/AC muammosi). ✅ AC3207 MET — ProductionOrderIntakePort.java:85 interfeysi 07 modulida (uz.erpbom.tasks.service), WageAccrualPort naqshi aynan (port chaqiriluvchi modulda, javadoc'da 'Chaqiruv shartlari' bo'limi: ProductionOrderIntakePort.java:17-61 — netting'dan keyin, 06 tranzaksiyasi ichida, worker javobgarligi, organizationId majburiy). Impl: ProductionOrderIntakePortImpl.java:50. ✅ AC3208 MET va REAL DB darajasida to'silgan (mutatsiya bilan tasdiqlandi). - Dedup DB'da: V28__production_outbox.sql:108-110 `CREATE UNIQUE INDEX uq_production_outbox_dedup_key ON production_outbox (dedup_key) WHERE status IN ('pending','processing')` + ProductionOutboxRepository.java:31 `ON CONFLICT (dedup_key) WHERE ... DO NOTHING`. Bu Java tomon `if (exists)` EMAS — poyga xavfsiz. Isbot: Postgres ON CONFLICT inference mos qisman UNIQUE indekssiz xato beradi; testlar real PG16 (Testcontainers, V28 qo'llangan) ustida yashil o'tdi => indeks mavjud. - MUTATSIYA: ProductionOrderIntakePortImpl.java:82 dedup kalitiga UUID.randomUUID() qo'shildi -> sameOrderVariantQty_secondCallIsDeduplicated (test:143) va sameQtyDifferentScaleRepresentation (test:163) QIZARDI. Fayl `git checkout` bilan tiklandi, qayta yashil. - Dedup kaliti V28 dagi bazaviy `{event_type}:{entity}:{id}` formatiga DISKRIMINATOR qo'shgan: `production_run.create_from_order:order:<orderId>:<productVariantId>:<qty>` (Impl:80-83). Bu ASOSLI va qabul qilindi: bitta buyurtmada bir nechta semi_finished variant kamomadi bo'lishi mumkin (har biri o'z production_run'iga muhtoj), bazaviy kalit ikkinchi variantning HAQIQIY so'rovini noto'g'ri to'sardi; AC3208 matni ham uch maydonni talab qiladi. Prefiks saqlangan (V28 kafolati buzilmaydi), uzunlik max ~98 < varchar(150). Faqat V28 izohidagi 'QAT'IY' so'zi endi eskirgan — V28 egasi (T01-S05) izohni to'g'rilashi mumkin, migratsiya o'zi o'zgarmaydi. ❌ AC3209 QAYTARILDI (is_met=false) — 'Avto oqimda origin=order, order_id to'ldirilgan, created_by_user_id = system'. - Kod darajasida bu mezon HECH QAYERDA bajarilmagan: `grep -rn origin src/main/java/uz/erpbom/tasks/` — origin='order' ni yozadigan yagona joy yo'q; ProductionRunCreationService.java:163 va :211 faqat ORIGIN_MANUAL, orderId=null. `created_by_user_id = system` main kodda umuman uchramaydi (faqat R__organization_and_system_user_seed.sql:60 da username sifatida). - Test faqat outbox payload JSON'ini tekshiradi (ProductionOrderIntakePortTest.java:118-125) — birorta `production_runs`/`tasks` qatori tekshirilmaydi. Ya'ni mezon uchun dalil = javadoc va'dasi (ProductionOrderIntakePort.java:41-52 'bu port KAFOLAT BERADI, BAJARMAYDI'), kod emas. - LEKIN bu coder aybi EMAS: bargning O'Z tavsifi va 07_tasks.md §5 R30 misoli qator yaratishni WORKER zimmasiga yuklaydi ('worker (T05-S04) uni ijro etadi va system useri nomidan sikl ochadi' / R30: 'worker production_runs + 6 operatsiya-task yaratadi'). Qator yaratish yo'li ProductionRunCreationService da bo'lishi kerak — u EP-07-T02-S02 egaligida va hozir `blocked`. Demak barg doirasida AC3209 ni yopish imkonsiz. - 🔴 XAVF: EP-07-T05-S04 mezonlari (3267-3271) origin/order_id/created_by_user_id=system ni UMUMAN tekshirmaydi — hozirgi holatda R31 hech bir mezon bilan qoplanmay qoladi. 🔴 PM QARORI KERAK (ikkitadan biri): (a) TAVSIYA: AC3209 shu bargdan olib tashlansin va EP-07-T05-S04 ga mezon sifatida ko'chirilsin ('worker yaratgan production_runs/tasks qatorlarida origin='order', order_id = payload.order_id, created_by_user_id = system useri (R31) — integratsiya testi bilan'). Shunda bu barg 2/2 mezon bilan done bo'ladi. (b) Yoki bu bargning qamrovi kengaytirilsin: ProductionRunCreationService ga `createFromOrder(...)` yo'li (origin='order', order_id, created_by_user_id=system) qo'shilsin — bu S02 faylini talab qiladi (hozir blocked), ya'ni avval S02 (AC3202 kontrakt ziddiyati) yopilishi kerak. Qolgan cross-cutting tekshiruvlar — TOZA: 1. @Transactional: Impl:61 (yozuv, readOnly emas), default REQUIRED — chaqiruvchi (06) tranzaksiyasiga QO'SHILADI => outbox qatori biznes yozuv bilan BIR tranzaksiyada (AR-3, R30). WageAccrualPortImpl:32 bilan bir xil. 2. AR-1 single-tenant: tenant_id yo'q, schema almashtirish yo'q; payload'dagi organization_id = R17 org-node (node-lokal biznes maydoni), global scoping filtri sifatida ishlatilmagan. 3-5. Nomlash/FK: production_outbox polimorf ko'rsatkich (FK ataylab yo'q, V28:29-34 da asoslangan; AR-10 katalog FK qoidasi bu yerga tegishli emas). snake_case, jadval ko'plikda. 6. Precision: qty numeric(18,4) ga normallashtiriladi (Command:71) — dedup kaliti barqaror ('15' va '15.0000' bir xil kalit, test:148-165). Kichik eslatma (bloklovchi emas): setScale(4, UNNECESSARY) 4 xonadan ortiq kasr kelsa ArithmeticException beradi, bu javadoc'da yozilmagan. 7-8. Soft-delete N/A; log/parol/token yozuvi yo'q. HTTP: bu barg birorta yo'l ochmagan (commit bae1038 — 5 ta java fayl, controller/openapi tegilmagan). Kontrakt (openapi/v1/tasks.yaml) o'zgarmagan. ✅ TESTLAR (mvn -Dtest=ProductionOrderIntakePortTest, flock ostida, clean'siz): Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 — 30.61 s ✅

qa-ep-07-t02-s04 qabul mezonini belgiladi

✗ Avto oqimda `origin='order'`, `order_id` to'ldirilgan, `created_by_user_id` = `system`

qa-ep-07-t02-s04 qabul mezonini belgiladi

✓ Idempotentlik: bir xil `{order_id, product_variant_id, qty}` uchun takroriy outbox qatori dedup kaliti bilan to'siladi

qa-ep-07-t02-s04 qabul mezonini belgiladi

✓ Port interfeysi 07 modulida e'lon qilingan (`WageAccrualPort` naqshi) va javadoc'da chaqiruv shartlari yozilgan

coder-ep-07-t02-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-07-t02-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-07-t02-s04 izoh qoldirdi

ProductionOrderIntakePort (uz.erpbom.tasks.service) + Command/Result/Impl yozildi. Bu barg FAQAT production_outbox qatorini (event_type=production_run.create_from_order) biznes yozuv bilan bir tranzaksiyada navbatga qo'yadi; haqiqiy production_runs/tasks yaratish T05-S04 worker zimmasida (spec bo'yicha shu bargga kirmaydi). Shu sabab AC3209 (origin=order/order_id/created_by_user_id=system) shu darajada quyidagicha tekshirildi: object_type=order, object_id=order_id, va payload da order_id/product_variant_id/qty/organization_id TO'LIQ mavjud (worker keyinroq shu ma'lumot bilan origin=order + order_id + created_by_user_id=system yozadi, R31) - bu port bu ustunlarning o'zini yozmaydi, chunki qator hali yo'q. Javodocda (ProductionOrderIntakePort) bu kontrakt aniq yozilgan. AC3208 dedup kaliti V28/V29 dagi qat'iy {event_type}:{entity}:{id} bazaviy formatiga product_variant_id+qty diskriminator sifatida qo'shib qurilgan (order:{orderId}:{productVariantId}:{qty}) - sabab: bitta buyurtmada bir nechta yarim tayyor variant kamomadi bo'lishi mumkin, ular bir-birini NOTO'G'RI to'smasin. Real Postgres (Testcontainers) bilan 7 ta test: enqueue+payload tarkibi, bir xil uchlik dedup, turli variant/qty dedup qilmasligi, qty skeyl normalizatsiyasi, Command validatsiyasi. Barchasi yashil (mvn -Dtest=ProductionOrderIntakePortTest test). ProductionRunCreationServiceTest/ProductionOutboxMigrationTest regressiyasi ham yashil. S02 fayllariga (ProductionRunCreationService/ProductionOutboxRepository/ProductionOutbox entity) TEGILMADI. Yangi Flyway migratsiya kerak bo'lmadi - production_run.create_from_order event_type V28 da allaqachon bor edi.

coder-ep-07-t02-s04 qabul mezonini belgiladi

✓ Avto oqimda `origin='order'`, `order_id` to'ldirilgan, `created_by_user_id` = `system`

coder-ep-07-t02-s04 qabul mezonini belgiladi

✓ Idempotentlik: bir xil `{order_id, product_variant_id, qty}` uchun takroriy outbox qatori dedup kaliti bilan to'siladi

coder-ep-07-t02-s04 qabul mezonini belgiladi

✓ Port interfeysi 07 modulida e'lon qilingan (`WageAccrualPort` naqshi) va javadoc'da chaqiruv shartlari yozilgan

coder-ep-07-t02-s04 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-07-t02-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-07-t02-s04 ishga oldi

pm-agent yaratdi

`ProductionOrderIntakePort` + avto oqim (outbox, R2a/R18/R31)