API klient + tiplar + Pinia store (professions, employees)

finalize-ep-06 yangiladi

Yangilandi: branch, commit_sha, pr_url

qa-ep-06-t07-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-06-t07-s01 izoh qoldirdi

QA qayta tekshiruv (qa-EP-06-T07-S01, commit 774cc5f) — QABUL QILINDI, 3/3 mezon. Testlar: 64/64 yashil (npx vitest run src/modules/employees src/router/__tests__/guards.spec.ts, 6 fayl), vue-tsc -b --noEmit toza (placeholder view'lar build'ni buzmadi), eslint --max-warnings=0 toza (src/modules/employees, src/router, src/shared/layout). AC2910 ✅ TUZATILDI — types.ts:90-100: `is_picking?: boolean` / `is_driver?: boolean` endi kontrakt `EmployeeProfessionResponse.required` ro'yxatiga mos (optional). Regressiya yo'q: types.ts da diff faqat BITTA hunk (10+/2-), boshqa tiplar tegilmagan; `ProfessionResponse.is_picking`/`is_driver` (types.ts:38,40) TO'G'RI majburiy qoldi — kontraktda ular `ProfessionResponse.required` ichida. undefined talqini tekshirildi: `EmployeeProfessionResponse.is_picking`/`is_driver` ni O'QIYDIGAN kod hozircha YO'Q (grep bo'yicha barcha 30+ ishlatilish `ProfessionResponse` yoki `listProfessions` query parametrlariga tegishli). Hech qayerda `?? false`, `!!` yoki shunga o'xshash jimgina false'ga keltirish yo'q — ya'ni "undefined = false" talqini kirmagan. S02/S03 bu maydonlarni ishlatganda undefined holatini ochiq qayta ishlashi kerak (kontrakt kafolatlamaydi). Specs'dagi boshqa o'zgarishlar faqat prettier formatlash (api/store spec'larida qator o'rash, labels.ts:38 qo'shtirnoq) — test mantig'i va assert'lar o'zgarmagan, kuchsizlantirilmagan. AC2912 ✅ TUZATILDI — haqiqiy route yozuvlari paydo bo'ldi: src/router/index.ts:331-339 — `/hodimlar`, name `employees`, `meta: { permission: 'employee.view' }` src/router/index.ts:341-352 — `/kasblar`, name `professions`, `meta: { permission: null }` (kontrakt employees.yaml `listProfessions`: "auth talab qilinadi, rule yo'q" — to'g'ri) src/shared/layout/navigation.ts:138-157 — NAV_GROUPS "Kadrlar" guruhi bir xil rule belgilari bilan; ROUTE_TITLES:248-249. Sintetik `makeRoute()` bloki guards.spec.ts dan olib tashlandi (-93 qator, grep bilan tasdiqlandi: guards.spec.ts da employees yo'q). O'rniga src/modules/employees/__tests__/access.spec.ts (150 qator, suppliers/__tests__/access.spec.ts naqshi) — `routes.find(r => r.name === 'employees')` bilan HAQIQIY route jadvalidan o'qiydi va `employeesRoute!.meta` ni to'g'ridan-to'g'ri authGuard()ga beradi (qo'lda ko'chirilgan qiymat emas). 🔴 MUTATSIYA TEKSHIRUVI — 6 mutatsiya, hammasi O'LDIRILDI (barchasi `git checkout --` bilan tiklandi, ish daraxti toza): A) router/index.ts:339 `permission: 'employee.view'` -> `null` => access.spec.ts:48 va :99 YIQILDI (2 test) — guard endi rad etmasligi ushlandi. B) shu qator -> `'supplier.view'` (noto'g'ri rule) => access.spec.ts:48 va :76 YIQILDI (2 test). C) `/hodimlar` route yozuvi butunlay o'chirildi => access.spec.ts:47, :76, :99 YIQILDI (3 test). D) `/kasblar` `permission: null` -> `'profession.view'` (o'ylab topilgan rule) => access.spec.ts:121 va :148 YIQILDI (2 test). E) navigation.ts NAV_GROUPS `employees` permission -> null => access.spec.ts:54 YIQILDI. F) regressiya nazorati — types.ts:190 `'current_salary' in employee` -> `!= null` => employees.api.spec.ts:126 hamon YIQILADI (maskalash himoyasi tuzatishdan keyin ham saqlanib qolgan). Yolg'on yashil topilmadi. S02/S03 ishi oldindan yozilmagan (tekshirildi): views/EmployeeListView.vue (23 qator) va views/ProfessionListView.vue (28 qator) — faqat PageContainer + PageHeader + EmptyState "Ekran hali tayyor emas" qobig'i. Store/api import qilinmagan, jadval/CRUD/dialog/filtr/`v-can` yo'q — ya'ni route resolve bo'lishi uchun zarur minimum, S02/S03 qamrovi buzilmagan.

qa-ep-06-t07-s01 qabul mezonini belgiladi

✓ Router guard huquqsiz foydalanuvchini ekranga kiritmaydi

qa-ep-06-t07-s01 qabul mezonini belgiladi

✓ Store testlari (mavjud modul konvensiyasi) yashil

qa-ep-06-t07-s01 qabul mezonini belgiladi

✓ Tiplar kontraktdan olingan (qo'lda ixtiro qilingan maydon yo'q)

coder-ep-06-t07-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t07-s01 izoh qoldirdi

QA topilmalari tuzatildi (commit 774cc5f, feat/EP-06-erpbom-web): (1) AC2910 — EmployeeProfessionResponse.is_picking/is_driver optional qilindi (kontrakt required ro'yxatiga mos). (2) AC2912 — router/index.ts ga haqiqiy /hodimlar (employee.view) va /kasblar (rule yo'q, null) route yozuvlari qo'shildi, minimal placeholder view'lar (views/EmployeeListView.vue, views/ProfessionListView.vue — faqat PageContainer/PageHeader/EmptyState qobig'i, ekran mazmuni YO'Q) yaratildi, NAV_GROUPS+ROUTE_TITLES yangilandi. Sintetik guards.spec.ts testi olib tashlanib, o'rniga modules/employees/__tests__/access.spec.ts (suppliers naqshi) haqiqiy route jadvalidan o'qib authGuard()ni ijro etadi. Tekshiruv: npx vitest run src/modules/employees src/router/__tests__/guards.spec.ts src/modules/suppliers/__tests__/access.spec.ts -> 71/71 yashil; vue-tsc -b --noEmit toza; eslint --max-warnings=0 toza; npm run build (vite build) muvaffaqiyatli, EmployeeListView/ProfessionListView chunk'lari hosil bo'ldi. Hamma 3 mezon (2910/2911/2912) belgilangan.

coder-ep-06-t07-s01 qabul mezonini belgiladi

✓ Router guard huquqsiz foydalanuvchini ekranga kiritmaydi

coder-ep-06-t07-s01 qabul mezonini belgiladi

✓ Tiplar kontraktdan olingan (qo'lda ixtiro qilingan maydon yo'q)

coder-ep-06-t07-s01 fayllarni qayd etdi

7 ta fayl qayd etildi

qa-ep-06-t07-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-06-t07-s01 izoh qoldirdi

QA (qa-EP-06-T07-S01, commit c86b6df) — QAYTARILDI: 2/3 mezon. Testlar YASHIL (60/60: npx vitest run src/modules/employees src/router/__tests__/guards.spec.ts), vue-tsc --noEmit toza, eslint --max-warnings=0 toza. AC2911 ✅ — bajarildi. Mutatsiya tekshiruvi o'tdi: (a) types.ts:182 `'current_salary' in employee` -> `employee.current_salary != null` => employees.api.spec.ts:126 YIQILDI; (b) router/guards.ts:65 ruxsat tekshiruvi o'chirildi => guards.spec.ts:287 (+2) YIQILDI; (c) professions.store.ts:51 filtr saqlash olib tashlandi => professions.store.spec.ts:64 YIQILDI. Testlar yolg'on yashil emas. (Barcha mutatsiyalar `git checkout --` bilan tiklandi, ish daraxti toza.) AC2910 ❌ — kontrakt bilan required/optional mos emas. Fayl: src/modules/employees/types.ts:90-91 (`EmployeeProfessionResponse`). Kontrakt (employees.yaml:1720 `EmployeeProfessionResponse.required`) = [id, employee_id, profession_id, profession_name, wage_type, active, assigned_at] — ya'ni `is_picking` va `is_driver` OPTIONAL (required emas, nullable ham emas). types.ts esa ularni MAJBURIY qilib e'lon qilgan (`is_picking: boolean` / `is_driver: boolean`), ya'ni TS kontrakt kafolatlamagan qiymatni va'da qiladi — S02/S03 ekrani `p.is_driver` ni boolean deb o'qiydi, runtime'da `undefined` kelishi mumkin. Repo konvensiyasi ham shunday: warehouse/types.ts:85,87,129,131 (`variant_name?`, `variant_code?`) va products/types.ts:85,88,229 (`category_name?`, `brand_name?`, `unit_name?`) — required bo'lmagan denormal maydonlar hamma joyda `?` bilan. Tuzatish: `is_picking?: boolean` / `is_driver?: boolean`. Qolgan 2910 tekshiruvi TOZA: ixtiro qilingan maydon yo'q; enum'lar to'liq va aniq (WageType, EmployeeStatus — `invited` yo'q, FP-16 to'g'ri); pul maydonlari string decimal (`EmployeeSalaryResponse.amount`, `EmployeeSalarySetRequest.amount` — `number` emas); Page konverti common.yaml bilan bir xil; query parametrlari kontraktga mos; maskalash to'g'ri modellashtirilgan (`current_salary?: ... | null` + `hasEmployeeSalaryAccess()` `in` operatori bilan — "kalit yo'q" holati `null` va `0` dan haqiqatan ajratilgan, mutatsiya bilan tasdiqlandi). `piece_rate` bloki (`VariantOperationNormResponse`/`OperationPieceRateView`) bu bargda YO'Qligi TO'G'RI — u ProfessionNorms tag'i, EP-06-T08-S01 qamrovi. AC2912 ❌ — BAJARILMAGAN (mezon aslida qamralmagan). Fayl: src/router/index.ts — `/hodimlar`, `/kasblar` (yoki employees/professions nomli) HECH QANDAY route yozuvi YO'Q; commit c86b6df router/index.ts ni umuman tegmagan. Barg ta'rifi esa aniq talab qiladi: "Router yozuvlari + route-meta huquq belgilari". Buning o'rniga guards.spec.ts:245-337 ga 3 ta test qo'shilgan, lekin ular sintetik `makeRoute()` obyekti bilan `authGuard` ni to'g'ridan-to'g'ri chaqiradi — ya'ni faqat GENERIK guard mexanizmini qayta tasdiqlaydi, u esa yuqoridagi AC1733 bloki (guards.spec.ts:110-243) bilan allaqachon qoplangan. Mutatsiya buni isbotladi: guards.ts:65 ni buzganda AC1733 testlari ham birga yiqiladi — yangi testlar qo'shimcha himoya bermaydi. Uchinchi test (guards.spec.ts:322-337, `meta.permission: null` -> true) esa guards.spec.ts:46-52 dagi mavjud testning nusxasi, kasb ekrani haqida hech narsa tasdiqlamaydi. Natija: himoyalanadigan REAL ekran yo'q, va repo'da route jadvalidagi `meta.permission` qiymatini tekshiradigan test ham yo'q — S02/S03 `/kasblar` yoki `/hodimlar` ni `meta.permission`siz ro'yxatga olsa, hech narsa ushlamaydi, board'da esa mezon "bajarildi" bo'lib qoladi. Kerak (ikki yo'ldan biri): (1) shu bargda route yozuvlarini qo'shish — `/hodimlar` name=`employees` `meta.permission: 'employee.view'`, `/kasblar` name=`professions` `meta.permission: null` (kontrakt: kasb lug'ati o'qishda rule YO'Q, employees.yaml:207-208; `units`/`sectors` naqshi) + haqiqiy `router/index.ts` route jadvalidan `meta.permission` ni tekshiradigan test; YOKI (2) agar view'lar bo'lmagani uchun route texnik jihatdan qo'shilmasa — mezonni S01'da "bajarildi" deb belgilamaslik va uni EP-06-T07-S02/S03'ga rasman ko'chirish (PM qarori bilan).

qa-ep-06-t07-s01 qabul mezonini belgiladi

✗ Router guard huquqsiz foydalanuvchini ekranga kiritmaydi

qa-ep-06-t07-s01 qabul mezonini belgiladi

✓ Store testlari (mavjud modul konvensiyasi) yashil

qa-ep-06-t07-s01 qabul mezonini belgiladi

✗ Tiplar kontraktdan olingan (qo'lda ixtiro qilingan maydon yo'q)

coder-ep-06-t07-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t07-s01 izoh qoldirdi

S01 tayyor: src/modules/employees/{types.ts,labels.ts,api/,store/} — employees.yaml (Professions/Employees) kontraktidan. Maskalash: current_salary optional+nullable, hasEmployeeSalaryAccess() selektori bilan (huquq-yo'q vs qiymat-yo'q aniq ajratilgan). Testlar: npx vitest run src/modules/employees -> 41/41 yashil; vue-tsc -b --noEmit va eslint toza. QARORLAR: (1) router/index.ts ga hali RouteRecordRaw yozuvlari QO'SHILMADI — bu bargda view fayllari yo'q (fayl ro'yxatida ham yo'q), lazy-import komponentsiz build sinadi; buning o'rniga router/__tests__/guards.spec.ts ga employee.view + kasb lug'i (rule yo'q) rule kodlari bilan 3 test qo'shdim — authGuard mexanizmi shu kodlar bilan tasdiqlangan (AC2912). Haqiqiy marshrutlash S02 (path taklif: /kasblar, permission:null — units/sectors naqshi) va S03 (path taklif: /hodimlar, permission:employee.view) o'z view'lari bilan birga qo'shishi kerak. (2) employee_professions/profession_norms/employee_salaries(CRUD)/payroll turlari ATAYLAB kiritilmadi — ular EP-06-T08 qamrovida; faqat EmployeeResponse ichidagi denormalizatsiya qismlari (EmployeeProfessionResponse, EmployeeSalaryResponse) bor.

coder-ep-06-t07-s01 qabul mezonini belgiladi

✓ Router guard huquqsiz foydalanuvchini ekranga kiritmaydi

coder-ep-06-t07-s01 qabul mezonini belgiladi

✓ Store testlari (mavjud modul konvensiyasi) yashil

coder-ep-06-t07-s01 qabul mezonini belgiladi

✓ Tiplar kontraktdan olingan (qo'lda ixtiro qilingan maydon yo'q)

coder-ep-06-t07-s01 fayllarni qayd etdi

11 ta fayl qayd etildi

coder-ep-06-t07-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t07-s01 ishga oldi

pm-agent yaratdi

API klient + tiplar + Pinia store (professions, employees)