`ProfessionNormController` — REST + marshrut kesimida o'qish

finalize-ep-06 yangiladi

Yangilandi: commit_sha, pr_url

finalize-ep-06 statusni o'zgartirdi Ishlanyapti → Bajarildi

finalize-ep-06 statusni o'zgartirdi Bloklangan → Ishlanyapti

finalize-ep-06 statusni o'zgartirdi Ishlanyapti → Bloklangan

FINALIZE EP-06 drift gate (scripts/openapi-diff.sh v1/employees) — verdikt: BLOCKING (exit=1), A toifasida piece_rate maydoni "properties.deleted" bo'lib chiqdi: kontrakt e'lon qilgan kalitni springdoc generatsiya qilgan hujjatda TOPMAYDI. Sabab: kalit RBAC bo'yicha shartli qilingan — @JsonIgnore + @JsonAnyGetter naqshi (VariantOperationNormResponse + VariantOperationNormPage.items), springdoc @JsonAnyGetter chiqaradigan kalitlarni ko'rmaydi. Xatti-harakat TO'G'RI (huquq bo'lsa kalit real javobda bor), lekin HUJJAT kontraktdan chetda — bu A toifasi va baseline bilan "qabul qilib" bo'lmaydi (write-baseline A ni ataylab yozmaydi). Kerakli tuzatish KODDA (kontrakt daxlsiz): shartli kalitni springdoc'ga ko'rsatish — mas. @Schema bilan e'lon qilingan xossa yoki OpenApiCustomizer/ModelConverter orqali qo'shish. Finalize agenti kodni tuzatmaydi (epic-finalize qoida 1).

finalize-ep-06 statusni o'zgartirdi Bajarildi → Ishlanyapti

finalize EP-06 — drift A toifasi

qa-ep-06-t04-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-06-t04-s03 izoh qoldirdi

QA (qa-EP-06-T04-S03) — 5/5 mezon TEKSHIRILDI, done. TESTLAR (QA o'zi yurgizdi, flock ostida): - ProfessionNormControllerIntegrationTest: Tests run: 14, Failures: 0, Errors: 0 - PieceRateControllerIntegrationTest (EP-02 regressiya): Tests run: 17, Failures: 0, Errors: 0 MUTATSIYA TEKSHIRUVI (3 ta ataylab buzish -> test yiqildi -> tiklandi, bytecode javap bilan tasdiqlandi): 1. VariantOperationRepository: ORDER BY olib tashlandi (@Query bilan) -> routeListReturnsOperationsOrderedByOperationNoRegardlessOfInsertionOrder YIQILDI (expected: 1, but was: 2). AC2878 testi HAQIQIY — fixture operatsiyalarni teskari tartibda (PK tartibi operation_no ga TESKARI) kiritadi. 2. ProfessionNormRepository: org-node filtri parametrni e'tiborga olmaydigan qilindi -> routeListReturnsNodeLocalNorm YIQILDI (expected: "6.0000" but was: "4.0000"). AC2880 testi HAQIQATAN node-lokal. 3. POST dagi @RequirePermission olib tashlandi -> creatingWithoutSetPermissionReturnsForbidden YIQILDI (expected 403, but was 201 CREATED). AC2881 testi haqiqiy. Tiklashdan keyin: git diff bo'sh, 3 ta .class QO'LDA o'chirilib qayta kompilyatsiya qilindi, javap bytecode'da @Query yo'q / org filtri joyida / 4 ta @RequirePermission bor — testlar yana 14/14 yashil. MEZONLAR: - 2878 (tartib): VariantProfessionNormService#listRoute qator manbai RecipeVersionService#findActive -> VariantOperationRepository#findByRecipeVersionIdOrderByOperationNoAsc (RecipeVersionService.java:762). Sahifalash sublist bilan, tartib saqlanadi. total_items=3 tekshirildi. - 2879 (null + ajratish): qator manbai variant_operations, profession_norms EMAS -> normativi yo'q operatsiya ham qaytadi, 404 emas. HAQIQIY JSON tekshirildi: {"...","profession_norm":null,"piece_rate":{...}} — kalit BOR, qiymati null. Eslatma: kontraktda alohida boolean 'bayroq' maydoni YO'Q (VariantOperationNormResponse required: [variant_operation_id, operation_no, operation_name, profession_id]); ajratish JSON darajasida "kalit bor + null" vs "kalit umuman yo'q" semantikasi bilan berilgan. Alohida bayroq maydoni qo'shilsa bu AC2882 (drift) ni buzardi — muzlatilgan kontrakt ustun. - 2880 (node-lokal): bitta operatsiya uchun root (4.0000) va child (6.0000) org-node normativlari; ikki so'rov ikki xil qiymat qaytaradi. Kontrakt yaml:135-138 dagi misol bilan bir xil (Toshkent 4/kun, Samarqand 6/kun). - 2881 (403): to'rtta yo'lning HAMMASIDA @RequirePermission("profession_norm.set") — javap bytecode bilan tasdiqlandi (grep emas): listRoute, create, update, listLogs. Huquqsiz POST va PUT -> 403 FORBIDDEN, code=FORBIDDEN. - 2882 (drift YO'Q): maydon-ma-maydon solishtirildi + HAQIQIY JSON chiqarildi. VariantOperationNormResponse kalitlari kontrakt bilan AYNAN: variant_operation_id, operation_no (int32), operation_name, profession_id, profession_name, profession_norm (nullable), piece_rate (shartli). @JsonIgnore ISHLAYDI — piece_rate_visible / piece_rate_or_null JSON'ga SIZIB CHIQMAYDI. piece_rate maskalashi kontrakt (yaml:142-144, 893, 1863) talab qilganidek: huquq yo'q -> kalit UMUMAN yo'q; huquq bor + stavka yo'q -> kalit bor, null. OperationPieceRateView: piece_rate_id, amount, bonus_rate (string decimal). ProfessionNormLogResponse: aynan 7 ta required maydon. Xato kodlari: VALIDATION_ERROR 400, DUPLICATE_PROFESSION_NORM 409, 404, 401, 403 — hammasi test bilan qoplangan. RBAC CHETLANISHI TASDIQLANDI (coder haq): kontrakt preambulasi (employees.yaml:41-55 "Normativni O'QISH — profession_norm.set") va to'rtta endpoint summary (879, 927, 982, 1026-qatorlar) — hammasi FAQAT profession_norm.set. piece_rate.view kontraktda endpoint darajasida HECH QAYERDA yo'q, faqat javob ichidagi blok maskalashi. Task brief'idagi "YOKI piece_rate.view" kontraktga zid edi — muzlatilgan kontrakt ustun. S01 dan QOLDIRILGAN ISH — BAJARILGAN: variant_operation_id ning marshrutga tegishliligi VariantProfessionNormService#requireOperationInActiveRoute da tekshiriladi; begona variantning operatsiyasi bilan POST -> 400 VALIDATION_ERROR (createRejectsOperationNotBelongingToVariantRoute testi bilan qoplangan). CROSS-CUTTING: o'qish metodlari @Transactional(readOnly=true), yozish @Transactional; tenant_id YO'Q (org-node = organizations FK); fizik DELETE yo'q; snake_case; normativ numeric(18,4) ("4.0000"), stavka numeric(18,2) ("10000.00"); token/parol log'ga yozilmaydi. Modul chegarasi: products ma'lumoti FAQAT products servislari (RecipeVersionService/PieceRateService/ProductVariantService) orqali o'qiladi, repository'ga to'g'ridan-to'g'ri tegilmagan — ADR §2.3 ga mos; aylanma bean bog'liqligi yo'q (kontekst 14 ta testda muammosiz ko'tarildi). KUZATUVLAR (bu bargni bloklamaydi, mezonlarga tegmaydi — EP-06 darajasida ko'rib chiqilsin): 1. PUT /product-variants/{id}/profession-norms/{normId} — yo'ldagi {id} E'TIBORGA OLINMAYDI: normId ning shu variantga tegishliligi tekshirilmaydi, ya'ni A variantning yo'li orqali B variantning normativini yangilash mumkin (ProfessionNormController.java:75-82). Kontrakt PUT uchun bu tekshiruvni TALAB QILMAYDI (POST uchun esa aniq talab qiladi va u bajarilgan) — shuning uchun drift emas, lekin sub-resurs yo'li uchun mantiqan bo'shliq. 2. O'qishda scope_for(profession_norm.set) qo'llanmaydi — node A ga scoped user organization_id=B berib B ning normativini o'qiy oladi. Bu butun kod bazasidagi mavjud naqsh (PieceRateController ham shunday) va @RequirePermission javadoc'i buni service qatlamining ishi deydi; 09_auth §6.1 doirasidagi cross-cutting masala, bu barg emas.

qa-ep-06-t04-s03 qabul mezonini belgiladi

✓ Kontrakt bilan drift yo'q

qa-ep-06-t04-s03 qabul mezonini belgiladi

✓ `profession_norm.set` siz yozishga urinish 403

qa-ep-06-t04-s03 qabul mezonini belgiladi

✓ Boshqa org-node so'ralganda o'sha node'ning normativi qaytadi (node-lokal testi)

qa-ep-06-t04-s03 qabul mezonini belgiladi

✓ Normativ belgilanmagan operatsiya javobda aniq ajratiladi (null qiymat + bayroq), 404 emas

qa-ep-06-t04-s03 qabul mezonini belgiladi

✓ Variant marshruti kesimida o'qish javobi operatsiyalarni `operation_no` bo'yicha tartibda qaytaradi

coder-ep-06-t04-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t04-s03 izoh qoldirdi

Muhim qaror: task tavsifida o'qish RBAC'i "profession_norm.set YOKI piece_rate.view" deb yozilgan, lekin openapi/v1/employees.yaml ning "Muhandislik qarorlari" preambulasi (36-50 qatorlar) va listVariantProfessionNorms/listProfessionNormLogs summary matni so'zma-so'z FAQAT profession_norm.set deydi ("o'qish umumiy autentifikatsiyaga OCHILMADI") — piece_rate.view faqat javobdagi piece_rate blokining ko'rinishini boshqaradi (maskalash), endpoint darajasidagi OR emas. Task ko'rsatmasining o'zi ham "kontrakt bitta rule ko'rsatgan bo'lsa - kontrakt ustun" deydi, shu sabab barcha 4 yo'lda (GET marshrut/POST/PUT/GET logs) yagona @RequirePermission("profession_norm.set") ishlatildi; piece_rate.view faqat VariantProfessionNormService ichida piece_rate maydonini ko'rsatish/yashirish uchun tekshiriladi (@JsonAnyGetter orqali - huquqsiz kalit UMUMAN yo'q, huquqli-lekin-belgilanmagan holatda kalit null qiymat bilan chiqadi). Me'moriy qaror: yangi VariantProfessionNormService (ProfessionNormService'ning o'zi EMAS) yaratildi, chunki RecipeVersionService allaqachon (EP-06-T04-S02) ProfessionNormService'ga bog'liq - agar marshrut o'qish logikasi ProfessionNormService'ga qo'shilsa, ProfessionNormService -> RecipeVersionService bog'liqligi aylanma konstruktor bog'liqlik (Spring circular dependency) hosil qilardi. Cross-module qo'shimchalar (ADR §2.3, mavjud namunalarga o'xshab - ProfessionService#namesByIds kabi): PieceRateService#byVariantOperationIds (+ PieceRateRepository batch metodi) va ProfessionNormRepository#findActiveByVariantOperationIdsAndOrganizationId - ikkalasi ham faqat YANGI metod qo'shish, mavjud metodlarga tegilmagan. Test: 14/14 yashil (ProfessionNormControllerIntegrationTest, real HTTP + Testcontainers PostgreSQL 16). Regressiya tekshirildi: PieceRateControllerIntegrationTest (17/17) va ProfessionControllerIntegrationTest (12/12) ham yashil.

coder-ep-06-t04-s03 qabul mezonini belgiladi

✓ Kontrakt bilan drift yo'q

coder-ep-06-t04-s03 qabul mezonini belgiladi

✓ `profession_norm.set` siz yozishga urinish 403

coder-ep-06-t04-s03 qabul mezonini belgiladi

✓ Boshqa org-node so'ralganda o'sha node'ning normativi qaytadi (node-lokal testi)

coder-ep-06-t04-s03 qabul mezonini belgiladi

✓ Normativ belgilanmagan operatsiya javobda aniq ajratiladi (null qiymat + bayroq), 404 emas

coder-ep-06-t04-s03 qabul mezonini belgiladi

✓ Variant marshruti kesimida o'qish javobi operatsiyalarni `operation_no` bo'yicha tartibda qaytaradi

coder-ep-06-t04-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-06-t04-s03 fayllarni qayd etdi

10 ta fayl qayd etildi

coder-ep-06-t04-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t04-s03 ishga oldi

pm-agent bog'liqlik qo'shdi

→ EP-06-T04-S01

pm-agent yaratdi

`ProfessionNormController` — REST + marshrut kesimida o'qish