`EmployeeController` — REST + RBAC + ro'yxat/qidiruv

finalize-ep-06 yangiladi

Yangilandi: pr_url

qa-ep-06-t03-s04 statusni o'zgartirdi Review → Bajarildi

QA: 5/5 mezon mustaqil tasdiqlandi; 16/16 test yashil; 7 ta mutatsiya (bytecode bilan) mos testlarni yiqitdi; drift gate QA tomonidan jonli ilovadan qayta yurgizildi — bargning O'Z yo'llarida drift NOL, gate yumshatilmagan, ratchet buzilmagan.

qa-ep-06-t03-s04 izoh qoldirdi

QA (qa-EP-06-T03-S04) — 5/5 mezon MUSTAQIL tasdiqlandi, barg `done`. Test: `mvn -Dtest=EmployeeControllerIntegrationTest test` -> **Tests run: 16, Failures: 0, Errors: 0** (exit=0), commit 6a7517a kodi o'zgarmagan holda (HEAD=59c8c2f bilan `git diff 6a7517a HEAD -- <barg fayllari>` bo'sh). MUTATSIYA TEKSHIRUVI (har biri javap bilan bytecode darajasida tasdiqlangan, hammasi tiklandi): 1. `EmployeeRepository.search`: `e.status = :status` -> `<>` => AC2860 testi YIQILDI; 2. `ep.active = true` -> `ep.active = ep.active` => AC2861 testi YIQILDI; 3. `WHERE e.deletedAt IS NULL` -> har doim rost => AC2862 testi YIQILDI; 4. `EmployeeController.list` dan `@RequirePermission` olindi => AC2859 (ro'yxat) testi YIQILDI; 5. `violatesUniqueUserIdConstraint` -> `return true` + `requireOrganization` olindi => QA(a) testi YIQILDI (409 USER_ALREADY_LINKED qaytdi, 404 o'rniga); 6. `@DecimalMin(inclusive=false)` -> `true` => QA(b) testi YIQILDI (201 qaytdi, 400 o'rniga); 7. `EmployeeProfessionController` dan `@RequirePermission` olindi => yangi 2 ta test YIQILDI. Tiklangandan keyin qayta kompilyatsiya + 16/16 yashil; `*.bak` qolmagan. AC2859 — 🔧 QA QO'SHIMCHASI: barg tavsifi `profession.assign` (kasb biriktirish/olib qo'yish) yo'llarini ham RBAC doirasiga kiritadi, lekin `POST/DELETE /employees/{id}/professions` uchun HTTP darajasida `403` + `auth_logs.deny` testi repo'da HECH QAYERDA yo'q edi (S02 mezonlari 2848-2851 faqat biznes qoidalari). QA ikkita test qo'shdi (`assigningProfessionWithoutAssignPermission...`, `unassigningProfessionWithoutAssignPermission...`) — 7-mutatsiya ular yuk ko'tarayotganini isbotladi. 🔴 Bu o'zgarish `EmployeeControllerIntegrationTest.java` da COMMIT QILINMAGAN holda turibdi (QA commit qilmaydi) — commit qilinishi kerak, aks holda qamrov yo'qoladi. AC2859 asosiy qism: 8 yo'l (GET ro'yxat, GET kartochka, POST, PUT, activate, suspend, fire, GET professions) — har biri uchun alohida test, `auth_logs` da HAQIQIY qator `WHERE result='deny' AND action=<rule> AND user_id=<user>` = 1. AC2860/2861/2862 — har birida ijobiy VA salbiy tarmoq: kutilgan hodim `contains`, kutilmagan `doesNotContain`; 2861 da nofaol biriktirish qatori DB'da HAQIQATAN qoladi (`unassign` orqali, `active=false`), 2862 da `UPDATE employees SET deleted_at = now()` bilan haqiqiy soft-delete qatori + kartochka 404. AC2863 — DRIFT: QA gate'ni O'ZI yurgizdi (jonli ilova, HEAD kodidan yig'ilgan `target/classes`, toza DB, `API_BASE_URL=http://127.0.0.1:18080`, ya'ni `GENERATED_OPENAPI_FILE` YO'Q -> skriptning provenance tekshiruvi haqiqiy springdoc hujjatida o'tdi). Natija exit=1, LEKIN mezon "exit 0" emas (toifa siyosati + ratchet): * shu bargning O'Z yo'llarida drift NOL — gate "KODDA BOR, KONTRAKTDA YO'Q" (qo'shimcha) BO'LIMINI umuman chiqarmadi (0 ta), "KONTRAKTDA BOR, KODDA YO'Q" 7 ta operatsiya = `GET/PUT /employees/{id}/salary`, `/salary/logs`, `/employees/{id}/payroll/summary`, `/me/payroll/summary`, `/me/payroll/entries`, `/wage-entries` — hammasi EP-06-T05/T06/T09 hududi; qolgan 2 bloklovchi band `VariantOperationNormResponse/Page.piece_rate` (EP-06-T04); * gate YUMSHATILMAGAN/FILTRLANMAGAN: `git show 6a7517a` `scripts/` va `openapi/` dan BIRORTA faylga tegmagan, ish daraxtida ham ular toza; * ratchet: bargning diffi drift'ni OSHIRA olmaydi — DTO o'zgarishlari faqat hujjatlash-qo'shimchasi (`@Size(max)` -> `@Size(min=1,max)`, `@Schema(format="password")`, xulq o'zgarmagan), yangi endpoint'lar esa 7 ta `paths.deleted` bandini YOPADI. Joriy `weaker_new` = 3 ta, hammasi `sort` pattern (13 -> 3 da'vosi yo'nalish bo'yicha tasdiqlanadi); * qolgan 3 ta `sort` pattern bandi YANGI istisno EMAS: bu gap `drift-baseline.json` da BARCHA baselined modullarda qabul qilingan (auth 5, products 9, suppliers 2, warehouse 13) va `openapi/DRIFT_DECISIONS.md` §5.4 da repo bo'ylab ataylab keyingi bosqichga qoldirilgan deb hujjatlashtirilgan. Hisobot: gate chiqishi + JSON QA scratchpad'ida (`qa-drift-employees.json`, head=59c8c2f). QA(a) tasdig'i: `EmployeeService.saveEmployeeOrThrowAlreadyLinked` endi FAQAT `uq_employees_user_id` constraint NOMI bo'yicha ajratadi + `requireOrganization` INSERT'dan oldin tekshiradi -> noto'g'ri `organization_id` endi `404 NOT_FOUND`, akkaunt takrori `409 USER_ALREADY_LINKED`; HAR IKKI tarmoq ALOHIDA testda va 5-mutatsiya bilan isbotlangan. QA(b) tasdig'i: `amount=0` HTTP qatlamida `400 VALIDATION_ERROR` + `fields[].field` da `amount` (DB CHECK 0 ga ruxsat bersa ham so'rov DB'ga yetib bormaydi); 6-mutatsiya bilan isbotlangan. ⚠️ EPIC YAKUNI UCHUN ESLATMA (bu bargni bloklamaydi): shu barg ochgan `GET /employees` va `GET /employees/{id}` `current_salary` ni HAR QANDAY `employee.view` egasiga qaytaradi (`EmployeeService#buildResponses`), kontrakt esa (employees.yaml 433-434, 1592-1594) va 04_employees.md §7 uni faqat `employee_salary.view` egasiga ochishni talab qiladi. Bu ish EP-06-T05-S02 (`RBAC maskalash`) da rejalashtirilgan va hali `backlog` — epic yopilishidan oldin albatta bajarilishi kerak.

qa-ep-06-t03-s04 qabul mezonini belgiladi

✓ Kontrakt bilan drift yo'q

qa-ep-06-t03-s04 qabul mezonini belgiladi

✓ Soft-delete qilingan hodim ro'yxatda ko'rinmaydi

qa-ep-06-t03-s04 qabul mezonini belgiladi

✓ `profession_id` filtri faqat FAOL biriktirilgan hodimlarni qaytaradi

qa-ep-06-t03-s04 qabul mezonini belgiladi

✓ Ro'yxat `status=fired` filtri bilan faqat bo'shatilganlarni qaytaradi

qa-ep-06-t03-s04 qabul mezonini belgiladi

✓ Har yo'l uchun huquqsiz so'rov 403 va `auth_logs` ga `deny` (mavjud aspekt)

coder-ep-06-t03-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t03-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-06-t03-s04 izoh qoldirdi

AC2863 (drift) — gate ishga tushirildi (scripts/openapi-diff.sh v1/employees, isolated Testcontainers fixture'idan capture qilib GENERATED_OPENAPI_FILE bilan; erpbom-dev-postgres eski/mos kelmaydigan migratsiya versiyasida edi — shu sabab shared dev DB'ga tegilmadi). Natija: exit=1 (blocking). Sabab tahlili (gate'ning o'zi yumshatilmadi/filtrlanmadi): - "KODDA BOR, KONTRAKTDA YO'Q" — 0 ta (MEN qo'shgan yo'llarda ortiqcha yo'q). - "KONTRAKTDA BOR, KODDA YO'Q" — 7 ta, HAMMASI boshqa bargalar doirasida: /employees/{id}/salary(+/logs), /employees/{id}/payroll/summary, /me/payroll/*, /wage-entries (EP-06-T05/EP-06-T06/EP-06-T09 hududi — bu subtask kontrakt qamrovi FAQAT Employees + EmployeeProfessions GET). - BLOKLOVCHI (A) 8 ta: 6 tasi yuqoridagi yo'llar; 2 tasi VariantOperationNormResponse/Page dagi piece_rate strukturaviy farqi (ProfessionNormController/EP-06-T04 hududi, bu bargda tegilmagan). - minLength/format drift (13 ta edi) — EP-05-T02 naqshi bilan tuzatildi (@Size(min=1,...), @Schema(format="password")) — endi 3 ta qoldi, ular HAMMASI sort parametrining `pattern` metadatasi (ParameterCustomizer/@RawQueryValues migratsiyasi kerak — DRIFT_DECISIONS.md §5.4 bo'yicha butun repo miqyosida ATAYLAB keyingi bosqichga qoldirilgan, bu bargda ham shunga rioya qilindi). Xulosa: MEN qo'shgan/tuzatgan yo'llar (GET/POST/PUT /employees, activate/suspend/fire, GET .../professions) kontrakt bilan struktura darajasida mos (0 qo'shimcha, 0 yetishmayotgan yo'l); qolgan blocking drift 100% boshqa subtasklar hali qo'shmagan marshrutlar + boshqa bargaga tegishli 1 ta schema farqi. Butun modul darajasidagi drift-baseline yozish (--write-baseline) barcha employees.yaml subtasklari tugagach qilinishi kerak. AC2863 shu sabab is_met:false qoldirildi (raw gate exit=1) — QA to'liq kontekst bilan qaror qabul qilsin.

coder-ep-06-t03-s04 qabul mezonini belgiladi

✗ Kontrakt bilan drift yo'q

coder-ep-06-t03-s04 qabul mezonini belgiladi

✓ Soft-delete qilingan hodim ro'yxatda ko'rinmaydi

coder-ep-06-t03-s04 qabul mezonini belgiladi

✓ `profession_id` filtri faqat FAOL biriktirilgan hodimlarni qaytaradi

coder-ep-06-t03-s04 qabul mezonini belgiladi

✓ Ro'yxat `status=fired` filtri bilan faqat bo'shatilganlarni qaytaradi

coder-ep-06-t03-s04 qabul mezonini belgiladi

✓ Har yo'l uchun huquqsiz so'rov 403 va `auth_logs` ga `deny` (mavjud aspekt)

coder-ep-06-t03-s04 fayllarni qayd etdi

10 ta fayl qayd etildi

coder-ep-06-t03-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t03-s04 ishga oldi

pm-agent bog'liqlik qo'shdi

→ EP-06-T03-S03

pm-agent bog'liqlik qo'shdi

→ EP-06-T03-S02

pm-agent bog'liqlik qo'shdi

→ EP-06-T03-S01

pm-agent yaratdi

`EmployeeController` — REST + RBAC + ro'yxat/qidiruv