02_products qoldig'i — qoida 26d validatsiyasi + `professionName` javobda

finalize-ep-06 yangiladi

Yangilandi: pr_url

qa-ep-06-t02-s03 izoh qoldirdi

QA (qa-EP-06-T02-S03) — commit 7b29cf7 tekshirildi, 6/6 mezon o'tdi. SPEC MUVOFIQLIGI (02_products qoida 26d / 04_employees §2.4) - RecipeVersionService:455 requirePieceRateProfession() — saveOperations() ichida, nom-takror tekshiruvidan KEYIN, entity save'dan OLDIN. Mavjud emas → NotFound (404), wage_type != 'piece_rate' → 409 INVALID_OPERATION_PROFESSION. Bu 26d ning aynan o'zi — yangi cheklov qo'shilmagan. - Operatsiya yaratishning YAGONA yo'li create()→saveOperations() (grep bo'yicha boshqa yozuv yo'li yo'q), shu sabab orchestration (POST /product-variants) ham qamrab olingan. - Kontrakt: products.yaml:1563 (404 — 'variant yoki component_variant_id/profession_id topilmadi'), :3223 RecipeVersionSaveConflict va :3128 VariantSaveConflict — ikkalasida ham 409 INVALID_OPERATION_PROFESSION bor; xato matni kontrakt misoli bilan bir xil ('Operatsiya kasbi ishbay turida emas'). Chetga chiqish yo'q. - professionName: RecipeVersionService:716 ProfessionService.namesByIds() BATCH (N+1 yo'q); buildResponse() — create/get/activate uchun YAGONA yo'l (:687→:702), demak GET ham to'ladi. MUTATSIYA TEKSHIRUVI (har mutatsiya javap bilan bytecode darajasida tasdiqlandi, keyin git checkout bilan tiklandi; ish daraxti toza, target/classes qayta kompilyatsiya qilindi) - MUT-A RecipeVersionService:457 shart → `wageType == null` (javap: ldc 'piece_rate'+ifne → ifnonnull) ⇒ operationWithNonPieceRateProfessionIsRejectedWith409 YIQILDI ✅ - MUT-D RecipeVersionService:718 professionName → null ⇒ operationResponseIncludesProfessionName YIQILDI ✅ (shu runda unknownOperationProfessionIdReturnsNotFound O'TDI — ya'ni test aynan mavjudlik tekshiruvini nishonlaydi, tautologik emas) - MUT-B RecipeVersionService:386 requirePieceRateProfession() chaqiruvi olib tashlandi ⇒ unknownOperationProfessionIdReturnsNotFound YIQILDI ✅ (DB FK violation 404 o'rniga o'tib ketardi) - MUT-C PieceRateService:201 shart → `wageType == null` (javap tasdiqladi) ⇒ nonPieceRateProfessionOperationReturns409 YIQILDI ✅ Hech bir test assert'siz/tavtologik emas. TESTLAR (flock ostida, mvn clean ISHLATILMADI) - RecipeVersionServiceTest 6/0/0 · RecipeVersionControllerIntegrationTest 35/0/0 · PieceRateControllerIntegrationTest 17/0/0 - AC2841 REGRESSIYA (haqiqatan yurgizildi, 'tegmadim' emas): ProductVariantOrchestrationIntegrationTest 11 · ProductVariantControllerIntegrationTest 23 · ReferenceCostControllerIntegrationTest 8 · SellingPriceControllerIntegrationTest 17 · RecipesAndRoutesMigrationTest 19 · SellingPricesAndPieceRatesMigrationTest 17 · AdditionalPriceRequirementServiceTest 6 = jami 101/0/0, BUILD SUCCESS. - Fixture o'zgarishlari ZAIFLASHTIRMAGAN: numstat bo'yicha RecipeVersionControllerIntegrationTest +90/-0, ProductVariantOrchestrationIntegrationTest +29/-0, PieceRateControllerIntegrationTest +59/-7 (7 qator — faqat eskirgan javadoc bloki), RecipeVersionServiceTest +7/-1 (konstruktor null argumenti). Bironta assert olib tashlanmagan, kutilgan xatti-harakat yumshatilmagan — testlar endi haqiqiy piece_rate professions yozuvlarini yaratadi (FK V19 talabi), tekshiruv kuchaygan. AC2840 — eskirgan izohlar: grep bo'yicha 'professions jadvali hali yo'q' da'vosi qolmagan; RecipeVersionService:69 va VariantOperation:23 dagi eslatmalar O'TGAN ZAMONda ('...edi', 'ilgari...sababli') va V19 ga havola qiladi. VariantOperationResponse:9 va PieceRateService:50-58 yangilangan. Boshqa faylda 26d haqida eskirgan da'vo yo'q. CROSS-CUTTING: yangi metodlar @Transactional(readOnly=true) (ProfessionService:191/:207) · tenant_id/schema mexanikasi qo'shilmagan (AR-1) · katalogga oddiy FK bor (fk_variant_operations_profession, V19) · outbox/broker aralashmagan · snake_case buzilmagan · precision o'zgarmagan · fizik DELETE yo'q · log'ga parol/token chiqmagan. KUZATUVLAR (defekt EMAS, qaytarishga asos emas — kelajakdagi ish uchun) 1. PieceRateService.update() (PUT) da 26d qayta tekshiruvi yo'q. Amalda teshik EMAS: PieceRateUpdateRequest faqat amount/bonusRate ni oladi, variant_operation_id o'zgarmas — ya'ni PUT orqali monthly kasbli operatsiyaga stavka BIRIKTIRIB bo'lmaydi. Yagona qoldiq stsenariy — stavka piece_rate paytida yaratilib, keyin kasb monthly ga o'zgartirilsa, amount tahriri o'tib ketadi. products.yaml:1994-1996 da updatePieceRate javoblarida 409 UMUMAN yo'q (200/400/401/403/404), shu sabab u yerda 409 qo'shish kontrakt drift bo'lardi. AC2838 create yo'lida to'liq yopilgan. 2. getWageType() findById dan foydalanadi — nofaol (active=false) piece_rate kasbni yangi operatsiyaga biriktirish mumkin. Spec 26d faqat wage_type ni talab qiladi, active ni emas — qo'shilsa O'YLAB TOPILGAN qoida bo'lardi, shu sabab hozirgi holat to'g'ri. namesByIds ham active filtrisiz — tarixiy ko'rsatish uchun to'g'ri. 3. saveOperations() da getWageType() har operatsiya uchun alohida chaqiriladi (marshrutda operatsiyalar kam — sezilarli emas); professionName yo'li allaqachon batch.

qa-ep-06-t02-s03 statusni o'zgartirdi Review → Bajarildi

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ EP-02 ning mavjud testlari yiqilmaydi (regressiya)

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ `RecipeVersionService`/`PieceRateService`/`VariantOperationResponse` javadoc'laridagi "professions jadvali hali yo'q" izohlari yangilangan

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ `GET` marshrut javobida `professionName` haqiqiy kasb nomi bilan to'ladi (bo'sh emas)

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ `monthly` kasbli operatsiyaga `piece_rates` belgilashga urinish rad etiladi

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ Mavjud bo'lmagan `profession_id` bilan operatsiya yaratishga urinish 404/422 (kontraktga muvofiq), DB FK violation EMAS

qa-ep-06-t02-s03 qabul mezonini belgiladi

✓ `wage_type='monthly'` kasb bilan marshrut operatsiyasi yaratishga urinish rad etiladi (qoida 26d)

coder-ep-06-t02-s03 izoh qoldirdi

Qoida 26d (RecipeVersionService.saveOperations — 404/409) va PieceRateService.create (409, mustaqil qayta tekshiruv, chunki wage_type keyinroq monthly ga o'zgarishi mumkin) yopildi. professionName endi ProfessionService.namesByIds bilan batch (N+1siz) to'ldiriladi. Cross-module chaqiruvlar uchun ProfessionService ga ikkita YANGI metod qo'shildi (mavjud metodlar o'zgartirilmadi): getWageType(id), namesByIds(ids). Barcha eskirgan "professions jadvali hali yo'q" javadoc izohlari yangilandi (entity/DTO/servis). EP-02 marshrut integratsiya testlari (RecipeVersionController 35/35, PieceRateController+ProductVariantOrchestration+ReferenceCost 36/36 birgalikda, RecipeVersionServiceTest 6/6, ProfessionServiceTest 14/14) — barchasi yashil, fixture'lar haqiqiy piece_rate professions bilan moslashtirildi (ddf403f davomi). ProfessionController* fayllariga tegilmadi.

coder-ep-06-t02-s03 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t02-s03 yangiladi

Yangilandi: branch, commit_sha

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ EP-02 ning mavjud testlari yiqilmaydi (regressiya)

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ `RecipeVersionService`/`PieceRateService`/`VariantOperationResponse` javadoc'laridagi "professions jadvali hali yo'q" izohlari yangilangan

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ `GET` marshrut javobida `professionName` haqiqiy kasb nomi bilan to'ladi (bo'sh emas)

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ `monthly` kasbli operatsiyaga `piece_rates` belgilashga urinish rad etiladi

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ Mavjud bo'lmagan `profession_id` bilan operatsiya yaratishga urinish 404/422 (kontraktga muvofiq), DB FK violation EMAS

coder-ep-06-t02-s03 qabul mezonini belgiladi

✓ `wage_type='monthly'` kasb bilan marshrut operatsiyasi yaratishga urinish rad etiladi (qoida 26d)

coder-ep-06-t02-s03 fayllarni qayd etdi

9 ta fayl qayd etildi

coder-ep-06-t02-s03 ishga oldi

coder-ep-06-t02-s03 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t02-s03 ishga oldi

pm-agent bog'liqlik qo'shdi

→ EP-06-T02-S01

pm-agent yaratdi

02_products qoldig'i — qoida 26d validatsiyasi + `professionName` javobda