V22 — `employee_salaries` + `employee_salary_logs`

finalize-ep-06 yangiladi

Yangilandi: pr_url

qa-ep-06-t01-s04 izoh qoldirdi

QA (qa-EP-06-T01-S04) — V22 tekshiruvi: **o'tdi**. **Spec muvofiqligi** (04_employees.md §2.5 / §2.5a): ikkala jadval ustunma-ustun mos — `employee_salaries`(id, employee_id, amount numeric(18,2), effective_from date, set_by_user_id, created_at, updated_at) va `employee_salary_logs`(id, employee_id, amount numeric(18,2), effective_from, effective_to NOT NULL, changed_by_user_id, created_at). Q6 qarori to'g'ri qo'llangan: `UNIQUE(employee_id)` TO'LIQ (partial emas) — bu jadval log emas, o'zgarish joyida UPDATE; tarix alohida log jadvalida. FK'lar haqiqiy (employees, users), ON DELETE yo'q → RESTRICT. **Mezonlar:** - 2819 — `uq_employee_salaries_employee_id` (to'liq unique) + `secondSalaryRowForSameEmployeeIsRejected` ✓ - 2820 — `chk_employee_salaries_amount_non_negative CHECK (amount >= 0)`; -1.00 rad, 0 ruxsat (chegara testi bor) ✓ - 2821 — Flyway V1…V23 zanjiri ustida `Successfully applied 27 migrations … now at version v23`, `flyway_schema_history` da v22 success=true ✓ **Cross-cutting:** tenant_id yo'q (AR-1) · katalogga oddiy FK (AR-10) · snake_case, jadval ko'plikda, FK to'liq nomdan · precision numeric(18,2) · fizik DELETE yo'q · parol/token log'da yo'q · outbox/tranzaksiya bu subtaskda qo'llanmaydi (faqat DDL). **Kontrakt:** openapi/v1/employees.yaml `EmployeeSalaryResponse` / `EmployeeSalaryLogResponse` maydon nomi va turlari V22 bilan aynan mos. **Mutatsiya tekshiruvi** (V22 SQL ga ataylab buzilish, har safar `git checkout --` bilan tiklangan): 1. `CREATE UNIQUE INDEX` → oddiy `CREATE INDEX` ⇒ `secondSalaryRowForSameEmployeeIsRejected` YIQILDI (killed) 2. `CHECK (amount >= 0)` → `>= -1` ⇒ `negativeAmountIsRejectedByCheckConstraint` YIQILDI (killed) 3. salaries.amount `numeric(18,2)` → `(18,0)` ⇒ `changingSalaryIsDoneInPlaceWithUpdate` YIQILDI (killed, BigDecimal scale orqali) 4. logs.effective_to `NOT NULL` olib tashlandi ⇒ **survived** — hech bir test bu da'voni tekshirmagan edi (ekvivalent mutant emas: spec §2.5a da effective_to majburiy). 5. logs.amount `(18,2)` → `(18,0)` ⇒ dastlab qamrovsiz edi. **QA test kuchaytirishi** (EmployeeSalariesMigrationTest.java, 15 → 19 test; commit QILINMADI, coder/PM commit qilsin): `employeeSalariesColumnsMatchSpecTypesAndNullability`, `employeeSalaryLogsColumnsMatchSpecTypesAndNullability` (information_schema orqali data_type + is_nullable + numeric_precision/scale), `salaryLogWithoutEffectiveToIsRejected` (SQLState 23502), `salaryLogAmountKeepsTwoDecimalScale`. Kuchaytirilgandan keyin 4- va 5- mutantlar ham YIQILDI (3 test qizil). **Test natijasi (toza V22, kuchaytirilgan test):** `Tests run: 19, Failures: 0, Errors: 0, Skipped: 0` — `mvn -Dtest=EmployeeSalariesMigrationTest test`. **Kuzatuv (bu subtask defekti emas, API subtaskiga):** openapi `EmployeeSalarySetRequest.amount` da `minimum: 0` + `exclusiveMinimum: true` — (a) DB CHECK 0 ni ruxsat etadi, kontrakt esa rad etadi, (b) `minimum` `type: string` ga umuman qo'llanmaydi (inert). API taskida aniqlashtirilsin. ⚠️ `RecipesAndRoutesMigrationTest` dagi qizil testlar V19 FK oqibati — S04 ga aloqasi yo'q, bu qarorga ta'sir qilmadi.

qa-ep-06-t01-s04 statusni o'zgartirdi Review → Bajarildi

qa-ep-06-t01-s04 qabul mezonini belgiladi

✓ V22 toza va mavjud bazada xatosiz o'tadi

qa-ep-06-t01-s04 qabul mezonini belgiladi

✓ `amount` manfiy bo'lsa CHECK rad etadi

qa-ep-06-t01-s04 qabul mezonini belgiladi

✓ Bir hodimga ikkinchi maosh qatori insert qilishga urinish `UNIQUE(employee_id)` bilan rad etiladi

coder-ep-06-t01-s04 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t01-s04 yangiladi

Yangilandi: branch, commit_sha

coder-ep-06-t01-s04 qabul mezonini belgiladi

✓ V22 toza va mavjud bazada xatosiz o'tadi

coder-ep-06-t01-s04 qabul mezonini belgiladi

✓ `amount` manfiy bo'lsa CHECK rad etadi

coder-ep-06-t01-s04 qabul mezonini belgiladi

✓ Bir hodimga ikkinchi maosh qatori insert qilishga urinish `UNIQUE(employee_id)` bilan rad etiladi

coder-ep-06-t01-s04 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-06-t01-s04 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t01-s04 ishga oldi

pm-agent bog'liqlik qo'shdi

→ EP-06-T01-S02

pm-agent yaratdi

V22 — `employee_salaries` + `employee_salary_logs`