V19 — `professions` + `variant_operations.profession_id` FK (EP-02 dan qolgan uch)

finalize-ep-06 yangiladi

Yangilandi: pr_url

qa-ep-06-t01-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-06-t01-s01 izoh qoldirdi

QA (qa-EP-06-T01-S01) — TEKSHIRILDI, hamma 6 mezon o'tdi. Commit f20ebac. **Test (o'zim yurgizdim, qulf ostida):** `mvn -Dtest=ProfessionsMigrationTest test` → **Tests run: 12, Failures: 0, Errors: 0** (PG16 Testcontainers, V1..V19 to'liq zanjir). **Mutatsiya tekshiruvi** — har test da'vosi yolg'onni ushlashi V19 SQL ni ataylab buzib tasdiqlandi (keyin `git checkout --` bilan tiklandi, ishchi nusxa toza): - A: `WHERE active` olib tashlandi + CHECK ga 'kpi' ruxsat etildi + FK ALTER o'chirildi → **4 test yiqildi**, aynan kutilganlari: newProfessionWithSameNameIsAllowedAfterOldOneIsDeactivated (duplicate key), wageTypeKpiIsRejectedByCheckConstraint, variantOperationsProfessionIdHasRealForeignKeyToProfessions, variantOperationWithUnknownProfessionIdIsRejected. - B: indeks `lower(btrim(name))` → `(name)` + `organization_id bigint` ustuni qo'shildi → **2 test yiqildi**: duplicateActiveProfessionNameIsRejectedCaseAndWhitespaceInsensitive, professionsTableHasNoOrganizationOrTenantIdColumn. Ya'ni assert'siz/tautologik test yo'q — hamma mutant o'ldirildi. **Mezonlar (kod darajasida):** - 2803/2804 — V19:42-44 `CREATE UNIQUE INDEX uq_professions_name_active ON professions (lower(btrim(name))) WHERE active` — partial VA funksional, §2.2 Q24=A ga aynan mos. - 2805 — V19:15-33 CREATE TABLE da `organization_id`/`tenant_id` YO'Q (AR-1, §2.2 2026-08-04). - 2806 — V19:31-32 `chk_professions_wage_type CHECK (wage_type IN ('piece_rate','monthly'))`, 'kpi' yo'q (Q11). - 2807 — V19:64-66 FK `fk_variant_operations_profession` + V19:70-71 `idx_variant_operations_profession_id` (postgresql skill §4). Test SQLSTATE 23503 ni tekshiradi. - 2808 — V1..V19 zanjiri toza PG16 da xatosiz; `flyway_schema_history` version=19, success=true. **Cross-cutting:** nomlash `snake_case`, jadval ko'plikda, FK nomi repo naqshiga mos (`fk_<jadval>_<havola>`), indeks `idx_<jadval>_<ustun>` ✓. AR-10 — katalogga oddiy FK (bu subtask aynan shu teshikni yopadi) ✓. Soft-delete = `active` (spec §2.2, CROSS_CUTTING H), fizik DELETE yo'q ✓. numeric ustun yo'q (precision N/A); service qatlami yo'q (@Transactional N/A); outbox N/A; parol/token log'i N/A. **Kontrakt (openapi/v1/employees.yaml):** drift YO'Q — `ProfessionResponse.id` int64 → `bigint`; `name` maxLength 255 → `varchar(255)`; `WageType enum [piece_rate, monthly]` → CHECK ayni shu ikkisi (kpi yo'q); `is_picking`/`is_driver` default false → `NOT NULL DEFAULT false`; `active`/`created_at`/`updated_at` mos. **Kuzatuv (mezon emas, bloklamaydi):** V19 da mavjud `variant_operations` qatorlarini oldindan tekshiruvchi DO-blok yo'q — faqat prose izoh (V19:54-61) standart 23503 xatosini hujjatlashtiradi. Toza bazada muammo yo'q; jonli baza paydo bo'lguncha yetarli. --- 🔴 **REGRESSIYA (mustaqil tasdiqlandi) — bu S01 ning defekti EMAS:** `mvn -Dtest=RecipesAndRoutesMigrationTest test` → **Tests run: 18, Failures: 1, Errors: 10** = jami **11 yiqilgan**. - 10 tasi — `insert or update on table "variant_operations" violates foreign key constraint "fk_variant_operations_profession"` (SQLSTATE 23503): EP-02 testi `profession_id` ni qotirib yozgan (`1L`, `999999999L`), `RecipesAndRoutesMigrationTest.java:473` helper'i orqali. - 1 tasi — assert yiqilishi: `variantOperationsProfessionIdHasNoForeignKeyConstraint` (`RecipesAndRoutesMigrationTest.java:182`) FK **BO'LMASLIGINI** da'vo qiladi (AC998). **Xulosa:** AC2807 ning ongli va muqarrar oqibati. V10 izohi (18-23-qator) FK yo'qligini ATAYLAB vaqtinchalik deb yozgan edi ("professions jadvali hali yo'q ... keyinroq qo'shiladi"); AC2807 aynan o'sha vaqtinchalik holatni bekor qiladi, ya'ni AC998 endi eskirgan kontraktni tekshiryapti. V19 to'g'ri yozilgan. ⚠️ **Alohida task kerak** (EP-02 doirasi — men tuzatmadim): (a) `variantOperationsProfessionIdHasNoForeignKeyConstraint` ni "FK BOR" ga aylantirish yoki o'chirish (AC998 ni AC2807 bekor qildi); (b) `insertVariantOperation` helper'i haqiqiy `professions` qatori yaratib undan `id` olsin. Shu task yopilmaguncha `feat/EP-06-erpbom-backend` shoxida to'plam QIZIL — epic'ni PR/merge ga olib chiqmang.

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ V19 toza bazada va V18 gacha to'ldirilgan bazada xatosiz o'tadi

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ `variant_operations.profession_id` uchun FK constraint MAVJUD (information_schema.table_constraints testi) va mavjud bo'lmagan `profession_id` bilan operatsiya insert qilish rad etiladi

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ `wage_type` ga 'kpi' yozishga urinish CHECK bilan rad etiladi (KPI v1'da yo'q)

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ `professions` da `organization_id`/`tenant_id` ustuni yo'q (information_schema testi)

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ "Payvandchi" `active=false` qilingach, yangi "Payvandchi" insert MUVAFFAQIYATLI (partial indeks testi)

qa-ep-06-t01-s01 qabul mezonini belgiladi

✓ Faol "Payvandchi" bor ekan `"payvandchi"` yoki `" Payvandchi "` insert qilishga urinish unique violation beradi

coder-ep-06-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-06-t01-s01 izoh qoldirdi

V19 (professions + variant_operations.profession_id haqiqiy FK) qo'shildi, 12 ta yangi test (ProfessionsMigrationTest) yashil, AC2803-2808 hammasi bajarildi. ⚠️ MUHIM — ma'lum regressiya (V10 izohida oldindan kutilgan, EP-02 dan qolgan uch): FK qo'shilishi bilan uz.erpbom.products.RecipesAndRoutesMigrationTest'dagi 11 ta test qizil bo'lib qoladi (tekshirib ko'rdim): 10 tasi profession_id=1/999999999 kabi haqiqiy professions'da yo'q qiymatlar bilan insert qilgani uchun 23503 (FK violation), va variantOperationsProfessionIdHasNoForeignKeyConstraint testi endi noto'g'ri (endi FK BOR, lekin test yo'q deb tasdiqlashga urinadi). Shu bilan bir qatorda PieceRateControllerIntegrationTest, ProductVariantOrchestrationIntegrationTest, RecipeVersionControllerIntegrationTest, ReferenceCostControllerIntegrationTest, SellingPricesAndPieceRatesMigrationTest'da ham profession_id literal qiymatlar (1..6) JSON/SQL'da hardcoded — ular ham xuddi shu sababdan sinishi kutiladi. Bu — V10 migratsiyasi izohida ataylab qoldirilgan 'EP-02 dan qolgan uch' va aynan shu subtaskning AC2807 talabi (haqiqiy FK + rad etish) tufayli kutilgan oqibat, spec ziddiyati emas. Men EP-06-T01-S01 doirasidan tashqariga chiqmaslik uchun (boshqa V-raqam/item'ga tegmaslik, parallel agentlar bilan to'qnashmaslik) bu fayllarni o'zgartirmadim. Tavsiya: 02_products modul uchun alohida qisqa fix-task (yoki QA/pm-agent orqali) — bu testlarda haqiqiy professions qatori oldindan yaratilib, keyin uning id'si ishlatilishi kerak (hardcoded 1/2/3.. o'rniga).

coder-ep-06-t01-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-06-t01-s01 fayllarni qayd etdi

2 ta fayl qayd etildi

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ V19 toza bazada va V18 gacha to'ldirilgan bazada xatosiz o'tadi

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ `variant_operations.profession_id` uchun FK constraint MAVJUD (information_schema.table_constraints testi) va mavjud bo'lmagan `profession_id` bilan operatsiya insert qilish rad etiladi

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ `wage_type` ga 'kpi' yozishga urinish CHECK bilan rad etiladi (KPI v1'da yo'q)

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ `professions` da `organization_id`/`tenant_id` ustuni yo'q (information_schema testi)

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ "Payvandchi" `active=false` qilingach, yangi "Payvandchi" insert MUVAFFAQIYATLI (partial indeks testi)

coder-ep-06-t01-s01 qabul mezonini belgiladi

✓ Faol "Payvandchi" bor ekan `"payvandchi"` yoki `" Payvandchi "` insert qilishga urinish unique violation beradi

coder-ep-06-t01-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-06-t01-s01 ishga oldi

pm-agent yaratdi

V19 — `professions` + `variant_operations.profession_id` FK (EP-02 dan qolgan uch)