📋 PM Board
Sub-task EP-04-T06-S03 Yuqori 03_warehouse erpbom-backend

`supplier_returns` — ta'minotchiga qaytarish (outbound, §8.8)

Bajarildi
Status:

Tavsif

`supplier_return.view` / `.create` / `.confirm` rule'lari. * `draft`: ombor (odatda `raw`) + `supplier_id` (**lookup**) + ixtiyoriy `source_receipt_id` + `notes`. * Qatorlar: variant + `qty` (**`good`** qoldiqdan) + `credit_unit_price`. 🔴 **Default `credit_unit_price` = variant oxirgi kirim narxi** ("LIFO" — 01_suppliers Q26; T03-S03 dagi lookup), **qo'lda tahrirlanadi** (kelishilgan narx). * `confirm` — **atomik** (qoida 37): har qator uchun `postOut(...)` (`condition = good`, `movementType = purchase_return_out`, `sourceType = purchase_return`) → FIFO chiqim, grain 🅰️; `fifo_cost_snapshot` = shu qatorning chiqim qatlamlari `Σ total_cost`. * **Kredit** = `Σ (qty × credit_unit_price)`; **FIFO ↔ kredit farqi** = `kredit − fifo_cost_snapshot`. ⛔ Ikkalasi ham 08_finance/01_suppliers ga tegishli — bu epicda `SupplierLedgerPort#onSupplierReturnConfirmed(...)` (no-op) orqali chiqariladi, qarz qatori YOZILMAYDI. * `cancel`: faqat `draft` dan.

Qabul mezonlari (DoD)

5 / 5 bajarildi

  • 5 dsp qaytarilganda FIFO chiqim 5×9 000 = 45 000 `fifo_cost_snapshot` ga yoziladi va qoldiq −5 bo'ladi (§8.8 misoli)

    qa-ep-04-t06-s03 · 1 о аввал

  • `credit_unit_price` default'i variantning oxirgi `confirmed` kirim narxidan keladi va qo'lda o'zgartirilishi mumkin

    qa-ep-04-t06-s03 · 1 о аввал

  • Kredit (`Σ qty × credit_unit_price`) va FIFO↔kredit farqi hisoblanib `SupplierLedgerPort` ga uzatiladi (mock bilan tasdiqlanadi); DB'da qarz qatori yaratilmaydi

    qa-ep-04-t06-s03 · 1 о аввал

  • `defective` qoldiqdan chiqim qilinmaydi (faqat `good`); qoldiq yetmasa rollback va hujjat `draft` qoladi

    qa-ep-04-t06-s03 · 1 о аввал

  • `confirmed` hujjatni bekor qilishga urinish rad etiladi (faqat `draft → cancelled`)

    qa-ep-04-t06-s03 · 1 о аввал

O'zgargan fayllar

16 ta

  • modified src/test/java/uz/erpbom/warehouse/controller/SupplierReturnConfirmedPostingTest.java
  • modified src/main/java/uz/erpbom/warehouse/controller/SupplierReturnController.java
  • modified src/main/java/uz/erpbom/warehouse/service/NoopSupplierLedgerPort.java
  • modified src/main/java/uz/erpbom/warehouse/service/SupplierLedgerPort.java
  • modified src/main/java/uz/erpbom/warehouse/service/SupplierReturnLedgerCommand.java
  • modified src/main/java/uz/erpbom/warehouse/service/SupplierReturnService.java
  • modified src/main/java/uz/erpbom/warehouse/repository/SupplierReturnLineRepository.java
  • modified src/main/java/uz/erpbom/warehouse/repository/SupplierReturnRepository.java
  • modified src/main/java/uz/erpbom/warehouse/mapper/SupplierReturnMapper.java
  • modified src/main/java/uz/erpbom/warehouse/dto/SupplierReturnResponse.java
  • modified src/main/java/uz/erpbom/warehouse/dto/SupplierReturnLineResponse.java
  • modified src/main/java/uz/erpbom/warehouse/dto/SupplierReturnLineInput.java
  • modified src/main/java/uz/erpbom/warehouse/dto/SupplierReturnUpdateRequest.java
  • modified src/main/java/uz/erpbom/warehouse/dto/SupplierReturnCreateRequest.java
  • modified src/main/java/uz/erpbom/warehouse/entity/SupplierReturnLine.java
  • modified src/main/java/uz/erpbom/warehouse/entity/SupplierReturn.java

Izoh qoldirish

Tarix

21 yozuv

  • ✎

    finalize-ep-04 yangiladi

    Yangilandi: commit_sha, pr_url

  • 💬

    qa-ep-04-t06-s03 izoh qoldirdi

    QA (qa-EP-04-T06-S03) — TEKSHIRILDI, `done`. **Testlar:** `mvn -Dtest=SupplierReturnConfirmedPostingTest test` → **9/9 yashil** (coder'ning 7 tasi + QA qo'shgan 2 ta). Bytecode `javap` bilan tasdiqlandi (parallel worker build'i tufayli bir marta eskirgan `.class` bilan yurgan edi — `touch` + qayta kompilyatsiyadan keyin toza). **Mutatsiya tekshiruvi: 6 mutant qo'yildi, 6 tasi ham O'LDI.** 1. `Σ consumption.totalCost()` → `qty × unitCost` → o'ldi (faqat YANGI ko'p qatlamli test ushladi) 2. `condition = good` → `defective` → o'ldi (4 test) 3. `confirm()` dan `@Transactional` olib tashlandi → o'ldi (faqat YANGI ko'p qatorli rollback testi ushladi) 4. `SupplierLedgerPort` chaqiruvi o'chirildi → o'ldi 5. farq formulasi teskari (`fifo − credit`) → o'ldi 6. `cancel()` dagi holat tekshiruvi olib tashlandi → o'ldi **QA test kuchaytirishi (commit `03118d1`, faqat test fayli):** * AC2496 — coder'ning bir qatlamli testi `Σ total_cost` va `qty × unit_cost` ni AJRATA OLMASDI (5×9 000 = 45 000 ikkalasida bir xil). Yangi ko'p qatlamli ssenariy: A qatlam 300 dona / 10 000.00 (`unit_cost` 33.3333, davriy kasr) + B qatlamdan qisman 50 → to'g'ri 12 500.00, noto'g'ri formula 12 499.99. Qoida 42 invarianti (`Σ stock_movements.total_cost`, partiya `remaining_cost`) ham tekshiriladi. * AC2499 — coder'ning testida birinchi (yagona) `postOut` yiqilardi, ya'ni tranzaksiya chegarasi isbotlanmasdi. Yangi ko'p qatorli ssenariy: 1-qator chiqimi BAJARILADI, 2-qator `good` yetmaydi → 1-qator `stock`/`stock_batches`/`stock_movements`/`fifo_cost_snapshot` bo'yicha to'liq qaytarilgani tekshiriladi (`defective` qoldiq 10 > 5 bo'lsa ham ishlatilmaydi). * AC2497 — yangiroq `draft` faktura (99 999.00) qo'shildi: lookup FAQAT `confirmed` (10 000.00) dan olishi isbotlandi; qo'lda 12 500.00 yozilib saqlanishi allaqachon bor edi. * AC2498 — port argumenti `ArgumentCaptor` bilan QIYMAT darajasida tekshirilgan (kredit 50 000.00 / FIFO 45 000.00 / farq 5 000.00 + yangi testda 14 000.00 / 12 500.00 / 1 500.00); `any()` bilan bo'sh `verify` YO'Q. "DB'da qarz qatori yaratilmaydi" — sxemada qarzdorlik jadvalining o'zi yo'qligi (`to_regclass`) assert qilindi. **Kontrakt:** `status` hech bir request DTO'da yo'q (o'tish faqat `/confirm`, `/cancel`); `SupplierReturnResponse`/`SupplierReturnLineResponse` maydonlari (`fifo_cost_snapshot`, `credit_unit_price` — string, nullable) kontrakt bilan aynan; xatolik kodlari `STOCK_INSUFFICIENT` / `INVALID_STATUS_TRANSITION` `StockPostingConflict` / `InvalidStatusTransition` javoblariga mos. **Cross-cutting:** har servis metodi `@Transactional` (o'qish `readOnly`); `tenant_id`/schema almashtirish yo'q; V17 da haqiqiy FK'lar; `numeric(18,4)` qty / `numeric(18,2)` narx; snake_case + ko'plik + to'liq nomli FK; fizik `DELETE` faqat `draft` qator almashtirishda (§2.15 da `deleted_at` yo'q, StockWriteOff bilan bir xil naqsh); log'da parol/token yo'q. `SupplierLedgerPort` chaqiruvi ichki DB yozuvi bo'lgani uchun outbox talab qilinmaydi (§8.8 p.3.d/e — ayni tranzaksiya). Kontrakt qarori (faqat `good` qatlamlardan FIFO, qatorda `condition` yo'q) qayta ochilmadi.

  • ⇄

    qa-ep-04-t06-s03 statusni o'zgartirdi Review → Bajarildi

  • ✓

    qa-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `confirmed` hujjatni bekor qilishga urinish rad etiladi (faqat `draft → cancelled`)

  • ✓

    qa-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `defective` qoldiqdan chiqim qilinmaydi (faqat `good`); qoldiq yetmasa rollback va hujjat `draft` qoladi

  • ✓

    qa-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ Kredit (`Σ qty × credit_unit_price`) va FIFO↔kredit farqi hisoblanib `SupplierLedgerPort` ga uzatiladi (mock bilan tasdiqlanadi); DB'da qarz qatori yaratilmaydi

  • ✓

    qa-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `credit_unit_price` default'i variantning oxirgi `confirmed` kirim narxidan keladi va qo'lda o'zgartirilishi mumkin

  • ✓

    qa-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ 5 dsp qaytarilganda FIFO chiqim 5×9 000 = 45 000 `fifo_cost_snapshot` ga yoziladi va qoldiq −5 bo'ladi (§8.8 misoli)

  • 📄

    worker-ep-04-t06 fayllarni qayd etdi

    16 ta fayl qayd etildi

  • ✎

    coder-ep-04-t06-s03 yangiladi

    Yangilandi: branch, commit_sha

  • ⇄

    coder-ep-04-t06-s03 statusni o'zgartirdi Ishlanyapti → Review

  • ✓

    coder-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `confirmed` hujjatni bekor qilishga urinish rad etiladi (faqat `draft → cancelled`)

  • ✓

    coder-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `defective` qoldiqdan chiqim qilinmaydi (faqat `good`); qoldiq yetmasa rollback va hujjat `draft` qoladi

  • ✓

    coder-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ Kredit (`Σ qty × credit_unit_price`) va FIFO↔kredit farqi hisoblanib `SupplierLedgerPort` ga uzatiladi (mock bilan tasdiqlanadi); DB'da qarz qatori yaratilmaydi

  • ✓

    coder-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ `credit_unit_price` default'i variantning oxirgi `confirmed` kirim narxidan keladi va qo'lda o'zgartirilishi mumkin

  • ✓

    coder-ep-04-t06-s03 qabul mezonini belgiladi

    ✓ 5 dsp qaytarilganda FIFO chiqim 5×9 000 = 45 000 `fifo_cost_snapshot` ga yoziladi va qoldiq −5 bo'ladi (§8.8 misoli)

  • 📄

    coder-ep-04-t06-s03 fayllarni qayd etdi

    16 ta fayl qayd etildi

  • ⇄

    coder-ep-04-t06-s03 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-04-t06-s03 ishga oldi

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-04-T06-S02

  • ✦

    pm-agent yaratdi

    `supplier_returns` — ta'minotchiga qaytarish (outbound, §8.8)

Ma'lumot

Agent
coder-ep-04-t06-s03
Olingan
1 о аввал
Boshlandi
21.08.2026 02:18
Tugadi
21.08.2026 02:59
Baho
6 soat
Spec
erp/docs/modules/03_warehouse.md#8.8
Branch
feat/EP-04-erpbom-backend
Commit
b6685d9b9b72
Pull request →

Bog'liqliklar

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T06-S03/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T06-S03/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'