Jo'natish (`ship`) — atomik FIFO chiqim (§8.2-A)

finalize-ep-04 yangiladi

Yangilandi: commit_sha, pr_url

qa-ep-04-t05-s02 statusni o'zgartirdi Review → Bajarildi

qa-ep-04-t05-s02 izoh qoldirdi

QA qayta tekshiruv (qa-EP-04-T05-S02) — QABUL QILINDI (done). Commit 3f153f0. === BLOKLOVCHI DEFEKT TUZATILGAN VA ISBOTLANGAN === Tuzatish: WarehouseTransferRepository.findByIdAndDeletedAtIsNullForUpdate (@Lock(PESSIMISTIC_WRITE)) — WarehouseTransferShipPoster.java:96-101 da hujjat qatori stock qulflaridan OLDIN qulflanadi, status tekshiruvi qulf OLINGANDAN KEYIN (:103). setLockTimeoutForCurrentTransaction() ham hujjat qulfidan oldinga ko'chirilgan (:90) — endi 3s chegarasi hujjat qulfiga ham amal qiladi (CROSS_CUTTING Q p.3 to'g'ri bajarilgan). O'lchandi (bitta transfer, qty=10, boshlang'ich 100): aynan 1 ta 200 + 1 ta 409 INVALID_STATUS_TRANSITION qty_on_hand = 90.0000 (ilgari 80.0000) stock_movements = 1 (ilgari 2) MUTATSIYA O'LDI: ...ForUpdate ni oddiy findByIdAndDeletedAtIsNull ga qaytardim (.class o'chirildi, qayta kompilyatsiya, javap bilan bytecode tasdiqlandi — ForUpdate 0 ta, qulfsiz variant 1 ta chaqiruv). Natija: concurrentShipsOfSameTransferOnlyOneSucceeds YIQILDI ("expected: 1L but was: 2L" — ikkalasi ham 200). Test bo'sh emas. git checkout bilan tiklandi. === QULF TARTIBI BUZILMAGAN === Tartib: hujjat (warehouse_transfers) -> keyin stock (warehouse_id, product_variant_id, condition) ASC. Yangi halqa yo'q: har tranzaksiya FAQAT BITTA hujjat qatorini qulflaydi va ular har xil, demak sikl yopilmaydi. Empirik: AC2482 deadlock testi (pg_stat_database.deadlocks + PostgreSQL server stderr log) hamon YASHIL. === MENING TEST KUCHAYTIRISHIM SAQLANGAN === git diff d02eebe..HEAD — test faylidan o'chirilgan yagona qator javadoc <li> yakuni (ro'yxat kengaytirilgan). Hamma assert joyida: deadlock log tekshiruvi (:348), pg_stat_database delta (:350), batchColumn qty_remaining/remaining_cost (:261-263), ko'p qatorli rollback testi (:234). === TESTLAR (o'zim yurgizdim, sinxron) === WarehouseTransferShipIntegrationTest 6/6, S01 WarehouseTransferControllerIntegrationTest 11/11, T02 StockPostingServiceTest 6/6 — jami 23/23 BUILD SUCCESS. T04/T06 ga tegilmadi. === ZONA / KONTRAKT === HEAD commit — 3 fayl, hammasi WarehouseTransfer* (Repository, ShipPoster, ship testi). openapi/v1/warehouse.yaml TEGILMAGAN (hamon faqat staged 'M ' — team lead tuzatishi). Boshqa worker'ning StockWriteOff*/SupplierReturn*/Expense* fayllari commit'ga TUSHMAGAN. Kontrakt o'zgarmagan: xatolik kodlari (STOCK_INSUFFICIENT / STOCK_BUSY / INVALID_STATUS_TRANSITION) va ship no-body kontraktga mos; `status` hech bir request DTO'da yo'q. Barcha 4 mezon (AC2479-2482) + QA topilmasi qoplandi va mutatsiya bilan tasdiqlandi. === KEYINGI BARGGA ESLATMA (S02 ni bloklamaydi, lekin yo'qolmasin) === Xuddi shu qulfsiz-o'qish naqshi `cancel` da qolgan: WarehouseTransferService.cancel — findOrThrow(id) (qulfsiz), status tekshiruvi ham qulfsiz. Konkurent `cancel` + `ship`: ikkalasi ham draft ko'rishi, ship chiqim yozib commit qilishi, keyin cancel status'ni `cancelled` ga o'tkazishi mumkin — natijada tovar chiqib ketgan, hujjat esa `cancelled` (§8.2-C: in_transit dan bekor qilish YO'Q — bu qoida chetlab o'tiladi). S03 (`receive`) yozilayotganda findByIdAndDeletedAtIsNullForUpdate ni `receive` VA `cancel` uchun ham qo'llash tavsiya etiladi (repository javadoc'i buni allaqachon nazarda tutgan).

coder-ep-04-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-04-t05-s02 yangiladi

Yangilandi: commit_sha

coder-ep-04-t05-s02 fayllarni qayd etdi

3 ta fayl qayd etildi

qa-ep-04-t05-s02 izoh qoldirdi

QA (qa-EP-04-T05-S02) — QAYTARILDI: 1 ta bloklovchi defekt. TESTLAR YASHIL: WarehouseTransferShipIntegrationTest 5/5, S01 regressiya WarehouseTransferControllerIntegrationTest 11/11, T02 StockPostingServiceTest 6/6 (jami 22/22). === BLOKLOVCHI DEFEKT: bir xil transferni IKKI MARTA jo'natish (double-ship) === Fayl: src/main/java/uz/erpbom/warehouse/service/WarehouseTransferShipPoster.java:83-87 Transfer qatori HECH QANDAY qulf bilan o'qilmaydi (findByIdAndDeletedAtIsNull — FOR UPDATE yo'q) va WarehouseTransfer entity'sida @Version ham yo'q. Ikki konkurent `ship` ikkalasi ham `status == draft` tekshiruvidan O'TADI, ikkalasi ham postOut qiladi, ikkalasi ham `in_transit` yozadi. O'lchangan natija (bitta transfer, bitta qator qty=10, boshlang'ich qoldiq 100): r1 = 200 OK, r2 = 200 OK (kutilgan: bittasi 409 INVALID_STATUS_TRANSITION) stock.qty_on_hand = 80.0000 (kutilgan 90.0000) <- IKKI MARTA kamaydi stock_movements = 2 ta transfer_out (kutilgan 1) — bir xil transfer_group_id, bir xil source_ref_id Nega bu qimmat: qoida 22 bo'yicha in-transit IMPLICIT (movement'lardan hisoblanadi), demak GET /stock/in-transit 10 o'rniga 20 ko'rsatadi; receive (S03) esa faqat 10 ni qaytaradi -> 10 dona qoldiq butunlay yo'qoladi. Bu §8.2-A qoida 20 ("bitta atomik tranzaksiya") va CROSS_CUTTING Q ni buzadi. TUZATISH (bittasini tanlang, (a) tavsiya etiladi — receive/cancel ni ham himoya qiladi): (a) `ship` boshida hujjat qatorini qulflang: WarehouseTransferRepository ga @Lock(PESSIMISTIC_WRITE) findByIdForUpdate(...) qo'shib, status tekshiruvidan OLDIN chaqiring. Bu stock qulflaridan OLDIN olinadi va CROSS_CUTTING Q tartibini buzmaydi (boshqa jadval, hamma oqimda bir xil ketma-ketlik). (b) WarehouseTransfer ga @Version (optimistik qulf). (c) Shartli UPDATE: `... SET status='in_transit' WHERE id=? AND status='draft'` va affected rows == 1 talab qilinsin. Qabul testi (iltimos tuzatish bilan birga qo'shing): ikki thread CountDownLatch bilan bir xil transferga POST /ship -> bittasi 200, bittasi 409 INVALID_STATUS_TRANSITION; qty_on_hand 90.0000; countMovements == 1. (WarehouseTransferShipIntegrationTest dagi concurrentShipsWithReversedLineOrderNeverDeadlock naqshini nusxalang.) === QA O'ZI TUZATGAN TEST BO'SHLIG'I (commit d02eebe, faqat test fayli) === 1) AC2482 QOPLANMAGAN edi. Mutatsiya tekshiruvi: WarehouseTransferShipPoster:95-97 dagi sort olib tashlanganda PostgreSQL 3/3 yurishda HAQIQIY 40P01 berdi (server log: "Process 71 waits for ShareLock on transaction 801; blocked by process 70"), LEKIN test baribir YASHIL qoldi — chunki WarehouseTransferService.shipWithRetry deadlock'ni ushlab tranzaksiyani qayta boshlaydi va 200 qaytaradi. Ya'ni test qulf TARTIBINI emas, RETRY ni sinayotgan edi. Endi deadlock yo'qligi to'g'ridan-to'g'ri PostgreSQL'dan tekshiriladi (container stderr log + pg_stat_database.deadlocks delta). Mutatsiya endi O'LADI (tasdiqlangan). 2) AC2481 bir qatorli test faqat "yozilmadi" ni isbotlardi (STOCK_INSUFFICIENT birinchi qator uchun birinchi tekshiruvda otiladi — qaytariladigan ish YO'Q). Qo'shildi: ko'p qatorli holat (qator A post qilinadi, qator B yiqiladi) — A ning stock + stock_batches.qty_remaining + remaining_cost + movement ishi ham qaytarilishi assert qilinadi. Atomiklik buzilganda test yiqilishi mutatsiya bilan tasdiqlangan. === O'TGAN TEKSHIRUVLAR === - AC2479/2480/2481/2482 — kod darajasida va test bilan tasdiqlandi (yolg'iz-aktyor oqimida). - StockPostingService.postOut ni chetlab StockOutPoster.post ni chaqirish — ASOSLI. postOut() = executeWithRetry(() -> stockOutPoster.post(cmd)); hamma invariant (qoida 4 qoldiq tekshiruvi, qoida 5 invariant qorovuli, FOR UPDATE, lock_timeout, FIFO qatlamlar, qoida 42, movement yozuvi) StockOutPoster.post ICHIDA va u CHAQIRILADI. Faqat retry qobig'i o'tkazib yuborilgan va to'g'ri tashqi chegarada qayta qurilgan — buni T02 ning O'Z javadoc'i talab qiladi (StockPostingService "composability chegarasi"). Ikki qavat retry YO'Q. - Retry @Transactional TASHQARISIDA — tasdiqlandi (ship() da @Transactional yo'q; mutant yurishida retry haqiqatan yangi jismoniy tranzaksiya ochgani amalda ko'rindi). - Kontrakt: ship no-body, `status` hech bir request DTO'da yo'q; xatolik kodlari (STOCK_INSUFFICIENT / STOCK_BUSY / INVALID_STATUS_TRANSITION) kontraktga mos; warehouse_transfer_lines da `condition` YO'Q, faqat `good` (defective yo'li qo'shilmagan). - Zona toza: commit fb57444 faqat WarehouseTransfer* (5 fayl). postOut/postIn (T02) va GET /stock/in-transit (T03) TEGILMAGAN. receive (S03) mantiqi YOZILMAGAN (receivedAt/receivedByUserId null qoladi) — to'g'ri. openapi/ coder tomonidan tegilmagan. - Cross-cutting 8/8: @Transactional (o'qish readOnly), tenant_id/schema mexanikasi qo'shilmagan, migratsiya yo'q, broker/kesh serveri yo'q, precision numeric(18,4), fizik DELETE yo'q, token/parol log'ga yozilmaydi. KICHIK (bloklamaydi): WarehouseTransferShipPoster:70-73 javadoc "komparator TO'LIQ uch maydonli kalitni ifodalaydi" deydi, lekin kod faqat productVariantId bo'yicha saralaydi. Xulq-atvor TO'G'RI (bitta transferda warehouse_id va condition o'zgarmas), faqat izoh o'zini noto'g'ri tasvirlaydi — izohni aniqlashtiring.

qa-ep-04-t05-s02 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-04-t05-s02 qabul mezonini belgiladi

✓ Ko'p qatorli transferda qulflar `(warehouse_id, product_variant_id, condition) ASC` tartibida olinadi (konkurent deadlock testi o'tadi)

qa-ep-04-t05-s02 qabul mezonini belgiladi

✓ Manbada qoldiq yetmasa `insufficient_stock` qaytadi va transfer `draft` holatida qoladi (rollback)

qa-ep-04-t05-s02 qabul mezonini belgiladi

✓ Ikki qatlamni qamragan chiqimda ikkita `transfer_out` movement yoziladi, ikkalasi ham bir xil `transfer_group_id` bilan

qa-ep-04-t05-s02 qabul mezonini belgiladi

✓ `ship` dan keyin manba `stock.qty_on_hand` kamayadi, qabul ombor qoldig'i O'ZGARMAYDI (tovar yo'lda)

coder-ep-04-t05-s02 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-04-t05-s02 yangiladi

Yangilandi: branch, commit_sha

coder-ep-04-t05-s02 qabul mezonini belgiladi

✓ Ko'p qatorli transferda qulflar `(warehouse_id, product_variant_id, condition) ASC` tartibida olinadi (konkurent deadlock testi o'tadi)

coder-ep-04-t05-s02 qabul mezonini belgiladi

✓ Manbada qoldiq yetmasa `insufficient_stock` qaytadi va transfer `draft` holatida qoladi (rollback)

coder-ep-04-t05-s02 qabul mezonini belgiladi

✓ Ikki qatlamni qamragan chiqimda ikkita `transfer_out` movement yoziladi, ikkalasi ham bir xil `transfer_group_id` bilan

coder-ep-04-t05-s02 qabul mezonini belgiladi

✓ `ship` dan keyin manba `stock.qty_on_hand` kamayadi, qabul ombor qoldig'i O'ZGARMAYDI (tovar yo'lda)

coder-ep-04-t05-s02 fayllarni qayd etdi

5 ta fayl qayd etildi

coder-ep-04-t05-s02 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-04-t05-s02 ishga oldi

pm-agent bog'liqlik qo'shdi

→ EP-04-T05-S01

pm-agent yaratdi

Jo'natish (`ship`) — atomik FIFO chiqim (§8.2-A)