📋 PM Board
Sub-task EP-04-T04-S02 Kritik 03_warehouse erpbom-backend

Holat mashinasi — submit / dispute / cancel / override (§4.1)

Bajarildi
Status:

Tavsif

Har o'tish **alohida** endpoint (status'ni PATCH qilish yo'q). * **`submit`** (`purchase_receipt.confirm`): `draft → pending_supplier`. Kamida 1 qator shart (qoida 13). Qatorlar qotadi. 🔴 **Avto-confirm skip (qoida 33, Q24):** faol shartnoma `payment_method = cash` **yoki** `term_days = 0` bo'lsa `pending_supplier` **o'tkazib yuboriladi** → to'g'ridan-to'g'ri `confirmed` (posting — S03), `supplier_confirmed_at = now()`, `is_override_confirm = false`. * **`dispute`** (hamkor tomoni — S04): `pending_supplier → disputed`, `dispute_reason` **majburiy** (qoida 35). * **Tahrirlash `disputed` dan**: xodim tahrir qilib qayta `pending_supplier` ga yuboradi (qatorlar yana ochiladi). * **`cancel`** (`purchase_receipt.override_confirm`): `pending_supplier`/`disputed` → `cancelled` (qoida 36). 🔴 `confirmed` ni bekor qilib **bo'lmaydi** (posting bajarilgan — yagona yo'l `supplier_returns`). * **`override confirm`** (`purchase_receipt.override_confirm`): `pending_supplier`/`disputed` → `confirmed` ta'minotchi o'rniga; `is_override_confirm = true` (audit). Loginsiz ta'minotchi (`suppliers.user_id IS NULL`) muddatli fakturasi **faqat** shu yo'l bilan tasdiqlanadi.

Qabul mezonlari (DoD)

6 / 6 bajarildi

  • Qatorsiz fakturani `submit` qilishga urinish rad etiladi (qoida 13)

    qa-ep-04-t04-s02 · 1 о аввал

  • Naqd (`payment_method='cash'`) yoki `term_days=0` shartnomali faktura `submit` da `pending_supplier` ni o'tkazib yuborib darhol `confirmed` bo'ladi va posting bajariladi

    qa-ep-04-t04-s02 · 1 о аввал

  • Muddatli faktura `submit` da `pending_supplier` bo'ladi va qoldiq O'ZGARMAYDI

    qa-ep-04-t04-s02 · 1 о аввал

  • `confirmed` fakturani `cancel` qilishga urinish rad etiladi; `pending_supplier`/`disputed` dan `cancel` faqat `override_confirm` rule bilan o'tadi

    qa-ep-04-t04-s02 · 1 о аввал

  • Override tasdiqda `is_override_confirm=true` yoziladi; oddiy `purchase_receipt.confirm` rule'i bilan `pending_supplier → confirmed` o'tkazishga urinish 403 beradi

    qa-ep-04-t04-s02 · 1 о аввал

  • `disputed → pending_supplier` qayta yuborishda qatorlar tahriri ruxsat etilgan, `dispute_reason` tozalanadi

    qa-ep-04-t04-s02 · 1 о аввал

O'zgargan fayllar

3 ta

  • modified src/test/java/uz/erpbom/warehouse/controller/PurchaseReceiptStateMachineTest.java
  • modified src/main/java/uz/erpbom/warehouse/controller/PurchaseReceiptController.java
  • modified src/main/java/uz/erpbom/warehouse/service/PurchaseReceiptService.java

Izoh qoldirish

Tarix

23 yozuv

  • ✎

    finalize-ep-04 yangiladi

    Yangilandi: commit_sha, pr_url

  • 💬

    qa-ep-04-t04-s02 izoh qoldirdi

    QA (qa-EP-04-T04-S02) — commit 359c0b5 mustaqil tekshirildi, 6/6 mezon tasdiqlandi. TESTLAR (flock ostida, tor doirada): - PurchaseReceiptStateMachineTest: 7/7 yashil (40.4s) - PurchaseReceiptCreateAndUpdateTest (S01 regressiya): 15/15 yashil (43.6s) MEZONLAR (kod darajasida isbot): - AC2457: PurchaseReceiptService.java:250 requireLines() -> :347-352 409 RECEIPT_NO_LINES; test :139-146 statusning 'draft' qolishini ham tekshiradi. - AC2458: :256 isAutoConfirmEligible -> :363-367 (cash YOKI term_days=0, SupplierService cache orqali); :259 transitionToConfirmed(..., isOverride=false) -> :384 postConfirmation. Test stock.qty_on_hand=10.0000 va stock_batches.total_cost=10000.00 ni HAQIQIY SQL bilan o'qiydi (test :167-168). - AC2459: :261 setStatus(pending_supplier) — posting yo'lidan tashqarida; test :206 stock.qty_on_hand=0 ni DB dan o'qiydi. - AC2460: cancel :305 OVERRIDE_ALLOWED_STATUSES={pending_supplier,disputed} -> confirmed uchun 409 INVALID_STATUS_TRANSITION (xabar kontrakt InvalidStatusTransition misoli bilan aynan mos); controller :107 @RequirePermission(override_confirm) -> .confirm-only token 403 (test :224-226). - AC2461: :390 setIsOverrideConfirm(isOverride); controller :100-105 /confirm = override_confirm -> .confirm-only token 403 (test :271-274), keyin status pending_supplier da qolgani tekshiriladi. - AC2462: :252-254 disputed dan chiqishda setDisputeReason(null); qatorlar tahriri EDITABLE_STATUSES (:86) orqali disputed da ruxsat; test PUT bilan qatorni almashtirib, dispute_reason=null va yangi qator ekanini tasdiqlaydi. MUTATSIYA TEKSHIRUVI (har biri kodga kiritildi, test yiqildi, git checkout -- <fayl> bilan tiklandi): (a) isAutoConfirmEligible sharti teskari qilindi -> 6/7 test yiqildi (cash/term0 'pending_supplier', muddatli 'confirmed' bo'ldi). (b) setIsOverrideConfirm(false) qotirildi -> overrideConfirmRequiresOverridePermissionAndMarksAudit yiqildi (:282). (c) setDisputeReason(null) olib tashlandi -> resubmittingFromDisputedAllowsLineEditAndClearsDisputeReason yiqildi (:317). Uchala mutatsiya ham ushlandi — testlar tautologik emas. Tiklangandan keyin qayta 7/7 yashil. KONTRAKT / CROSS-CUTTING: - operationId'lar mos: /submit=submitPurchaseReceipt (purchase_receipt.confirm), /confirm=overrideConfirmPurchaseReceipt (override_confirm), /cancel=cancelPurchaseReceipt (override_confirm). - Xatolik kodlari PurchaseReceiptPostingConflict / InvalidStatusTransition doirasida, xabarlar kontrakt misollari bilan bir xil. - Hech bir request DTO'da status maydoni yo'q (Create/Update record'lari tekshirildi). - Posting o'zicha yozilmagan: faqat StockPostingService.postIn(PostInCommand) (:411-421) — condition=good, sourceType=purchase, sourceRefId=receipt.id, totalCost=qty x unit_cost (HALF_UP, scale 2). - Yangi rule YO'Q (R__permissions_and_currencies_seed.sql tegilmagan), yangi migratsiya YO'Q — commit atigi 3 fayl. - §4.1 ning 5 statusi ALL_STATUSES (:82-83) da qotirilgan va DB CHECK bilan solishtirilib test qilingan (PurchaseReceiptCreateAndUpdateTest:367-384). - submit/overrideConfirm/cancel — hammasi @Transactional (:244, :281, :302); posting va faktura yozuvi bitta tranzaksiya chegarasida (qoida 14). S03 GA ESLATMA: snapshot ustunlari (contract_id, term_days_snapshot, payment_method_snapshot, payment_basis) va due_date S02 da ATAYLAB yozilmagan (kutilgan chegara) — postConfirmation() alohida metod sifatida ochiq qoldirilgan; S03 da snapshot HAQIQIY supplier_contracts dan (v1/v2 farqi bilan) olinishi shart, S02 dagi suppliers cache o'qishi faqat avto-confirm shartiga tegishli.

  • ⇄

    qa-ep-04-t04-s02 statusni o'zgartirdi Review → Bajarildi

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ `disputed → pending_supplier` qayta yuborishda qatorlar tahriri ruxsat etilgan, `dispute_reason` tozalanadi

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Override tasdiqda `is_override_confirm=true` yoziladi; oddiy `purchase_receipt.confirm` rule'i bilan `pending_supplier → confirmed` o'tkazishga urinish 403 beradi

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ `confirmed` fakturani `cancel` qilishga urinish rad etiladi; `pending_supplier`/`disputed` dan `cancel` faqat `override_confirm` rule bilan o'tadi

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Muddatli faktura `submit` da `pending_supplier` bo'ladi va qoldiq O'ZGARMAYDI

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Naqd (`payment_method='cash'`) yoki `term_days=0` shartnomali faktura `submit` da `pending_supplier` ni o'tkazib yuborib darhol `confirmed` bo'ladi va posting bajariladi

  • ✓

    qa-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Qatorsiz fakturani `submit` qilishga urinish rad etiladi (qoida 13)

  • ⇄

    coder-ep-04-t04-s02 statusni o'zgartirdi Ishlanyapti → Review

  • 💬

    coder-ep-04-t04-s02 izoh qoldirdi

    submit/confirm(override)/cancel yozildi (PurchaseReceiptService#submit/overrideConfirm/cancel, controller 3 yangi POST). Posting StockPostingService.postIn orqali, alohida postConfirmation() metodida - S03 shartnoma snapshot+due_date bilan kengaytiradi (bu bargda snapshot/payment_basis ustunlariga tegilmadi, worker-pm korsatmasi boyicha). Auto-confirm sharti (cash/term_days=0) SupplierService.get() dagi read-only cache orqali oqildi (modul chegarasi buzilmadi). 7 yangi test (PurchaseReceiptStateMachineTest) + mavjud 15 (S01) + 5 (migratsiya) yashil.

  • ✎

    coder-ep-04-t04-s02 yangiladi

    Yangilandi: branch, commit_sha

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ `disputed → pending_supplier` qayta yuborishda qatorlar tahriri ruxsat etilgan, `dispute_reason` tozalanadi

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Override tasdiqda `is_override_confirm=true` yoziladi; oddiy `purchase_receipt.confirm` rule'i bilan `pending_supplier → confirmed` o'tkazishga urinish 403 beradi

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ `confirmed` fakturani `cancel` qilishga urinish rad etiladi; `pending_supplier`/`disputed` dan `cancel` faqat `override_confirm` rule bilan o'tadi

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Muddatli faktura `submit` da `pending_supplier` bo'ladi va qoldiq O'ZGARMAYDI

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Naqd (`payment_method='cash'`) yoki `term_days=0` shartnomali faktura `submit` da `pending_supplier` ni o'tkazib yuborib darhol `confirmed` bo'ladi va posting bajariladi

  • ✓

    coder-ep-04-t04-s02 qabul mezonini belgiladi

    ✓ Qatorsiz fakturani `submit` qilishga urinish rad etiladi (qoida 13)

  • 📄

    coder-ep-04-t04-s02 fayllarni qayd etdi

    3 ta fayl qayd etildi

  • ⇄

    coder-ep-04-t04-s02 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-04-t04-s02 ishga oldi

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-04-T04-S01

  • ✦

    pm-agent yaratdi

    Holat mashinasi — submit / dispute / cancel / override (§4.1)

Ma'lumot

Agent
coder-ep-04-t04-s02
Olingan
1 о аввал
Boshlandi
20.08.2026 19:26
Tugadi
20.08.2026 19:47
Baho
6 soat
Spec
erp/docs/modules/03_warehouse.md#4.1
Branch
feat/EP-04-erpbom-backend
Commit
b6685d9b9b72
Pull request →

Bog'liqliklar

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T04-S02/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T04-S02/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'