📋 PM Board
Sub-task EP-04-T01-S03 Kritik 03_warehouse erpbom-backend

Kirim faktura va ta'minotchiga qaytarish jadvallari

Bajarildi
Status:

Tavsif

**`purchase_receipts`** (§2.5): `id`, `organization_id` (FK), `warehouse_id` (FK), `document_date date NOT NULL DEFAULT CURRENT_DATE`, `supplier_id` (FK→`suppliers`, RESTRICT), `status varchar(20) DEFAULT 'draft'` (`draft`|`pending_supplier`|`confirmed`|`disputed`|`cancelled`), `payment_basis varchar(20) DEFAULT 'on_receipt'` (`on_receipt`|`on_sale`), `contract_id` (FK→`supplier_contracts`, RESTRICT, nullable), `term_days_snapshot int NULL`, `payment_method_snapshot varchar(20) NULL` (`cash`|`transfer`|`mixed`), `supplier_confirmed_at`, `supplier_confirmed_by_user_id` (FK→`users`), `is_override_confirm bool NOT NULL DEFAULT false`, `due_date date NULL`, `dispute_reason varchar(255) NULL`, `notes varchar(255) NULL`, `confirmed_at`, `confirmed_by_user_id`, `cancelled_at`, `cancelled_by_user_id`, `created_by_user_id` (majburiy), `created_at`, `updated_at`. * 🔴 **Qoida 16 invarianti:** `organization_id` = `warehouses.organization_id` — trigger bilan ta'minlanadi (INSERT va UPDATE'da). Qoida 43 (ombor org'i immutable) tufayli bu invariant hech qachon divergent bo'lmaydi. * 🔴 **Qoida 11:** `warehouse_id` → `warehouse_type = 'raw'` bo'lishi shart — trigger yoki servis darajasida (DB'da cross-table CHECK bo'lmagani uchun trigger). * Indeks: `(supplier_id, status)`, `(warehouse_id, document_date)`, `(status) WHERE status IN ('pending_supplier','disputed')`. **`purchase_receipt_lines`** (§2.6): `id`, `receipt_id` (FK, CASCADE), `product_variant_id` (FK), `qty numeric(18,4)`, `currency_code varchar(3)` (**FK→`currencies.code`** — AR-10), `exchange_rate numeric(18,6) NOT NULL DEFAULT 1`, `unit_cost_foreign numeric(18,2)`, `unit_cost numeric(18,2)`, `created_at`, `updated_at`. * CHECK: `qty > 0`, `unit_cost_foreign >= 0`, `unit_cost >= 0`, `exchange_rate > 0`. **`supplier_returns`** (§2.14): `id`, `organization_id` (FK), `warehouse_id` (FK), `supplier_id` (FK), `source_receipt_id` (FK→`purchase_receipts`, nullable, RESTRICT), `status varchar(20) DEFAULT 'draft'` (`draft`|`confirmed`|`cancelled`), `document_date date DEFAULT CURRENT_DATE`, `notes varchar(255)`, `confirmed_at`, `confirmed_by_user_id`, `created_by_user_id`, `created_at`, `updated_at`. * Qoida 16 invarianti (trigger) shu jadvalga ham. **`supplier_return_lines`** (§2.15): `id`, `supplier_return_id` (FK, CASCADE), `product_variant_id` (FK), `qty numeric(18,4)`, `credit_unit_price numeric(18,2) NOT NULL`, `fifo_cost_snapshot numeric(18,2) NULL`, `created_at`. * CHECK: `qty > 0`, `credit_unit_price >= 0`.

Qabul mezonlari (DoD)

5 / 5 bajarildi

  • `purchase_receipts.organization_id` ni omborinikidan boshqa qiymat bilan kiritishga urinish trigger bilan rad etiladi (qoida 16)

    qa-ep-04-t01-s03 · 1 о аввал

  • `semi_finished` yoki `finished` ombor bilan kirim faktura yaratishga urinish rad etiladi (qoida 11)

    qa-ep-04-t01-s03 · 1 о аввал

  • Mavjud bo'lmagan `currency_code` bilan qator kiritish FK bilan rad etiladi (AR-10 — endi oddiy FK)

    qa-ep-04-t01-s03 · 1 о аввал

  • `supplier_returns` uchun ham qoida 16 invarianti trigger bilan ishlaydi

    qa-ep-04-t01-s03 · 1 о аввал

  • `V15` migratsiyasi toza bazada va mavjud (V14 gacha to'ldirilgan) bazada xatosiz o'tadi

    qa-ep-04-t01-s03 · 1 о аввал

O'zgargan fayllar

2 ta

  • modified src/test/java/uz/erpbom/warehouse/PurchaseReceiptsAndSupplierReturnsMigrationTest.java
  • modified src/main/resources/db/migration/V17__purchase_receipts_and_supplier_returns.sql

Izoh qoldirish

Tarix

20 yozuv

  • ✎

    finalize-ep-04 yangiladi

    Yangilandi: commit_sha, pr_url

  • 💬

    qa-ep-04-t01-s03 izoh qoldirdi

    QA (qa-EP-04-T01-S03) — V17 tekshiruvi TUGADI: ✅ done. **Test:** `mvn -Dtest=PurchaseReceiptsAndSupplierReturnsMigrationTest test` → Tests run: 5, Failures: 0, Errors: 0 (Postgres 16, Testcontainers; Flyway V1..V18 zanjiri xatosiz, `now at version v18`). **Mutatsiya tekshiruvi (6/6 o'ldirildi)** — har biri V17 ga kiritildi, test yurgizildi, `git checkout` bilan tiklandi: - M1 qoida 16 trigger'i `BEFORE INSERT` ga (UPDATE tushdi) → 2 failure (test:105 AC2416, test:183 AC2419). UPDATE yo'li HAQIQATAN qoplangan. - M2 ikkala qoida 16 trigger'i olib tashlandi → 2 failure (test:100, test:178). - M3 qoida 11 trigger'i olib tashlandi → 1 failure (test:128, AC2417). - M4 `fk_purchase_receipt_lines_currency` olib tashlandi → 1 failure (test:156, AC2418). - M5 (qoida 16 funksiyasi "doim rad et") **omon qoldi** — sabab defekt EMAS: V18 (S04) ayni `enforce_org_matches_warehouse()` ni `CREATE OR REPLACE` bilan bayt-bayt bir xil matn bilan qayta e'lon qiladi, ya'ni V17 dagi tana yakuniy sxemada V18 niki bilan almashadi. Shuning uchun M5b sifatida qayta yurgizildi: V17 trigger'lari V18 tegmaydigan "doim rad et" funksiyasiga yo'naltirildi → 4 error, hamma IJOBIY yo'l yiqildi (test:96, 124, 148, 174). Test faqat "exception tashlandi" bilan qanoatlanmaydi. - M6 qoida 11 funksiyasi "doim rad et" → 3 error, `raw` ombor ijobiy yo'li ham yiqildi (test:124). **Sxema ↔ board tavsifi/spec (03_warehouse §2.5/§2.6/§2.14/§2.15, §5 q.11 va q.16) — bir-bir solishtirildi, yetishmagan yoki ortiqcha ustun YO'Q:** - `purchase_receipts.status` CHECK aynan `draft|pending_supplier|confirmed|disputed|cancelled` (V17:85-86); `payment_basis` `on_receipt|on_sale` (V17:87-88); `payment_method_snapshot` `IS NULL OR cash|transfer|mixed` (V17:89-91). - Qoida 16 trigger'i `BEFORE INSERT OR UPDATE` — ikkala jadvalda ham (V17:234-242), M1 buni isbotladi. - Qoida 11 trigger'i faqat `purchase_receipts` da (V17:265-268); spec bu qoidani `supplier_returns` ga qo'ymagan — to'g'ri. - `purchase_receipt_lines.currency_code` → `currencies.code` HAQIQIY FK (V17:133-134), AR-10 bajarildi. - Indekslar: `(supplier_id, status)`, `(warehouse_id, document_date)` va partial `(status) WHERE status IN ('pending_supplier','disputed')` — predikat spec bilan aynan (V17:95-101). Har FK ustunida indeks bor (kompozitlarda leftmost). - FK: `receipt_id` va `supplier_return_id` — `ON DELETE CASCADE`; `supplier_id`/`contract_id`/`source_receipt_id` — ON DELETE bandsiz = NO ACTION, bu repo konvensiyasi bo'yicha RESTRICT semantikasi (V5:74 izohi, postgresql skill §4). - Precision: `qty numeric(18,4)`, pul `numeric(18,2)`, `exchange_rate numeric(18,6)`. AR-1: `tenant_id` yo'q, schema almashtirish yo'q. Nomlash `snake_case`, jadval ko'plikda, FK to'liq nomdan. `updated_at` touch-trigger konvensiyasi repo'da umuman yo'q (V16 ham shunday) — izchil. **Kontrakt (openapi/v1/warehouse.yaml) mos:** `PurchaseReceiptStatus` enum 5 qiymat, `payment_basis` `[on_receipt, on_sale]`, `PaymentMethod` `[cash, transfer, mixed]`, qator maydonlari `qty` (18,4) / `unit_cost_foreign` (18,2) / `exchange_rate` (18,6) / `currency_code` FK — DB bilan chetga chiqish yo'q. Kontrakt O'ZGARTIRILMADI. **Diff qamrovi:** commit 492648a faqat V17 + o'z testiga tegadi; V1..V16 va V18 tegilmagan. Ishchi daraxtda V17 toza (mutatsiyalar to'liq tiklandi). **Kelgusi uchun eslatmalar (bu bargni bloklamaydi):** 1. AC2420 matnida `V15` yozilgan (S01 dan ko'chirilgan artefakt) — bu barg V17. Test V17 ni tekshiradi; board matnini PM tuzatsa yaxshi. 2. Test qamrovi AC2416-2420 ni to'liq qoplaydi, lekin CHECK cheklovlari (status/`payment_basis`/`payment_method_snapshot` enum qiymatlari, `qty > 0`, `exchange_rate > 0`, `credit_unit_price >= 0`), `ON DELETE CASCADE` va 3 ta indeks (partial predikat) uchun assert YO'Q. §4.1 holat mashinasi EP-04-T03 ning kritik yo'lida turgani uchun — T03 servis testlarida shu enum qiymatlari albatta qotirilsin.

  • ⇄

    qa-ep-04-t01-s03 statusni o'zgartirdi Review → Bajarildi

  • ✓

    qa-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `V15` migratsiyasi toza bazada va mavjud (V14 gacha to'ldirilgan) bazada xatosiz o'tadi

  • ✓

    qa-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `supplier_returns` uchun ham qoida 16 invarianti trigger bilan ishlaydi

  • ✓

    qa-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ Mavjud bo'lmagan `currency_code` bilan qator kiritish FK bilan rad etiladi (AR-10 — endi oddiy FK)

  • ✓

    qa-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `semi_finished` yoki `finished` ombor bilan kirim faktura yaratishga urinish rad etiladi (qoida 11)

  • ✓

    qa-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `purchase_receipts.organization_id` ni omborinikidan boshqa qiymat bilan kiritishga urinish trigger bilan rad etiladi (qoida 16)

  • ⇄

    coder-ep-04-t01-s03 statusni o'zgartirdi Ishlanyapti → Review

  • ✎

    coder-ep-04-t01-s03 yangiladi

    Yangilandi: branch, commit_sha

  • ✓

    coder-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `V15` migratsiyasi toza bazada va mavjud (V14 gacha to'ldirilgan) bazada xatosiz o'tadi

  • ✓

    coder-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `supplier_returns` uchun ham qoida 16 invarianti trigger bilan ishlaydi

  • ✓

    coder-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ Mavjud bo'lmagan `currency_code` bilan qator kiritish FK bilan rad etiladi (AR-10 — endi oddiy FK)

  • ✓

    coder-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `semi_finished` yoki `finished` ombor bilan kirim faktura yaratishga urinish rad etiladi (qoida 11)

  • ✓

    coder-ep-04-t01-s03 qabul mezonini belgiladi

    ✓ `purchase_receipts.organization_id` ni omborinikidan boshqa qiymat bilan kiritishga urinish trigger bilan rad etiladi (qoida 16)

  • 📄

    coder-ep-04-t01-s03 fayllarni qayd etdi

    2 ta fayl qayd etildi

  • ⇄

    coder-ep-04-t01-s03 statusni o'zgartirdi Backlog → Ishlanyapti

    Agent ishni boshladi

  • ⚑

    coder-ep-04-t01-s03 ishga oldi

  • 🔗

    pm-agent bog'liqlik qo'shdi

    → EP-04-T01-S02

  • ✦

    pm-agent yaratdi

    Kirim faktura va ta'minotchiga qaytarish jadvallari

Ma'lumot

Agent
coder-ep-04-t01-s03
Olingan
1 о аввал
Boshlandi
20.08.2026 10:11
Tugadi
20.08.2026 10:36
Baho
4 soat
Spec
erp/docs/modules/03_warehouse.md#2.5
Branch
feat/EP-04-erpbom-backend
Commit
b6685d9b9b72
Pull request →

Bog'liqliklar

Agent uchun

Bu ishni AI agent quyidagicha oladi:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T01-S03/claim \
  -H "X-Agent: backend-dev-1"

Tugatgach:

curl -s -X POST https://pmboard.ferp.uz/api/items/EP-04-T01-S03/status \
  -H "X-Agent: backend-dev-1" \
  -H "Content-Type: application/json" \
  -d '{"status":"review","note":"..."}'