Hamkor: faol shartnomani tasdiqlash (ownership, idempotent)

finalize-ep-03 yangiladi

Yangilandi: pr_url

team-lead-pm yangiladi

Yangilandi: estimate_hours

qa-ep-03-t10-s01 izoh qoldirdi

QA (qa-EP-03-T10-S01) — 5 mezon ham ALOHIDA tekshirildi, hammasi o'tdi. Verdikt: done. TESTLAR (flock qulfi ostida, real Postgres 16 / Testcontainers): - SupplierContractConfirmationTest: Tests run: 6, Failures: 0, Errors: 0 - Regressiya (S01 umumiy klasslarga tegdi): SupplierSelfControllerIntegrationTest 7/0/0, SupplierContractVersioningTest 9/0/0 MUTATSIYA TEKSHIRUVI (test yolg'onni ushlaydimi — har mutant tiklandi, git toza): - Mutant A — idempotentlik sharti olib tashlandi (SupplierContractService.confirmActive: `if (active.getPartnerConfirmedAt() == null)` -> `if (true)`) => repeatedConfirmationIsIdempotentAndKeepsOriginalTimestamp YIQILDI (expected 03:10:28.610521Z, but was 03:10:28.737255254Z). Test tautologik emas. - Mutant B — egalik guard'i yumshatildi (SupplierSelfService: findByUserId -> orElseGet(findAll().get(0))) + active tekshiruvi o'chirildi => confirmWithoutLinkedSupplierReturnsForbidden (403 kutildi, 200 keldi) va confirmForInactiveSupplierReturnsForbiddenWithSupplierInactiveCode (403 kutildi, 200 keldi) YIQILDI. - Mutant C — SupplierContractRepository.findActiveForUpdate status filtri kengaytirildi (`status IN ('active','replaced') ORDER BY version ASC LIMIT 1`) => confirmAfterNewVersionTargetsOnlyTheNewActiveVersionNeverTheReplacedOne YIQILDI (version expected 2, but was 1). `replaced` himoyasi haqiqatan test bilan qoplangan. KOD DARAJASIDA: 1. Ownership (§8.4 p.1/p.3): SupplierSelfService.confirmMyActiveContract — findOwnedSupplierOrThrow (suppliers.user_id = :me, aks holda 403 FORBIDDEN) + active=false => 403 SUPPLIER_INACTIVE. Endpoint id qabul qilmaydi, egalik JWT'dan hosila qilinadi. AudienceOwnershipPort — HAQIQIY SupplierAudienceOwnershipAdapter (existsActiveByUserId, real DB so'rovi); StubAudienceOwnershipPort klassi repo'da YO'Q. `aud='supplier'` o'lchovi login bosqichida yopilgan (LoginService AUDIENCE_REQUIRED_USER_TYPE: supplier->partner, web->internal) — partner user 'web' token ololmaydi. 2. Faqat active versiya: findActiveForUpdate — `WHERE supplierId AND status='active'` + PESSIMISTIC_WRITE; replaced qator bu yo'l bilan qo'lga kirmaydi. 3. Idempotentlik: partnerConfirmedAt != null bo'lsa save chaqirilmaydi, birinchi qiymat saqlanadi, 200 + o'sha qiymat qaytadi. 4. partner_confirmed_by_user_id = joriy JWT userId (test DB darajasida ham tasdiqladi). CROSS-CUTTING: yozish metodlari @Transactional, GET'lar readOnly=true · tenant_id/schema mexanikasi qo'shilmagan (AR-1) · FK fk_supplier_contracts_partner_confirmed_by_user -> users (V14) · async/outbox talab qilinmaydi (§8.4 p.2 "boshqa hech narsa o'zgarmaydi") · snake_case, jadval ko'plikda · yangi numeric maydon yo'q · fizik DELETE yo'q · token/parol log'ga yozilmaydi. KONTRAKT: openapi/v1/suppliers.yaml bilan aynan mos — POST /api/v1/suppliers/me/contracts/active/confirm, tana yo'q, 200 -> SupplierContractResponse, 403 -> PartnerForbidden (FORBIDDEN / SUPPLIER_INACTIVE), 404 -> NotFound. Javob maydonlari snake_case (partner_confirmed_at date-time nullable, partner_confirmed_by_user_id int64 nullable). Kontrakt QA tomonidan O'ZGARTIRILMADI. MIGRATSIYA: yangi Flyway migratsiya YO'Q — commit 14dbed1 faqat 6 java fayliga tegdi, V14 (EP-03-T09) qayta yaratilmagan. To'g'ri. Eslatma (defekt emas, bu barg qamrovidan tashqari): controller request-time'da principal.audience() ni alohida tekshirmaydi — guard login bosqichidagi user_type<->audience xaritasiga tayanadi. Bu EP-03-T05-S02 da qabul qilingan naqsh bilan bir xil, shu bargda yangi og'ish emas. git status toza (faqat T00 re-freeze'dan qolgan staged openapi/v1/suppliers.yaml — QA teginmagan).

qa-ep-03-t10-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-03-t10-s01 qabul mezonini belgiladi

✓ `replaced` versiyani tasdiqlashga urinish rad etiladi

qa-ep-03-t10-s01 qabul mezonini belgiladi

✓ `active=false` ta'minotchi hamkori -> `403`

qa-ep-03-t10-s01 qabul mezonini belgiladi

✓ Boshqa ta'minotchining shartnomasini tasdiqlashga urinish -> `403`

qa-ep-03-t10-s01 qabul mezonini belgiladi

✓ Takroriy tasdiq `200` qaytaradi va `partner_confirmed_at` qiymati O'ZGARMAYDI

qa-ep-03-t10-s01 qabul mezonini belgiladi

✓ Hamkor o'z faol shartnomasini tasdiqlaydi -> ikkala ustun to'ladi

coder-ep-03-t10-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-03-t10-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-03-t10-s01 qabul mezonini belgiladi

✓ `replaced` versiyani tasdiqlashga urinish rad etiladi

coder-ep-03-t10-s01 qabul mezonini belgiladi

✓ `active=false` ta'minotchi hamkori -> `403`

coder-ep-03-t10-s01 qabul mezonini belgiladi

✓ Boshqa ta'minotchining shartnomasini tasdiqlashga urinish -> `403`

coder-ep-03-t10-s01 qabul mezonini belgiladi

✓ Takroriy tasdiq `200` qaytaradi va `partner_confirmed_at` qiymati O'ZGARMAYDI

coder-ep-03-t10-s01 qabul mezonini belgiladi

✓ Hamkor o'z faol shartnomasini tasdiqlaydi -> ikkala ustun to'ladi

coder-ep-03-t10-s01 fayllarni qayd etdi

6 ta fayl qayd etildi

team-lead-pm yangiladi

Yangilandi: estimate_hours

coder-ep-03-t10-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-03-t10-s01 ishga oldi

team-lead-pm yaratdi

Hamkor: faol shartnomani tasdiqlash (ownership, idempotent)