Maven + Spring Boot 3 karkasi va paket strukturasi

finalize-ep-01 yangiladi

Yangilandi: pr_url

finalize-ep-01 yangiladi

Yangilandi: commit_sha

qa-ep-01-t01-s01 statusni o'zgartirdi Review → Bajarildi

qa-ep-01-t01-s01 izoh qoldirdi

QA re-check (qa-EP-01-T01-S01) — ✅ QABUL QILINDI, 7/7. Commit 6bf8bfc. === 🔴 AC 84 — DETERMINIZM ISBOTLANDI (ikkala yurish, o'zim yurgizdim) === RUN A (env YO'Q): env -u DB_URL -u DB_USER -u DB_PASSWORD -u JWT_SECRET mvn -q verify -B -> EXIT=0; RequiredEnvironmentPropertiesTest: Tests run: 5, Failures: 0 ErpbomBackendApplicationTests: Tests run: 1, Failures: 0 RUN B (env BOR): DB_URL=jdbc:postgresql://localhost:5432/erpbom DB_USER=u DB_PASSWORD=p JWT_SECRET=s mvn -q verify -B -> EXIT=0; RequiredEnvironmentPropertiesTest: Tests run: 5, Failures: 0 ErpbomBackendApplicationTests: Tests run: 1, Failures: 0 Ikkala holatda ham 6 test, 0 failure, 0 skipped. Oldingi qaytarishdagi muhitga bog'liqlik YO'Q. Sabab to'g'ri hal qilingan: test endi `--erpbom.db-url=` kabi command-line argument beradi (RequiredEnvironmentPropertiesTest.java:100-108, `toCommandLineArgs`). Spring Boot'da command-line argument property source ierarxiyasida OS environment'dan YUQORI turadi — shuning uchun DB_URL eksport qilingan bo'lsa ham qiymat bo'sh qoladi. To'g'ri yechim. === 🔴 MUTATSIYA TEKSHIRUVI — yangi assert yolg'onni HAQIQATAN ushlaydi === Mutatsiya 1 (aniqlik/specificity): RequiredEnvironmentProperties.java da DB_USER va DB_PASSWORD @NotBlank xabarlari ALMASHTIRILDI. -> Tests run: 5, Failures: 2 (EXIT=1) -> applicationReportsExactMissingVariable[2]: expected "DB_USER muhit o'zgaruvchisi majburiy" but was "DB_PASSWORD muhit o'zgaruvchisi majburiy" -> applicationReportsExactMissingVariable[3]: expected "DB_PASSWORD ..." but was "DB_USER ..." Ya'ni coder javadoc'da da'vo qilgan holat (xabarlar almashtirilgani) AMALDA ushlanadi. Mutatsiya 2 (asosiy regressiya): 4 ta @NotBlank butunlay olib tashlandi. -> Tests run: 5, Failures: 5 (EXIT=1), har birida: AssertionError: "Ilova majburiy muhit o'zgaruvchilarisiz muvaffaqiyatli ko'tarildi — rad etishi kerak edi" `expectBindValidationException` (RequiredEnvironmentPropertiesTest.java:110-127) ilova ko'tarilib ketsa ham, sabab zanjirida BindValidationException topilmasa ham yiqiladi — yolg'on-yashillik yo'li yopiq. Assert kengligi bo'yicha xulosa: yangi assert oldingi `.hasMessageContaining("erpbom")` kabi HAMMA NARSAGA MOS KELMAYDI. Endi tekshiriladi: (a) istisno turi aynan BindValidationException, (b) xatolar soni aynan 1 ta (parametrli testda), (c) FieldError.getField() aynan kutilgan maydon (dbUrl/dbUser/dbPassword/jwtSecret), (d) getDefaultMessage() aynan tenglik (isEqualTo, containsni emas). Bu — tor va aniq kontrakt. Har 4 env alohida qoplangan: @ParameterizedTest @CsvSource 4 qator (RequiredEnvironmentPropertiesTest.java:63-70) + hammasi birdan bo'sh holat (:41-56, containsExactlyInAnyOrder bilan 4 xabar). AC 89 ning "sababni aniq yozadi" qismi endi TEST BILAN qoplangan (avval qoplanmagan edi). === SCOPE — coder chegaradan chiqmagan === git diff 99059cd..HEAD --stat: src/test/java/uz/erpbom/common/config/RequiredEnvironmentPropertiesTest.java | 116 +++++-- 1 file changed, 107 insertions(+), 9 deletions(-) Boshqa BIRORTA fayl o'zgarmagan. Xususan: - ErpbomBackendApplication.java TEGILMAGAN — DataSource/DataSourceTransactionManager/HibernateJpa/Flyway autoconfig exclusion'lari JOYIDA (S02 ning ishi), S02 izohi ham saqlangan. - pom.xml, application*.yml, .gitignore, paket daraxti — o'zgarmagan. Shu sababli AC 85/86/87/88/90 regress bo'lmagan (qayta yurgizilmadi, diff bilan tasdiqlandi). AC 89 mexanizmi (RequiredEnvironmentProperties.java) ham o'zgarmagan — oldingi tekshiruvdagi jonli isbot kuchda qoladi. === Hygiene eslatmasi (blokerlik EMAS, tuzatish talab qilinmaydi) === target/surefire-reports/ da uz.erpbom.common.config.ScratchProbeTest hisoboti qolib ketgan (11:07:21 — coder'ning o'z mutatsiya sinovidan). Manbasi ham, .class fayli ham YO'Q, git'da kuzatilmaydi, target/ .gitignore'da — ya'ni commit'ga tushmaydi va mening ikkala verify yurishimda ISHLAMADI (timestamp bilan tasdiqlandi: mening hisobotlarim 11:12, o'shaniki 11:07). Faqat eslatma: `target/` tozalanmagani uchun eski hisobot/class fayllari qolib ketishi mumkin — shubha bo'lganda `mvn clean verify`. === Repo holati === Ikkala mutatsiya `git checkout --` bilan AYNAN tiklandi. Tiklangandan keyin yakuniy verify: EXIT=0, Tests run 5+1, Failures 0. Ishchi daraxt TOZA (git status bo'sh), HEAD = 6bf8bfc — board'dagi holat bilan mos. QA hech narsa commit/push qilmadi, kodni tuzatmadi, erp/docs ga yozmadi.

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ `mvn -q verify` xatosiz o'tadi

coder-ep-01-t01-s01 yangiladi

Yangilandi: commit_sha

coder-ep-01-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ `mvn -q verify` xatosiz o'tadi

coder-ep-01-t01-s01 fayllarni qayd etdi

1 ta fayl qayd etildi

qa-ep-01-t01-s01 izoh qoldirdi

QA (qa-EP-01-T01-S01) — QAYTARILDI. 6/7 mezon o'tdi, AC 84 yiqildi. === ❌ AC 84 — `mvn -q verify` DETERMINISTIK EMAS === Fayl: src/test/java/uz/erpbom/common/config/RequiredEnvironmentPropertiesTest.java:19-26 Test haqiqiy `SpringApplication`ni ishga tushiradi va u OS muhitini MEROS oladi. Shu sababli build natijasi shell muhitiga bog'liq: A) env'siz: mvn -q verify -> BUILD SUCCESS (Tests run: 2, Failures: 0) B) env bor: DB_URL=... DB_USER=u DB_PASSWORD=p JWT_SECRET=s mvn -q verify -> Tests run: 2, Failures: 1 -> RequiredEnvironmentPropertiesTest.applicationFailsToStartWithoutRequiredEnvironmentVariables:25 Sabab: application.yml:15-18 da `${DB_URL:}` OS env'dan to'ladi; env eksport qilingan bo'lsa ilova NORMAL ko'tariladi, `assertThatThrownBy` esa istisno kutadi -> yiqiladi. Nega bu jiddiy: AR-8 bo'yicha deploy/CI muhitida aynan shu 4 env eksport qilingan bo'ladi (docker-compose). Ya'ni test lokalda yashil, CI/VPS'da qizil bo'ladi. Kutilgan: `mvn -q verify` HAR QANDAY muhitda (env bor/yo'q) yashil. Olingan: env bor bo'lsa qizil. Tuzatish yo'nalishi (dasturchiga): testni ambient muhitdan izolyatsiya qil — bo'sh qiymatlarni command-line arg orqali ber, ular OS env'dan yuqori precedence'ga ega: app.run("--erpbom.db-url=", "--erpbom.db-user=", "--erpbom.db-password=", "--erpbom.jwt-secret=") Shunda DB_URL eksport qilingan bo'lsa ham qiymat bo'sh qoladi va @NotBlank ishlaydi. === ⚠️ Qo'shimcha (AC 84 bilan birga tuzatilsin) — assert juda kuchsiz === RequiredEnvironmentPropertiesTest.java:25-26 — `.hasMessageContaining("erpbom")`. Paket nomi `uz.erpbom` bo'lgani uchun deyarli HAR QANDAY startup xatosi bu assert'dan o'tadi. AC 89 ning "sababni aniq yozadi" qismi test bilan umuman qoplanmagan: @NotBlank message'larini bo'shatib qo'ysa ham test yashil qoladi. Kerak: har 4 sabab matni assert qilinsin — "DB_URL muhit o'zgaruvchisi majburiy", "DB_USER ...", "DB_PASSWORD ...", "JWT_SECRET ...". === ✅ Tekshirilgan va o'tgan mezonlar (dalil bilan) === AC 85 — HAQIQATDA ko'tarildi: `mvn spring-boot:run -Dspring-boot.run.profiles=dev` (4 env bilan) -> "Tomcat started on port 8080", "Started ErpbomBackendApplication in 3.247 seconds"; GET /actuator/health -> {"status":"UP"}; GET /v3/api-docs -> 200. AC 86 — paket daraxti java-spring-coder skill'i bilan AYNAN mos: 11 modul (auth, customers, employees, finance, notifications, orders, products, reports, suppliers, tasks, warehouse) x 6 qatlam (controller, dto, entity, mapper, repository, service) + common/{cache, config, exception, outbox, storage, util}. `tenant` paketi YO'Q (AR-1). Butun repo bo'ylab "tenant" faqat pom.xml:22 va README.md:3 dagi "single-tenant" nasriy matnida. AC 87 — pom.xml da amqp/redis/modulith/pgbouncer/rabbit/hazelcast bog'liqligi yo'q (yagona moslik — pom.xml:68 dagi "Redis YO'Q" izohi). `mvn dependency:tree` chiqishi ham toza — tranzitiv tarzda ham kirmagan. AC 88 — DEKLARATSIYA EMAS, AMALDA sinaldi: vaqtincha `uz.erpbom.qatmp` da unmapped target property'li @Mapper yaratildi -> `mvn compile` QATTIQ xato berdi: [ERROR] QaMapper.java:[4,38] Unmapped target property: "missingField". Ya'ni pom.xml:135 dagi `-Amapstruct.unmappedTargetPolicy=ERROR` real ishlaydi. Sinov fayllari o'chirildi. AC 89 — MAHSULOT XULQI SIFATIDA HAQIQIY (test aytganiga ishonilmadi). DataSourceAutoConfiguration o'chirilgani bu mezonni YOLG'ON QILMAYDI: validatsiya @EnableConfigurationProperties + @Validated orqali datasource'dan MUSTAQIL ishlaydi. Har 4 env alohida-alohida sinaldi (qolgan 3 tasi joyida, bittasi olib tashlangan holda) — 4/4 holatda dev profil ko'tarilmadi: MISSING=DB_URL -> EXIT=1, "DB_URL muhit o'zgaruvchisi majburiy" MISSING=DB_USER -> EXIT=1, "DB_USER muhit o'zgaruvchisi majburiy" MISSING=DB_PASSWORD -> EXIT=1, "DB_PASSWORD muhit o'zgaruvchisi majburiy" MISSING=JWT_SECRET -> EXIT=1, "JWT_SECRET muhit o'zgaruvchisi majburiy" Banner "APPLICATION FAILED TO START" + Origin (application.yml qator raqami) bilan. Sabab aniq. AC 90 — .gitignore:2 `target/`, :6 `.env` (+ :7 `.env.*`), :8 `*.key` (+ :9 `*.pem`). ✓ === Mutatsiya tekshiruvi (test yolg'onni ushlaydimi?) === RequiredEnvironmentProperties.java dagi 4 ta @NotBlank vaqtincha izohga olindi -> test KUTILGANDEK yiqildi (Tests run: 1, Failures: 1). Ya'ni test tavtologik emas, asosiy regressiyani ushlaydi. Fayl `git checkout --` bilan AYNAN tiklandi; ishchi daraxt toza, HEAD = 99059cd (board'dagi commit_sha bilan bir xil). === DataSource/JPA/Flyway exclusion bo'yicha xulosa === S02 da olib tashlanishi 3 joyda aniq qayd etilgan — muammo emas: ErpbomBackendApplication.java:15-20 ("S02 shu exclude ro'yxatini olib tashlaydi") RequiredEnvironmentProperties.java:17 application-dev.yml:2-4 Eslatma (blokerlik emas, S02 uchun): DB_URL hozir faqat `erpbom.db-url` ga bog'langan; S02 da `spring.datasource.url` qo'shilganda bir env ikki joyda ishlatiladi — divergensiya bo'lmasin. === Cross-cutting === AR-1 (tenant yo'q) ✓ · AR-2 (bitta backend) ✓ · AR-4 (Caffeine in-process, Redis yo'q) ✓ · AR-11 (repo nomi) ✓. Sir/token log'ga yozilmaydi: actuator exposure `health,info` bilan cheklangan (application.yml:20-24), configprops/env ochiq emas. Qolgan cross-cutting bandlar (tranzaksiya, FK, precision, soft-delete) bu bosqichda N/A — DB qatlami hali yo'q. Qisqasi: faqat AC 84 ni tuzatish kerak — test ambient muhitdan izolyatsiya qilinsin va sabab matnlari assert qilinsin. Qolgan hamma narsa yashil.

qa-ep-01-t01-s01 statusni o'zgartirdi Review → Ishlanyapti

qa-ep-01-t01-s01 qabul mezonini belgiladi

✗ `mvn -q verify` xatosiz o'tadi

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ `.gitignore` da `target/`, `.env`, `*.key` bor

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ Majburiy env (`DB_URL`, `DB_USER`, `DB_PASSWORD`, `JWT_SECRET`) o'chirilganda ilova ko'tarilmaydi va sababni aniq yozadi

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ MapStruct `unmappedTargetPolicy = ReportingPolicy.ERROR` bilan sozlangan

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ `pom.xml` da amqp/redis/modulith/pgbouncer bog'liqligi yo'q

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ Paket daraxti java-spring-coder skill'idagi struktura bilan bir xil (11 modul + common), `tenant` paketi yo'q

qa-ep-01-t01-s01 qabul mezonini belgiladi

✓ Ilova `mvn spring-boot:run -Dspring-boot.run.profiles=dev` bilan ko'tariladi

coder-ep-01-t01-s01 statusni o'zgartirdi Ishlanyapti → Review

coder-ep-01-t01-s01 yangiladi

Yangilandi: branch, commit_sha

coder-ep-01-t01-s01 izoh qoldirdi

Qaror: Spring Boot 3.5.16 (3.x oxirgi stabil minor; 4.0/4.1 mavjud lekin talab aynan 3.x). DataSourceAutoConfiguration/DataSourceTransactionManagerAutoConfiguration/HibernateJpaAutoConfiguration/FlywayAutoConfiguration ErpbomBackendApplication da vaqtincha exclude qilingan (izohli TODO bilan) - chunki hostda hali dev DB stack yo'q (T04 da keladi) va haqiqiy datasource ulanishi EP-01-T02 (S02) doirasida. Majburiy env talabi (AC89) shu exclude'dan mustaqil: uz.erpbom.common.config.RequiredEnvironmentProperties (@ConfigurationProperties(prefix=erpbom) + @NotBlank) orqali amalga oshirildi va application.yml da bo'sh-default placeholder bilan bog'langan. MapStruct unmappedTargetPolicy=ERROR global compiler arg orqali sozlandi, shunda skill'dagi minimal namuna (componentModel=spring) o'zgarishsiz ishlaydi. S02 uchun eslatma: exclude ro'yxatini olib tashlab, spring.datasource.* + Flyway location qo'shish kerak bo'ladi.

coder-ep-01-t01-s01 fayllarni qayd etdi

66 ta fayl qayd etildi

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ `.gitignore` da `target/`, `.env`, `*.key` bor

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ Majburiy env (`DB_URL`, `DB_USER`, `DB_PASSWORD`, `JWT_SECRET`) o'chirilganda ilova ko'tarilmaydi va sababni aniq yozadi

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ MapStruct `unmappedTargetPolicy = ReportingPolicy.ERROR` bilan sozlangan

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ `pom.xml` da amqp/redis/modulith/pgbouncer bog'liqligi yo'q

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ Paket daraxti java-spring-coder skill'idagi struktura bilan bir xil (11 modul + common), `tenant` paketi yo'q

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ Ilova `mvn spring-boot:run -Dspring-boot.run.profiles=dev` bilan ko'tariladi

coder-ep-01-t01-s01 qabul mezonini belgiladi

✓ `mvn -q verify` xatosiz o'tadi

coder-ep-01-t01-s01 fayllarni qayd etdi

16 ta fayl qayd etildi

coder-ep-01-t01-s01 statusni o'zgartirdi Backlog → Ishlanyapti

Agent ishni boshladi

coder-ep-01-t01-s01 ishga oldi

pm-agent yaratdi

Maven + Spring Boot 3 karkasi va paket strukturasi